tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore(joinir): Clarify TODO comment in exit_binding.rs

Browse Source 
Phase 179-A Step 4: Update TODO comment to be more specific about
the future improvement path (using MirBuilder's next_value_id()).

Changed vague "TODO: This should be delegated to a proper ValueId allocator"
to clear "Future improvement: Delegate to MirBuilder's next_value_id()".

Note: Other TODOs in loop_patterns/mod.rs are placeholder tests waiting
for future implementation and are intentionally kept as-is.
This commit is contained in:
nyash-codex
2025-12-08 18:41:01 +09:00
parent 4cbe412c22
commit 1e51c2c521
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mir/builder/control_flow/joinir/patterns/exit_binding.rs
View File

@ -176,8 +176,8 @@ impl<'a> ExitBindingBuilder<'a> {
/// Allocate a new ValueId for a post-loop carrier
///
/// TODO: This should be delegated to a proper ValueId allocator
/// For now, we use a placeholder strategy
/// Phase 193-4: Temporary sequential allocation strategy.
/// Future improvement: Delegate to MirBuilder's next_value_id() for proper allocation.
fn allocate_new_value_id(&self) -> ValueId {
// Find the maximum ValueId in current variable_map
let max_id = self.variable_map.values()