From 1e51c2c521a55956015af8691da251892e01d8de Mon Sep 17 00:00:00 2001 From: nyash-codex Date: Mon, 8 Dec 2025 18:41:01 +0900 Subject: [PATCH] chore(joinir): Clarify TODO comment in exit_binding.rs Phase 179-A Step 4: Update TODO comment to be more specific about the future improvement path (using MirBuilder's next_value_id()). Changed vague "TODO: This should be delegated to a proper ValueId allocator" to clear "Future improvement: Delegate to MirBuilder's next_value_id()". Note: Other TODOs in loop_patterns/mod.rs are placeholder tests waiting for future implementation and are intentionally kept as-is. --- src/mir/builder/control_flow/joinir/patterns/exit_binding.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mir/builder/control_flow/joinir/patterns/exit_binding.rs b/src/mir/builder/control_flow/joinir/patterns/exit_binding.rs index cd9c3767..d219a469 100644 --- a/src/mir/builder/control_flow/joinir/patterns/exit_binding.rs +++ b/src/mir/builder/control_flow/joinir/patterns/exit_binding.rs @@ -176,8 +176,8 @@ impl<'a> ExitBindingBuilder<'a> { /// Allocate a new ValueId for a post-loop carrier /// - /// TODO: This should be delegated to a proper ValueId allocator - /// For now, we use a placeholder strategy + /// Phase 193-4: Temporary sequential allocation strategy. + /// Future improvement: Delegate to MirBuilder's next_value_id() for proper allocation. fn allocate_new_value_id(&self) -> ValueId { // Find the maximum ValueId in current variable_map let max_id = self.variable_map.values()