Files
hakorune/docs/reference/architecture/mir-26-instruction-diet.md
Moe Charm fffbac9aac feat: MIR TypeOp/WeakRef/Barrier PoC implementation
- Add TypeOpKind, WeakRefOp, BarrierOp enums for unified instructions
- Implement TypeOp instruction combining TypeCheck/Cast
- Implement WeakRef instruction combining WeakNew/WeakLoad
- Implement Barrier instruction combining BarrierRead/BarrierWrite
- Update VM to handle new unified instructions
- Update MIR printer for new instruction formats
- Add feature flags mir_typeop_poc and mir_refbarrier_unify_poc
- Maintain backward compatibility with legacy instructions

This is Phase 8.5 MIR instruction diet PoC implementation.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-23 19:27:02 +09:00

3.1 KiB
Raw Blame History

MIR 26-Instruction Diet (Agreed Final Set)

Goal

  • Converge on a lean, proven instruction set guided by vm-stats and E2E.
  • Preserve hot paths, demote meta, fold type ops, reserve room for growth.

Agreed Final Set (26)

  1. Const
  2. Copy
  3. Load
  4. Store
  5. BinOp
  6. UnaryOp
  7. Compare
  8. Jump
  9. Branch
  10. Phi
  11. Return
  12. Call
  13. BoxCall
  14. NewBox
  15. ArrayGet
  16. ArraySet
  17. RefNew
  18. RefGet
  19. RefSet
  20. Await
  21. Print
  22. ExternCall (keep minimal; prefer BoxCall)
  23. TypeOp (unify TypeCheck/Cast)
  24. WeakRef (unify WeakNew/WeakLoad)
  25. Barrier (unify BarrierRead/BarrierWrite)
  26. Reserve (future async/error instr)

Hot/Core (keep)

  • Data: Const, Copy, Load, Store
  • ALU: BinOp, UnaryOp, Compare
  • Control: Jump, Branch, Phi, Return
  • Calls: Call, BoxCall
  • Objects: NewBox
  • Arrays: ArrayGet, ArraySet

Likely Keep (usage-dependent)

  • Refs: RefNew, RefGet, RefSet (seen in language features; keep unless stats prove cold)
  • Async: Await (FutureNew/Set can be Box/APIs)

Meta (demote to build-mode)

  • Debug, Nop, Safepoint

Type Ops (fold)

  • TypeCheck, Cast → fold/verify-time or unify as a single TypeOp (optional).

External (unify)

  • ExternCall → prefer BoxCall; keep ExternCall only where required.

Extended/Reserve

  • Weak*: WeakNew, WeakLoad
  • Barriers: BarrierRead, BarrierWrite
  • 2 Reserve IDs for future async/error instrumentation

Mapping Notes

  • HTTP E2E shows BoxCall/NewBox dominate (3342%), then Const/NewBox, with Branch/Jump/Phi only in error flows.
  • FileBox path similarly heavy on BoxCall/NewBox/Const.
  • Implication: invest into BoxCall fast path and const/alloc optimization.

Migration Strategy

  1. Introduce an experimental feature gate that switches TypeCheck/Cast to TypeOp or folds them.
  2. Demote Debug/Nop/Safepoint under non-release builds.
  3. Keep ExternCall available, route new external APIs via BoxCall when possible.
  4. Track Weak*/Barrier usage; unify under WeakRef/Barrier. Graduate dedicated ops only if vm-stats shows recurring use.

Mapping from Current → Final

  • TypeCheck, Cast → TypeOp
  • WeakNew, WeakLoad → WeakRef
  • BarrierRead, BarrierWrite → Barrier
  • (Keep) ExternCall, but prefer BoxCall where possibleExternCall は最小限に)
  • (Keep) Debug/Nop/Safepoint as meta under non-release builds命令セット外のビルドモード制御に降格

Verification

  • Add MIR verifier rule: use-before-def across merges is rejected (guards phi misuse).
  • Add snapshot tests for classic if-merge returning phi.

Appendix: Rationale

  • Smaller ISA simplifies VM fast paths and aids JIT/AOT later.
  • Data shows hot paths concentrated on calls, const, alloc; control sparse and localized.
  • Folding type ops reduces interpreter/VM dispatch; verification handles safety.

Feature Flags (Cargo)

  • mir_typeop_poc: enable TypeOp PoC mapping (builder emits TypeOp instead of TypeCheck/Cast)
  • mir_refbarrier_unify_poc: enable WeakRef/Barrier PoC mapping (builder emits unified ops)

Status (2025-08-23)

  • Flags declared in Cargo.toml (off by default)
  • PoC design doc: docs/development/proposals/mir-typeop-weakref-barrier-poc.md
  • Next: land builder/VM mapping behind flags, add snapshot tests; no behavior change with flags off