Files

nyash-codex a7dbc15878 feat(joinir): Phase 240-EX - Pattern2 header condition ExprLowerer integration

Implementation:
- Add make_pattern2_scope_manager() helper for DRY
- Header conditions use ExprLowerer for supported patterns
- Legacy fallback for unsupported patterns
- Fail-Fast on supported patterns that fail

Tests:
- 4 new tests (all pass)
- test_expr_lowerer_supports_simple_header_condition_i_less_literal
- test_expr_lowerer_supports_header_condition_var_less_var
- test_expr_lowerer_header_condition_generates_expected_instructions
- test_pattern2_header_condition_via_exprlowerer

Also: Archive old phase documentation (34k lines removed)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

2025-12-11 00:33:04 +09:00

2.1 KiB

Raw Blame History

Phase 178: LoopUpdateAnalyzer String Detection

Summary

Phase 178 extends LoopUpdateAnalyzer to detect string/complex carrier updates, enabling Fail-Fast behavior for unsupported patterns.

Changes

1. UpdateRhs Enum Extension (`loop_update_analyzer.rs`)

Added two new variants:

StringLiteral(String) - for result = result + "x" patterns
Other - for method calls and complex expressions

2. analyze_rhs Extension

Extended to detect:

String literals: ASTNode::Literal { value: LiteralValue::String(_) }
Method calls: ASTNode::MethodCall { .. }
Other complex expressions: ASTNode::Call, ASTNode::BinaryOp, etc.

3. Pattern 2/4 can_lower Updates

Both pattern2_with_break.rs and pattern4_with_continue.rs now check for string/complex updates in can_lower() and return false if detected.

This triggers a clear error message instead of silent incorrect behavior.

4. Legacy Fallback Comment Fixes

Updated misleading comments about "legacy fallback" - LoopBuilder was removed in Phase 187-2 and all loops must use JoinIR.

Behavior

When a loop contains string concatenation like:

loop(i < limit) {
    result = result + "x"  // String update
    i = i + 1
}

Phase 178 now produces a clear error:

[pattern2/can_lower] Phase 178: String/complex update detected, rejecting Pattern 2 (unsupported)
[ERROR] MIR compilation error: [joinir/freeze] Loop lowering failed:
JoinIR does not support this pattern, and LoopBuilder has been removed.

Test Results

P1 (simple while): OK
P2 (break + int carriers): OK
P4 (continue + multi-carrier): OK
String loops: Fail-Fast with clear error

Known Issues

79 global test failures: Pre-existing issue, NOT caused by Phase 178
- Confirmed by git stash test - failures exist in HEAD~1
- Tracked separately from Phase 178

Future Work

To support string loops, either:

Add JoinIR instructions for string concatenation (Option A)
Process loop body statements in MIR alongside JoinIR control flow (Option B)

Phase 178 provides the detection foundation for future string support. Status: Historical

2.1 KiB Raw Blame History