tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(joinir): verbose flag should not use env var (test pollution)

Browse Source 
joinir_dev_enabled() was being used in verbose flags, causing debug
output to appear during smoke tests and polluting expected output.

Changed 3 locations from:
  let verbose = debug || crate::config::env::joinir_dev_enabled()
To:
  let verbose = debug

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
tomoaki
2025-12-25 04:42:32 +09:00
parent 5b74b3134a
commit e55665aa22
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/mir/builder/control_flow/joinir/merge/instruction_rewriter.rs
View File

@ -239,7 +239,8 @@ fn plan_rewrites(
use super::block_remapper::remap_block_id;
let trace = trace::trace();
let verbose = debug || crate::config::env::joinir_dev_enabled();
// Only verbose if explicitly requested via debug flag (not env var - causes test failures)
let verbose = debug;
macro_rules! log {
($enabled:expr, $($arg:tt)*) => {
trace.stderr_if(&format!($($arg)*), $enabled);
@ -929,7 +930,8 @@ fn apply_rewrites(
debug: bool,
) -> Result<(), String> {
let trace = trace::trace();
let verbose = debug || crate::config::env::joinir_dev_enabled();
// Only verbose if explicitly requested via debug flag (not env var - causes test failures)
let verbose = debug;
macro_rules! log {
($enabled:expr, $($arg:tt)*) => {
trace.stderr_if(&format!($($arg)*), $enabled);
@ -1100,7 +1102,8 @@ pub(super) fn merge_and_rewrite(
// 3. apply_rewrites() - Mutate builder (apply changes)
let trace = trace::trace();
let verbose = debug || crate::config::env::joinir_dev_enabled();
// Only verbose if explicitly requested via debug flag (not env var - causes test failures)
let verbose = debug;
macro_rules! log {
($enabled:expr, $($arg:tt)*) => {
trace.stderr_if(&format!($($arg)*), $enabled);