feat(phase284): P1 Complete - Return in Loop with Block Remap Fix

## Summary

Completed Phase 284 P1: Enable return statements in Pattern4/5 loops via
JoinInst::Ret infrastructure (100% pre-existing, no new infrastructure needed).

**Critical Bug Fix**: Block ID remap priority
- Fixed: local_block_map must take precedence over skipped_entry_redirects
- Root cause: Function-local block IDs can collide with global remap entries
  (example: loop_step:bb4 vs k_exit:bb4 after merge allocation)
- Impact: Conditional Jump else branches were incorrectly redirected to exit
- Solution: Check local_block_map FIRST, then skipped_entry_redirects

## Implementation

### New Files
- `src/mir/join_ir/lowering/return_collector.rs` - Return detection SSOT (top-level only, P1 scope)
- `apps/tests/phase284_p1_return_in_loop_min.hako` - Test fixture (exit code 7)
- Smoke test scripts (VM/LLVM)

### Modified Files
- `loop_with_continue_minimal.rs`: Return condition check + Jump generation
- `pattern4_with_continue.rs`: K_RETURN registration in continuation_funcs
- `canonical_names.rs`: K_RETURN constant
- `instruction_rewriter.rs`: Fixed Branch remap priority (P1 fix)
- `terminator.rs`: Fixed Jump/Branch remap priority (P1 fix)
- `conversion_pipeline.rs`: Return normalization support

## Testing

 VM: exit=7 PASS
 LLVM: exit=7 PASS
 Baseline: 46 PASS, 1 FAIL (pre-existing emit issue)
 Zero regression

## Design Notes

- JoinInst::Ret infrastructure was 100% complete before P1
- Bridge automatically converts JoinInst::Ret → MIR Return terminator
- Pattern4/5 now properly merge k_return as non-skippable continuation
- Correct semantics: true condition → return, false → continue loop

## Next Phase (P2+)

- Refactor: Block remap SSOT (block_remapper.rs)
- Refactor: Return jump emitter extraction
- Scope: Nested if/loop returns, multiple returns
- Design: Standardize early exit pattern (return/break/continue as Jump with cond)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
2025-12-23 14:21:27 +09:00
parent 41d92bedb9
commit 661bbe1ab7
22 changed files with 1123 additions and 131 deletions

View File

@ -0,0 +1,23 @@
// Phase 284 P1: Return in loop test (minimal)
// Expected: VM/LLVM both return 7
static box Main {
main() {
local i
i = 0
loop(i < 10) {
i = i + 1
if (i == 3) {
return 7 // Early return with code 7
}
if (i == 5) {
continue // Force Pattern4 match
}
}
return 0 // Should never reach here
}
}

View File

@ -6,6 +6,8 @@
- 目的: `return``ExitKind` + `compose::*` / `emit_frag()` に収束させ、pattern側の個別実装を増やさない
- 入口: `docs/development/current/main/phases/phase-284/README.md`
- 手順: `docs/development/current/main/phases/phase-284/P0-INSTRUCTIONS.md`
- 次: Phase 285design-firstBox lifecycle SSOT`docs/development/current/main/phases/phase-285/README.md`
- 次の次: Phase 286design-firstJoinIR line absorption`docs/development/current/main/phases/phase-286/README.md`
## Recently Completed (2025-12-23)

View File

@ -21,6 +21,29 @@ Related:
- P0docs-onlyで “return の意味” と “Ok(None)/Err” の境界を固定
- P1+ で Rust/LLVM の実装を SSOT に収束pattern側に例外実装を増やさない
- **Phase 285planned, design-first: Box lifecycle / weakref / finalization / GC SSOT**
- 目的: Box の生存期間(強参照/弱参照/解放/最終化)を SSOT として固定し、「実装が仕様」になっている箇所を潰す
- ねらい:
- VM 側の weakref/finalization を仕様化(テストで固定)
- LLVM harness 側の未対応/差分を “仕様として明文化” し、将来の実装計画を切る
- 入口: `docs/development/current/main/phases/phase-285/README.md`
- スコープ案:
- P0docs-only: 仕様SSOT + 用語 + ルート集合roots+ 禁止事項finalizer内での再入などを固定
- P1investigation: Rust VM 実装の棚卸し + LLVM harness の現状差分を記録
- P2smoke: weakref の最小 fixture/smoke を VM/可能ならLLVM で固定
- 参考(現状の入口候補):
- weakref 表現: `src/value.rs``NyashValue::WeakBox`
- finalization: `src/finalization.rs`
- **Phase 286planned, design-first: JoinIR Line AbsorptionJoinIR→CorePlan/Frag 収束)**
- 目的: 移行期間に残っている「2本の loweringPlan line / JoinIR line」を、構造で 1 本に収束させる
- ねらい: `return/break/continue` のような “大きな出口語彙” の実装場所が揺れない状態にする
- 入口: `docs/development/current/main/phases/phase-286/README.md`
- P0docs-only: `docs/development/current/main/phases/phase-286/P0-INSTRUCTIONS.md`
- SSOT:
- Plan/Frag: `compose::*` + `emit_frag()`Phase 280/281
- JoinIR line 共通入口: `src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs`
- (✅ done**Phase 282**: Router shrinkage + detection SSOT + extractor refactor
- 完了: `docs/development/current/main/phases/phase-282/README.md`

View File

@ -61,6 +61,36 @@ AST/Stmt → │ Plan Extractor Box (pure) │
(terminator operand only)
```
注記(名前の揺れを防ぐ):
- **PlanFreeze** という呼び名を使う場合、意味は **Normalizer + Verifier の合成(凍結点)**
- 目的は「一致宣言Ok(Some))した後は後戻りせず、**DomainPlan →(変換+検証)→ FrozenCorePlan** に確定する」こと。
- 実装上は分割して持ってもよいが、会話や指示書では “凍結点” を **PlanFreeze** と呼ぶと迷子が減る。
PlanFreeze 版(同じ収束形、箱名だけ明確化):
```
┌──────────────────────────────┐
AST/Stmt → │ Plan Extractor (pure) │
│ - Ok(None)/Ok(DomainPlan)/Err
└──────────────┬───────────────┘
v
┌──────────────────────────────┐
│ PlanFreeze (=Normalizer+Verifier) │
│ - DomainPlan → FrozenCorePlan │
│ - close-but-unsupported => Err │
└──────────────┬───────────────┘
v
┌──────────────────────────────┐
│ Plan Lowerer (only builder) │
└──────────────┬───────────────┘
v
┌──────────────────────────────┐
│ Frag + compose::* + emit_frag() │
└──────────────────────────────┘
```
### 0.0.2 「収束している」と呼ぶ条件(定義)
この定義を満たしている状態を、JoinIR/CFG 合成の「収束」と呼ぶ:
@ -81,6 +111,24 @@ AST/Stmt → │ Plan Extractor Box (pure) │
参照(相談メモ / 背景):
- `docs/development/current/main/investigations/phase-272-frag-plan-architecture-consult.md`
### 0.0.3 現状の実装2本の lowering line
現状は移行期間のため、入口が 2 本ある(=「2本のコンパイラ」になりやすい状態。ここを **Phase 286** で 1 本に収束させる。
- **Plan lineroute=plan**
- 対象: Pattern6/7Plan-based
- 入口: `src/mir/builder/control_flow/joinir/patterns/router.rs``route=plan ...`
- SSOT: `src/mir/builder/control_flow/plan/*``Frag + compose::* + emit_frag()`
- **JoinIR lineroute=joinir**
- 対象: Pattern15,89JoinIR table-based
- 入口: `src/mir/builder/control_flow/joinir/patterns/router.rs``route=joinir ...`
- 共通入口(変換/merge の集約点): `src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs`
注意:
- 「return/break/continue のような “大きい出口語彙”」を実装する時、どちらの line に効く修正かを先に固定しないと迷子が再発する。
- Phase 284 は “ExitKind へ収束” を先に決め、Phase 286 で line 自体を吸収して 1 本化する。
## 0. 読み方ガイドReader's Guide
このファイルは情報量が多いので、「何を知りたいか」で読む場所を分けると楽だよ:

View File

@ -21,6 +21,10 @@ P1 のゴールは:
- `return` を含む loop-body が “別パターンへ静かに流れる” 状態をなくす
- SSOT 経路で `ExitKind::Return` に落ちるようにする
補足(設計意図):
- Phase 284 は “return だけ” を特別扱いするのではなく、**Exit の語彙ExitKindを SSOT 化**するフェーズでもある。
- `return` を「条件付き Jump の一種」として扱えるようにしておくと、将来の `break/continue` / `throw` も同じ導線に乗る。
## 実装タスク(推奨順)
### Step 1: 現状の `return` ハンドリングを棚卸しread-only
@ -42,9 +46,28 @@ P1 のゴールは:
- loop body のどの位置でも `return` が現れたら `ExitKind::Return` で外へ出せること
- これを **1 箇所**に寄せるpattern 側に増やさない)
重要: Phase 284 で一番の迷子ポイントは「どこに寄せるか」なので、先に経路を固定する。
#### A) Plan line と JoinIR line を混同しない(必須)
- **Plan linePattern6/7**: `src/mir/builder/control_flow/plan/normalizer.rs` が Frag 構築 SSOT。
`compose::cleanup()` / `emit_frag()` へ寄せるのが正しい。
- **JoinIR linePattern15,9**: `src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs` が共通入口。
Pattern4/5 の root fix を `plan/normalizer.rs` に寄せても効かない(経路が違う)。
#### B) root fix の候補JoinIR line を対象にする)
実装候補(どれか 1 つに決める):
- A) loop loweringFrag 構築)段で Return edge を first-class で追加
- B) JoinIR conversion の merge 段で Return を ExitKind に正規化
- B1) JoinIR lowerer 側に “Return collector” を 1 箇所だけ追加し、Pattern4/5 はそれを呼ぶだけにする
- 方針: まずは **fixture で使う形だけ**を対応(例: top-level if の then に return
- 未対応形は Errsilent fallback 禁止)
- B2) JoinIR→MIR 変換/merge の共通入口へ正規化を寄せる(`conversion_pipeline.rs` / `merge/mod.rs`
- ただし、JoinModule に return 相当が無いと後段で作れないので、ここは “最後に出る地点” にしないこと
- 実体としては B1 が先に必要になるケースが多い
重要:
- `conversion_pipeline.rs` は JoinModule 構築の後で走るため、「return の配線を作る」責務をそこへ押し込むと設計が歪みやすい。
P1 の最小は「JoinIR lowering の入口JoinInst を作る地点)で return を ExitKind に落とす」こと。
要件:
- Fail-Fast: “表現できない return” は Errsilent fallback 禁止)
@ -76,4 +99,3 @@ smoke:
- `return` を含む loop fixture が VM/LLVM で同一動作
- pattern 側に “return の特例 if” が増えていないroot fix のみ)
- `Ok(None)` / `Err` の境界が崩れていないsilent fallback なし)

View File

@ -39,6 +39,40 @@ Phase 284 の完了条件は「`return` を含むケースが close-but-unsuppor
- `return` の lowering は **ExitKind + compose + emit_frag** に集約する。
- pattern の extractor は “認識” のみSSOT=extract`return` の解釈ロジックを増やさない。
補足: Phase 284 は “return だけのため” ではない。ここで固定するのは **Exit 正規化**ExitKind の語彙化)で、
`return/break/continue/(将来の unwind)` を同じ土台に載せるのが狙い。
「Jump/Branch の配線で exit を表現できる」状態ができると、return はその一例として自然に入る。
## Responsibility Map迷子防止
このフェーズで一番起きやすい事故は「`return` をどこで処理するべきか分からず、pattern 側へ散布してしまう」こと。
そこで、**どの経路で lower されるか**を前提に責務を固定する。
### A) Plan linePattern6/7
- 入口: `src/mir/builder/control_flow/joinir/patterns/router.rs`route=plan
- SSOT:
- `src/mir/builder/control_flow/plan/normalizer.rs`Frag 構築: branches/wires/exits
- `src/mir/builder/control_flow/edgecfg/api/compose.rs`(合成 SSOT
- `src/mir/builder/control_flow/edgecfg/api/emit.rs``emit_frag()` terminator SSOT
- ここでは `return` を **Return edgeExitKind::Return**として組み立てるのが自然。
### B) JoinIR linePattern15,9
- 入口: `src/mir/builder/control_flow/joinir/patterns/router.rs`route=joinir
- SSOT:
- JoinIR 生成pattern 固有の JoinIR lowerer
- `src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs`JoinIR→MIR→merge の唯一入口)
- `src/mir/builder/control_flow/joinir/merge/mod.rs`Return merge / exit block SSOT
- **注意**: `src/mir/builder/control_flow/plan/normalizer.rs` は Plan line 専用なので、
Pattern4/5 の return 問題の root fix をここへ寄せても効かない。
### 禁止事項Phase 284 の憲法)
- ❌ Pattern4/5 の `lower()` へ「return を特別扱いする if」を散布しないSSOTが割れる
- ❌ Extractor が `return` を見つけた時に `Ok(None)` で黙殺しないsilent reroute 禁止)
-`return` の “対応/非対応” は **共通入口の Fail-Fast**で固定するP1 で実装)
## Scope
### P0docs-only
@ -56,3 +90,14 @@ Phase 284 の完了条件は「`return` を含むケースが close-but-unsuppor
- P0: `return` の SSOTExitKind/compose/emitと detect 境界が明文化されている
- P1+: `return` を含む loop fixture が VM/LLVM で同一結果になり、smoke で固定されている
## P1 の実装方針design-first 注記)
P1 の root fix は「PlanNormalizer へ寄せる」ではなく、**JoinIR line の共通入口**へ寄せる:
- 入口候補:
- `src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs`(最終的な “ここで統一したい”)
- もしくは JoinIR lowerer 側に “Return collector” を 1 箇所だけ作り、Pattern4/5 はそれを呼ぶだけにする
どちらにしても、目的は同じ:
- pattern 側へロジックを増やさず(散布しない)
- `ExitKind::Return` へ収束させるMIR では Return 終端として生成される)

View File

@ -0,0 +1,49 @@
# Phase 285 P0docs-only: Box lifecycle / weakref / finalization / GC SSOT
目的: “実装が仕様” になっている Box の寿命・弱参照・最終化を、docs と smoke の SSOT に固定する。
## 1. このP0でやることコード変更なし
1) 仕様SSOTを 1 ファイルにまとめる
- `docs/development/current/main/phases/phase-285/README.md` を入口SSOTとして育てる。
2) 用語と境界を固定する
- strong/weak/roots/finalizer/collection の定義
- weakref の APIupgrade/生存判定)
- finalizer の禁止事項(再入・例外・順序)
3) LLVM harness の扱いを明文化する
- 未対応なら “未対応” を仕様として書く(差分を隠さない)。
## 2. README に必ず書く事項(チェックリスト)
- [ ] “roots” は何かstack/local/global/handle/plugin 等)
- [ ] strong/weak の意味upgrade の成否条件)
- [ ] finalizer はあるか/いつ発火するか/何が禁止か
- [ ] GC/解放のトリガ(自動/手動/閾値/テスト用)
- [ ] VM と LLVM harness の差分(未対応の場合の方針)
## 3. 次P1/P2への導線箇条書きでOK
- P1investigation: 棚卸し対象のファイル一覧と観測ポイント
- P2smoke: fixture の仕様stdout/exitと LLVM 側の扱いPASS/SKIP
## 4. P1 調査チェックリスト(提案)
### Rust VMSSOT
- `src/value.rs`
- `NyashValue::WeakBox` の生成箇所weak をどう作るか)
- `upgrade()` 失敗時の観測方法(文字列化/判定API
- unit test: `test_weak_reference_drop` の仕様(何を固定しているか)
- `src/finalization.rs`
- finalizer の存在(あれば: 登録、呼び出しタイミング、順序)
- 禁止事項(再入/例外/I/O/allocをどこでガードするか
- `src/box_trait.rs` / `src/scope_tracker.rs`
- Box の所有モデルArc/Weakの境界、roots の形成点)
### LLVM harness差分を SSOT 化)
- `src/llvm_py/`
- weakref/finalizer の相当機能があるか(まず “無いなら無い” を明文化)
- 未対応の場合は smoke を SKIP にし、理由をログで固定する方針

View File

@ -0,0 +1,71 @@
# Phase 285: Box lifecycle / weakref / finalization / GC SSOT
Status: Planned (design-first)
## Goal
Box の生存期間(強参照/弱参照/解放/最終化/GCを SSOT として固定し、移行期間でも意味論が割れない状態にする。
## Why now
- JoinIR/Plan/compose の収束が進むほど、実行時の “値の寿命” の揺れが目立つ。
- weakref/finalization は「実装が仕様」になりやすく、後から直すコストが最大級。
- LLVM harness 側は未対応の可能性が高く、差分を “仕様として明文化” しないと再現/調査が難しい。
## SSOT References (current code)
- weakref の値表現: `src/value.rs``NyashValue::WeakBox`
- finalization: `src/finalization.rs`
- Box trait: `src/box_trait.rs``SharedNyashBox = Arc<dyn NyashBox>`
- Scope tracking: `src/scope_tracker.rs`Box の登録/スコープ)
## Snapshot今わかっていること
- weakref は `Weak<Mutex<dyn NyashBox>>` で保持される(`NyashValue::WeakBox`
- `WeakBox``to_string()``upgrade()` を試み、`WeakRef(null)` 表示になりうる(観測可能)
- `src/value.rs` に weakref の drop 挙動を固定する unit test がある(`test_weak_reference_drop`
## Responsibility Mapどこが仕様を決めるか
- **SSOT意味**: Rust VM 実装(`src/value.rs`, `src/finalization.rs` 周辺)
- **SSOT観測**: fixture/smokePhase 285 P2 で作る)
- **LLVM harness**: まずは “差分を仕様として明文化” が優先(未対応なら SKIP を SSOT 化する)
## 用語P0で固定する
- **Strong reference**: 所有参照(`Arc` 等で Box を保持)
- **Weak reference**: 非所有参照(`Weak` / `upgrade()` が失敗しうる)
- **Upgrade**: weak → strong の昇格(成功/失敗が意味論)
- **Roots**: 解放/GC から保護される参照集合stack/local/global/handle/plugin
- **Finalizer**: 解放に伴う最終化処理(もし存在するなら)
## Questions to Answer (P0/P1)
- weakref の “生存判定” は何で観測できるか(`toString` / `is_alive` / `upgrade` API など)
- finalizer は存在するか / いつ発火するかdrop 時GC 時?明示 API
- finalizer 内での禁止事項再入、例外、I/O、allocationをどうするか
- LLVM harness の扱い(現状未対応なら “未対応として SSOT 化”)
## Scope (proposed)
### P0docs-only
- 用語の固定strong/weak/roots/finalizer/collection
- 仕様の固定weakref の upgrade 成否、finalizer の発火条件、禁止事項)
- “LLVM harness の扱い” を明文化(未対応なら未対応として SSOT に書く)
### P1investigation
- Rust VM の現状実装の棚卸し(どこで roots が形成され、どこで解放/最終化されるか)
- LLVM harness の現状調査(弱参照/GC が無い場合は差分として記録)
### P2smoke
- weakref の最小 fixture/smoke を作り、挙動を固定する
- VM: stdout/exit code で固定
- LLVM: 未対応なら “スキップ理由” を smoke で明示
## Non-goals
- GC アルゴリズム刷新RC→tracing 等の設計変更)
- LLVM harness に同等機能を “一気に” 実装(差分の記録→段階導入を優先)

View File

@ -0,0 +1,25 @@
# Phase 286 P0docs-only: JoinIR Line Absorption SSOT
目的: 「JoinIR line が第2の lowerer として残っている」状態を、設計で終わらせる(収束点の SSOT を固定する)。
## このP0でやることコード変更なし
1) 収束点1本化ポイントを SSOT として決める
2) 禁止事項散布・二重SSOTを文章で固定する
3) Phase 284Return/ Phase 285Box lifecycleと整合する責務マップを作る
## README に必ず入れる事項(チェックリスト)
- [ ] 「Plan line / JoinIR line」の現状と、なぜ二重化が危険か迷子の原因
- [ ] 収束後の SSOT フロー(`Extractor → PlanFreeze → Lowerer → Frag/emit_frag`
- [ ] JoinIR の将来位置づけDomainPlan生成補助 / もしくは撤去までの段階)
- [ ] 禁止事項pattern側へ return/break/continue を散布しない、Ok(None)黙殺禁止)
- [ ] 次フェーズP1 investigation / P2 PoCの観測点と最小成功条件
## SSOTリンク
- RouterSSOT=extract / safety valve: `docs/development/current/main/phases/phase-282/README.md`
- Frag/compose/emit SSOT: `docs/development/current/main/design/edgecfg-fragments.md`
- JoinIR line 共通入口: `src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs`
- Plan line SSOT: `docs/development/current/main/phases/phase-273/README.md`

View File

@ -0,0 +1,61 @@
# Phase 286: JoinIR Line AbsorptionJoinIR→CorePlan/Frag 収束)
Status: Planned (design-first)
## Goal
移行期間に残っている「2本の lowering」を、構造で 1 本に収束させる。
- Plan linePattern6/7: `CorePlan → Frag(compose) → emit_frag()` が SSOT
- JoinIR linePattern15,9: `JoinIR → bridge → merge` が SSOT
Phase 286 では JoinIR line を “第2の lowerer” として放置せず、**Plan/Frag SSOT へ吸収**する道筋を固定する。
## Whyなぜ今
- `return` のような「大きな出口語彙」は、責務が分散すると実装場所が揺れて事故りやすい
- 移行期間の弱点は「同じASTでも経路により意味論が割れる可能性がある」こと
- pattern を溶かしていく思想の最後の壁が “JoinIR line の残存” になりやすい
## SSOTPhase 286 で守る憲法)
- **SSOT=extract**Phase 282: 検出は extract の成功でのみ決める。`pattern_kind` は O(1) safety valve のみ。
- **CFG/terminator SSOT**Phase 280/281: `Frag + compose::* + emit_frag()` が唯一の terminator 生成点。
- **Fail-Fast**: close-but-unsupported を `Ok(None)` で黙殺しないsilent reroute 禁止)。
## Responsibility Mapどこを触るか
- JoinIR line の共通入口(現状):
- `src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs`
- `src/mir/join_ir_vm_bridge/bridge.rs`
- `src/mir/builder/control_flow/joinir/merge/mod.rs`
- Plan/Frag SSOT収束先:
- `src/mir/builder/control_flow/plan/*`
- `src/mir/builder/control_flow/edgecfg/api/compose.rs`
- `src/mir/builder/control_flow/edgecfg/api/emit.rs`
## Scope提案
### P0docs-only
- 「JoinIR line をどの粒度で吸収するか」を SSOT として決める
- 例: JoinIR は DomainPlan 生成の補助へ降格 / JoinIR→MIR merge を段階撤去
- “禁止事項” を明文化pattern 側への散布、二重 SSOT の再発)
### P1investigation
- JoinIR line が持っている「本当は SSOT に寄せたい責務」を棚卸し
- return/break/continue の扱い
- exit phi / boundary の責務
- optimizer/type propagation の入り口
### P2PoC
- 代表 1 パターン(例: Pattern4を “JoinIR 生成 → CorePlan/Frag” に変換する PoC
- 目的: merge を通さずに `emit_frag()` 経由で終端が生成できることの証明
## AcceptanceP0
- 2本の lowering が “設計として” どこで 1 本に収束するかが明文化されている
- Phase 284Return/ Phase 285GCと矛盾しない

View File

@ -484,7 +484,15 @@ pub(super) fn merge_and_rewrite(
let remapped = remapper.remap_instruction(inst);
// Phase 189 FIX: Manual block remapping for Branch/Phi (JoinIrIdRemapper doesn't know func_name)
// Phase 259 P0 FIX: Check skipped_entry_redirects first (for k_exit blocks)
// Phase 284 P1 FIX: Check local_block_map FIRST, then skipped_entry_redirects
//
// WHY: Function-local block IDs may collide with skipped_entry_redirects (global IDs).
// Example: loop_step's bb4 (continue block) vs k_exit's remapped entry (also bb4).
// If we check skipped_entry_redirects first, function-local blocks get incorrectly
// redirected to exit_block_id.
//
// RULE: local_block_map takes precedence for function-local blocks.
// skipped_entry_redirects only applies to cross-function references.
let remapped_with_blocks = match remapped {
MirInstruction::Branch {
condition,
@ -493,14 +501,14 @@ pub(super) fn merge_and_rewrite(
then_edge_args,
else_edge_args,
} => {
let remapped_then = skipped_entry_redirects
let remapped_then = local_block_map
.get(&then_bb)
.or_else(|| local_block_map.get(&then_bb))
.or_else(|| skipped_entry_redirects.get(&then_bb))
.copied()
.unwrap_or(then_bb);
let remapped_else = skipped_entry_redirects
let remapped_else = local_block_map
.get(&else_bb)
.or_else(|| local_block_map.get(&else_bb))
.or_else(|| skipped_entry_redirects.get(&else_bb))
.copied()
.unwrap_or(else_bb);
MirInstruction::Branch {
@ -876,17 +884,36 @@ pub(super) fn merge_and_rewrite(
target_block
}
TailCallKind::ExitJump => {
// Exit: jump directly to exit_block_id (not k_exit's entry block)
// k_exit is skipped during merge, so its entry block doesn't exist.
// Phase 259 P0 FIX: Use exit_block_id instead of target_block.
if debug {
log!(
true,
"[cf_loop/joinir] Phase 259 P0: ExitJump redirecting from {:?} to exit_block_id {:?}",
target_block, exit_block_id
);
// Exit: jump to continuation function's entry block
// Phase 284 P1: Check if the target is a skippable continuation
// - Skippable (k_exit): jump to exit_block_id (k_exit blocks are skipped)
// - Non-skippable (k_return): jump to target_block (k_return blocks are merged)
let is_target_skippable = target_func_name
.as_ref()
.map(|name| skippable_continuation_func_names.contains(name))
.unwrap_or(false);
if is_target_skippable {
// Phase 259 P0 FIX: Skippable continuation - use exit_block_id
if debug {
log!(
true,
"[cf_loop/joinir] Phase 259 P0: ExitJump (skippable) redirecting from {:?} to exit_block_id {:?}",
target_block, exit_block_id
);
}
exit_block_id
} else {
// Phase 284 P1: Non-skippable continuation - use remapped target_block
if debug {
log!(
true,
"[cf_loop/joinir] Phase 284 P1: ExitJump (non-skippable) to target_block {:?}",
target_block
);
}
target_block
}
exit_block_id
}
};
@ -924,6 +951,19 @@ pub(super) fn merge_and_rewrite(
let mut remapped_term: Option<MirInstruction> = None;
match term {
MirInstruction::Return { value } => {
// Phase 284 P1: Non-skippable continuations (like k_return) should keep Return
// Only convert Return → Jump for skippable continuations and regular loop body
if is_continuation_candidate && !is_skippable_continuation {
// Non-skippable continuation (e.g., k_return): keep Return terminator
// Remap the return value to HOST value space
let remapped_value = value.map(|v| remapper.remap_value(v));
new_block.set_terminator(MirInstruction::Return { value: remapped_value });
log!(
true,
"[cf_loop/joinir] Phase 284 P1: Keeping Return for non-skippable continuation '{}' (value={:?})",
func_name, remapped_value
);
} else {
// Convert Return to Jump to exit block
// All functions return to same exit block (Phase 189)
//
@ -1073,6 +1113,7 @@ pub(super) fn merge_and_rewrite(
edge_args: None,
});
}
} // Phase 284 P1: Close else block for skippable/regular Return → Jump
}
MirInstruction::Jump { target, edge_args } => {
// Phase 260 P0.1 Step 5: Use terminator::remap_jump()

View File

@ -27,13 +27,15 @@ fn remap_edge_args(
/// Remap Jump instruction
///
/// Applies block ID remapping (skipped_entry_redirects + local_block_map) and
/// Applies block ID remapping (local_block_map + skipped_entry_redirects) and
/// edge_args ValueId remapping.
///
/// # Phase 259 P0 FIX
/// # Phase 284 P1 FIX
///
/// Checks skipped_entry_redirects FIRST (for k_exit blocks that were skipped
/// during merge). Fallback to local_block_map if not found.
/// Checks local_block_map FIRST for function-local blocks.
/// Fallback to skipped_entry_redirects for cross-function references (skipped continuations).
///
/// WHY: Function-local block IDs may collide with skipped_entry_redirects (global IDs).
pub(in crate::mir::builder::control_flow::joinir::merge) fn remap_jump(
remapper: &JoinIrIdRemapper,
target: BasicBlockId,
@ -41,9 +43,9 @@ pub(in crate::mir::builder::control_flow::joinir::merge) fn remap_jump(
skipped_entry_redirects: &BTreeMap<BasicBlockId, BasicBlockId>,
local_block_map: &BTreeMap<BasicBlockId, BasicBlockId>,
) -> MirInstruction {
let remapped_target = skipped_entry_redirects
let remapped_target = local_block_map
.get(&target)
.or_else(|| local_block_map.get(&target))
.or_else(|| skipped_entry_redirects.get(&target))
.copied()
.unwrap_or(target);
@ -55,12 +57,15 @@ pub(in crate::mir::builder::control_flow::joinir::merge) fn remap_jump(
/// Remap Branch instruction
///
/// Applies block ID remapping (skipped_entry_redirects + local_block_map) for
/// Applies block ID remapping (local_block_map + skipped_entry_redirects) for
/// both then/else branches, condition ValueId remapping, and edge_args remapping.
///
/// # Phase 259 P0 FIX
/// # Phase 284 P1 FIX
///
/// Checks skipped_entry_redirects FIRST (for k_exit blocks).
/// Checks local_block_map FIRST for function-local blocks.
/// Fallback to skipped_entry_redirects for cross-function references.
///
/// WHY: Function-local block IDs may collide with skipped_entry_redirects (global IDs).
pub(in crate::mir::builder::control_flow::joinir::merge) fn remap_branch(
remapper: &JoinIrIdRemapper,
condition: ValueId,
@ -71,15 +76,15 @@ pub(in crate::mir::builder::control_flow::joinir::merge) fn remap_branch(
skipped_entry_redirects: &BTreeMap<BasicBlockId, BasicBlockId>,
local_block_map: &BTreeMap<BasicBlockId, BasicBlockId>,
) -> MirInstruction {
let remapped_then = skipped_entry_redirects
let remapped_then = local_block_map
.get(&then_bb)
.or_else(|| local_block_map.get(&then_bb))
.or_else(|| skipped_entry_redirects.get(&then_bb))
.copied()
.unwrap_or(then_bb);
let remapped_else = skipped_entry_redirects
let remapped_else = local_block_map
.get(&else_bb)
.or_else(|| local_block_map.get(&else_bb))
.or_else(|| skipped_entry_redirects.get(&else_bb))
.copied()
.unwrap_or(else_bb);

View File

@ -7,6 +7,7 @@
//! - Convert JoinModule to MirModule
//! - Merge MirModule blocks into current function
//! - Handle boundary mapping and exit PHI generation
//! - **Phase 284 P1**: Handle return statements via return_collector SSOT
//!
//! ## Usage
//!
@ -26,9 +27,12 @@
//! - **Consistent error handling**: Unified error messages
//! - **Testability**: Can test conversion independently
//! - **Reduces duplication**: Eliminates 120 lines across Pattern 1-4
//! - **Phase 284 P1**: SSOT for return statement handling (not scattered in patterns)
use crate::ast::ASTNode;
use crate::mir::builder::MirBuilder;
use crate::mir::join_ir::lowering::inline_boundary::JoinInlineBoundary;
use crate::mir::join_ir::lowering::return_collector::{collect_return_from_body, ReturnInfo};
use crate::mir::join_ir::JoinModule;
use crate::mir::ValueId;
use std::collections::BTreeMap;
@ -82,6 +86,63 @@ impl JoinIRConversionPipeline {
pattern_name: &str,
debug: bool,
) -> Result<Option<ValueId>, String> {
// Phase 284 P1: Delegate to execute_with_body with None (backward compatibility)
Self::execute_with_body(builder, join_module, boundary, pattern_name, debug, None)
}
/// Execute unified conversion pipeline with optional body for return detection
///
/// Phase 284 P1: This is the SSOT for return statement handling.
/// Patterns should call this with body to enable return detection.
///
/// # Arguments
///
/// - `builder`: MirBuilder instance for merging blocks
/// - `join_module`: JoinIR module to convert
/// - `boundary`: Optional boundary mapping for input/output values
/// - `pattern_name`: Name for debug messages (e.g., "pattern1", "pattern4")
/// - `debug`: Enable debug output
/// - `body`: Optional loop body for return detection (Phase 284 P1)
///
/// # Returns
///
/// - `Ok(Some(ValueId))`: Exit PHI result or return value
/// - `Ok(None)`: No exit PHI generated (simple loops without return)
/// - `Err(String)`: Conversion or merge failure, or unsupported return pattern
pub fn execute_with_body(
builder: &mut MirBuilder,
join_module: JoinModule,
boundary: Option<&JoinInlineBoundary>,
pattern_name: &str,
debug: bool,
body: Option<&[ASTNode]>,
) -> Result<Option<ValueId>, String> {
// Phase 284 P1: Check for return statements in body (SSOT)
let return_info = if let Some(body) = body {
match collect_return_from_body(body) {
Ok(info) => info,
Err(e) => {
return Err(format!(
"[{}/pipeline] Return detection failed: {}",
pattern_name, e
))
}
}
} else {
None
};
// Phase 284 P1: If return found, generate Return terminator
if let Some(ret_info) = &return_info {
// For now, we generate a Return terminator with the literal value
// This is added after the normal loop processing
if debug {
eprintln!(
"[{}/pipeline] Phase 284 P1: Return detected with value {}",
pattern_name, ret_info.value
);
}
}
use super::super::trace;
use crate::mir::join_ir::frontend::JoinFuncMetaMap;
use crate::mir::join_ir_vm_bridge::bridge_joinir_to_mir_with_meta;
@ -129,6 +190,25 @@ impl JoinIRConversionPipeline {
// Step 4: Merge into current function
let exit_phi_result = builder.merge_joinir_mir_blocks(&mir_module, boundary, debug)?;
// Phase 284 P1: Log return detection (actual handling is in JoinIR lowerer)
// The JoinIR lowerer should have already processed the return and added JoinInst::Ret
// to the JoinModule. The bridge converts JoinInst::Ret to MIR Return terminator.
if return_info.is_some() && debug {
eprintln!(
"[{}/pipeline] Phase 284 P1: Return was detected in body (processed by JoinIR lowerer)",
pattern_name
);
}
Ok(exit_phi_result)
}
/// Get return info from loop body (Phase 284 P1 SSOT)
///
/// This is the SSOT for return detection. Patterns should use this
/// before constructing JoinModule to know if return handling is needed.
#[allow(dead_code)]
pub fn detect_return(body: &[ASTNode]) -> Result<Option<ReturnInfo>, String> {
collect_return_from_body(body)
}
}

View File

@ -4,9 +4,8 @@
use crate::ast::ASTNode;
// Phase 282 P9a: Use common_helpers
use super::common_helpers::{
count_control_flow, has_break_statement, has_return_statement, ControlFlowDetector,
};
// Phase 284 P1: has_return_statement removed (now handled by return_collector SSOT)
use super::common_helpers::{count_control_flow, has_break_statement, ControlFlowDetector};
#[derive(Debug, Clone)]
pub(crate) struct Pattern4Parts {
@ -66,14 +65,8 @@ pub(crate) fn extract_loop_with_continue_parts(
return Ok(None);
}
// Phase 4: Check for return (USER CORRECTION: Err, not Ok(None)!)
if has_return_statement_recursive(body) {
// Has return → Fail-fast (close-but-unsupported)
// Phase 142 P2: Return in Pattern4 not yet supported
return Err(
"Pattern4 with return statement not yet supported (Phase 142 P2 pending)".to_string(),
);
}
// Phase 284 P1: Return check removed - now handled by return_collector SSOT
// in conversion_pipeline.rs (JoinIR line common entry point)
// Phase 5: Return extracted parts
// USER CORRECTION: No loop_var update validation - defer to Pattern4CarrierAnalyzer
@ -103,16 +96,8 @@ fn has_break_statement_recursive(body: &[ASTNode]) -> bool {
has_break_statement(body)
}
/// Check recursively if body has return statement
///
/// # Phase 282 P9a: Delegates to common_helpers::has_return_statement
///
/// Note: common_helpers skips nested loop bodies by default, which differs from
/// Pattern4's original behavior (which recursed into nested loops for return).
/// However, this is acceptable because return detection is fail-fast anyway.
fn has_return_statement_recursive(body: &[ASTNode]) -> bool {
has_return_statement(body)
}
// Phase 284 P1: has_return_statement_recursive removed
// Return detection now handled by return_collector SSOT in conversion_pipeline.rs
// ============================================================================
// Unit Tests
@ -231,8 +216,9 @@ mod tests {
}
#[test]
fn test_pattern4_with_return_returns_err() {
// loop(i < 10) { if (done) { return } i = i + 1 } → Err (unsupported)
fn test_pattern4_with_return_is_allowed() {
// Phase 284 P1: loop(i < 10) { if (done) { return } i = i + 1 } → Ok(Some(...))
// Return check moved to return_collector SSOT in conversion_pipeline.rs
let condition = make_condition("i", 10);
let body = vec![
ASTNode::If {
@ -252,10 +238,12 @@ mod tests {
];
let result = extract_loop_with_continue_parts(&condition, &body);
assert!(result.is_err()); // USER CORRECTION: return → Err (not Ok(None))
let err_msg = result.unwrap_err();
assert!(err_msg.contains("return statement not yet supported"));
assert!(err_msg.contains("Phase 142 P2"));
assert!(result.is_ok()); // Phase 284 P1: Now allowed at extractor level
let parts = result.unwrap();
assert!(parts.is_some()); // Pattern4 extraction succeeds
let parts = parts.unwrap();
assert_eq!(parts.loop_var, "i");
assert_eq!(parts.continue_count, 1);
}
#[test]

View File

@ -85,13 +85,9 @@ pub(crate) fn extract_infinite_early_exit_parts(
let (break_count, continue_count, return_count, has_nested_loop) =
count_control_flow_recursive(body);
// USER GUIDANCE: return があったら Errclose-but-unsupported
// 文言統一: lower() の Err と同じ文言を使用(二重仕様防止)
if return_count > 0 {
return Err(
"Pattern5: return in loop body is not supported (design-first; see Phase 284 Return as ExitKind SSOT)".to_string()
);
}
// Phase 284 P1: Return check removed - now handled by return_collector SSOT
// in conversion_pipeline.rs (JoinIR line common entry point)
// Note: return_count is still tracked for debug logging
// ========================================================================
// Block 3: Validate break/continue counts (exactly 1 each)
@ -212,21 +208,25 @@ mod tests {
}
#[test]
fn test_pattern5_with_return_returns_err() {
// loop(true) { if (...) { return } continue } → Err (USER GUIDANCE!)
fn test_pattern5_with_return_is_allowed() {
// Phase 284 P1: loop(true) { if (...) { return } if (done) { break } continue }
// Return check moved to return_collector SSOT in conversion_pipeline.rs
// Note: Pattern5 requires exactly 1 break, so we need to add one
let condition = make_true_literal();
let body = vec![
make_if_return(), // if (...) { return }
make_if_return(), // if (...) { return }
make_if_break(), // if (done) { break } - required for Pattern5
make_continue(),
];
let result = extract_infinite_early_exit_parts(&condition, &body);
assert!(result.is_err()); // return → Err (close-but-unsupported)
// 文言統一チェック: Phase 284 参照の固定文言を確認
let err_msg = result.unwrap_err();
assert!(err_msg.contains("Pattern5: return in loop body is not supported"));
assert!(err_msg.contains("Phase 284 Return as ExitKind SSOT"));
assert!(result.is_ok()); // Phase 284 P1: Now allowed at extractor level
let parts = result.unwrap();
assert!(parts.is_some()); // Pattern5 extraction succeeds
let parts = parts.unwrap();
assert_eq!(parts.break_count, 1);
assert_eq!(parts.continue_count, 1);
assert_eq!(parts.return_count, 1); // Return is now tracked, not rejected
}
#[test]

View File

@ -39,48 +39,8 @@ use crate::mir::loop_pattern_detection::error_messages;
use crate::mir::ValueId;
use std::collections::BTreeMap;
/// Phase 142 P2: Detect return statements in loop body
///
/// This is a helper function for Fail-Fast behavior when return statements
/// are detected in Pattern4 (continue) loops, which are not yet fully supported.
///
/// # Arguments
///
/// * `body` - Loop body statements to scan
///
/// # Returns
///
/// `true` if at least one return statement is found in the body
fn has_return_in_body(body: &[ASTNode]) -> bool {
for stmt in body {
if has_return_node(stmt) {
return true;
}
}
false
}
/// Helper: Recursively check if node or its children contain return
fn has_return_node(node: &ASTNode) -> bool {
match node {
ASTNode::Return { .. } => true,
ASTNode::If {
then_body,
else_body,
..
} => {
then_body.iter().any(|n| has_return_node(n))
|| else_body
.as_ref()
.map_or(false, |body| body.iter().any(|n| has_return_node(n)))
}
ASTNode::Loop { body, .. } => {
// Nested loops: scan recursively (though not common in our patterns)
body.iter().any(|n| has_return_node(n))
}
_ => false,
}
}
// Phase 284 P1: has_return_in_body/has_return_node removed
// Return detection now handled by return_collector SSOT in conversion_pipeline.rs
/// Phase 282 P6: Detection function for Pattern 4 (ExtractionBased)
///
@ -194,16 +154,8 @@ pub(crate) fn lower(
),
);
// Phase 142 P2: Double-check for return statements (defensive - extractor already checks)
// This check is now redundant (extractor returns Err), but kept for backward compatibility
if has_return_in_body(ctx.body) {
return Err(
"[Pattern4] Early return is not yet supported in continue loops. \
This will be implemented in Phase 142 P2. \
Pattern: loop with both continue and return statements."
.to_string(),
);
}
// Phase 284 P1: Return check removed - now handled by return_collector SSOT
// in conversion_pipeline.rs (JoinIR line common entry point)
// Phase 33-19: Connect to actual implementation (zero behavior change)
builder.cf_loop_pattern4_with_continue(ctx.condition, ctx.body, ctx.func_name, ctx.debug)
@ -254,19 +206,21 @@ impl MirBuilder {
}
/// Preprocessed data for Pattern 4 lowering.
struct Pattern4Prepared {
struct Pattern4Prepared<'a> {
loop_var_name: String,
loop_scope: crate::mir::join_ir::lowering::loop_scope_shape::LoopScopeShape,
carrier_info: crate::mir::join_ir::lowering::carrier_info::CarrierInfo,
carrier_updates: BTreeMap<String, UpdateExpr>,
/// Phase 284 P1: Reference to loop body for return detection
body: &'a [ASTNode],
}
/// Normalize, build context, analyze carriers, and promote loop-body locals.
fn prepare_pattern4_context(
fn prepare_pattern4_context<'a>(
builder: &mut MirBuilder,
condition: &ASTNode,
body: &[ASTNode],
) -> Result<Pattern4Prepared, String> {
body: &'a [ASTNode],
) -> Result<Pattern4Prepared<'a>, String> {
use super::pattern4_carrier_analyzer::Pattern4CarrierAnalyzer;
use super::pattern_pipeline::{build_pattern_context, PatternVariant};
use crate::mir::loop_pattern_detection::loop_body_cond_promoter::{
@ -423,6 +377,7 @@ fn prepare_pattern4_context(
loop_scope,
carrier_info,
carrier_updates,
body, // Phase 284 P1: Include body for return detection
})
}
@ -430,17 +385,38 @@ fn prepare_pattern4_context(
fn lower_pattern4_joinir(
builder: &mut MirBuilder,
condition: &ASTNode,
prepared: &Pattern4Prepared,
prepared: &Pattern4Prepared<'_>,
debug: bool,
) -> Result<Option<ValueId>, String> {
use super::super::merge::exit_line::meta_collector::ExitMetaCollector;
use super::conversion_pipeline::JoinIRConversionPipeline;
use crate::mir::join_ir::lowering::join_value_space::JoinValueSpace;
use crate::mir::join_ir::lowering::loop_with_continue_minimal::lower_loop_with_continue_minimal;
use crate::mir::join_ir::lowering::return_collector::{collect_return_from_body, ReturnInfo};
use crate::mir::join_ir::lowering::JoinInlineBoundaryBuilder;
trace::trace().varmap("pattern4_start", &builder.variable_ctx.variable_map);
// Phase 284 P1: Detect return statements in body
let return_info: Option<ReturnInfo> = match collect_return_from_body(prepared.body) {
Ok(info) => info,
Err(e) => {
return Err(format!("[pattern4] Return detection failed: {}", e));
}
};
if let Some(ref ret_info) = return_info {
trace::trace().debug(
"pattern4",
&format!(
"Phase 284 P1: Return detected - value={}, has_condition={}, in_else={}",
ret_info.value,
ret_info.condition.is_some(),
ret_info.in_else
),
);
}
let mut join_value_space = JoinValueSpace::new();
#[cfg(feature = "normalized_dev")]
@ -454,6 +430,7 @@ fn lower_pattern4_joinir(
&prepared.carrier_info,
&prepared.carrier_updates,
&mut join_value_space,
return_info.as_ref(), // Phase 284 P1
#[cfg(feature = "normalized_dev")]
Some(&binding_map_clone),
) {
@ -520,11 +497,23 @@ fn lower_pattern4_joinir(
),
);
// Phase 284 P1: Build continuation set - include k_return if return_info exists
let continuation_funcs = {
use crate::mir::join_ir::lowering::canonical_names as cn;
let mut funcs = std::collections::BTreeSet::new();
funcs.insert(cn::K_EXIT.to_string());
if return_info.is_some() {
funcs.insert(cn::K_RETURN.to_string());
}
funcs
};
let boundary = JoinInlineBoundaryBuilder::new()
.with_inputs(join_inputs, host_inputs) // Dynamic carrier count
.with_exit_bindings(exit_bindings)
.with_loop_var_name(Some(prepared.loop_var_name.clone()))
.with_carrier_info(prepared.carrier_info.clone())
.with_continuation_funcs(continuation_funcs) // Phase 284 P1
.build();
let _result_val = JoinIRConversionPipeline::execute(

View File

@ -70,6 +70,14 @@ pub const MAIN: &str = "main";
/// - Normalized shadow exit routing
pub const POST_K: &str = "post_k";
/// Phase 284 P1: Canonical name for early return exit function
///
/// Used in:
/// - Pattern 4, 5 (loop patterns with early return)
/// - JoinInlineBoundary.continuation_funcs
/// - ExitLine/ExitMeta handling for return statements
pub const K_RETURN: &str = "k_return";
#[cfg(test)]
mod tests {
use super::*;
@ -81,6 +89,7 @@ mod tests {
assert!(!LOOP_STEP.is_empty());
assert!(!MAIN.is_empty());
assert!(!POST_K.is_empty());
assert!(!K_RETURN.is_empty());
}
#[test]
@ -90,6 +99,7 @@ mod tests {
assert_eq!(LOOP_STEP, "loop_step");
assert_eq!(MAIN, "main");
assert_eq!(POST_K, "post_k");
assert_eq!(K_RETURN, "k_return");
}
#[test]

View File

@ -68,6 +68,7 @@ use crate::mir::join_ir::lowering::join_value_space::JoinValueSpace;
use crate::mir::join_ir::lowering::loop_body_local_env::LoopBodyLocalEnv; // Phase 244
use crate::mir::join_ir::lowering::loop_scope_shape::LoopScopeShape;
use crate::mir::join_ir::lowering::loop_update_analyzer::{UpdateExpr, UpdateRhs};
use crate::mir::join_ir::lowering::return_collector::ReturnInfo; // Phase 284 P1
use crate::mir::join_ir::{
BinOpKind, CompareOp, ConstValue, JoinFuncId, JoinFunction, JoinInst, JoinModule, MirLikeInst,
UnaryOp,
@ -109,6 +110,7 @@ use std::collections::BTreeMap; // Phase 222.5-D: HashMap → BTreeMap for deter
/// * `carrier_info` - Phase 196: Carrier metadata for dynamic multi-carrier support
/// * `carrier_updates` - Phase 197: Update expressions for each carrier variable
/// * `join_value_space` - Phase 202-C: Unified JoinIR ValueId allocator (Local region: 1000+)
/// * `return_info` - Phase 284 P1: Optional return statement info for early exit
///
/// # Returns
///
@ -122,6 +124,12 @@ use std::collections::BTreeMap; // Phase 222.5-D: HashMap → BTreeMap for deter
/// - **Output slots**: k_exit returns all carrier values
/// - **Exit metadata**: ExitMeta containing all carrier bindings
/// - **Caller responsibility**: Create JoinInlineBoundary to map ValueIds
///
/// # Phase 284 P1: Return Handling
///
/// If `return_info` is provided, generates:
/// - A `k_return` function that returns the literal value
/// - Conditional jump to k_return when return condition is met
pub(crate) fn lower_loop_with_continue_minimal(
_scope: LoopScopeShape,
condition: &ASTNode,
@ -129,6 +137,7 @@ pub(crate) fn lower_loop_with_continue_minimal(
carrier_info: &CarrierInfo,
carrier_updates: &BTreeMap<String, UpdateExpr>, // Phase 222.5-D: HashMap → BTreeMap for determinism
join_value_space: &mut JoinValueSpace,
return_info: Option<&ReturnInfo>, // Phase 284 P1
#[cfg(feature = "normalized_dev")] binding_map: Option<
&std::collections::BTreeMap<String, crate::mir::BindingId>,
>,
@ -178,6 +187,8 @@ pub(crate) fn lower_loop_with_continue_minimal(
let main_id = JoinFuncId::new(0);
let loop_step_id = JoinFuncId::new(1);
let k_exit_id = JoinFuncId::new(2);
// Phase 284 P1: k_return for early return handling
let k_return_id = JoinFuncId::new(3);
// ==================================================================
// ValueId allocation (Phase 202-C: Dynamic based on carrier count)
@ -416,6 +427,108 @@ pub(crate) fn lower_loop_with_continue_minimal(
rhs: const_1,
}));
// ------------------------------------------------------------------
// Phase 284 P1: Return Condition Check (if return_info present)
// ------------------------------------------------------------------
// For fixture: if (i == 3) { return 7 }
// Condition is checked against i_next (after increment)
if let Some(ret_info) = return_info {
debug.log(
"phase284",
&format!(
"Generating return handling: value={}, has_condition={}",
ret_info.value,
ret_info.condition.is_some()
),
);
if let Some(ref cond_ast) = ret_info.condition {
// Return is inside an if block - need to evaluate condition
// Phase 284 P1: Only support simple comparison (i == N)
// Extract the comparison value from the condition AST
if let ASTNode::BinaryOp {
operator: crate::ast::BinaryOperator::Equal,
left,
right,
..
} = cond_ast.as_ref()
{
// Check if left is loop variable and right is integer
let compare_value = match (left.as_ref(), right.as_ref()) {
(
ASTNode::Variable { name, .. },
ASTNode::Literal {
value: crate::ast::LiteralValue::Integer(n),
..
},
) if name == &loop_var_name => Some(*n),
_ => None,
};
if let Some(cmp_val) = compare_value {
// Generate: return_cond = (i_next == cmp_val)
let return_cmp_const = alloc_value();
let return_cond = alloc_value();
loop_step_func
.body
.push(JoinInst::Compute(MirLikeInst::Const {
dst: return_cmp_const,
value: ConstValue::Integer(cmp_val),
}));
// Phase 284 P1: Use i_next because fixture has increment BEFORE the if check
// Execution: i_next = i_param + 1, then check if i_next == 3
loop_step_func
.body
.push(JoinInst::Compute(MirLikeInst::Compare {
dst: return_cond,
op: if ret_info.in_else {
CompareOp::Ne
} else {
CompareOp::Eq
},
lhs: i_next, // Use i_next (post-increment value)
rhs: return_cmp_const,
}));
// Generate: Jump(k_return, [], cond=return_cond)
loop_step_func.body.push(JoinInst::Jump {
cont: k_return_id.as_cont(),
args: vec![],
cond: Some(return_cond),
});
debug.log(
"phase284",
&format!(
"Return condition: i_next == {} → jump to k_return",
cmp_val
),
);
} else {
debug.log(
"phase284",
"Return condition not supported (not loop_var == N pattern)",
);
}
} else {
debug.log(
"phase284",
"Return condition not supported (not Equal comparison)",
);
}
} else {
// Unconditional return - always jump to k_return
loop_step_func.body.push(JoinInst::Jump {
cont: k_return_id.as_cont(),
args: vec![],
cond: None,
});
debug.log("phase284", "Unconditional return → jump to k_return");
}
}
// ------------------------------------------------------------------
// Continue Condition Check: (i_next % 2 == 0)
// ------------------------------------------------------------------
@ -667,6 +780,38 @@ pub(crate) fn lower_loop_with_continue_minimal(
join_module.add_function(k_exit_func);
// ==================================================================
// Phase 284 P1: k_return() function for early return
// ==================================================================
if let Some(ret_info) = return_info {
let return_value_id = alloc_value();
let mut k_return_func = JoinFunction::new(k_return_id, "k_return".to_string(), vec![]);
// Generate: return_value = Const(ret_info.value)
k_return_func
.body
.push(JoinInst::Compute(MirLikeInst::Const {
dst: return_value_id,
value: ConstValue::Integer(ret_info.value),
}));
// Generate: Ret(return_value)
k_return_func.body.push(JoinInst::Ret {
value: Some(return_value_id),
});
join_module.add_function(k_return_func);
debug.log(
"phase284",
&format!(
"Generated k_return function: returns {}",
ret_info.value
),
);
}
// Set entry point
join_module.entry = Some(main_id);

View File

@ -65,6 +65,7 @@ pub mod loop_update_summary; // Phase 170-C-2: Update pattern summary for shape
pub(crate) mod loop_view_builder; // Phase 33-23: Loop lowering dispatch
pub mod loop_with_break_minimal; // Phase 188-Impl-2: Pattern 2 minimal lowerer
pub mod loop_with_continue_minimal;
pub(crate) mod return_collector; // Phase 284 P1: Return statement collector SSOT
pub mod method_call_lowerer; // Phase 224-B: MethodCall lowering (metadata-driven)
pub mod user_method_policy; // Phase 252: User-defined method policy (SSOT for static box method whitelists)
pub mod method_return_hint; // Phase 83: P3-D 既知メソッド戻り値型推論箱

View File

@ -0,0 +1,294 @@
//! Phase 284 P1: Return Collector for JoinIR Lowering
//!
//! SSOT for detecting return statements in loop bodies.
//! All JoinIR patterns (Pattern4/5/etc.) use this common helper.
//!
//! # P1 Scope
//!
//! - Single return statement only (multiple → Err)
//! - Return value must be integer literal (other types → Err)
//! - Return can be in top-level if's then/else (recursive scan)
//! - Return in nested loop → Err
//!
//! # Design
//!
//! This collector extracts return info from AST, which is later converted
//! to JoinInst::Ret in the JoinIR lowerer for proper MIR generation.
use crate::ast::{ASTNode, LiteralValue};
/// Phase 284 P1: Return statement info from loop body
#[derive(Debug, Clone)]
pub struct ReturnInfo {
/// The integer literal value (P1 scope: only integer literals supported)
pub value: i64,
/// The if condition (Some if return is inside an if block)
/// This is used to generate conditional jump in JoinIR
pub condition: Option<Box<ASTNode>>,
/// Whether the return is in the else branch (negates condition)
pub in_else: bool,
}
/// Collect return statement from loop body
///
/// # P1 Scope
///
/// - Single return statement only
/// - Return value must be integer literal
/// - Return can be in top-level if's then/else (recursive scan)
/// - Return in nested loop is Err
///
/// # Returns
///
/// - `Ok(Some(info))` - Single return found with integer literal value and condition
/// - `Ok(None)` - No return found
/// - `Err(msg)` - Unsupported pattern (Fail-Fast)
pub fn collect_return_from_body(body: &[ASTNode]) -> Result<Option<ReturnInfo>, String> {
let mut found_returns: Vec<ReturnInfo> = Vec::new();
collect_returns_recursive(body, &mut found_returns, None, false)?;
match found_returns.len() {
0 => Ok(None),
1 => Ok(Some(found_returns.remove(0))),
n => Err(format!(
"Phase 284 P1 scope: multiple return statements not yet supported (found {})",
n
)),
}
}
/// Recursive helper to collect return statements from if branches
///
/// # Arguments
///
/// * `body` - Current body to scan
/// * `found` - Accumulator for found return statements
/// * `current_condition` - If condition if we're inside an if block
/// * `in_else` - Whether we're in the else branch
fn collect_returns_recursive(
body: &[ASTNode],
found: &mut Vec<ReturnInfo>,
current_condition: Option<&ASTNode>,
in_else: bool,
) -> Result<(), String> {
for stmt in body {
match stmt {
ASTNode::Return { value, .. } => {
// P1 scope: return value must be integer literal
let return_value = match value {
Some(boxed_value) => match boxed_value.as_ref() {
ASTNode::Literal {
value: LiteralValue::Integer(n),
..
} => *n,
_ => {
return Err(
"Phase 284 P1 scope: return value must be integer literal"
.to_string(),
);
}
},
None => {
return Err(
"Phase 284 P1 scope: return must have a value (void return not supported)"
.to_string(),
);
}
};
found.push(ReturnInfo {
value: return_value,
condition: current_condition.map(|c| Box::new(c.clone())),
in_else,
});
}
ASTNode::If {
condition,
then_body,
else_body,
..
} => {
// Recurse into if branches with the condition tracked
// For then branch: use condition as-is
collect_returns_recursive(then_body, found, Some(condition.as_ref()), false)?;
// For else branch: mark in_else=true (condition should be negated)
if let Some(else_b) = else_body {
collect_returns_recursive(else_b, found, Some(condition.as_ref()), true)?;
}
}
ASTNode::Loop { body: nested, .. } => {
// P1 scope: return in nested loop is NOT supported
if has_return_in_body(nested) {
return Err(
"Phase 284 P1 scope: return in nested loop not yet supported".to_string(),
);
}
// Don't recurse into nested loops for return collection
}
_ => {}
}
}
Ok(())
}
/// Helper: Check if body contains any return statement (recursive)
fn has_return_in_body(body: &[ASTNode]) -> bool {
for stmt in body {
if matches!(stmt, ASTNode::Return { .. }) {
return true;
}
match stmt {
ASTNode::If {
then_body,
else_body,
..
} => {
if has_return_in_body(then_body) {
return true;
}
if let Some(else_b) = else_body {
if has_return_in_body(else_b) {
return true;
}
}
}
ASTNode::Loop { body: nested, .. } => {
if has_return_in_body(nested) {
return true;
}
}
_ => {}
}
}
false
}
// ============================================================================
// Unit Tests
// ============================================================================
#[cfg(test)]
mod tests {
use super::*;
use crate::ast::Span;
fn make_int_return(n: i64) -> ASTNode {
ASTNode::Return {
value: Some(Box::new(ASTNode::Literal {
value: LiteralValue::Integer(n),
span: Span::unknown(),
})),
span: Span::unknown(),
}
}
fn make_if_with_return(n: i64) -> ASTNode {
ASTNode::If {
condition: Box::new(ASTNode::Variable {
name: "x".to_string(),
span: Span::unknown(),
}),
then_body: vec![make_int_return(n)],
else_body: None,
span: Span::unknown(),
}
}
#[test]
fn test_no_return() {
let body = vec![];
let result = collect_return_from_body(&body);
assert!(result.is_ok());
assert!(result.unwrap().is_none());
}
#[test]
fn test_single_top_level_return() {
let body = vec![make_int_return(7)];
let result = collect_return_from_body(&body);
assert!(result.is_ok());
let info = result.unwrap().unwrap();
assert_eq!(info.value, 7);
assert!(info.condition.is_none()); // Top-level, no condition
assert!(!info.in_else);
}
#[test]
fn test_return_in_if_then() {
let body = vec![make_if_with_return(42)];
let result = collect_return_from_body(&body);
assert!(result.is_ok());
let info = result.unwrap().unwrap();
assert_eq!(info.value, 42);
assert!(info.condition.is_some()); // Has condition from if
assert!(!info.in_else); // In then branch
}
#[test]
fn test_return_in_if_else() {
let body = vec![ASTNode::If {
condition: Box::new(ASTNode::Variable {
name: "x".to_string(),
span: Span::unknown(),
}),
then_body: vec![],
else_body: Some(vec![make_int_return(99)]),
span: Span::unknown(),
}];
let result = collect_return_from_body(&body);
assert!(result.is_ok());
let info = result.unwrap().unwrap();
assert_eq!(info.value, 99);
assert!(info.condition.is_some()); // Has condition from if
assert!(info.in_else); // In else branch (condition should be negated)
}
#[test]
fn test_multiple_returns_err() {
let body = vec![make_int_return(1), make_int_return(2)];
let result = collect_return_from_body(&body);
assert!(result.is_err());
assert!(result.unwrap_err().contains("multiple return"));
}
#[test]
fn test_return_in_nested_loop_err() {
let body = vec![ASTNode::Loop {
condition: Box::new(ASTNode::Literal {
value: LiteralValue::Bool(true),
span: Span::unknown(),
}),
body: vec![make_int_return(7)],
span: Span::unknown(),
}];
let result = collect_return_from_body(&body);
assert!(result.is_err());
assert!(result.unwrap_err().contains("nested loop"));
}
#[test]
fn test_non_integer_return_err() {
let body = vec![ASTNode::Return {
value: Some(Box::new(ASTNode::Literal {
value: LiteralValue::String("hello".to_string()),
span: Span::unknown(),
})),
span: Span::unknown(),
}];
let result = collect_return_from_body(&body);
assert!(result.is_err());
assert!(result.unwrap_err().contains("integer literal"));
}
#[test]
fn test_void_return_err() {
let body = vec![ASTNode::Return {
value: None,
span: Span::unknown(),
}];
let result = collect_return_from_body(&body);
assert!(result.is_err());
assert!(result.unwrap_err().contains("void return"));
}
}

View File

@ -0,0 +1,23 @@
#!/bin/bash
# Phase 284 P1: Return in loop test (LLVM EXE)
# Expected: Exit code 7 from early return
source "$(dirname "$0")/../../../lib/test_runner.sh"
source "$(dirname "$0")/../../../lib/llvm_exe_runner.sh"
export SMOKES_USE_PYVM=0
require_env || exit 2
llvm_exe_preflight_or_skip || exit 0
# No plugins required for this minimal test
INPUT_HAKO="$NYASH_ROOT/apps/tests/phase284_p1_return_in_loop_min.hako"
OUTPUT_EXE="$NYASH_ROOT/tmp/phase284_p1_return_in_loop_llvm_exe"
EXPECTED_EXIT_CODE=7
LLVM_BUILD_LOG="/tmp/phase284_p1_return_in_loop_build.log"
if llvm_exe_build_and_run_expect_exit_code; then
test_pass "phase284_p1_return_in_loop_llvm: exit code 7 (early return from loop)"
else
exit 1
fi

View File

@ -0,0 +1,47 @@
#!/bin/bash
# Phase 284 P1: Return in loop test (VM)
# Expected: Exit code 7 from early return
source "$(dirname "$0")/../../../lib/test_runner.sh"
source "$(dirname "$0")/../../../lib/output_validator.sh"
export SMOKES_USE_PYVM=0
require_env || exit 2
PASS_COUNT=0
FAIL_COUNT=0
RUN_TIMEOUT_SECS=${RUN_TIMEOUT_SECS:-10}
INPUT="$NYASH_ROOT/apps/tests/phase284_p1_return_in_loop_min.hako"
echo "[INFO] Phase 284 P1: Return in loop test (VM) - $INPUT"
set +e
OUTPUT=$(timeout "$RUN_TIMEOUT_SECS" env \
NYASH_DISABLE_PLUGINS=1 \
HAKO_JOINIR_STRICT=1 \
"$NYASH_BIN" --backend vm "$INPUT" 2>&1)
EXIT_CODE=$?
set -e
if [ "$EXIT_CODE" -eq 124 ]; then
echo "[FAIL] hakorune timed out (>${RUN_TIMEOUT_SECS}s)"
FAIL_COUNT=$((FAIL_COUNT + 1))
elif [ "$EXIT_CODE" -eq 7 ]; then
echo "[PASS] Exit code verified: 7 (early return from loop)"
PASS_COUNT=$((PASS_COUNT + 1))
else
echo "[FAIL] hakorune exited with code $EXIT_CODE (expected 7)"
echo "[INFO] output (tail):"
echo "$OUTPUT" | tail -n 50 || true
FAIL_COUNT=$((FAIL_COUNT + 1))
fi
echo "[INFO] PASS: $PASS_COUNT, FAIL: $FAIL_COUNT"
if [ "$FAIL_COUNT" -eq 0 ]; then
test_pass "phase284_p1_return_in_loop_vm: Test passed"
exit 0
else
test_fail "phase284_p1_return_in_loop_vm: Test failed"
exit 1
fi