tomoaki/hakmem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ENV Cleanup: Delete Ultra HEAP & BG Remote dead code (-1,096 LOC)

Browse Source 
Deleted files (11):
- core/ultra/ directory (6 files: tiny_ultra_heap.*, tiny_ultra_page_arena.*)
- core/front/tiny_ultrafront.h
- core/tiny_ultra_fast.inc.h
- core/hakmem_tiny_ultra_front.inc.h
- core/hakmem_tiny_ultra_simple.inc
- core/hakmem_tiny_ultra_batch_box.inc

Edited files (10):
- core/hakmem_tiny.c: Remove Ultra HEAP #includes, move ultra_batch_for_class()
- core/hakmem_tiny_tls_state_box.inc: Delete TinyUltraFront, g_ultra_simple
- core/hakmem_tiny_phase6_wrappers_box.inc: Delete ULTRA_SIMPLE block
- core/hakmem_tiny_alloc.inc: Delete Ultra-Front code block
- core/hakmem_tiny_init.inc: Delete ULTRA_SIMPLE ENV loading
- core/hakmem_tiny_remote_target.{c,h}: Delete g_bg_remote_enable/batch
- core/tiny_refill.h: Remove BG Remote check (always break)
- core/hakmem_tiny_background.inc: Delete BG Remote drain loop

Deleted ENV variables:
- HAKMEM_TINY_ULTRA_HEAP (build flag, undefined)
- HAKMEM_TINY_ULTRA_L0
- HAKMEM_TINY_ULTRA_HEAP_DUMP
- HAKMEM_TINY_ULTRA_PAGE_DUMP
- HAKMEM_TINY_ULTRA_FRONT
- HAKMEM_TINY_BG_REMOTE (no getenv, dead code)
- HAKMEM_TINY_BG_REMOTE_BATCH (no getenv, dead code)
- HAKMEM_TINY_ULTRA_SIMPLE (references only)

Impact:
- Code reduction: -1,096 lines
- Binary size: 305KB → 304KB (-1KB)
- Build: PASS
- Sanity: 15.69M ops/s (3 runs avg)
- Larson: 1 crash observed (seed 43, likely existing instability)

Notes:
- Ultra HEAP never compiled (#if HAKMEM_TINY_ULTRA_HEAP undefined)
- BG Remote variables never initialized (g_bg_remote_enable always 0)
- Ultra SLIM (ultra_slim_alloc_box.h) preserved (active 4-layer path)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Moe Charm (CI)
2025-11-27 04:35:47 +09:00
parent f4978b1529
commit 6b791b97d4
22 changed files with 61 additions and 1096 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
core/hakmem_tiny_background.inc
View File

@ -14,7 +14,8 @@ static int g_bg_bin_started = 0;
// ============================================================================
// Targeted remote-drain queue moved to separate module
// Functions: remote_target_enqueue(), remote_target_pop()
// Variables: g_bg_remote_enable, g_remote_target_head, g_remote_target_len, g_bg_remote_batch
// Variables: g_remote_target_head, g_remote_target_len
// NOTE: g_bg_remote_enable, g_bg_remote_batch REMOVED (dead code cleanup 2025-11-27)
// ============================================================================
// EXTRACTED TO hakmem_tiny_bg_spill.c/.h (Phase 2C-2)
@ -71,23 +72,8 @@ static void* tiny_bg_refill_main(void* arg) {
bg_spill_drain_class(k, lock);
}
}
// Drain remote frees: targeted by per-class queue (avoid scanning all slabs)
if (g_bg_remote_enable) {
for (int k = 0; k < TINY_NUM_CLASSES; k++) {
int processed = 0;
while (processed < g_bg_remote_batch) {
TinySlab* s = remote_target_pop(k);
if (!s) break;
pthread_mutex_t* lock = &g_tiny_class_locks[k].m;
pthread_mutex_lock(lock);
tiny_remote_drain_locked(s);
pthread_mutex_unlock(lock);
processed++;
// If more remain (due to concurrent pushes), the slab may be re-enqueued
// by producers when threshold is hit again.
}
}
}
// Drain remote frees - REMOVED (dead code cleanup 2025-11-27)
// The g_bg_remote_enable feature was never enabled in production
usleep(sleep_us);
}
return NULL;