Files

tomoaki be4de67601 fix(joinir): improve Pattern3 classification to exclude simple conditional assignment (Phase 264 P0)

Problem:
- Pattern3 heuristic was too conservative: detect_if_in_body() returned
  true for ANY if statement, causing simple conditional assignments to be
  misclassified as Pattern3IfPhi
- Example: `if i == 0 then seg = "first" else seg = "other"` was routed
  to Pattern3, but Pattern3 only handles if-sum patterns like
  `sum = sum + (if x then 1 else 0)`
- This caused loops with conditional assignment to fail Pattern3 check
  and exhaust all routing paths

Solution (Conservative, Phase 264 P0):
- ast_feature_extractor.rs:
  - detect_if_else_phi_in_body(): Always return false
  - has_if = has_if_else_phi (don't use detect_if_in_body())
- loop_pattern_detection/mod.rs:
  - Add has_if_sum_signature() (returns false for P0)
  - has_if_else_phi = carrier_count > 1 && has_if_sum_signature(scope)

Effect:
- Simple conditional assignment loops now fall through to Pattern1 ✅
- Pattern3 misrouting prevented ✅

Results:
- Lib tests: 1368/1368 PASS (no regression)
- Minimal repro: phase264_p0_bundle_resolver_loop_min.hako PASS ✅
- Quick smoke: 45/46 (unchanged - complex BundleResolver loop needs P1)

Phase 264 P1 TODO:
- Implement accurate if-sum signature detection (AST/CFG analysis)
- Support complex nested loops in Pattern2 or new pattern

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2025-12-21 11:49:03 +09:00

README.md

Hakorune Smoke Tests v2 — Guide (Nyash-compatible)

Overview

Entry: tools/smokes/v2/run.sh — unified runner for quick/integration/full.
Profiles:
- quick — fast developer checks.
- integration — VM↔LLVM parity, basic stability.
- full — comprehensive matrix.

🎯 Two Baselines (Runbook)

これから開発の基準となる2つのベースライン：

📦 VM ライン（Rust VM - 既定）

用途: 開発・デバッグ・検証用（高速・型安全）

# ビルド
cargo build --release

# 一括スモークテスト
tools/smokes/v2/run.sh --profile quick

# 個別スモークテスト
tools/smokes/v2/run.sh --profile quick --filter "<glob>"
# 例: --filter "core/json_query_min_vm.sh"

# 単発実行（参考）
$NYASH_BIN --backend vm apps/APP/main.hako

⚡ llvmlite ライン（LLVMハーネス）

用途: 本番・最適化・配布用（実証済み安定性）

前提: Python3 + llvmlite

pip install llvmlite  # 未導入の場合

実行手順:

# ビルド（LLVM_SYS_180_PREFIX不要！）
cargo build --release --features llvm

# 一括スモークテスト
tools/smokes/v2/run.sh --profile integration

# 個別スモークテスト
tools/smokes/v2/run.sh --profile integration --filter "<glob>"

# 単発実行
NYASH_LLVM_USE_HARNESS=1 $NYASH_BIN --backend llvm apps/tests/peek_expr_block.hako

# 有効化確認
$NYASH_BIN --version | rg -i 'features.*llvm'

💡 重要: 両方のラインのテストが通ることで、MIR14統一アーキテクチャの品質を保証！

🔁 QuickでAST/LLVM系も実行したいとき

通常、quick は LLVM未ビルド時に AST/LLVM系テストを自動で SKIP します。 Quickでも実行したい場合は、先に LLVM 有効でビルドしてください：

LLVM_SYS_180_PREFIX=$(llvm-config-18 --prefix) cargo build --release --features llvm
tools/smokes/v2/run.sh --profile quick

テストランナーは LLVM 非対応時にヒントを出力します（buildコマンドの案内）。

Notes

Using resolution: prefer nyash.toml aliases (SSOT). Some tests may enable NYASH_ALLOW_USING_FILE=1 internally for convenience.
Plugin warnings are informational; smokes are designed to pass without dynamic plugins.
Harness single-run may take longer due to link+exec; integration profile includes generous timeouts.
Binary selection in scripts: always use $NYASH_BIN (the runner sets it to target/release/hakorune when present, otherwise falls back to nyash).
Branding: user‑visible messages prefer “Hakorune”; the legacy nyash binary remains for compatibility but may be gated（HAKO_ALLOW_NYASH=1）。

Dev Mode (defaults)

In v2 smokes, the quick profile exports NYASH_DEV=1 by default.
- This enables CLI --dev-equivalent defaults inside Nyash:
  - AST using ON (SSOT + AST prelude merge)
  - Operator Boxes in observe mode (no adoption)
  - Minimal diagnostics; output parity is preserved
You can also run manually with nyash --dev script.hako.

Common commands

Quick suite (auto NYASH_DEV=1):
- tools/smokes/v2/run.sh --profile quick
Focus JSON smokes:
- tools/opbox-json.sh (Roundtrip/Nested, plugins disabled, generous timeout)
One-off program (VM):
- $NYASH_BIN --backend vm --dev apps/APP/main.hako

Key env knobs

NYASH_DEV=1 — enable dev defaults (same effect as --dev).
SMOKES_DEFAULT_TIMEOUT — per test timeout seconds (default 15 for quick).
SMOKES_PLUGIN_MODE=dynamic|static — plugin mode for preflight (auto by default).
SMOKES_FORCE_CONFIG=rust_vm_dynamic|llvm_static — force backend config.
SMOKES_NOTIFY_TAIL — lines to show on failure tail (default 80).