tomoaki
edc7355937
Apply Phase 256.8 SSOT fix to Pattern4/6/7: - Use join_module.entry.params.clone() instead of hardcoded ValueIds - Add fail-fast validation for params count mismatch - Remove ValueId(0), ValueId(PARAM_MIN + k) patterns - Clean up unused PARAM_MIN imports This prevents entry_param_mismatch errors structurally and maintains consistency with Pattern2/3. Changes: - pattern4_with_continue.rs: Lines 442-476 (SSOT extraction + validation) - pattern6_scan_with_init.rs: Lines 447-471 (SSOT extraction + validation) - pattern7_split_scan.rs: Lines 495-526 (SSOT extraction + validation) All patterns now use the same SSOT principle: 1. Extract entry function (priority: join_module.entry → fallback "main") 2. Use params as SSOT: join_inputs = entry_func.params.clone() 3. Build host_inputs in expected order (pattern-specific) 4. Fail-fast validation: join_inputs.len() == host_inputs.len() Verification: - cargo build --release: ✅ PASS (no PARAM_MIN warnings) - Quick profile: ✅ First FAIL still json_lint_vm (baseline maintained) - Pattern6 smoke: ✅ PASS (index_of test) - Pattern7 smoke: Pre-existing phi pred mismatch (not introduced by SSOT) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Investigations Folder
This folder contains investigation notes and analysis for debugging sessions.
Active Investigations
Phase 131-12: LLVM Wrong Result (Case C)
Status: ✅ Root cause identified Problem: LLVM backend returns wrong results for loop exit values Root Cause: vmap object identity mismatch between Pass A and Pass C
Key Documents:
- phase131-12-case-c-llvm-wrong-result.md - Initial investigation scope
- phase131-12-p1-vmap-identity-analysis.md - Detailed trace analysis
- phase131-12-p1-trace-summary.md - Executive summary with fix recommendations
Quick Summary:
- Bug: Pass A deletes
_current_vmapbefore Pass C runs - Impact: Terminators use wrong vmap object, missing all Pass A writes
- Fix: Store vmap_cur in deferred_terminators tuple (Option 3)
Next Steps:
- Implement Option 3 fix in block_lower.py
- Add Fail-Fast check in instruction_lower.py
- Verify with NYASH_LLVM_VMAP_TRACE=1
- Run full test suite
Trace Environment Variables
Phase 131-12-P1 Traces
NYASH_LLVM_VMAP_TRACE=1 # Object identity and vmap keys tracing
NYASH_LLVM_USE_HARNESS=1 # Enable llvmlite harness
NYASH_LLVM_DUMP_IR=<path> # Save LLVM IR to file
Investigation Workflow
- Scope - Define problem and test case (phase131-12-case-c-*.md)
- Trace - Add instrumentation and collect data (phase131-12-p1-vmap-identity-*.md)
- Analysis - Identify root cause with evidence (phase131-12-p1-trace-summary.md)
- Fix - Implement solution with validation
- Document - Update investigation notes with results
Archive
Completed investigations are kept for reference and pattern recognition.
JoinIR Generalization Study (Historical)
joinir-generalization-study.md（Phase 131–138 の状況と一般化案の相談用コンテキスト。SSOT は design/ を参照）