Files
hakorune/tools/hako_check/rules/rule_analyzer_io_safety.hako
nyash-codex 50ac8af2b8 Phase 21.4 Complete: FileBox SSOT + Analyzer Stabilization (7 Tasks)
 Task 1: Fallback Guarantee (create_box failure → ring1/core-ro auto fallback)
- Three-tier fallback system: plugin → builtin → core-ro
- Mode control: auto/plugin-only/core-ro
- New: src/box_factory/builtin_impls/file_box.rs
- New: tools/test_filebox_fallback_smoke.sh

 Task 2: Provider Registration SSOT (static/dynamic/core-ro unified)
- ProviderFactory trait with priority-based selection
- Global registry PROVIDER_FACTORIES implementation
- Priority: dynamic(100) > builtin(10) > core-ro(0)
- New: src/boxes/file/builtin_factory.rs
- New: tools/smoke_provider_modes.sh

 Task 3: FileBox Publication Unification
- Verified: basic/file_box.rs already minimized (11 lines)
- Perfect re-export pattern maintained

 Task 4: ENV Unification (FILEBOX_MODE/DISABLE_PLUGINS priority)
- Removed auto-setting of NYASH_USE_PLUGIN_BUILTINS
- Removed auto-setting of NYASH_PLUGIN_OVERRIDE_TYPES
- Added deprecation warnings with migration guide
- ENV hierarchy: DISABLE_PLUGINS > BOX_FACTORY_POLICY > FILEBOX_MODE

 Task 5: Error Log Visibility (Analyzer rule execution errors to stderr)
- Added [rule/exec] logging before IR-based rule execution
- Format: [rule/exec] HC012 (dead_static_box) <filepath>
- VM errors now traceable via stderr output

 Task 6: Unnecessary Using Removal (14 rules Str alias cleanup)
- Removed unused `using ... as Str` from 14 rule files
- All rules use local _itoa() helper instead
- 14 lines of dead code eliminated

 Task 7: HC017 Skip & TODO Documentation (UTF-8 support required)
- Enhanced run_tests.sh with clear skip message
- Added "Known Limitations" section to README.md
- Technical requirements documented (3 implementation options)
- Re-enable timeline: Phase 22 (Unicode Support Phase)

📊 Test Results:
- Analyzer: 10 tests PASS, 1 skipped (HC017)
- FileBox fallback: All 3 modes PASS
- Provider modes: All 4 modes PASS
- Build: Success (0 errors, 0 warnings)

🎯 Key Achievements:
- 28 files modified/created
- Three-Tier Fallback System (stability)
- SSOT Provider Registry (extensibility)
- ENV unification (operational clarity)
- Error visibility (debugging efficiency)
- Code cleanup (maintainability)
- Comprehensive documentation (Phase 22 ready)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 17:04:21 +09:00

86 lines
2.5 KiB
Plaintext

// tools/hako_check/rules/rule_analyzer_io_safety.hako — HC021: Analyzer IO Safety
// Detects analyzer rules that perform direct I/O operations (FileBox, NetworkBox, etc.)
// Analyzer rules should receive all data through method parameters (CLI-internal push approach).
static box RuleAnalyzerIoSafetyBox {
method apply(text, path, out) {
if text == null { return 0 }
// Only check files that look like analyzer rules (contain "Box" and "apply")
if text.indexOf("Box") < 0 || text.indexOf("apply") < 0 {
return 0
}
local lines = me._split_lines(text)
local i = 0
while i < lines.size() {
local ln = lines.get(i)
local line_num = i + 1
// Remove comments for analysis
local comment_pos = ln.indexOf("//")
local code = ln
if comment_pos >= 0 {
code = ln.substring(0, comment_pos)
}
// Check for FileBox instantiation
if code.indexOf("new FileBox") >= 0 {
local msg = "[HC021] analyzer rule uses direct file I/O (new FileBox): use CLI-internal push approach instead"
out.push(msg + " :: " + path + ":" + me._itoa(line_num))
}
// Check for file operations (even on passed-in FileBox)
if code.indexOf(".open(") >= 0 || code.indexOf(".read(") >= 0 || code.indexOf(".write(") >= 0 {
local msg = "[HC021] analyzer rule uses file operations: use CLI-internal push approach instead"
out.push(msg + " :: " + path + ":" + me._itoa(line_num))
}
// Check for other dangerous I/O boxes
if code.indexOf("new NetworkBox") >= 0 || code.indexOf("new SocketBox") >= 0 {
local msg = "[HC021] analyzer rule uses network I/O: use CLI-internal push approach instead"
out.push(msg + " :: " + path + ":" + me._itoa(line_num))
}
i = i + 1
}
return out.size()
}
_split_lines(s) {
local arr = new ArrayBox()
if s == null { return arr }
local n = s.length()
local last = 0
local i = 0
loop(i < n) {
local ch = s.substring(i, i+1)
if ch == "\n" {
arr.push(s.substring(last, i))
last = i + 1
}
i = i + 1
}
if last <= n { arr.push(s.substring(last)) }
return arr
}
_itoa(n) {
local v = 0 + n
if v == 0 { return "0" }
local out = ""
local digits = "0123456789"
local tmp = ""
while v > 0 {
local d = v % 10
tmp = digits.substring(d, d+1) + tmp
v = v / 10
}
out = tmp
return out
}
}
static box RuleAnalyzerIoSafetyMain { method main(args) { return 0 } }