Files
hakorune/tools/hako_check/rules/rule_duplicate_method.hako
nyash-codex 50ac8af2b8 Phase 21.4 Complete: FileBox SSOT + Analyzer Stabilization (7 Tasks)
 Task 1: Fallback Guarantee (create_box failure → ring1/core-ro auto fallback)
- Three-tier fallback system: plugin → builtin → core-ro
- Mode control: auto/plugin-only/core-ro
- New: src/box_factory/builtin_impls/file_box.rs
- New: tools/test_filebox_fallback_smoke.sh

 Task 2: Provider Registration SSOT (static/dynamic/core-ro unified)
- ProviderFactory trait with priority-based selection
- Global registry PROVIDER_FACTORIES implementation
- Priority: dynamic(100) > builtin(10) > core-ro(0)
- New: src/boxes/file/builtin_factory.rs
- New: tools/smoke_provider_modes.sh

 Task 3: FileBox Publication Unification
- Verified: basic/file_box.rs already minimized (11 lines)
- Perfect re-export pattern maintained

 Task 4: ENV Unification (FILEBOX_MODE/DISABLE_PLUGINS priority)
- Removed auto-setting of NYASH_USE_PLUGIN_BUILTINS
- Removed auto-setting of NYASH_PLUGIN_OVERRIDE_TYPES
- Added deprecation warnings with migration guide
- ENV hierarchy: DISABLE_PLUGINS > BOX_FACTORY_POLICY > FILEBOX_MODE

 Task 5: Error Log Visibility (Analyzer rule execution errors to stderr)
- Added [rule/exec] logging before IR-based rule execution
- Format: [rule/exec] HC012 (dead_static_box) <filepath>
- VM errors now traceable via stderr output

 Task 6: Unnecessary Using Removal (14 rules Str alias cleanup)
- Removed unused `using ... as Str` from 14 rule files
- All rules use local _itoa() helper instead
- 14 lines of dead code eliminated

 Task 7: HC017 Skip & TODO Documentation (UTF-8 support required)
- Enhanced run_tests.sh with clear skip message
- Added "Known Limitations" section to README.md
- Technical requirements documented (3 implementation options)
- Re-enable timeline: Phase 22 (Unicode Support Phase)

📊 Test Results:
- Analyzer: 10 tests PASS, 1 skipped (HC017)
- FileBox fallback: All 3 modes PASS
- Provider modes: All 4 modes PASS
- Build: Success (0 errors, 0 warnings)

🎯 Key Achievements:
- 28 files modified/created
- Three-Tier Fallback System (stability)
- SSOT Provider Registry (extensibility)
- ENV unification (operational clarity)
- Error visibility (debugging efficiency)
- Code cleanup (maintainability)
- Comprehensive documentation (Phase 22 ready)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 17:04:21 +09:00

73 lines
2.0 KiB
Plaintext

// tools/hako_check/rules/rule_duplicate_method.hako — HC013: Duplicate Method
// Detect methods with the same name and arity defined multiple times in the same box.
static box RuleDuplicateMethodBox {
method apply_ir(ir, path, out) {
local boxes = ir.get("boxes")
if boxes == null { return 0 }
// Check each box for duplicate methods
local bi = 0
while bi < boxes.size() {
local box_info = boxes.get(bi)
if box_info == null { bi = bi + 1; continue }
local box_name = box_info.get("name")
if box_name == null { bi = bi + 1; continue }
local methods = box_info.get("methods")
if methods == null { bi = bi + 1; continue }
// Track seen methods: {name/arity -> first_span}
local seen = new MapBox()
local mi = 0
while mi < methods.size() {
local method = methods.get(mi)
if method == null { mi = mi + 1; continue }
local name = method.get("name")
local arity = method.get("arity")
if name == null || arity == null { mi = mi + 1; continue }
// Create signature: name/arity
local sig = name + "/" + me._itoa(arity)
// Check if already seen
if seen.has(sig) == 1 {
// Duplicate detected!
local span = method.get("span")
local line = (span != null) ? span : 1
out.push("[HC013] duplicate method definition: " + box_name + "." + sig + " at line " + me._itoa(line))
} else {
// First occurrence - store it
local span = method.get("span")
seen.set(sig, span)
}
mi = mi + 1
}
bi = bi + 1
}
return out.size()
}
_itoa(n) {
local v = 0 + n
if v == 0 { return "0" }
local out = ""
local digits = "0123456789"
local tmp = ""
while v > 0 {
local d = v % 10
tmp = digits.substring(d, d+1) + tmp
v = v / 10
}
out = tmp
return out
}
}
static box RuleDuplicateMethodMain { method main(args) { return 0 } }