## Phase 132: Exit PHI Value Parity Fix ### Problem Pattern 1 (Simple While) returned 0 instead of final loop variable value (3) - VM: RC: 3 ✅ (correct) - LLVM: Result: 0 ❌ (wrong) ### Root Cause (Two Layers) 1. **JoinIR/Boundary**: Missing exit_bindings → ExitLineReconnector not firing 2. **LLVM Python**: block_end_values snapshot dropping PHI values ### Fix **JoinIR** (simple_while_minimal.rs): - Jump(k_exit, [i_param]) passes exit value **Boundary** (pattern1_minimal.rs): - Added LoopExitBinding with carrier_name="i", role=LoopState - Enables ExitLineReconnector to update variable_map **LLVM** (block_lower.py): - Use predeclared_ret_phis for reliable PHI filtering - Protect builder.vmap PHIs from overwrites (SSOT principle) ### Result - ✅ VM: RC: 3 - ✅ LLVM: Result: 3 - ✅ VM/LLVM parity achieved ## Phase 132-Post: Box-First Refactoring ### Rust Side **JoinModule::require_function()** (mod.rs): - Encapsulate function search logic - 10 lines → 1 line (90% reduction) - Reusable for Pattern 2-5 ### Python Side **PhiManager Box** (phi_manager.py - new): - Centralized PHI lifecycle management - 47 lines → 8 lines (83% reduction) - SSOT: builder.vmap owns PHIs - Fail-Fast: No silent overwrites **Integration**: - LLVMBuilder: Added phi_manager - block_lower.py: Delegated to PhiManager - tagging.py: Register PHIs with manager ### Documentation **New Files**: - docs/development/architecture/exit-phi-design.md - docs/development/current/main/investigations/phase132-llvm-exit-phi-wrong-result.md - docs/development/current/main/phases/phase-132/ **Updated**: - docs/development/current/main/10-Now.md - docs/development/current/main/phase131-3-llvm-lowering-inventory.md ### Design Principles - Box-First: Logic encapsulated in classes/methods - SSOT: Single Source of Truth (builder.vmap for PHIs) - Fail-Fast: Early explicit failures, no fallbacks - Separation of Concerns: 3-layer architecture 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Phase 132: Exit Values Parity (VM == LLVM)
Date: 2025-12-15
Status: ✅ Done
Scope: Pattern 1(Simple While)で「ループ終了後の return i」が VM/LLVM で一致することを固定する
背景
最小ケース:
static box Main {
main() {
local i = 0
loop(i < 3) { i = i + 1 }
return i // 期待: 3
}
}
- VM:
RC: 3✅ - LLVM:
Result: 0❌(修正前)
根本原因(2層)
1) JoinIR/Boundary 層: exit 値が境界を通っていない
- Pattern 1 の JoinIR で
k_exitに渡す args が空のままだと、exit 側でホストのvariable_map["i"]が更新されない。 - その結果
return iが初期値(0)を返し得る。
2) LLVM Python 層: PHI の SSOT が壊れている
phi.basic_blockが llvmlite で確定前はNoneになり得るため、PHI を落とす filter を信頼できない。builder.vmapにある PHI placeholder を、Pass A の “sync created values” が上書きしてしまい、retが PHI ではなく0を参照することがある。
修正内容
JoinIR/Boundary 層(exit 値を明示的に渡す)
src/mir/join_ir/lowering/simple_while_minimal.rsJump(k_exit, [i_param])として exit 値を渡す
src/mir/builder/control_flow/joinir/patterns/pattern1_minimal.rsLoopExitBindingを作成してwith_exit_bindings()で境界に設定
LLVM Python 層(PHI SSOT を保護する)
src/llvm_py/builders/block_lower.py- PHI filtering を
predeclared_ret_phisベースにし、phi.basic_block依存を排除 builder.vmapの既存 PHI(placeholder)を上書きしない(PHI を SSOT として保護)
- PHI filtering を
検証
/tmp/p1_return_i.hakoが VM/LLVM で3を返すNYASH_LLVM_STRICT=1でも “miss→0” に落ちない(Fail-Fast が維持される)
詳細ログ:
docs/development/current/main/investigations/phase132-llvm-exit-phi-wrong-result.md