Files

nyash-codex 22b0c14adb feat(joinir): Phase 135 P1 - Contract checks Fail-Fast (二度と破れない設計)

## Summary
Adds early Fail-Fast contract verification to prevent Phase 135 P0 issues from recurring.
Two new verifiers catch allocator SSOT violations and boundary inconsistencies before --verify.

## Changes

### Step 1: verify_condition_bindings_consistent
**Location**: `src/mir/builder/control_flow/joinir/merge/contract_checks.rs`

**Contract**: condition_bindings can have aliases (multiple names for same join_value),
but same join_value with different host_value is a violation.

**Example Error**:
```
[JoinIRVerifier/Phase135-P1] condition_bindings conflict:
  join_value ValueId(104) mapped to both ValueId(12) and ValueId(18)
```

**Catches**: ConditionLoweringBox bypassing SSOT allocator before BoundaryInjector

### Step 2: verify_header_phi_dsts_not_redefined
**Location**: `src/mir/builder/control_flow/joinir/merge/contract_checks.rs`

**Contract**: Loop header PHI dst ValueIds must not be reused as dst in non-PHI instructions.
Violation breaks MIR SSA (PHI dst overwrite).

**Example Error**:
```
[JoinIRVerifier/Phase135-P1] Header PHI dst ValueId(14) redefined by non-PHI instruction in block 3:
  Instruction: Call { dst: Some(ValueId(14)), ... }
```

**Catches**: ValueId collisions between header PHI dsts and lowered instructions

### Integration
**Location**: `src/mir/builder/control_flow/joinir/merge/mod.rs`

Added to `verify_joinir_contracts()`:
1. Step 1 runs before merge (validates boundary)
2. Step 2 runs after merge (validates func with PHI dst set)

### Documentation
- Updated `phase135_trim_mir_verify.sh` - Added P1 contract_checks description
- Updated `phase-135/README.md` - Added P1 section with contract details and effects

## Acceptance
✅ Build: SUCCESS
✅ Smoke: phase135_trim_mir_verify.sh - PASS
✅ Regression: phase132_exit_phi_parity.sh - 3/3 PASS
✅ Regression: phase133_json_skip_whitespace_llvm_exe.sh - PASS

## Effect
- **Prevention**: Future Box implementations catch SSOT violations immediately
- **Explicit Errors**: Phase 135-specific messages instead of generic --verify failures
- **Unbreakable**: Debug builds always detect violations, enforced by CI/CD

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2025-12-15 19:25:33 +09:00

README.md

Hakorune Smoke Tests v2 — Guide (Nyash-compatible)

Overview

Entry: tools/smokes/v2/run.sh — unified runner for quick/integration/full.
Profiles:
- quick — fast developer checks.
- integration — VM↔LLVM parity, basic stability.
- full — comprehensive matrix.

🎯 Two Baselines (Runbook)

これから開発の基準となる2つのベースライン：

📦 VM ライン（Rust VM - 既定）

用途: 開発・デバッグ・検証用（高速・型安全）

# ビルド
cargo build --release

# 一括スモークテスト
tools/smokes/v2/run.sh --profile quick

# 個別スモークテスト
tools/smokes/v2/run.sh --profile quick --filter "<glob>"
# 例: --filter "core/json_query_min_vm.sh"

# 単発実行（参考）
$NYASH_BIN --backend vm apps/APP/main.hako

⚡ llvmlite ライン（LLVMハーネス）

用途: 本番・最適化・配布用（実証済み安定性）

前提: Python3 + llvmlite

pip install llvmlite  # 未導入の場合

実行手順:

# ビルド（LLVM_SYS_180_PREFIX不要！）
cargo build --release --features llvm

# 一括スモークテスト
tools/smokes/v2/run.sh --profile integration

# 個別スモークテスト
tools/smokes/v2/run.sh --profile integration --filter "<glob>"

# 単発実行
NYASH_LLVM_USE_HARNESS=1 $NYASH_BIN --backend llvm apps/tests/peek_expr_block.hako

# 有効化確認
$NYASH_BIN --version | rg -i 'features.*llvm'

💡 重要: 両方のラインのテストが通ることで、MIR14統一アーキテクチャの品質を保証！

🔁 QuickでAST/LLVM系も実行したいとき

通常、quick は LLVM未ビルド時に AST/LLVM系テストを自動で SKIP します。 Quickでも実行したい場合は、先に LLVM 有効でビルドしてください：

LLVM_SYS_180_PREFIX=$(llvm-config-18 --prefix) cargo build --release --features llvm
tools/smokes/v2/run.sh --profile quick

テストランナーは LLVM 非対応時にヒントを出力します（buildコマンドの案内）。

Notes

Using resolution: prefer nyash.toml aliases (SSOT). Some tests may enable NYASH_ALLOW_USING_FILE=1 internally for convenience.
Plugin warnings are informational; smokes are designed to pass without dynamic plugins.
Harness single-run may take longer due to link+exec; integration profile includes generous timeouts.
Binary selection in scripts: always use $NYASH_BIN (the runner sets it to target/release/hakorune when present, otherwise falls back to nyash).
Branding: user‑visible messages prefer “Hakorune”; the legacy nyash binary remains for compatibility but may be gated（HAKO_ALLOW_NYASH=1）。

Dev Mode (defaults)

In v2 smokes, the quick profile exports NYASH_DEV=1 by default.
- This enables CLI --dev-equivalent defaults inside Nyash:
  - AST using ON (SSOT + AST prelude merge)
  - Operator Boxes in observe mode (no adoption)
  - Minimal diagnostics; output parity is preserved
You can also run manually with nyash --dev script.hako.

Common commands

Quick suite (auto NYASH_DEV=1):
- tools/smokes/v2/run.sh --profile quick
Focus JSON smokes:
- tools/opbox-json.sh (Roundtrip/Nested, plugins disabled, generous timeout)
One-off program (VM):
- $NYASH_BIN --backend vm --dev apps/APP/main.hako

Key env knobs

NYASH_DEV=1 — enable dev defaults (same effect as --dev).
SMOKES_DEFAULT_TIMEOUT — per test timeout seconds (default 15 for quick).
SMOKES_PLUGIN_MODE=dynamic|static — plugin mode for preflight (auto by default).
SMOKES_FORCE_CONFIG=rust_vm_dynamic|llvm_static — force backend config.
SMOKES_NOTIFY_TAIL — lines to show on failure tail (default 80).