tomoaki
be4de67601
Problem: - Pattern3 heuristic was too conservative: detect_if_in_body() returned true for ANY if statement, causing simple conditional assignments to be misclassified as Pattern3IfPhi - Example: `if i == 0 then seg = "first" else seg = "other"` was routed to Pattern3, but Pattern3 only handles if-sum patterns like `sum = sum + (if x then 1 else 0)` - This caused loops with conditional assignment to fail Pattern3 check and exhaust all routing paths Solution (Conservative, Phase 264 P0): - ast_feature_extractor.rs: - detect_if_else_phi_in_body(): Always return false - has_if = has_if_else_phi (don't use detect_if_in_body()) - loop_pattern_detection/mod.rs: - Add has_if_sum_signature() (returns false for P0) - has_if_else_phi = carrier_count > 1 && has_if_sum_signature(scope) Effect: - Simple conditional assignment loops now fall through to Pattern1 ✅ - Pattern3 misrouting prevented ✅ Results: - Lib tests: 1368/1368 PASS (no regression) - Minimal repro: phase264_p0_bundle_resolver_loop_min.hako PASS ✅ - Quick smoke: 45/46 (unchanged - complex BundleResolver loop needs P1) Phase 264 P1 TODO: - Implement accurate if-sum signature detection (AST/CFG analysis) - Support complex nested loops in Pattern2 or new pattern 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Smokes v2 — Minimal Runner and Policy
Policy
- Use [SKIP:] prefix for environment/host dependent skips.
- Examples: [SKIP] hakorune not built, [SKIP:env] plugin path missing
- Keep reasons short and stable to allow grep-based canaries.
- Prefer JSON-only output in CI: set
NYASH_JSON_ONLY=1to avoid noisy logs. - Diagnostics lines like
[provider/select:*]are filtered by default inlib/test_runner.sh.- Toggle: set
HAKO_SILENT_TAGS=0to disable filtering and show raw logs.HAKO_SHOW_CALL_LOGS=1also bypasses filtering.
- Toggle: set
Helpers
tools/smokes/v2/lib/mir_canary.shprovides:extract_mir_from_output— between [MIR_BEGIN]/[MIR_END]assert_has_tokens,assert_skip_tag,assert_order,assert_token_count
tools/lib/canary.shprovides minimal, harness-agnostic aliases:extract_mir_between_tags— same asextract_mir_from_outputrequire_tokens token...— fail if any token missing
Notes
- Avoid running heavy integration smokes in CI by default. Use
--profile quick. - When a test depends on external tools (e.g., LLVM), prefer
[SKIP:<reason>]over failure. - Stage‑B/selfhost canaries（
stage1_launcher_*,phase251*など）は Stage‑3 デフォルト環境で安定しないため、quick プロファイルでは[SKIP:stageb]として扱い、必要に応じて別プロファイル（integration/full）で個別に実行する。 - Selfhost quick カバレッジは最小 1 本（
core/selfhost_minimal.sh）に絞り、Stage‑3 + JoinIR 前提で Stage‑B→VM を通るかだけを確認する。 - S3 backend 向けの長尺テスト群も quick 向きではないため、timeout を短く保ちたい場合は
[SKIP:slow]にして別途ローカルで回すことを推奨する。
Quick tips
- EXE-heavy cases (e.g.,
phase2100/*) may take longer. When running quick with these tests, pass a larger timeout like--timeout 120. - Smokes v2 auto-cleans temporary crate EXE objects created under
/tmp(pattern:ny_crate_backend_exe_*.o) after the run.
Developer Notes
- JoinIR If/Select (Phase 33): A/B test with
NYASH_FEATURES=stage3 HAKO_JOINIR_IF_SELECT=1 ./target/release/hakorune apps/tests/joinir_if_select_simple.hako（dev-only、CI対象外。NYASH_JOINIR_CORE は deprecated/無視）