Files
hakorune/tools/hako_check/rules/rule_global_assign.hako
nyash-codex 50ac8af2b8 Phase 21.4 Complete: FileBox SSOT + Analyzer Stabilization (7 Tasks)
 Task 1: Fallback Guarantee (create_box failure → ring1/core-ro auto fallback)
- Three-tier fallback system: plugin → builtin → core-ro
- Mode control: auto/plugin-only/core-ro
- New: src/box_factory/builtin_impls/file_box.rs
- New: tools/test_filebox_fallback_smoke.sh

 Task 2: Provider Registration SSOT (static/dynamic/core-ro unified)
- ProviderFactory trait with priority-based selection
- Global registry PROVIDER_FACTORIES implementation
- Priority: dynamic(100) > builtin(10) > core-ro(0)
- New: src/boxes/file/builtin_factory.rs
- New: tools/smoke_provider_modes.sh

 Task 3: FileBox Publication Unification
- Verified: basic/file_box.rs already minimized (11 lines)
- Perfect re-export pattern maintained

 Task 4: ENV Unification (FILEBOX_MODE/DISABLE_PLUGINS priority)
- Removed auto-setting of NYASH_USE_PLUGIN_BUILTINS
- Removed auto-setting of NYASH_PLUGIN_OVERRIDE_TYPES
- Added deprecation warnings with migration guide
- ENV hierarchy: DISABLE_PLUGINS > BOX_FACTORY_POLICY > FILEBOX_MODE

 Task 5: Error Log Visibility (Analyzer rule execution errors to stderr)
- Added [rule/exec] logging before IR-based rule execution
- Format: [rule/exec] HC012 (dead_static_box) <filepath>
- VM errors now traceable via stderr output

 Task 6: Unnecessary Using Removal (14 rules Str alias cleanup)
- Removed unused `using ... as Str` from 14 rule files
- All rules use local _itoa() helper instead
- 14 lines of dead code eliminated

 Task 7: HC017 Skip & TODO Documentation (UTF-8 support required)
- Enhanced run_tests.sh with clear skip message
- Added "Known Limitations" section to README.md
- Technical requirements documented (3 implementation options)
- Re-enable timeline: Phase 22 (Unicode Support Phase)

📊 Test Results:
- Analyzer: 10 tests PASS, 1 skipped (HC017)
- FileBox fallback: All 3 modes PASS
- Provider modes: All 4 modes PASS
- Build: Success (0 errors, 0 warnings)

🎯 Key Achievements:
- 28 files modified/created
- Three-Tier Fallback System (stability)
- SSOT Provider Registry (extensibility)
- ENV unification (operational clarity)
- Error visibility (debugging efficiency)
- Code cleanup (maintainability)
- Comprehensive documentation (Phase 22 ready)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 17:04:21 +09:00

45 lines
2.0 KiB
Plaintext
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

static box RuleGlobalAssignBox {
apply(text, path, out) {
// HC010: global mutable state 禁止top-levelの識別子= を雑に検出)
local lines = me._split_lines(text)
local in_box = 0; local in_method = 0
local i = 0; while i < lines.size() {
local ln = lines.get(i)
local t = me._ltrim(ln)
if t.indexOf("static box ") == 0 { in_box = 1; in_method = 0 }
if in_box == 1 && t == "}" { in_box = 0; in_method = 0 }
if in_box == 1 && t.indexOf("method ") == 0 { in_method = 1 }
if in_box == 1 && in_method == 0 {
// at top-level inside box: ident =
if me._looks_assign(t) == 1 {
out.push("[HC010] global assignment (top-level in box is forbidden): " + path + ":" + me._itoa(i+1))
}
}
i = i + 1 }
}
_ltrim(s) { return me._ltrim_chars(s, " \t") }
_split_lines(s) {
local arr = new ArrayBox(); if s == null { return arr }
local n = s.length(); local last = 0; local i = 0
while i < n { local ch = s.substring(i,i+1); if ch == "\n" { arr.push(s.substring(last,i)); last = i+1 } i = i + 1 }
arr.push(s.substring(last)); return arr
}
_ltrim_chars(s, cs) {
local n=s.length(); local head=0
local i = 0; while i < n { local ch=s.substring(i,i+1); if ch!=" "&&ch!="\t" { head=i; break }; if i==n-1 { head=n }; i = i + 1 }
return s.substring(head)
}
_itoa(n) { local v=0+n; if v==0 { return "0" } local out=""; local digits="0123456789"; local tmp=""; while v>0 { local d=v%10; tmp=digits.substring(d,d+1)+tmp; v=v/10 } out=tmp; return out }
_looks_assign(t) {
// very naive: identifier start followed by '=' somewhere (and not 'static box' or 'method')
if t.length() < 3 { return 0 }
local c = t.substring(0,1)
if !((c>="A"&&c<="Z")||(c>="a"&&c<="z")||c=="_") { return 0 }
if t.indexOf("static box ") == 0 || t.indexOf("method ") == 0 { return 0 }
if t.indexOf("=") > 0 { return 1 }
return 0
}
}
static box RuleGlobalAssignMain { method main(args) { return 0 } }