Files
hakorune/src/box_factory/builtin.rs
nyash-codex 50ac8af2b8 Phase 21.4 Complete: FileBox SSOT + Analyzer Stabilization (7 Tasks)
 Task 1: Fallback Guarantee (create_box failure → ring1/core-ro auto fallback)
- Three-tier fallback system: plugin → builtin → core-ro
- Mode control: auto/plugin-only/core-ro
- New: src/box_factory/builtin_impls/file_box.rs
- New: tools/test_filebox_fallback_smoke.sh

 Task 2: Provider Registration SSOT (static/dynamic/core-ro unified)
- ProviderFactory trait with priority-based selection
- Global registry PROVIDER_FACTORIES implementation
- Priority: dynamic(100) > builtin(10) > core-ro(0)
- New: src/boxes/file/builtin_factory.rs
- New: tools/smoke_provider_modes.sh

 Task 3: FileBox Publication Unification
- Verified: basic/file_box.rs already minimized (11 lines)
- Perfect re-export pattern maintained

 Task 4: ENV Unification (FILEBOX_MODE/DISABLE_PLUGINS priority)
- Removed auto-setting of NYASH_USE_PLUGIN_BUILTINS
- Removed auto-setting of NYASH_PLUGIN_OVERRIDE_TYPES
- Added deprecation warnings with migration guide
- ENV hierarchy: DISABLE_PLUGINS > BOX_FACTORY_POLICY > FILEBOX_MODE

 Task 5: Error Log Visibility (Analyzer rule execution errors to stderr)
- Added [rule/exec] logging before IR-based rule execution
- Format: [rule/exec] HC012 (dead_static_box) <filepath>
- VM errors now traceable via stderr output

 Task 6: Unnecessary Using Removal (14 rules Str alias cleanup)
- Removed unused `using ... as Str` from 14 rule files
- All rules use local _itoa() helper instead
- 14 lines of dead code eliminated

 Task 7: HC017 Skip & TODO Documentation (UTF-8 support required)
- Enhanced run_tests.sh with clear skip message
- Added "Known Limitations" section to README.md
- Technical requirements documented (3 implementation options)
- Re-enable timeline: Phase 22 (Unicode Support Phase)

📊 Test Results:
- Analyzer: 10 tests PASS, 1 skipped (HC017)
- FileBox fallback: All 3 modes PASS
- Provider modes: All 4 modes PASS
- Build: Success (0 errors, 0 warnings)

🎯 Key Achievements:
- 28 files modified/created
- Three-Tier Fallback System (stability)
- SSOT Provider Registry (extensibility)
- ENV unification (operational clarity)
- Error visibility (debugging efficiency)
- Code cleanup (maintainability)
- Comprehensive documentation (Phase 22 ready)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 17:04:21 +09:00

87 lines
2.7 KiB
Rust

/*!
* Builtin Box Factory (Phase 15.5: Transitioning to "Everything is Plugin")
*
* ⚠️ MIGRATION IN PROGRESS: Phase 15.5 Core Box Unification
* 🎯 Goal: Remove builtin priority, make all Boxes plugin-based
* 📋 Current: builtin > user > plugin (PROBLEMATIC)
* 🚀 Target: plugin > user > builtin_compat (Phase 1) → plugin-only (Phase 3)
*
* Implementation Strategy:
* - Phase 0: ✅ Separate implementations to builtin_impls/ (easy deletion)
* - Phase 1: 🚧 Add strict_plugin_first policy + access guards
* - Phase 2: 🔄 Delete builtin_impls/ files one by one
* - Phase 3: ❌ Delete BuiltinBoxFactory entirely
*/
use super::BoxFactory;
use super::RuntimeError;
use crate::box_trait::NyashBox;
// Separated implementations (Phase 0: ✅ Complete)
use super::builtin_impls;
/// Factory for builtin Box types
pub struct BuiltinBoxFactory;
impl BuiltinBoxFactory {
pub fn new() -> Self {
Self
}
}
impl BoxFactory for BuiltinBoxFactory {
fn create_box(
&self,
name: &str,
args: &[Box<dyn NyashBox>],
) -> Result<Box<dyn NyashBox>, RuntimeError> {
// Phase 0: ✅ Route to separated implementations (easy deletion)
match name {
// Phase 2.1-2.2: DELETE when plugins are confirmed working
"StringBox" => builtin_impls::string_box::create(args),
"IntegerBox" => builtin_impls::integer_box::create(args),
// Phase 2.3: DELETE when BoolBox plugin is created
"BoolBox" => builtin_impls::bool_box::create(args),
// Phase 2.4-2.5: DELETE when collection plugins confirmed
"ArrayBox" => builtin_impls::array_box::create(args),
"MapBox" => builtin_impls::map_box::create(args),
// Phase 2.6: DELETE LAST (critical for logging)
"ConsoleBox" => builtin_impls::console_box::create(args),
// Phase 15.5: Fallback support (auto/core-ro modes)
"FileBox" => builtin_impls::file_box::create(args),
// Special: Keep vs Delete discussion needed
"NullBox" => builtin_impls::null_box::create(args),
// Leave other types to other factories (user/plugin)
_ => Err(RuntimeError::InvalidOperation {
message: format!("Unknown Box type: {}", name),
}),
}
}
fn box_types(&self) -> Vec<&str> {
vec![
// Primitive wrappers
"StringBox",
"IntegerBox",
"BoolBox",
// Collections/common
"ArrayBox",
"MapBox",
"ConsoleBox",
// Fallback support
"FileBox",
"NullBox",
]
}
fn is_builtin_factory(&self) -> bool {
true
}
}