tomoaki 3cdeb95cbc refactor(joinir): Eliminate block allocation duplication with BlockAllocator ...

Problem:
- joinir_block_converter.rs had 4 duplicate block allocation patterns
- Lines 260-265, 487-489, 635-639, 740-748 all manually allocating BasicBlockIds
- Total duplication: 27 lines across 4 sites

Solution:
- Use existing BlockAllocator (Phase 260 P0.2) for all block allocations
- Replace manual patterns with allocate_two(), allocate_three(), allocate_n()

Changes:
- Site 1/4 (handle_conditional_method_call): 6 lines → 3 lines (-3)
- Site 2/4 (handle_jump): 4 lines → 3 lines (-1)
- Site 3/4 (handle_if_merge): 6 lines → 3 lines (-3)
- Site 4/4 (handle_nested_if_merge): 11 lines → 8 lines (-3)

Result:
- ✅ 10 lines eliminated
- ✅ Improved readability (clear intent)
- ✅ Improved maintainability (SSOT for allocation)
- ✅ No behavior change (all tests pass)
- ✅ No regression: phase269_p1_2, phase259_p0, phase269_p0 PASS

Follow-up potential:
- MergeVariableHandlerBox duplication (lines 652-660, 667-675, 785-791, 800-806)
- CallInstructionGeneratorBox duplication (lines 403-406, 511-514, 536-546)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2025-12-22 03:58:12 +09:00

..

builder

fix(joinir): Phase 269 P1.2 - static call normalization for this.method()

2025-12-22 03:33:30 +09:00

control_tree

feat(mir): Phase 260 P2 - Delete BasicBlock.jump_args, unify to terminator SSOT

2025-12-21 09:39:20 +09:00

definitions

chore: Phase 25.1 完了 - LoopForm v2/Stage1 CLI/環境変数削減 + Phase 26-D からの変更

2025-11-21 06:25:17 +09:00

if_in_loop_phi

feat(joinir): Phase 183 LoopBodyLocal role separation + test fixes

2025-12-08 23:43:26 +09:00

instruction

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

instruction_kinds

feat(mir): Phase 63-6-1/2 MIR Phi type_hint field & JoinIR propagation

2025-11-30 04:35:40 +09:00

join_ir

refactor(mir): phase260 p0.1 strangler hardening + smoke fixtures

2025-12-21 05:47:37 +09:00

join_ir_vm_bridge

refactor(joinir): Eliminate block allocation duplication with BlockAllocator

2025-12-22 03:58:12 +09:00

join_ir_vm_bridge_dispatch

Phase 33 NORM canon test: enforce normalized dev route for P1/P2/JP mini

2025-12-11 20:54:33 +09:00

loop_canonicalizer

fix(joinir): stabilize Phase 256 merge (jump_args, DCE, func names)

2025-12-20 11:01:48 +09:00

loop_pattern_detection

fix(joinir): improve Pattern3 classification to exclude simple conditional assignment (Phase 264 P0)

2025-12-21 11:49:03 +09:00

lowerers

Phase 30.1 & 73: Stage-3 features env and JoinIR flag cleanup

2025-11-30 14:30:28 +09:00

optimizer_passes

refactor(mir): phase260 p0.1 strangler hardening + smoke fixtures

2025-12-21 05:47:37 +09:00

passes

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

phi_core

Phase 33 NORM canon test: enforce normalized dev route for P1/P2/JP mini

2025-12-11 20:54:33 +09:00

region

refactor(mir): Phase 139-P3-B - RoutingDecision を enum 対応 + レガシー削除

2025-12-16 07:02:14 +09:00

ssot

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

utils

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

verification

refactor(verify): Phase 260 P2 - Remove dual-source edge-args validation

2025-12-21 09:39:26 +09:00

aot_plan_import.rs

chore: Phase 25.1 完了 - LoopForm v2/Stage1 CLI/環境変数削減 + Phase 26-D からの変更

2025-11-21 06:25:17 +09:00

basic_block.rs

feat(mir): Phase 260 P2 - Delete BasicBlock.jump_args, unify to terminator SSOT

2025-12-21 09:39:20 +09:00

binding_id.rs

feat(mir): Phase 74 - BindingId infrastructure (dev-only)

2025-12-13 05:34:56 +09:00

builder.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

cfg_extractor.rs

feat(joinir): Phase 171-C-3 LoopBodyCarrierPromoter integration with Pattern 2/4

2025-12-07 23:45:55 +09:00

control_form.rs

refactor(edgecfg): add Frag/ExitKind API entrypoint (Phase 264 design-first)

2025-12-21 12:49:53 +09:00

effect.rs

feat(runtime): Phase 103 CoreServices Optional化 - Memory Constraints対応

2025-12-03 13:59:06 +09:00

function_emission.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

function.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

hints.rs

refactor(mir): Extract MetadataContext from MirBuilder (Phase 136 follow-up 6/7)

2025-12-15 22:03:34 +09:00

instruction_introspection.rs

chore(fmt): add legacy stubs and strip trailing whitespace to unblock cargo fmt

2025-09-17 07:43:07 +09:00

instruction.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

join_ir_ops.rs

feat(joinir): Phase 188-Impl-3 Pattern 3 (Loop with If-Else PHI) implementation

2025-12-05 15:45:42 +09:00

join_ir_runner.rs

refactor(mir): Phase 139-P3-B - RoutingDecision を enum 対応 + レガシー削除

2025-12-16 07:02:14 +09:00

loop_api.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

loop_form.rs

Span trace utilities and runner source hint

2025-11-24 14:17:02 +09:00

mod.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

naming.rs

Span trace utilities and runner source hint

2025-11-24 14:17:02 +09:00

optimizer_stats.rs

chore(fmt): add legacy stubs and strip trailing whitespace to unblock cargo fmt

2025-09-17 07:43:07 +09:00

optimizer.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

printer_helpers.rs

refactor(mir): phase260 p0 edge-args plumbing (strangler) + ssot api + docs

2025-12-21 04:34:22 +09:00

printer.rs

refactor(joinir): Phase 189 - Remove hardcoded 'sum' variable, generalize exit PHI connection

2025-12-05 19:39:54 +09:00

query.rs

feat(select): Task 2-E complete - VM/LLVM backend support for Select instruction

2025-12-20 03:20:55 +09:00

slot_registry.rs

feat: スモークテストv2実装＆Phase 15.5後のプラグイン対応

2025-09-24 09:30:42 +09:00

spanned_instruction.rs

Normalize passes keep spans and clean warnings

2025-11-24 15:02:51 +09:00

types.rs

chore: Phase 25.1 完了 - LoopForm v2/Stage1 CLI/環境変数削減 + Phase 26-D からの変更

2025-11-21 06:25:17 +09:00

value_id.rs

test(mir): fix test compilation after Call instruction callee field addition

2025-11-17 09:45:03 +09:00

value_kind.rs

Normalize passes keep spans and clean warnings

2025-11-24 15:02:51 +09:00

verification_types.rs

chore: Phase 25.1 完了 - LoopForm v2/Stage1 CLI/環境変数削減 + Phase 26-D からの変更

2025-11-21 06:25:17 +09:00

verification.rs

feat(joinir): Phase 257 P1.1/P1.2/P1.3 - Pattern6 SSOT + LoopHeaderPhi CFG fix

2025-12-20 23:30:27 +09:00