- Add destination write helpers (write_box_result, write_void, write_result) - Add argument validation helpers (validate_args_exact/range/min) - Add receiver conversion helper (convert_to_box) - Update handlers to use new helpers Reduces code duplication: - Destination patterns: 37 call sites converted - Each replacement saves 2-3 lines (74-111 lines saved) - Helper infrastructure: 178 lines added - Net improvement: Reduced duplication + better maintainability Impact: - Build: ✓ SUCCESS (0 errors, 146 warnings) - Tests: ✓ 8/9 smoke tests PASS - Functionality: ✓ PRESERVED (no behavior changes) Files created: - src/backend/mir_interpreter/utils/mod.rs - src/backend/mir_interpreter/utils/destination_helpers.rs - src/backend/mir_interpreter/utils/arg_validation.rs - src/backend/mir_interpreter/utils/receiver_helpers.rs Files modified: 15 handler files - arithmetic.rs, boxes.rs, boxes_array.rs, boxes_instance.rs - boxes_map.rs, boxes_object_fields.rs, boxes_plugin.rs - boxes_string.rs, calls.rs, extern_provider.rs, externals.rs - memory.rs, misc.rs, mod.rs Related: Phase 21.0 refactoring Risk: Low (pure refactoring, no behavior change)
33 lines
1.2 KiB
Rust
33 lines
1.2 KiB
Rust
use super::*;
|
|
use super::super::utils::*;
|
|
|
|
impl MirInterpreter {
|
|
pub(super) fn handle_debug(&mut self, message: &str, value: ValueId) -> Result<(), VMError> {
|
|
let v = self.reg_load(value)?;
|
|
if std::env::var("NYASH_CLI_VERBOSE").ok().as_deref() == Some("1") {
|
|
eprintln!("[mir-debug] {} => {:?}", message, v);
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
pub(super) fn handle_print(&mut self, value: ValueId) -> Result<(), VMError> {
|
|
let v = self.reg_load(value)?;
|
|
// Align with calls.rs behavior: Void/BoxRef(VoidBox) prints as null; raw String/StringBox unquoted
|
|
match &v {
|
|
VMValue::Void => { println!("null"); return Ok(()); }
|
|
VMValue::BoxRef(bx) => {
|
|
if bx.as_any().downcast_ref::<crate::box_trait::VoidBox>().is_some() {
|
|
println!("null"); return Ok(());
|
|
}
|
|
if let Some(sb) = bx.as_any().downcast_ref::<crate::box_trait::StringBox>() {
|
|
println!("{}", sb.value); return Ok(());
|
|
}
|
|
}
|
|
VMValue::String(s) => { println!("{}", s); return Ok(()); }
|
|
_ => {}
|
|
}
|
|
println!("{}", v.to_string());
|
|
Ok(())
|
|
}
|
|
}
|