tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
095213c580689c09c11fe495d9fa59731bb71bc1
hakorune/tools/smokes/v2
History
tomoaki 095213c580 refactor(smoke): Clarify auto_detect.conf responsibilities with profile parameter 
**Problem**:
- detect_optimal_config() took no arguments (line 11)
- Quick profile SSOT forcing scattered outside function (line 134-137)
- Profile-specific logic split between detect_optimal_config() and auto_configure()
- Hard to understand flow: "why is this logic duplicated?"

**Solution** (Task 4 - Low Priority):
- Accept profile parameter: `detect_optimal_config(profile)`
- Move quick profile SSOT forcing inside function (top priority)
- Eliminate duplicate logic in auto_configure()
- Update show_auto_config() to pass profile parameter

**Changes**:
- detect_optimal_config(): Add `local profile="${1:-quick}"`
- Quick SSOT check: Move to function top (early return)
- auto_configure(): Pass `"$profile"` to detect_optimal_config
- show_auto_config(): Pass `"${SMOKES_CURRENT_PROFILE:-quick}"`
- Remove 6 lines of duplicate quick forcing logic

**Benefits**:
- Single responsibility: Profile logic inside detect_optimal_config
- Clearer flow: All detection in one function
- Maintainability: One place to modify profile behavior
- Readability: Intent is explicit (profile parameter)

**Verification**:
- ✅ detect_optimal_config "quick": returns rust_vm_dynamic (SSOT)
- ✅ detect_optimal_config "integration": returns llvm_static
- ✅ Quick profile: 154/154 PASS

**Note**: This is a low-impact refactoring (code organization only)
- Behavior unchanged (same logic, better location)
- No performance impact
- Future-proof for profile-specific detection

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-26 17:32:48 +09:00
..
configs
refactor(smoke): Clarify auto_detect.conf responsibilities with profile parameter
2025-12-26 17:32:48 +09:00
lib
refactor(smoke): Consolidate LLVM detection to can_run_llvm() SSOT
2025-12-26 17:31:19 +09:00
profiles
refactor(smoke): Consolidate LLVM detection to can_run_llvm() SSOT
2025-12-26 17:31:19 +09:00
measure_test_times.sh
smokes(v2): Slim quick profile (Phase 287 P1)
2025-12-25 07:48:18 +09:00
README_CLAUDE_REMINDER.md
phase: 20.49 COMPLETE; 20.50 Flow+String minimal reps; 20.51 selfhost v0/v1 minimal (Option A/B); hv1-inline binop/unop/copy; docs + run_all + CURRENT_TASK -> 21.0
2025-11-06 15:41:52 +09:00
README.md
smokes(v2): Reach 45s target (Phase 287 P2)
2025-12-25 07:58:51 +09:00
run_quick.sh
feat(phase21.5/22.1): MirBuilder JsonFrag refactor + FileBox ring-1 + registry tests
2025-11-10 19:42:42 +09:00
run.sh
MIR: lexical scoping + builder vars modules
2025-12-13 01:30:04 +09:00

README.md

Smokes v2 — Minimal Runner and Policy

Profiles

quick

  • Purpose: Fast feedback for development
  • Target: ~45 seconds, ~400 tests (Phase 287 P2: 45.85s / 413 tests ✅)
  • Contents: Minimal gate tests - basic syntax, using resolution, essential control flow
  • Excluded: Heavy selfhost/Stage-B, crate exe, S3/LLVM integration, long-running tests (>0.4s)

integration

  • Purpose: Integration and heavier tests
  • Contents: Selfhost canaries, Stage-B, crate exe, S3/LLVM, phase-specific comprehensive tests
  • Run: ./tools/smokes/v2/run.sh --profile integration

full

  • Purpose: Complete regression coverage
  • Contents: All tests (network of quick + integration + additional)
  • Run: ./tools/smokes/v2/run.sh --profile full

plugins

  • Purpose: Plugin-specific tests (dynamic loading, etc.)
  • Run: ./tools/smokes/v2/run.sh --profile plugins

Policy

  • Use [SKIP:] prefix for environment/host dependent skips.
    • Examples: [SKIP] hakorune not built, [SKIP:env] plugin path missing
    • Keep reasons short and stable to allow grep-based canaries.
  • Prefer JSON-only output in CI: set NYASH_JSON_ONLY=1 to avoid noisy logs.
  • Diagnostics lines like [provider/select:*] are filtered by default in lib/test_runner.sh.
    • Toggle: set HAKO_SILENT_TAGS=0 to disable filtering and show raw logs. HAKO_SHOW_CALL_LOGS=1 also bypasses filtering.

Helpers

  • tools/smokes/v2/lib/mir_canary.sh provides:
    • extract_mir_from_output — between [MIR_BEGIN]/[MIR_END]
    • assert_has_tokens, assert_skip_tag, assert_order, assert_token_count
  • tools/lib/canary.sh provides minimal, harness-agnostic aliases:
    • extract_mir_between_tags — same as extract_mir_from_output
    • require_tokens token... — fail if any token missing

Notes

  • Avoid running heavy integration smokes in CI by default. Use --profile quick.
  • When a test depends on external tools (e.g., LLVM), prefer [SKIP:<reason>] over failure.
  • Stage‑B/selfhost canaries（stage1_launcher_*, phase251* など）は Stage‑3 デフォルト環境で安定しないため、quick プロファイルでは [SKIP:stageb] として扱い、必要に応じて別プロファイル（integration/full）で個別に実行する。
  • Selfhost quick カバレッジは最小 1 本（core/selfhost_minimal.sh）に絞り、Stage‑3 + JoinIR 前提で Stage‑B→VM を通るかだけを確認する。
  • S3 backend 向けの長尺テスト群も quick 向きではないため、timeout を短く保ちたい場合は [SKIP:slow] にして別途ローカルで回すことを推奨する。

Quick tips

  • EXE-heavy cases (e.g., phase2100/*) may take longer. When running quick with these tests, pass a larger timeout like --timeout 120.
  • Smokes v2 auto-cleans temporary crate EXE objects created under /tmp (pattern: ny_crate_backend_exe_*.o) after the run.

Developer Notes

  • JoinIR If/Select (Phase 33): A/B test with NYASH_FEATURES=stage3 HAKO_JOINIR_IF_SELECT=1 ./target/release/hakorune apps/tests/joinir_if_select_simple.hako（dev-only、CI対象外。NYASH_JOINIR_CORE は deprecated/無視）