a3df5ecc7a
Implements role-based separation of LoopBodyLocal variables to prevent inappropriate Trim promotion for body-only local variables. ## Changes ### Task 183-1: Design Documentation - Created `phase183-loopbodylocal-role-separation.md` with role taxonomy: - Condition LoopBodyLocal: Used in loop conditions → Trim promotion target - Body-only LoopBodyLocal: Only in body → No promotion needed - Documented architectural approach and implementation strategy ### Task 183-2: Implementation - Added `TrimLoopLowerer::is_var_used_in_condition()` helper - Recursively checks if variable appears in condition AST - Handles BinaryOp, UnaryOp, MethodCall node types - Updated `try_lower_trim_like_loop()` to filter condition LoopBodyLocal - Only processes LoopBodyLocal that appear in break conditions - Skips body-only LoopBodyLocal (returns Ok(None) early) - Added 5 unit tests for variable detection logic ### Task 183-3: Test Files - Created `phase183_body_only_loopbodylocal.hako` - Demonstrates body-only LoopBodyLocal (`temp`) not triggering Trim - Verified trace output: "No LoopBodyLocal detected, skipping Trim lowering" - Created additional test files (phase183_p1_match_literal, phase183_p2_atoi, phase183_p2_parse_number) ### Task 183-4: Documentation Updates - Updated `joinir-architecture-overview.md` with Phase 183 results - Updated `CURRENT_TASK.md` with Phase 183 completion status ## Results ✅ LoopBodyLocal role separation complete ✅ Body-only LoopBodyLocal skips Trim promotion ✅ 5 unit tests passing ✅ Trace verification successful ## Next Steps (Phase 184+) - Body-local variable MIR lowering support - String concatenation filter relaxation - Full _parse_number/_atoi implementation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
47 lines
1.2 KiB
Plaintext
47 lines
1.2 KiB
Plaintext
// Phase 183-3: Pattern2 Break test (_atoi pattern)
|
|
// Tests: Integer loop with break on non-digit character
|
|
// Note: Uses body-only LoopBodyLocal (digit computation not in condition)
|
|
|
|
static box Main {
|
|
main(args) {
|
|
// Simulate _atoi: convert "123" to integer
|
|
// For simplicity, we manually set up digit values
|
|
local result = 0
|
|
local i = 0
|
|
local n = 3 // length of "123"
|
|
|
|
loop(i < n) {
|
|
// Body-only LoopBodyLocal: digit computation
|
|
// In real _atoi: local digit = "0123456789".indexOf(ch)
|
|
// Here we simulate with hardcoded values for "123"
|
|
local digit = 0
|
|
if i == 0 { digit = 1 } // '1'
|
|
if i == 1 { digit = 2 } // '2'
|
|
if i == 2 { digit = 3 } // '3'
|
|
|
|
// Break on non-digit (digit < 0) - NOT using digit in condition here
|
|
// This is simplified: we always have valid digits
|
|
|
|
result = result * 10 + digit
|
|
i = i + 1
|
|
}
|
|
|
|
// Debug: print actual values
|
|
print("Final result:")
|
|
print(result)
|
|
print("Final i:")
|
|
print(i)
|
|
|
|
// Expected: result = 123
|
|
if result == 123 {
|
|
if i == 3 {
|
|
print("PASS: P2 Break with body-only LoopBodyLocal works")
|
|
return 0
|
|
}
|
|
}
|
|
|
|
print("FAIL: result or i incorrect")
|
|
return 1
|
|
}
|
|
}
|