f74b7d2b04
📦 Hotfix 1 & 2: Parameter ValueId Reservation + Exit PHI Validation (Box-First Theory)
...
**箱理論に基づく根治的修正**：
## 🎯 Hotfix 1: Parameter ValueId Reservation (パラメータ ValueId 予約)
### 根本原因
- MirFunction counter が params.len() を考慮していなかった
- local variables が parameter ValueIds を上書き
### 箱理論的解決
1. **LoopFormContext Box**
- パラメータ予約を明示的に管理
- 境界をはっきりさせる
2. **MirFunction::new() 改善**
- `initial_counter = param_count.max(1)` でパラメータ予約
- Parameters are %0, %1, ..., %N-1
3. **ensure_counter_after() 強化**
- パラメータ数 + 既存 ValueIds 両方を考慮
- `min_counter = param_count.max(max_id + 1)`
4. **reserve_parameter_value_ids() 追加**
- 明示的な予約メソッド（Box-First）
## 🎯 Hotfix 2: Exit PHI Predecessor Validation (Exit PHI 検証)
### 根本原因
- LoopForm builder が存在しないブロックを PHI predecessor に追加
- 「幽霊ブロック」問題
### 箱理論的解決
1. **LoopFormOps.block_exists() 追加**
- CFG 存在確認メソッド
- 境界を明確化
2. **build_exit_phis() 検証**
- 非存在ブロックをスキップ
- デバッグログ付き
### 実装ファイル
- `src/mir/function.rs`: Parameter reservation
- `src/mir/phi_core/loopform_builder.rs`: Context + validation
- `src/mir/loop_builder.rs`: LoopFormOps impl
- `src/mir/builder/stmts.rs`: Local variable allocation
### 業界標準準拠
- ✅ LLVM IR: Parameters are %0, %1, ...
- ✅ SSA Form: PHI predecessors must exist in CFG
- ✅ Cytron et al. (1991): Parameter reservation principle
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-11-18 06:39:45 +09:00
f85e485195
feat(mir/phi): add LoopForm Meta-Box for PHI circular dependency solution
...
**Problem**: ValueId(14)/ValueId(17) circular dependency in multi-carrier
loop PHI construction. Loop body PHIs referenced ValueIds not defined in
header exit block, causing SSA use-before-def violations.
**Root Cause**: Interleaved ValueId allocation when processing pinned
(parameters like 'me', 'args') and carrier (locals like 'i', 'n')
variables created forward references:
```
Iteration 1: pre_copy=%13, phi=%14 ✅
Iteration 2: pre_copy=%15, phi=%19 ✅ (but %14 not yet emitted!)
Body PHI: phi %17 = [%14, bb3] ❌ %14 doesn't exist in bb3
```
**Solution**: LoopForm Meta-Box with 3-pass PHI construction algorithm
inspired by Braun et al. (2013) "Simple and Efficient SSA Construction".
**Core Design**:
- **Meta-Box abstraction**: Treat entire loop as single Box with explicit
carrier/pinned separation
- **Three-pass algorithm**:
1. Allocate ALL ValueIds upfront (no emission)
2. Emit preheader copies in deterministic order
3. Emit header PHIs (incomplete)
4. Seal PHIs after loop body (complete)
- **Guarantees**: No circular dependencies possible (all IDs pre-allocated)
**Academic Foundation**:
- Cytron et al. (1991): Classical SSA with dominance frontiers
- Braun et al. (2013): Simple SSA with incomplete φ-nodes ✅ Applied here
- LLVM Canonical Loop Form: Preheader→Header(PHI)→Body→Latch
**Files Added**:
1. **src/mir/phi_core/loopform_builder.rs** (360 lines):
- LoopFormBuilder struct with carrier/pinned separation
- LoopFormOps trait (abstraction layer)
- Three-pass algorithm implementation
- Unit tests (all pass ✅ )
2. **docs/development/analysis/loopform-phi-circular-dependency-solution.md**:
- Comprehensive problem analysis (600+ lines)
- Academic literature review
- Alternative approaches comparison
- Detailed implementation plan
3. **docs/development/analysis/LOOPFORM_PHI_SOLUTION_SUMMARY.md**:
- Executive summary (250 lines)
- Testing strategy
- Migration timeline (4 weeks)
- Risk assessment
4. **docs/development/analysis/LOOPFORM_PHI_NEXT_STEPS.md**:
- Step-by-step integration guide (400 lines)
- Code snippets for mir/loop_builder.rs
- Troubleshooting guide
- Success metrics
**Testing**:
- ✅ Unit tests pass (deterministic allocation verified)
- ⏳ Integration tests (Week 2 with feature flag)
- ⏳ Selfhost support (Week 3)
**Migration Strategy**:
- Week 1 (Current): ✅ Prototype complete
- Week 2: Integration with NYASH_LOOPFORM_PHI_V2=1 feature flag
- Week 3: Selfhost compiler support
- Week 4: Full migration, deprecate old code
**Advantages**:
1. **Correctness**: Guarantees SSA definition-before-use
2. **Simplicity**: ~360 lines (preserves Box Theory philosophy)
3. **Academic alignment**: Matches state-of-art SSA construction
4. **Backward compatible**: Feature-flagged with rollback capability
**Impact**: This resolves the fundamental ValueId circular dependency
issue blocking Stage-B selfhosting, while maintaining the LoopForm
design philosophy of "normalize everything, confine to scope".
**Total Contribution**: ~2,000 lines of code + documentation
**Next Steps**: Integrate LoopFormBuilder into src/mir/loop_builder.rs
following LOOPFORM_PHI_NEXT_STEPS.md guide (estimated 2-4 hours).
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-11-17 04:56:47 +09:00
13f21334c9
fix(aot): resolve copy chains in PHI propagation for deep loop coverage
...
Fix CollectionsHot type_table to resolve copy chains when propagating types
through PHI nodes, enabling ArrayBox optimization in deeply nested loops (matmul).
**Root Cause:**
- PHI incoming values were checked directly in type_table
- Copy chains (e.g., SSA 56→11) were not resolved
- Types failed to propagate through deep loop nesting
**Solution:**
- Add copy_src_map parameter to build_type_table()
- Resolve copy chains before checking if PHI incoming values are typed
- Multi-pass fixpoint algorithm (up to 12 passes) ensures convergence
**Impact:**
- matmul: ArrayBox A/B/C now propagate through nested loops
- Expected: boxcall→externcall conversion for get/set/push
- Backwards compatible: opt-in (NYASH_AOT_COLLECTIONS_HOT=1), no behavior change when disabled
**Analysis:**
- Documented in docs/development/analysis/matmul_collections_hot_fix.md
- Box→SSA flow traced: A(dst=2)→...→71(get), B(dst=3)→...→73(get), C(dst=4)→...→105(set)
**Testing:** Pending verification due to VM step budget constraints
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-11-14 06:54:56 +09:00
