f0536fa330
feat(joinir): Phase 222-2 ConditionPatternBox normalization implementation
...
Phase 222: If Condition Normalization - Part 2
Goal: Support '0 < i', 'i > j' patterns in addition to 'i > 0'
Changes:
1. condition_pattern.rs (+160 lines):
- Added ConditionValue enum (Variable | Literal)
- Added NormalizedCondition struct (left_var, op, right)
- Added flip_compare_op() for operator reversal
- Added binary_op_to_compare_op() converter
- Added normalize_comparison() main normalization function
- Extended analyze_condition_pattern() to accept 3 cases:
* Phase 219: var CmpOp literal (e.g., i > 0)
* Phase 222: literal CmpOp var (e.g., 0 < i) → normalized
* Phase 222: var CmpOp var (e.g., i > j)
- Added 9 unit tests (all passing)
2. loop_update_summary.rs (cleanup):
- Commented out obsolete test_typical_index_names
- Function is_typical_index_name() was removed in earlier phase
Test results:
- 7 normalization tests: PASS ✅
- 2 pattern analysis tests: PASS ✅
Next: Phase 222-3 - integrate normalization into is_if_sum_pattern()
Status: Ready for integration
2025-12-10 09:18:21 +09:00
e6e306c020
fix(joinir): Phase 219 Phantom Carrier Bug fix complete
...
Fixes phantom carrier detection that blocked AST-based if-sum lowerer.
## Problem
Name-based heuristic in loop_update_summary.rs created phantom "count"
carrier even when variable didn't exist, causing:
1. counter_count() = 2 (i + phantom "count") instead of 1
2. is_simple_if_sum_pattern() = false
3. AST-based lowerer never activates (falls back to legacy)
4. Result: RC=0 instead of expected values
## Solution
Assignment-based carrier detection:
### New API (recommended)
```rust
pub fn analyze_loop_updates_from_ast(
loop_body_ast: &[ASTNode]
) -> LoopUpdateSummary
```
- Extracts only variables with actual assignments in loop body
- Classifies by RHS structure (not name)
- Eliminates phantom carriers completely
### Changes
1. **Added**: `extract_assigned_variables()` - AST walker for assignments
2. **Added**: `find_assignment_rhs()` - RHS expression extraction
3. **Added**: `classify_update_kind_from_rhs()` - Structure-based classification
4. **Added**: `is_likely_loop_index()` - Name heuristic for disambiguation
5. **Deprecated**: `analyze_loop_updates()` - Legacy name-based API (3 call sites remain)
### Verification
Before:
```
variable_map = {i, sum, defs, len}
→ Phantom "count" detected
→ counter_count() = 2
→ is_simple_if_sum_pattern() = false
```
After:
```
assigned_vars = {i, sum} // Only assigned!
→ No phantom carriers
→ counter_count() = 1
→ accumulation_count() = 1
→ is_simple_if_sum_pattern() = true ✅
```
## Files Modified
**Core Fix**:
- src/mir/join_ir/lowering/loop_update_summary.rs (+116 lines)
- New assignment-based API
- Phantom carrier elimination
**Integration**:
- src/mir/builder/control_flow/joinir/patterns/pattern_pipeline.rs (+3 lines)
- Updated is_if_sum_pattern() to use new API
## Test Results
- ✅ Phantom carrier bug fixed
- ✅ AST lowerer activates correctly
- ⚠️ 3 deprecation warnings (expected, legacy call sites)
- ⏳ phase212/218 still RC=0 (blocked by condition variable support)
## Design Principles
1. **No Phantom Carriers**: Only variables with actual assignments
2. **Assignment-Based Detection**: LHS from AST assignments only
3. **Structure-Based Classification**: RHS patterns + name disambiguation
## Next Steps
Phase 220: Condition variable extraction and wiring to enable
phase212/218 tests to pass with correct RC values.
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com >
2025-12-10 02:30:14 +09:00
338d1aecf1
feat(joinir): Phase 213 AST-based if-sum lowerer for Pattern 3
...
Implement dual-mode architecture for Pattern 3 (Loop with If-Else PHI):
- Add is_simple_if_sum_pattern() detection helper
- Detects 1 CounterLike + 1-2 AccumulationLike carrier patterns
- Unit tests for various carrier compositions
- Add dual-mode dispatch in Pattern3 lowerer
- ctx.is_if_sum_pattern() branches to AST-based vs legacy PoC
- Legacy mode preserved for backward compatibility
- Create loop_with_if_phi_if_sum.rs (~420 lines)
- AST extraction: loop condition, if condition, updates
- JoinIR generation: main, loop_step, k_exit structure
- Helper functions: extract_loop_condition, extract_if_condition, etc.
- Extend PatternPipelineContext for Pattern 3
- is_if_sum_pattern() detection using LoopUpdateSummary
- extract_if_statement() helper for body analysis
Note: E2E RC=2 not yet achieved due to pre-existing Pattern 3
pipeline issue (loop back branch targets wrong block). This
affects both if-sum and legacy modes. Fix planned for Phase 214.
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2025-12-10 00:54:46 +09:00
d7805e5974
feat(joinir): Phase 213-2 Step 2-2 & 2-3 Data structure extensions
...
Extended PatternPipelineContext and CarrierUpdateInfo for Pattern 3 AST-based generalization.
Changes:
1. PatternPipelineContext:
- Added loop_condition: Option<ASTNode>
- Added loop_body: Option<Vec<ASTNode>>
- Added loop_update_summary: Option<LoopUpdateSummary>
- Updated build_pattern_context() for Pattern 3
2. CarrierUpdateInfo:
- Added then_expr: Option<ASTNode>
- Added else_expr: Option<ASTNode>
- Updated analyze_loop_updates() with None defaults
Status: Phase 213-2 Steps 2-2 & 2-3 complete
Next: Create Pattern3IfAnalyzer to extract if statement and populate update summary
2025-12-10 00:01:53 +09:00
c9458ef11e
feat(joinir): Phase 170-C-2 LoopUpdateSummary skeleton and design doc
...
Add UpdateKind/LoopUpdateSummary types for loop update pattern analysis.
Currently uses carrier name heuristics internally (same as 170-C-1),
but provides clean interface for future AST/MIR-based analysis.
New types:
- UpdateKind: CounterLike | AccumulationLike | Other
- CarrierUpdateInfo: name + kind pair
- LoopUpdateSummary: collection with helper methods
Helper methods:
- has_single_counter(): for StringExamination detection
- has_accumulation(): for ArrayAccumulation detection
Design doc: docs/development/current/main/phase170-c2-update-summary-design.md
- Describes LoopFeatures.update_summary integration plan
- Migration path to AST/MIR analysis
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-12-07 14:17:58 +09:00
