tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
2,022 Commits 1 Branch 0 Tags
ee2915a6b2d97fb1ac0164543b75b5f3d6b810d3
Commit Graph

5 Commits

Author SHA1 Message Date
nyash-codex
ee2915a6b2 refactor(mir): Extract VariableContext from MirBuilder (Phase 136 follow-up 5/7) 
## Summary
Extracted variable mapping management into dedicated VariableContext struct,
completing step 5 of 7 in the Context Box refactoring plan.

## Changes
- NEW: src/mir/builder/variable_context.rs (VariableContext struct + helpers)
- Modified: src/mir/builder.rs (added variable_ctx field + sync helpers)
- Updated: phase-136-context-box-progress.md (5/7 progress)

## Extracted Fields
- variable_map: BTreeMap<String, ValueId> → variable_ctx.variable_map

## Key Features
- snapshot/restore for if/loop pattern state management
- JoinIR integration: CarrierInfo::from_variable_map()
- ExitLine contract enforcement (carriers in variable_map)
- NYASH_TRACE_VARMAP debug visualization support

## Design Clarity
- BindingContext: String → BindingId (binding identity, survives SSA renaming)
- VariableContext: String → ValueId (current SSA values, block-local)
- Both contexts work together for complete variable management

## Tests
- cargo test --release --lib: 1014/1018 passed (4 pre-existing failures)
- phase135_trim_mir_verify.sh: PASS
- Backward compatibility: 100% maintained (deprecated fields synced)

## Progress
Phase 136 Context Extraction: 5/7 complete (71%)
- ✅ Step 1: TypeContext
- ✅ Step 2: CoreContext
- ✅ Step 3: ScopeContext
- ✅ Step 4: BindingContext
- ✅ Step 5: VariableContext (this commit)
- ⏳ Step 6: MetadataContext
- ⏳ Step 7: CompilationContext

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2025-12-15 21:50:50 +09:00
nyash-codex
3127ebb73d feat(mir): Phase 136 Step 3/7 - ScopeContext extraction 
## Summary
Extract scope and control flow management into ScopeContext for better organization.

## Changes
- **New file**: src/mir/builder/scope_context.rs (264 lines)
  - Lexical scope stack management
  - Control flow stacks (loop/if)
  - Function context tracking
  - Debug scope helpers
- **Updated**: src/mir/builder.rs
  - Add scope_ctx field
  - Mark legacy fields as deprecated
  - Add sync helpers (sync_scope_ctx_to_legacy, sync_legacy_to_scope_ctx)
- **Updated**: src/mir/builder/vars/lexical_scope.rs
  - Use scope_ctx as SSOT
  - Sync to legacy fields for backward compat
- **Updated**: src/mir/builder/lifecycle.rs
  - Sync current_function via scope_ctx
- **Updated**: src/mir/builder/calls/lowering.rs
  - Sync function context in lowering flow

## Extracted Fields (7)
1. lexical_scope_stack - Block-scoped locals
2. loop_header_stack - Loop headers for break/continue
3. loop_exit_stack - Loop exit blocks
4. if_merge_stack - If merge blocks
5. current_function - Currently building function
6. function_param_names - Function parameters (for LoopForm)
7. debug_scope_stack - Debug region identifiers

## Test Results
- ✅ cargo build --release (291 warnings - deprecated usage)
- ✅ cargo test --release --lib - 1005/1009 PASS
- ✅ phase135_trim_mir_verify.sh - PASS
- ⚠️ phase132_exit_phi_parity.sh - Error (pre-existing issue)

## Progress
Phase 136: 3/7 Contexts complete (TypeContext, CoreContext, ScopeContext)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2025-12-15 20:28:21 +09:00
nyash-codex
89edf11699 docs: Update Phase 136 progress with CoreContext commit hash 2025-12-15 20:10:47 +09:00
nyash-codex
81d79161e4 feat(mir): Phase 136 Step 2/7 - CoreContext extraction complete 
Extract core ID generation fields from MirBuilder to improve organization:
- value_gen: ValueIdGenerator
- block_gen: BasicBlockIdGenerator
- next_binding_id: u32 (Phase 74)
- temp_slot_counter: u32
- debug_join_counter: u32

Implementation:
- Created src/mir/builder/core_context.rs (215 lines)
- Added core_ctx field to MirBuilder as SSOT
- Deprecated legacy fields with backward compat
- ID allocation methods use core_ctx and sync legacy fields
- Added next_block_id() helper, replaced 30+ block_gen.next() calls

Testing:
- cargo build --release: SUCCESS (193 warnings expected)
- cargo test --release --lib: 1004/1004 PASS (+7 tests)
- phase135_trim_mir_verify.sh: PASS
- phase132_exit_phi_parity.sh: 3/3 PASS

Progress: 2/7 Context extractions complete (TypeContext + CoreContext)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2025-12-15 20:10:36 +09:00
nyash-codex
076f193f76 refactor(mir): Extract TypeContext from MirBuilder (Phase 136 follow-up 1/7) 
## Summary
Extract type-related fields into dedicated TypeContext for better code
organization and maintainability. First step of 7-context refactoring plan.

## Changes
- **New**: src/mir/builder/type_context.rs
  - Consolidates value_types, value_kinds, value_origin_newbox
  - Provides clean API for type operations
  - BTreeMap/HashMap as appropriate for determinism

- **Modified**: src/mir/builder.rs
  - Add type_ctx field to MirBuilder
  - Deprecate old fields (backward compat)
  - Add sync helpers for gradual migration
  - Initialize type_ctx in new()

- **Doc**: phase-136-context-box-progress.md
  - Track refactoring progress (1/7 complete)
  - Document design principles
  - Plan next steps (CoreContext)

## Impact
- 16 files with 113 deprecated field usages
- No breaking changes (gradual migration)
- All tests pass (997/997)

## Test Results
✅ cargo build --release (warnings only)
✅ cargo test --release --lib (997 passed)
✅ phase135_trim_mir_verify.sh (PASS)
✅ phase132_exit_phi_parity.sh (3/3 PASS)

## Next Step
CoreContext extraction (ValueId/BlockId generators)

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2025-12-15 19:59:55 +09:00