|
|
9e32807a96
|
refactor(joinir): Phase 82-83 - Debug flag SSOT + Fallback verification
Phase 82: Centralized JoinIR debug flag reading
- Added is_joinir_debug() SSOT function in joinir_flags.rs
- Replaced 16 direct env::var() calls across 8 files
- Updated docs to recommend HAKO_JOINIR_DEBUG (NYASH_ deprecated)
- Backward compat: Both env vars work
Phase 83: Verified promoted carrier fallback behavior
- Confirmed NO fallback to name-based lookup for DigitPos/Trim
- Documented fallback expectations in Phase 80/81 docs
- Added verification commands and expected output
Changes:
- src/config/env/joinir_flags.rs: +187 lines (new SSOT module)
- 8 files: env var reads → is_joinir_debug() calls
- 3 docs: HAKO_JOINIR_DEBUG examples + fallback sections
- 1 summary doc: phase82-83-debug-flag-ssot-summary.md
Tests: 970/970 lib PASS, 58/58 normalized_dev PASS
Impact: Dev-only (zero production changes)
|
2025-12-13 19:01:14 +09:00 |
|
|
|
5029cfc4a0
|
feat(joinir): Phase 81 - Pattern2 ExitLine contract verification (dev-only)
Task 81-A: ExitLine audit findings
- ExitLineReconnector: Correctly skips ConditionOnly carriers (lines 124-132)
- ExitMetaCollector: Includes all carriers for latch (lines 148-215)
- CarrierRole filtering: Verified correct implementation
- Contract compliance: Full compliance with Phase 227-228 design
- No fixes required: Implementation verified correct
Task 81-B: E2E tests for promoted carriers
- test_phase81_digitpos_exitline_contract(): DigitPos pattern (PASS)
- test_phase81_trim_exitline_contract(): Trim pattern (PASS)
- Verified Exit PHI excludes ConditionOnly carriers (is_digit_pos, is_ch_match)
- Verified Exit PHI includes LoopState carriers (result, i, etc.)
- Both tests execute successfully with correct output values
Task 81-D: Smoke test verification
- tools/smokes/v2/run.sh --profile quick: 1/2 PASS (baseline maintained)
- Pre-existing json_lint_vm failure unrelated to Phase 81
- No new regressions introduced
Task 81-C: Contract documentation
- Audit findings documented with detailed evidence
- E2E test results and manual verification commands recorded
- Smoke test baseline comparison documented
- Contract clarity improved for future development
Tests: 970/970 lib tests PASS (baseline), +2 E2E tests PASS
Integration: phase246_json_atoi.rs 9/9 PASS (existing DigitPos test verified)
Smoke: quick profile 1/2 PASS (no regressions)
Design: Verification-only, zero production impact
Phase 81 complete: ExitLine contract verified for promoted carriers
|
2025-12-13 18:31:02 +09:00 |
|
|
|
0e3b825a52
|
docs(joinir): Phase 81 design - Pattern2 ExitLine contract verification
Phase 81 SSOT 設計文書作成（P1 優先度）
Goal: Pattern2（DigitPos/Trim）promoted carriers の ExitLine 接続契約を堅牢化
Key sections:
- Background: Phase 74-80 完了後の ExitLine 契約不明確問題
- Invariants: CarrierRole discrimination, ExitLine reconnection timing
- Design: Verification-only strategy (no new features)
- Tasks:
- 81-A: ExitLine Audit (analysis)
- 81-B: E2E Tests (DigitPos + Trim)
- 81-C: Contract Documentation
- 81-D: Smoke Tests Verification
Acceptance criteria:
- 972/972 lib tests PASS (970 + 2 new E2E)
- tools/smokes/v2/run.sh --profile quick no regressions
- Contract documented
Out of scope: New features, architecture changes, Pattern3/4 work
Next: Task 81-A (ExitLine Audit)
Future: Phase 82 (P3/P4 後段 BindingId), Phase 83 (debug flag cleanup) - optional
|
2025-12-13 18:18:44 +09:00 |
|
