2 Commits

Author	SHA1	Message	Date
nyash-codex	d4f90976da	refactor(joinir): Phase 244 - ConditionLoweringBox trait unification ... Unify condition lowering logic across Pattern 2/4 with trait-based API. New infrastructure: - condition_lowering_box.rs: ConditionLoweringBox trait + ConditionContext (293 lines) - ExprLowerer implements ConditionLoweringBox trait (+51 lines) Pattern migrations: - Pattern 2 (loop_with_break_minimal.rs): Use trait API - Pattern 4 (loop_with_continue_minimal.rs): Use trait API Benefits: - Unified condition lowering interface - Extensible for future lowering strategies - Clean API boundary between patterns and lowering logic - Zero code duplication Test results: 911/911 PASS (+2 new tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2025-12-11 02:35:31 +09:00
nyash-codex	9b3d2bf001	refactor(joinir): Phase 223 cleanup - impl consolidation & comment cleanup ... Improves code organization and readability after Phase 223-3 implementation. ## Task R-1: impl Block Consolidation **loop_body_cond_promoter.rs**: - Merged 2 separate impl blocks into single unified impl - Added section headers for better organization: - Public API (extract_continue_condition, try_promote_for_condition) - Private Helpers (contains_continue) - Improved logical flow and discoverability ## Task R-2: Phase Comment Cleanup **pattern4_with_continue.rs**: - Simplified Phase 223-3 comments (removed redundant phase numbers) - Added concise section header explaining LoopBodyLocal promotion - Clarified inline comments for better understanding - Maintained implementation intent while reducing noise ## Impact - No functional changes - All tests PASS (5 cond_promoter tests, 8 pattern4 tests) - Better code organization for future maintenance - Cleaner git history for Phase 223 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2025-12-10 15:07:08 +09:00