hakorune

tomoaki/hakorune

Fork 0

Commit Graph

Author	SHA1	Message	Date
nyash-codex	d4f90976da	refactor(joinir): Phase 244 - ConditionLoweringBox trait unification Unify condition lowering logic across Pattern 2/4 with trait-based API. New infrastructure: - condition_lowering_box.rs: ConditionLoweringBox trait + ConditionContext (293 lines) - ExprLowerer implements ConditionLoweringBox trait (+51 lines) Pattern migrations: - Pattern 2 (loop_with_break_minimal.rs): Use trait API - Pattern 4 (loop_with_continue_minimal.rs): Use trait API Benefits: - Unified condition lowering interface - Extensible for future lowering strategies - Clean API boundary between patterns and lowering logic - Zero code duplication Test results: 911/911 PASS (+2 new tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2025-12-11 02:35:31 +09:00
nyash-codex	f0536fa330	feat(joinir): Phase 222-2 ConditionPatternBox normalization implementation Phase 222: If Condition Normalization - Part 2 Goal: Support '0 < i', 'i > j' patterns in addition to 'i > 0' Changes: 1. condition_pattern.rs (+160 lines): - Added ConditionValue enum (Variable \| Literal) - Added NormalizedCondition struct (left_var, op, right) - Added flip_compare_op() for operator reversal - Added binary_op_to_compare_op() converter - Added normalize_comparison() main normalization function - Extended analyze_condition_pattern() to accept 3 cases: * Phase 219: var CmpOp literal (e.g., i > 0) * Phase 222: literal CmpOp var (e.g., 0 < i) → normalized * Phase 222: var CmpOp var (e.g., i > j) - Added 9 unit tests (all passing) 2. loop_update_summary.rs (cleanup): - Commented out obsolete test_typical_index_names - Function is_typical_index_name() was removed in earlier phase Test results: - 7 normalization tests: PASS ✅ - 2 pattern analysis tests: PASS ✅ Next: Phase 222-3 - integrate normalization into is_if_sum_pattern() Status: Ready for integration	2025-12-10 09:18:21 +09:00

Author

SHA1

Message

Date

nyash-codex

d4f90976da

refactor(joinir): Phase 244 - ConditionLoweringBox trait unification

Unify condition lowering logic across Pattern 2/4 with trait-based API.

New infrastructure:
- condition_lowering_box.rs: ConditionLoweringBox trait + ConditionContext (293 lines)
- ExprLowerer implements ConditionLoweringBox trait (+51 lines)

Pattern migrations:
- Pattern 2 (loop_with_break_minimal.rs): Use trait API
- Pattern 4 (loop_with_continue_minimal.rs): Use trait API

Benefits:
- Unified condition lowering interface
- Extensible for future lowering strategies
- Clean API boundary between patterns and lowering logic
- Zero code duplication

Test results: 911/911 PASS (+2 new tests)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2025-12-11 02:35:31 +09:00

nyash-codex

f0536fa330

feat(joinir): Phase 222-2 ConditionPatternBox normalization implementation

Phase 222: If Condition Normalization - Part 2
Goal: Support '0 < i', 'i > j' patterns in addition to 'i > 0'

Changes:
1. condition_pattern.rs (+160 lines):
   - Added ConditionValue enum (Variable | Literal)
   - Added NormalizedCondition struct (left_var, op, right)
   - Added flip_compare_op() for operator reversal
   - Added binary_op_to_compare_op() converter
   - Added normalize_comparison() main normalization function
   - Extended analyze_condition_pattern() to accept 3 cases:
     * Phase 219: var CmpOp literal (e.g., i > 0)
     * Phase 222: literal CmpOp var (e.g., 0 < i) → normalized
     * Phase 222: var CmpOp var (e.g., i > j)
   - Added 9 unit tests (all passing)

2. loop_update_summary.rs (cleanup):
   - Commented out obsolete test_typical_index_names
   - Function is_typical_index_name() was removed in earlier phase

Test results:
- 7 normalization tests: PASS ✅
- 2 pattern analysis tests: PASS ✅

Next: Phase 222-3 - integrate normalization into is_if_sum_pattern()
Status: Ready for integration

2025-12-10 09:18:21 +09:00

2 Commits