hakorune

tomoaki/hakorune

Fork 0

Commit Graph

Author	SHA1	Message	Date
nyash-codex	525e59bc8d	feat(loop-phi): Add body-local variable PHI generation for Rust AST loops Phase 25.1c/k: Fix ValueId undefined errors in loops with body-local variables Problem: - FuncScannerBox.scan_all_boxes/1 and BreakFinderBox._find_loops/2 had ValueId undefined errors for variables declared inside loop bodies - LoopFormBuilder only generated PHIs for preheader variables, missing body-locals - Example: `local ch = s.substring(i, i+1)` inside loop → undefined on next iteration Solution: 1. Rust AST path (src/mir/loop_builder.rs): - Detect body-local variables by comparing body_end_vars vs current_vars - Generate empty PHI nodes at loop header for body-local variables - Seal PHIs with latch + continue snapshot inputs after seal_phis() - Added HAKO_LOOP_PHI_TRACE=1 logging for debugging 2. JSON v0 path (already fixed in previous session): - src/runner/json_v0_bridge/lowering/loop_.rs handles body-locals - Uses same strategy but for JSON v0 bridge lowering Results: - ✅ FuncScannerBox.scan_all_boxes: 41 body-local PHIs generated - ✅ Main.main (demo harness): 23 body-local PHIs generated - ⚠️ Still some ValueId undefined errors remaining (exit PHI issue) Files changed: - src/mir/loop_builder.rs: body-local PHI generation logic - lang/src/compiler/entry/func_scanner.hako: debug logging - /tmp/stageb_funcscan_demo.hako: test harness 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-11-19 23:12:01 +09:00
nyash-codex	39f5256c18	📊 Phase 25.1l: Region観測レイヤー骨格 + スコープ契約設計理解 Region Box統一理論の実装開始新規追加: - src/mir/region/mod.rs: Region/RefSlotKind型定義 - src/mir/region/observer.rs: Region観測レイヤー - docs/development/roadmap/phases/phase-25.1l/: 設計ドキュメント主要概念: - Region Box = Function/Loop/If の統一箱 - RefSlotKind = GC管理用スロット種別（Strong/Weak/Borrowed/NonRef） - 観測専用（NYASH_REGION_TRACE=1で動作、挙動変更なし）設計理解の深化: - ValueId(40)問題 = LoopForm v2スコープ契約違反の症状 - 根本解決 = Region観測で無名一時値のスコープまたぎを検出 - 箱理論3原則: 境界明確化/差し替え可能/段階的移行関連議論: - ChatGPT提案: Region統一理論でGC/寿命管理の基盤構築 - SlotRegistry: 変数の単一真実源（SSOT） - 階層構造: FunctionRegion → LoopRegion → IfRegion 次のステップ: - Phase 1: Region観測（現在）- 非破壊的追加 - Phase 2: メタデータ出力（MIR JSON拡張） - Phase 3: GC統合（retain/release挿入）テスト追加: - lang/src/compiler/tests/stageb_mini_driver.hako - tools/test_loopssa_breakfinder_slot.sh Build: ✅ 全警告は既存のもの Tests: 既存テスト全て緑維持	2025-11-19 02:44:40 +09:00
nyash-codex	80f8a7bc8c	🔧 Hotfix 7 (Enhanced): ValueId receiver alias tracking for nested loops - Problem: Pinned receiver variables in loops cause undefined ValueId errors - Enhanced fix: Update all receiver aliases (me + all __pin$N$@recv levels) - Handles nested loops by updating previous pin levels - Test status: Partial improvement, ValueId(50) → ValueId(40) - Further investigation needed for complete fix Files modified: - src/mir/phi_core/loopform_builder.rs (emit_header_phis)	2025-11-19 00:02:41 +09:00

Author

SHA1

Message

Date

nyash-codex

525e59bc8d

feat(loop-phi): Add body-local variable PHI generation for Rust AST loops

Phase 25.1c/k: Fix ValueId undefined errors in loops with body-local variables

**Problem:**
- FuncScannerBox.scan_all_boxes/1 and BreakFinderBox._find_loops/2 had ValueId
  undefined errors for variables declared inside loop bodies
- LoopFormBuilder only generated PHIs for preheader variables, missing body-locals
- Example: `local ch = s.substring(i, i+1)` inside loop → undefined on next iteration

**Solution:**
1. **Rust AST path** (src/mir/loop_builder.rs):
   - Detect body-local variables by comparing body_end_vars vs current_vars
   - Generate empty PHI nodes at loop header for body-local variables
   - Seal PHIs with latch + continue snapshot inputs after seal_phis()
   - Added HAKO_LOOP_PHI_TRACE=1 logging for debugging

2. **JSON v0 path** (already fixed in previous session):
   - src/runner/json_v0_bridge/lowering/loop_.rs handles body-locals
   - Uses same strategy but for JSON v0 bridge lowering

**Results:**
- ✅ FuncScannerBox.scan_all_boxes: 41 body-local PHIs generated
- ✅ Main.main (demo harness): 23 body-local PHIs generated
- ⚠️ Still some ValueId undefined errors remaining (exit PHI issue)

**Files changed:**
- src/mir/loop_builder.rs: body-local PHI generation logic
- lang/src/compiler/entry/func_scanner.hako: debug logging
- /tmp/stageb_funcscan_demo.hako: test harness

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-11-19 23:12:01 +09:00

nyash-codex

39f5256c18

📊 Phase 25.1l: Region観測レイヤー骨格 + スコープ契約設計理解

**Region Box統一理論の実装開始**

新規追加:
- src/mir/region/mod.rs: Region/RefSlotKind型定義
- src/mir/region/observer.rs: Region観測レイヤー
- docs/development/roadmap/phases/phase-25.1l/: 設計ドキュメント

主要概念:
- Region Box = Function/Loop/If の統一箱
- RefSlotKind = GC管理用スロット種別（Strong/Weak/Borrowed/NonRef）
- 観測専用（NYASH_REGION_TRACE=1で動作、挙動変更なし）

設計理解の深化:
- ValueId(40)問題 = LoopForm v2スコープ契約違反の症状
- 根本解決 = Region観測で無名一時値のスコープまたぎを検出
- 箱理論3原則: 境界明確化/差し替え可能/段階的移行

関連議論:
- ChatGPT提案: Region統一理論でGC/寿命管理の基盤構築
- SlotRegistry: 変数の単一真実源（SSOT）
- 階層構造: FunctionRegion → LoopRegion → IfRegion

次のステップ:
- Phase 1: Region観測（現在）- 非破壊的追加
- Phase 2: メタデータ出力（MIR JSON拡張）
- Phase 3: GC統合（retain/release挿入）

テスト追加:
- lang/src/compiler/tests/stageb_mini_driver.hako
- tools/test_loopssa_breakfinder_slot.sh

Build: ✅ 全警告は既存のもの
Tests: 既存テスト全て緑維持

2025-11-19 02:44:40 +09:00

nyash-codex

80f8a7bc8c

🔧 Hotfix 7 (Enhanced): ValueId receiver alias tracking for nested loops

- Problem: Pinned receiver variables in loops cause undefined ValueId errors
- Enhanced fix: Update all receiver aliases (me + all __pin$N$@recv levels)
- Handles nested loops by updating previous pin levels
- Test status: Partial improvement, ValueId(50) → ValueId(40)
- Further investigation needed for complete fix

Files modified:
- src/mir/phi_core/loopform_builder.rs (emit_header_phis)

2025-11-19 00:02:41 +09:00

3 Commits