Commit Graph

8 Commits

Author SHA1 Message Date
116ff105ed fix(mir/phi): include pinned variables in loop header PHIs
**Problem**: "use of undefined value ValueId(22)" errors in Stage-B
when method receivers were used after loops.

**Root cause**: prepare_loop_variables_with() explicitly skipped
pinned variables (like __pin$6438$@recv) when creating loop header
PHIs. Comment claimed they were "materialized via entry-phi in loop
body" but this only happened for the body block, not for loop exit
merge points. When receivers were used after loops, there was no PHI
to merge values from different control flow paths.

**Fix**: Remove the skip logic (lines 174-177) so pinned variables
get PHIs at loop headers and exits like any other variable.

**Impact**:
- ValueId(22) error eliminated in Stage-B selfhost tests
- MIR verification passes with NYASH_VM_VERIFY_MIR=1
- Pinned slots now correctly merge across loop boundaries
- No more "use of undefined value" for cross-loop receivers

**Test case**: /tmp/test_loop_recv.hako demonstrates receiver usage
in loop and after loop exit, now works correctly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-17 02:16:59 +09:00
06a729ff40 vm(hako): add v1 reader/dispatcher (flagged), commonize mir_call handler, share block scan; smokes: add v1 hakovm canary; docs: 20.37/20.38 plans, OOB policy; runner: v1 hakovm toggle; include SKIP summary 2025-11-03 23:21:48 +09:00
66b2a115ae fix(vm): implement StringBox.lastIndexOf + PHI bug fix + Stage-B compiler完全動作 🎉
## 🎯 主要修正

### 1️⃣ StringBox.lastIndexOf実装 (Stage-B compiler blocker解消)
- **問題**: `lang/src/compiler/parser/parser_box.hako:85`で`lastIndexOf`使用も未実装
- **修正**: `src/backend/mir_interpreter/handlers/boxes_string.rs:51-60`に追加
- **実装**: `rfind()`で最後の出現位置を検索、-1でnot found表現

### 2️⃣ VM SSA/PHI bug完全修正 (ループ内メソッド呼び出し)
- **原因**: メソッド内ループ×外側ループ呼び出しでPHI生成失敗
- **修正箇所**:
  - `src/mir/loop_builder.rs`: Exit PHI生成実装
  - `src/mir/phi_core/loop_phi.rs`: PHI incoming修正
  - `src/mir/phi_core/common.rs`: ユーティリティ追加

### 3️⃣ カナリアテスト追加
- **新規**: `tools/smokes/v2/profiles/quick/core/vm_nested_loop_method_call.sh`
- **構成**: Level 0/5b/5a/5 (段階的バグ検出)
- **結果**: 全テストPASS、Level 5で`[SUCCESS] VM SSA/PHI bug FIXED!`表示

### 4️⃣ using連鎖解決修正
- **問題**: `using sh_core`が子モジュールに伝播しない
- **修正**: 6ファイルに明示的`using`追加
  - compiler_stageb.hako, parser_box.hako
  - parser_stmt_box.hako, parser_control_box.hako
  - parser_exception_box.hako, parser_expr_box.hako

### 5️⃣ ParserBoxワークアラウンド
- **問題**: `skip_ws()`メソッド呼び出しでVMバグ発生
- **対応**: 3箇所でインライン化(PHI修正までの暫定対応)

## 🎉 動作確認

```bash
# Stage-B compiler完全動作!
$ bash /tmp/run_stageb.sh
{"version":0,"kind":"Program","body":[{"type":"Return","expr":{"type":"Int","value":42}}]}

# カナリアテスト全PASS
$ bash tools/smokes/v2/profiles/quick/core/vm_nested_loop_method_call.sh
[PASS] level0_simple_loop (.008s)
[PASS] level5b_inline_nested_loop (.007s)
[PASS] level5a_method_no_loop (.007s)
[SUCCESS] Level 5: VM SSA/PHI bug FIXED!
[PASS] level5_method_with_loop (VM BUG canary) (.008s)
```

## 🏆 技術的ハイライト

1. **最小再現**: Level 0→5bの段階的テストでバグパターン完全特定
2. **Task先生調査**: 表面エラーから真因(lastIndexOf未実装)発見
3. **適切実装**: `boxes_string.rs`のStringBox専用ハンドラに追加
4. **完全検証**: Stage-B compilerでJSON出力成功を実証

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-02 10:58:09 +09:00
25b6bd3ae1 Fix VM: string handler no longer hijacks length() on non-strings; ArrayBox.length returns correct values (fixes json_lint loop). Add string-literal reader init guard earlier 2025-11-01 19:26:49 +09:00
01b4417c5d docs(llvm/vm): 静的Box(self)規約を明文化 + Bridgeトグル追記; Gate‑C/Core 現状反映; CURRENT_TASK 更新。\n\n- 新規: docs/development/architecture/llvm/static_box_singleton.md\n- 追記: lang/src/vm/README.md に self 先頭規約/互換トグルを明記\n- 追記: CURRENT_TASK に本更新を記録\n- phase-20.33/CHECKLIST にドキュメント完了チェックを追加\n- bak フォルダはリポジトリ直下に存在せず(削除対象なし)\n\n併せて未コミット差分をスナップショット(Rust 層の前作業含む) 2025-11-01 16:31:48 +09:00
b9340a1b19 refactor(mir): Phase 6-2 - Apply helper methods to reduce ~28 lines in JSON v0 Bridge
**Phase 6-2完了:ヘルパーメソッド適用で28行削減達成!**

## 📊 削減実績
- **loop_.rs**: 8行→1行(7行削減) - PHI更新ループ統一
- **if_else.rs**: 6行→1行(5行削減) - Branch終端設定統一
- **try_catch.rs**: 8箇所×2-3行(16行削減) - Jump終端設定統一
- **合計**: ~28行削減

## 🔧 適用内容
### 1. loop_.rs - PHI更新の統一化
- **Before**: 手動でPHI命令を検索してinputs.push()
- **After**: `bb.update_phi_input(phi_dst, (bend, latch_val))?`

### 2. if_else.rs - Branch終端設定の統一化
- **Before**: if-let-Some + bb.set_terminator(Branch {...})
- **After**: `f.set_branch_terminator(cur, cval, then_bb, else_bb)?`

### 3. try_catch.rs - Jump終端設定の統一化(8箇所)
- **Before**: if-let-Some + bb.set_terminator(Jump {...})
- **After**: `f.set_jump_terminator(bb_id, target)?`

##  テスト結果
- `loop_min_while.nyash`:  PASS(0,1,2出力)
- `loop_phi_one_sided.nyash`:  PASS(ArrayBox警告のみ)
- ビルド:  88 warnings(既存レベル)

## 🎯 Phase 6進捗
- **Phase 6-1**:  ヘルパーメソッド追加(+46行)
- **Phase 6-2**:  ヘルパー適用(-28行)
- **実質削減**: -28行(基盤整備込み)

## 📋 次のステップ
- **Phase 6-3**: BranchMergeBuilder pattern(~100行削減見込み)
- **Phase 6-4**: 全体統合・最終テスト

Related: Phase 1-5(3,824行削減)に続く段階的リファクタリング

🐱 にゃーん!実用化成功!
2025-11-01 15:23:28 +09:00
cdf826cbe7 public: publish selfhost snapshot to public repo (SSOT using + AST merge + JSON VM fixes)
- SSOT using profiles (aliases/packages via nyash.toml), AST prelude merge
- Parser/member guards; Builder pin/PHI and instance→function rewrite (dev on)
- VM refactors (handlers split) and JSON roundtrip/nested stabilization
- CURRENT_TASK.md updated with scope and acceptance criteria

Notes: dev-only guards remain togglable via env; no default behavior changes for prod.
2025-09-26 14:34:42 +09:00
9384c80623 using: safer seam defaults (fix_braces OFF by default) + path-alias handling; json_native: robust integer parse + EscapeUtils unquote; add JsonCompat layer; builder: preindex static methods + fallback for bare calls; diagnostics: seam dump + function-call trace 2025-09-25 10:23:14 +09:00