3 Commits

Author	SHA1	Message	Date
nyash-codex	88400e7e22	feat(joinir): Phase 171-C-2 Trim pattern detection in LoopBodyCarrierPromoter ... Implements the Trim pattern detection logic for carrier promotion: - find_definition_in_body(): Iterative AST traversal to locate variable definitions - is_substring_method_call(): Detects substring() method calls - extract_equality_literals(): Extracts string literals from OR chains (ch == " " || ch == "\t") - TrimPatternInfo: Captures detected pattern details for carrier promotion This enables Pattern 5 to detect trim-style loops: ```hako loop(start < end) { local ch = s.substring(start, start+1) if ch == " " || ch == "\t" || ch == "\n" || ch == "\r" { start = start + 1 } else { break } } ``` Unit tests cover: - Simple and nested definition detection - substring method call detection - Single and chained equality literal extraction - Full Trim pattern detection with 2-4 whitespace characters Next: Phase 171-C-3 integration with Pattern 2/4 routing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2025-12-07 23:09:25 +09:00
nyash-codex	1356b61ff7	feat(joinir): Phase 170-D-impl-1 LoopConditionScopeBox skeleton creation ... Implement the LoopConditionScope analysis infrastructure for Pattern2/4 validation: New module: - src/mir/loop_pattern_detection/loop_condition_scope.rs (220 lines) Types: - CondVarScope enum: LoopParam, OuterLocal, LoopBodyLocal - CondVarInfo: Variable name + scope classification - LoopConditionScope: Collection of analyzed variables with helper methods Box implementation (LoopConditionScopeBox): - analyze(): Main entry point - extracts and classifies condition variables - extract_vars(): Recursive AST traversal to find all variable references - is_outer_local(): Heuristic for outer scope detection (phase 170-D simplified) Helper methods: - has_loop_body_local(): Check for unsupported loop-body variables - all_in(): Validate scope compatibility - var_names(): Get variable set - add_var(): Add with deduplication Tests: 5 unit tests for core functionality Architecture: Refactored loop_pattern_detection.rs → loop_pattern_detection/mod.rs for modular organization. Build: ✅ Passed with no errors 🤖 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>	2025-12-07 21:29:19 +09:00
nyash-codex	4e32a803a7	feat(joinir): Phase 33-22 CommonPatternInitializer & JoinIRConversionPipeline integration ... Unifies initialization and conversion logic across all 4 loop patterns, eliminating code duplication and establishing single source of truth. ## Changes ### Infrastructure (New) - CommonPatternInitializer (117 lines): Unified loop var extraction + CarrierInfo building - JoinIRConversionPipeline (127 lines): Unified JoinIR→MIR→Merge flow ### Pattern Refactoring - Pattern 1: Uses CommonPatternInitializer + JoinIRConversionPipeline (-25 lines) - Pattern 2: Uses CommonPatternInitializer + JoinIRConversionPipeline (-25 lines) - Pattern 3: Uses CommonPatternInitializer + JoinIRConversionPipeline (-25 lines) - Pattern 4: Uses CommonPatternInitializer + JoinIRConversionPipeline (-40 lines) ### Code Reduction - Total reduction: ~115 lines across all patterns - Zero code duplication in initialization/conversion - Pattern files: 806 lines total (down from ~920) ### Quality Improvements - Single source of truth for initialization - Consistent conversion flow across all patterns - Guaranteed boundary.loop_var_name setting (prevents SSA-undef bugs) - Improved maintainability and testability ### Testing - All 4 patterns tested and passing: - Pattern 1 (Simple While): ✅ - Pattern 2 (With Break): ✅ - Pattern 3 (If-Else PHI): ✅ - Pattern 4 (With Continue): ✅ ### Documentation - Phase 33-22 inventory and results document - Updated joinir-architecture-overview.md with new infrastructure ## Breaking Changes None - pure refactoring with no API changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>	2025-12-07 21:02:20 +09:00