fix(mir/builder): use function-local ValueId throughout MIR builder
Phase 25.1b: Complete SSA fix - eliminate all global ValueId usage in function contexts. Root cause: ~75 locations throughout MIR builder were using global value generator (self.value_gen.next()) instead of function-local allocator (f.next_value_id()), causing SSA verification failures and runtime "use of undefined value" errors. Solution: - Added next_value_id() helper that automatically chooses correct allocator - Fixed 19 files with ~75 occurrences of ValueId allocation - All function-context allocations now use function-local IDs Files modified: - src/mir/builder/utils.rs: Added next_value_id() helper, fixed 8 locations - src/mir/builder/builder_calls.rs: 17 fixes - src/mir/builder/ops.rs: 8 fixes - src/mir/builder/stmts.rs: 7 fixes - src/mir/builder/emission/constant.rs: 6 fixes - src/mir/builder/rewrite/*.rs: 10 fixes - + 13 other files Verification: - cargo build --release: SUCCESS - Simple tests with NYASH_VM_VERIFY_MIR=1: Zero undefined errors - Multi-parameter static methods: All working Known remaining: ValueId(22) in Stage-B (separate issue to investigate) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@ -51,11 +51,7 @@ impl super::MirBuilder {
|
||||
for p in params.iter() {
|
||||
// Allocate a value ID using the current function's value generator
|
||||
// This creates a local variable, not a parameter
|
||||
let pid = if let Some(ref mut f) = self.current_function {
|
||||
f.next_value_id()
|
||||
} else {
|
||||
self.value_gen.next()
|
||||
};
|
||||
let pid = self.next_value_id();
|
||||
if p == "args" {
|
||||
// new ArrayBox() with no args
|
||||
self.emit_instruction(MirInstruction::NewBox {
|
||||
|
||||
Reference in New Issue
Block a user