refactor(joinir): Phase 193-1 - AST Feature Extractor Box modularization

**Phase 193-1**: Create independent AST Feature Extractor Box module

## Summary
Extracted feature detection logic from router.rs into a new, reusable
ast_feature_extractor.rs module. This improves:
- **Modularity**: Feature extraction is now a pure, side-effect-free module
- **Reusability**: Can be used for Pattern 5-6 detection and analysis tools
- **Testability**: Pure functions can be unit tested independently
- **Maintainability**: Clear separation of concerns (router does dispatch, extractor does analysis)

## Changes

### New Files
- **src/mir/builder/control_flow/joinir/patterns/ast_feature_extractor.rs** (+180 lines)
  - `detect_continue_in_body()`: Detect continue statements
  - `detect_break_in_body()`: Detect break statements
  - `extract_features()`: Full feature extraction pipeline
  - `detect_if_else_phi_in_body()`: Pattern detection for if-else PHI
  - `count_carriers_in_body()`: Heuristic carrier counting
  - Unit tests for basic functionality

### Modified Files
- **src/mir/builder/control_flow/joinir/patterns/router.rs**
  - Removed 75 lines of feature detection code
  - Now delegates to `ast_features::` module
  - Phase 193 documentation in comments
  - Cleaner separation of concerns

- **src/mir/builder/control_flow/joinir/patterns/mod.rs**
  - Added module declaration for ast_feature_extractor
  - Updated documentation with Phase 193 info

## Architecture
```
router.rs (10 lines)
  └─→ ast_feature_extractor.rs (180 lines)
      - Pure functions for AST analysis
      - No side effects
      - High reusability
      - Testable in isolation
```

## Testing
 Build succeeds: `cargo build --release` compiles cleanly
 Binary compatibility: Existing .hako files execute correctly
 No logic changes: Feature detection identical to previous implementation

## Metrics
- Lines moved from router to new module: 75
- New module total: 180 lines (including tests and documentation)
- Router.rs reduced by ~40% in feature detection code
- New module rated  for reusability and independence

## Next Steps
- Phase 193-2: CarrierInfo Builder Enhancement
- Phase 193-3: Pattern Classification Improvement
- Phase 194: Further pattern detection optimizations

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
nyash-codex
2025-12-06 03:30:03 +09:00
parent 60bd5487e6
commit d28ba4cd9d
15 changed files with 992 additions and 344 deletions

View File

@ -0,0 +1,16 @@
# Troubleshooting Guides
このディレクトリには、Nyash/Hakorune を使うときに遭遇しがちなトラブルと、その対処方法をまとめたガイドを置いているよ。
## 現在のガイド
- `stage3-local-keyword-guide.md`
- Stage3 キーワード(特に `local`)を使用するときに必要な環境変数と、エラー発生時の診断方法。
- `using-resolution.md`
- `using` 解決まわりのエラーモジュール未解決、arity mismatch など)の原因と対処法。
## 置き場所のルール(提案)
- 開発者やユーザーが「実際にハマった時にすぐ読みたい」内容は、`docs/development/` ではなくここ(`guides/troubleshooting/`)に置く。
- フェーズ固有の一時メモは `docs/development/issues/` に置き、広く役立つノウハウになったらこちらに昇格させる、という二段構えにする。