fix(mir): Phase 25.1m - Continue PHI修正 & Bug A main(args)ループ修正
**Phase 25.1m: Continue PHI修正** - seal_phis に continue_snapshots 入力を追加 (loopform_builder.rs) - LoopShape::debug_validate に continue/break エッジ検証追加 (control_form.rs) - test_seal_phis_includes_continue_snapshots テスト追加 - 実証テスト成功: balanced scan loop で 228回イテレーション確認 **Bug A修正: main(args) でループ未実行問題** - LoopBuilder::build_loop で entry → preheader への jump 追加 - decls.rs でデュアル関数作成時のブロック接続修正 - mir_static_main_args_loop.rs テスト追加 **パーサー改善**: - parser_box.hako に HAKO_PARSER_PROG_MAX ガード追加(無限ループ対策) 🎉 成果: - Continue 文の PHI predecessor mismatch エラー完全解消 - main(args) パラメータ有りループが正常動作 - Stage-B balanced scan で continue 正常動作確認 (228回イテレーション) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@ -78,7 +78,7 @@ impl MirBuilder {
|
||||
ctx: &mut LoweringContext,
|
||||
) -> Result<(), String> {
|
||||
let signature = function_lowering::prepare_static_method_signature(
|
||||
func_name,
|
||||
func_name.clone(),
|
||||
params,
|
||||
body,
|
||||
);
|
||||
@ -89,6 +89,9 @@ impl MirBuilder {
|
||||
ctx.saved_function = self.current_function.take();
|
||||
ctx.saved_block = self.current_block.take();
|
||||
|
||||
eprintln!("[DEBUG/create_function_skeleton] Creating function: {}", func_name);
|
||||
eprintln!("[DEBUG/create_function_skeleton] Entry block: {:?}", entry);
|
||||
|
||||
// 新しい関数に切り替え
|
||||
self.current_function = Some(function);
|
||||
self.current_block = Some(entry);
|
||||
@ -98,7 +101,7 @@ impl MirBuilder {
|
||||
|
||||
// Region 観測レイヤ: static 関数用の FunctionRegion を積むよ。
|
||||
crate::mir::region::observer::observe_function_region(self);
|
||||
|
||||
|
||||
Ok(())
|
||||
}
|
||||
|
||||
@ -145,8 +148,11 @@ impl MirBuilder {
|
||||
|
||||
/// 🎯 箱理論: Step 4 - 本体lowering
|
||||
fn lower_function_body(&mut self, body: Vec<ASTNode>) -> Result<(), String> {
|
||||
eprintln!("[DEBUG/lower_function_body] body.len() = {}", body.len());
|
||||
let program_ast = function_lowering::wrap_in_program(body);
|
||||
eprintln!("[DEBUG/lower_function_body] About to call build_expression");
|
||||
let _last = self.build_expression(program_ast)?;
|
||||
eprintln!("[DEBUG/lower_function_body] build_expression completed");
|
||||
Ok(())
|
||||
}
|
||||
|
||||
|
||||
@ -29,15 +29,25 @@ impl super::MirBuilder {
|
||||
// Look for the main() method
|
||||
let out = if let Some(main_method) = methods.get("main") {
|
||||
if let ASTNode::FunctionDeclaration { params, body, .. } = main_method {
|
||||
// Also materialize a callable function entry "BoxName.main/N" for harness/PyVM
|
||||
let func_name = format!("{}.{}", box_name, "main");
|
||||
eprintln!("[DEBUG] build_static_main_box: Before lower_static_method_as_function");
|
||||
eprintln!("[DEBUG] variable_map = {:?}", self.variable_map);
|
||||
// Note: Metadata clearing is now handled by BoxCompilationContext (箱理論)
|
||||
// See lifecycle.rs and builder_calls.rs for context swap implementation
|
||||
let _ = self.lower_static_method_as_function(func_name, params.clone(), body.clone());
|
||||
eprintln!("[DEBUG] build_static_main_box: After lower_static_method_as_function");
|
||||
eprintln!("[DEBUG] variable_map = {:?}", self.variable_map);
|
||||
// Optional: materialize a callable function entry "BoxName.main/N" for harness/PyVM.
|
||||
// This static entryは通常の VM 実行では使用されず、過去の Hotfix 4 絡みの loop/control-flow
|
||||
// バグの温床になっていたため、Phase 25.1m では明示トグルが立っている場合だけ生成する。
|
||||
if std::env::var("NYASH_BUILD_STATIC_MAIN_ENTRY")
|
||||
.ok()
|
||||
.as_deref()
|
||||
== Some("1")
|
||||
{
|
||||
let func_name = format!("{}.{}", box_name, "main");
|
||||
eprintln!("[DEBUG] build_static_main_box: Before lower_static_method_as_function");
|
||||
eprintln!("[DEBUG] params.len() = {}", params.len());
|
||||
eprintln!("[DEBUG] body.len() = {}", body.len());
|
||||
eprintln!("[DEBUG] variable_map = {:?}", self.variable_map);
|
||||
// Note: Metadata clearing is now handled by BoxCompilationContext (箱理論)
|
||||
// See lifecycle.rs and builder_calls.rs for context swap implementation
|
||||
let _ = self.lower_static_method_as_function(func_name, params.clone(), body.clone());
|
||||
eprintln!("[DEBUG] build_static_main_box: After lower_static_method_as_function");
|
||||
eprintln!("[DEBUG] variable_map = {:?}", self.variable_map);
|
||||
}
|
||||
// Initialize local variables for Main.main() parameters
|
||||
// Note: These are local variables in the wrapper main() function, NOT parameters
|
||||
let saved_var_map = std::mem::take(&mut self.variable_map);
|
||||
|
||||
@ -152,11 +152,17 @@ impl super::MirBuilder {
|
||||
let scope_id = self.current_block.map(|bb| bb.as_u32()).unwrap_or(0);
|
||||
self.hint_scope_enter(scope_id);
|
||||
let mut last_value = None;
|
||||
for statement in statements {
|
||||
let total = statements.len();
|
||||
eprintln!("[DEBUG/build_block] Processing {} statements", total);
|
||||
for (idx, statement) in statements.into_iter().enumerate() {
|
||||
eprintln!("[DEBUG/build_block] Statement {}/{} current_block={:?} current_function={}",
|
||||
idx+1, total, self.current_block,
|
||||
self.current_function.as_ref().map(|f| f.signature.name.as_str()).unwrap_or("none"));
|
||||
last_value = Some(self.build_statement(statement)?);
|
||||
// If the current block was terminated by this statement (e.g., return/throw),
|
||||
// do not emit any further instructions for this block.
|
||||
if is_current_block_terminated(self)? {
|
||||
eprintln!("[DEBUG/build_block] Block terminated after statement {}", idx+1);
|
||||
break;
|
||||
}
|
||||
}
|
||||
@ -168,6 +174,7 @@ impl super::MirBuilder {
|
||||
if !self.is_current_block_terminated() {
|
||||
self.hint_scope_leave(scope_id);
|
||||
}
|
||||
eprintln!("[DEBUG/build_block] Completed, returning value {:?}", out);
|
||||
Ok(out)
|
||||
}
|
||||
|
||||
|
||||
@ -14,13 +14,13 @@ use crate::mir::{BasicBlock, BasicBlockId, MirFunction};
|
||||
|
||||
/// ループ構造の形だけを表す箱だよ。
|
||||
///
|
||||
/// - `preheader` : ループ直前のブロック(キャリア/ピン変数のコピー元)
|
||||
/// - `header` : ループヘッダ(条件判定と header PHI が置かれる)
|
||||
/// - `body` : 代表的なループ本体ブロック(最初の body など)
|
||||
/// - `latch` : ヘッダへ戻るバックエッジを張るブロック
|
||||
/// - `exit` : ループを抜けた先のブロック
|
||||
/// - `continue_targets` : continue がジャンプするブロック群(通常は latch か header)
|
||||
/// - `break_targets` : break がジャンプするブロック群(通常は exit)
|
||||
/// - `preheader` : ループ直前のブロック(キャリア/ピン変数のコピー元)
|
||||
/// - `header` : ループヘッダ(条件判定と header PHI が置かれる)
|
||||
/// - `body` : 代表的なループ本体ブロック(最初の body など)
|
||||
/// - `latch` : ヘッダへ戻るバックエッジを張るブロック
|
||||
/// - `exit` : ループを抜けた先のブロック
|
||||
/// - `continue_targets` : continue 文を含み、`header` へ遷移するブロック群(エッジの「出発点」)
|
||||
/// - `break_targets` : break 文を含み、`exit` へ遷移するブロック群(エッジの「出発点」)
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct LoopShape {
|
||||
pub preheader: BasicBlockId,
|
||||
@ -172,6 +172,8 @@ impl LoopShape {
|
||||
///
|
||||
/// - preheader → header にエッジがあること
|
||||
/// - latch → header にバックエッジがあること
|
||||
/// - continue_targets の各ブロックから header へのエッジがあること
|
||||
/// - break_targets の各ブロックから exit へのエッジがあること
|
||||
#[cfg(debug_assertions)]
|
||||
pub fn debug_validate<C: CfgLike>(&self, cfg: &C) {
|
||||
debug_assert!(
|
||||
@ -186,6 +188,24 @@ impl LoopShape {
|
||||
self.latch,
|
||||
self.header
|
||||
);
|
||||
|
||||
for ct in &self.continue_targets {
|
||||
debug_assert!(
|
||||
cfg.has_edge(*ct, self.header),
|
||||
"LoopShape invalid: continue source block {:?} does not branch to header {:?}",
|
||||
ct,
|
||||
self.header
|
||||
);
|
||||
}
|
||||
|
||||
for bt in &self.break_targets {
|
||||
debug_assert!(
|
||||
cfg.has_edge(*bt, self.exit),
|
||||
"LoopShape invalid: break source block {:?} does not branch to exit {:?}",
|
||||
bt,
|
||||
self.exit
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@ -318,8 +318,9 @@ impl<'a> LoopBuilder<'a> {
|
||||
// 📦 Hotfix 6: Add CFG predecessor for header from latch (same as legacy version)
|
||||
crate::mir::builder::loops::add_predecessor(self.parent_builder, header_id, latch_id)?;
|
||||
|
||||
// Pass 4: Seal PHIs with latch values
|
||||
loopform.seal_phis(self, actual_latch_id)?;
|
||||
// Pass 4: Seal PHIs with latch + continue values
|
||||
let continue_snaps = self.continue_snapshots.clone();
|
||||
loopform.seal_phis(self, actual_latch_id, &continue_snaps)?;
|
||||
|
||||
// Exit block
|
||||
self.set_current_block(exit_id)?;
|
||||
|
||||
@ -259,33 +259,75 @@ impl LoopFormBuilder {
|
||||
|
||||
/// Pass 4: Seal PHI nodes after loop body lowering
|
||||
///
|
||||
/// Completes PHI nodes with latch inputs, converting them from:
|
||||
/// Completes PHI nodes with latch + continue inputs, converting them from:
|
||||
/// phi [preheader_val, preheader]
|
||||
/// to:
|
||||
/// phi [preheader_val, preheader], [latch_val, latch]
|
||||
/// phi [preheader_val, preheader], [continue_val, continue_bb]..., [latch_val, latch]
|
||||
///
|
||||
/// # Parameters
|
||||
/// - `latch_id`: The block that closes the canonical backedge to `header`.
|
||||
/// - `continue_snapshots`: Per-`continue` block variable snapshots.
|
||||
/// Each entry represents a predecessor of `header` created by `continue`.
|
||||
pub fn seal_phis<O: LoopFormOps>(
|
||||
&mut self,
|
||||
ops: &mut O,
|
||||
latch_id: BasicBlockId,
|
||||
continue_snapshots: &[(BasicBlockId, HashMap<String, ValueId>)],
|
||||
) -> Result<(), String> {
|
||||
let debug = std::env::var("NYASH_LOOPFORM_DEBUG").is_ok();
|
||||
|
||||
if debug {
|
||||
eprintln!(
|
||||
"[loopform/seal_phis] header={:?} preheader={:?} latch={:?} continue_snapshots={}",
|
||||
self.header_id,
|
||||
self.preheader_id,
|
||||
latch_id,
|
||||
continue_snapshots.len()
|
||||
);
|
||||
}
|
||||
|
||||
// Seal pinned variable PHIs
|
||||
//
|
||||
// Pinned variables are loop-invariant parameters, but header has multiple
|
||||
// predecessors (preheader + continue + latch). To keep SSA well-formed,
|
||||
// we still materialize PHI inputs for all predecessors so that every edge
|
||||
// into header has a corresponding value.
|
||||
for pinned in &self.pinned {
|
||||
// Pinned variables are not modified in loop, so latch value = header phi
|
||||
let mut inputs: Vec<(BasicBlockId, ValueId)> =
|
||||
vec![(self.preheader_id, pinned.preheader_copy)];
|
||||
|
||||
// Add inputs from each continue snapshot that carries this variable.
|
||||
for (cid, snapshot) in continue_snapshots {
|
||||
if let Some(&value) = snapshot.get(&pinned.name) {
|
||||
inputs.push((*cid, value));
|
||||
}
|
||||
}
|
||||
|
||||
// Pinned variables are not modified in loop, so latch value typically
|
||||
// equals header PHI. Fallback to header_phi if lookup fails.
|
||||
let latch_value = ops
|
||||
.get_variable_at_block(&pinned.name, latch_id)
|
||||
.unwrap_or(pinned.header_phi);
|
||||
inputs.push((latch_id, latch_value));
|
||||
|
||||
ops.update_phi_inputs(
|
||||
self.header_id,
|
||||
pinned.header_phi,
|
||||
vec![
|
||||
(self.preheader_id, pinned.preheader_copy),
|
||||
(latch_id, latch_value),
|
||||
],
|
||||
)?;
|
||||
sanitize_phi_inputs(&mut inputs);
|
||||
|
||||
if debug {
|
||||
eprintln!(
|
||||
"[loopform/seal_phis] pinned '{}' phi={:?} inputs={:?}",
|
||||
pinned.name, pinned.header_phi, inputs
|
||||
);
|
||||
}
|
||||
|
||||
ops.update_phi_inputs(self.header_id, pinned.header_phi, inputs)?;
|
||||
}
|
||||
|
||||
// Seal carrier variable PHIs
|
||||
//
|
||||
// Carriers are loop-variant locals. They must merge values from:
|
||||
// - preheader (initial value before the loop),
|
||||
// - each continue block (early jump to header),
|
||||
// - latch (normal end-of-iteration backedge).
|
||||
for carrier in &mut self.carriers {
|
||||
carrier.latch_value = ops
|
||||
.get_variable_at_block(&carrier.name, latch_id)
|
||||
@ -293,14 +335,27 @@ impl LoopFormBuilder {
|
||||
format!("Carrier variable '{}' not found at latch block", carrier.name)
|
||||
})?;
|
||||
|
||||
ops.update_phi_inputs(
|
||||
self.header_id,
|
||||
carrier.header_phi,
|
||||
vec![
|
||||
(self.preheader_id, carrier.preheader_copy),
|
||||
(latch_id, carrier.latch_value),
|
||||
],
|
||||
)?;
|
||||
let mut inputs: Vec<(BasicBlockId, ValueId)> =
|
||||
vec![(self.preheader_id, carrier.preheader_copy)];
|
||||
|
||||
for (cid, snapshot) in continue_snapshots {
|
||||
if let Some(&value) = snapshot.get(&carrier.name) {
|
||||
inputs.push((*cid, value));
|
||||
}
|
||||
}
|
||||
|
||||
inputs.push((latch_id, carrier.latch_value));
|
||||
|
||||
sanitize_phi_inputs(&mut inputs);
|
||||
|
||||
if debug {
|
||||
eprintln!(
|
||||
"[loopform/seal_phis] carrier '{}' phi={:?} inputs={:?}",
|
||||
carrier.name, carrier.header_phi, inputs
|
||||
);
|
||||
}
|
||||
|
||||
ops.update_phi_inputs(self.header_id, carrier.header_phi, inputs)?;
|
||||
}
|
||||
|
||||
Ok(())
|
||||
@ -546,6 +601,7 @@ pub fn build_exit_phis_for_control<O: LoopFormOps>(
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
use std::collections::HashMap;
|
||||
|
||||
#[test]
|
||||
fn test_sanitize_phi_inputs() {
|
||||
@ -687,4 +743,152 @@ mod tests {
|
||||
assert_eq!(builder.carriers[0].preheader_copy, ValueId::new(104)); // i copy
|
||||
assert_eq!(builder.carriers[0].header_phi, ValueId::new(105)); // i phi
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_seal_phis_includes_continue_snapshots() {
|
||||
let preheader = BasicBlockId::new(0);
|
||||
let header = BasicBlockId::new(1);
|
||||
let latch = BasicBlockId::new(2);
|
||||
|
||||
// Prepare LoopFormBuilder with one pinned and one carrier variable
|
||||
let mut builder = LoopFormBuilder::new(preheader, header);
|
||||
builder.pinned.push(PinnedVariable {
|
||||
name: "p".to_string(),
|
||||
param_value: ValueId::new(1),
|
||||
preheader_copy: ValueId::new(10),
|
||||
header_phi: ValueId::new(20),
|
||||
});
|
||||
builder.carriers.push(CarrierVariable {
|
||||
name: "i".to_string(),
|
||||
init_value: ValueId::new(2),
|
||||
preheader_copy: ValueId::new(11),
|
||||
header_phi: ValueId::new(21),
|
||||
latch_value: ValueId::INVALID,
|
||||
});
|
||||
|
||||
// Mock LoopFormOps that records PHI updates
|
||||
struct MockSealOps {
|
||||
vars_at_block: HashMap<(BasicBlockId, String), ValueId>,
|
||||
phi_updates: Vec<(BasicBlockId, ValueId, Vec<(BasicBlockId, ValueId)>)>,
|
||||
}
|
||||
|
||||
impl MockSealOps {
|
||||
fn new() -> Self {
|
||||
Self {
|
||||
vars_at_block: HashMap::new(),
|
||||
phi_updates: Vec::new(),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl LoopFormOps for MockSealOps {
|
||||
fn new_value(&mut self) -> ValueId {
|
||||
// Not used by seal_phis in this test
|
||||
ValueId::new(999)
|
||||
}
|
||||
|
||||
fn ensure_counter_after(&mut self, _max_id: u32) -> Result<(), String> {
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn block_exists(&self, _block: BasicBlockId) -> bool {
|
||||
true
|
||||
}
|
||||
|
||||
fn get_block_predecessors(
|
||||
&self,
|
||||
_block: BasicBlockId,
|
||||
) -> std::collections::HashSet<BasicBlockId> {
|
||||
std::collections::HashSet::new()
|
||||
}
|
||||
|
||||
fn is_parameter(&self, _name: &str) -> bool {
|
||||
false
|
||||
}
|
||||
|
||||
fn set_current_block(&mut self, _block: BasicBlockId) -> Result<(), String> {
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn emit_copy(&mut self, _dst: ValueId, _src: ValueId) -> Result<(), String> {
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn emit_jump(&mut self, _target: BasicBlockId) -> Result<(), String> {
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn emit_phi(
|
||||
&mut self,
|
||||
_dst: ValueId,
|
||||
_inputs: Vec<(BasicBlockId, ValueId)>,
|
||||
) -> Result<(), String> {
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn update_phi_inputs(
|
||||
&mut self,
|
||||
block: BasicBlockId,
|
||||
phi_id: ValueId,
|
||||
inputs: Vec<(BasicBlockId, ValueId)>,
|
||||
) -> Result<(), String> {
|
||||
self.phi_updates.push((block, phi_id, inputs));
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn update_var(&mut self, _name: String, _value: ValueId) {}
|
||||
|
||||
fn get_variable_at_block(
|
||||
&self,
|
||||
name: &str,
|
||||
block: BasicBlockId,
|
||||
) -> Option<ValueId> {
|
||||
self.vars_at_block
|
||||
.get(&(block, name.to_string()))
|
||||
.copied()
|
||||
}
|
||||
}
|
||||
|
||||
let mut ops = MockSealOps::new();
|
||||
// Latch values for p and i
|
||||
ops.vars_at_block
|
||||
.insert((latch, "p".to_string()), ValueId::new(30));
|
||||
ops.vars_at_block
|
||||
.insert((latch, "i".to_string()), ValueId::new(31));
|
||||
|
||||
// Continue snapshot from block 5: p and i have distinct values there
|
||||
let cont_bb = BasicBlockId::new(5);
|
||||
let mut cont_snapshot: HashMap<String, ValueId> = HashMap::new();
|
||||
cont_snapshot.insert("p".to_string(), ValueId::new(40));
|
||||
cont_snapshot.insert("i".to_string(), ValueId::new(41));
|
||||
let continue_snapshots = vec![(cont_bb, cont_snapshot)];
|
||||
|
||||
// Act: seal PHIs
|
||||
builder
|
||||
.seal_phis(&mut ops, latch, &continue_snapshots)
|
||||
.expect("seal_phis should succeed");
|
||||
|
||||
// We expect PHI updates for both pinned (p) and carrier (i)
|
||||
assert_eq!(ops.phi_updates.len(), 2);
|
||||
|
||||
// Helper to find inputs for a given phi id
|
||||
let find_inputs = |phi_id: ValueId,
|
||||
updates: &[(BasicBlockId, ValueId, Vec<(BasicBlockId, ValueId)>)]| {
|
||||
updates
|
||||
.iter()
|
||||
.find(|(_, id, _)| *id == phi_id)
|
||||
.map(|(_, _, inputs)| inputs.clone())
|
||||
.expect("phi id not found in updates")
|
||||
};
|
||||
|
||||
let pinned_inputs = find_inputs(ValueId::new(20), &ops.phi_updates);
|
||||
assert!(pinned_inputs.contains(&(preheader, ValueId::new(10))));
|
||||
assert!(pinned_inputs.contains(&(cont_bb, ValueId::new(40))));
|
||||
assert!(pinned_inputs.contains(&(latch, ValueId::new(30))));
|
||||
|
||||
let carrier_inputs = find_inputs(ValueId::new(21), &ops.phi_updates);
|
||||
assert!(carrier_inputs.contains(&(preheader, ValueId::new(11))));
|
||||
assert!(carrier_inputs.contains(&(cont_bb, ValueId::new(41))));
|
||||
assert!(carrier_inputs.contains(&(latch, ValueId::new(31))));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user