tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(joinir): L-1.3 - Rename minimal helpers to Case-A helpers

Browse Source 
LoopToJoinLowerer API cleanup:

1. Rename methods to reflect their purpose as Case-A helpers:
   - lower_minimal_skip_ws_case_a → lower_case_a_for_skip_ws
   - lower_minimal_trim_case_a → lower_case_a_for_trim
   - lower_minimal_append_defs_case_a → lower_case_a_for_append_defs
   - lower_minimal_stage1_case_a → lower_case_a_for_stage1_resolver

2. Update comments to clarify these are thin wrappers over `lower()`
   - "Case-A 汎用 lowerer の薄いラッパー"
   - Actual logic is centralized in `lower` method

3. Update all 4 call sites:
   - skip_ws.rs
   - funcscanner_trim.rs
   - funcscanner_append_defs.rs
   - stage1_using_resolver.rs

Test results: standalone (2/2), JSON snapshot (6/6) PASS

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
nyash-codex
2025-11-26 10:28:03 +09:00
parent 51ff558904
commit 853cb36800
5 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/mir/join_ir/lowering/loop_to_join.rs
View File

@ -297,14 +297,12 @@ impl LoopToJoinLowerer {
}
// ========================================
// Convenience methods for specific patterns
// Case-A helpers for specific function patterns
// ========================================
/// Main.skip/1 専用の lowering
///
/// Phase 31 Step 1 の検証用メソッド。
/// 既存の `skip_ws.rs` からの移行確認に使用。
pub fn lower_minimal_skip_ws_case_a(
/// Case-A 汎用 lowerer の「Main.skip/1 用」薄いラッパー。
/// 実際のロジックは `lower` に集約されている。
pub fn lower_case_a_for_skip_ws(
&self,
func: &MirFunction,
loop_form: &LoopForm,
@ -312,8 +310,9 @@ impl LoopToJoinLowerer {
self.lower(func, loop_form, Some("Main.skip/1"))
}
/// FuncScannerBox.trim/1 専用の lowering
pub fn lower_minimal_trim_case_a(
/// Case-A 汎用 lowerer の「FuncScannerBox.trim/1 用」薄いラッパー。
/// 実際のロジックは `lower` に集約されている。
pub fn lower_case_a_for_trim(
&self,
func: &MirFunction,
loop_form: &LoopForm,
@ -321,8 +320,9 @@ impl LoopToJoinLowerer {
self.lower(func, loop_form, Some("FuncScannerBox.trim/1"))
}
/// FuncScannerBox.append_defs/2 専用の lowering
pub fn lower_minimal_append_defs_case_a(
/// Case-A 汎用 lowerer の「FuncScannerBox.append_defs/2 用」薄いラッパー。
/// 実際のロジックは `lower` に集約されている。
pub fn lower_case_a_for_append_defs(
&self,
func: &MirFunction,
loop_form: &LoopForm,
@ -330,8 +330,9 @@ impl LoopToJoinLowerer {
self.lower(func, loop_form, Some("FuncScannerBox.append_defs/2"))
}
/// Stage1UsingResolverBox.resolve_for_source/5 専用の lowering
pub fn lower_minimal_stage1_case_a(
/// Case-A 汎用 lowerer の「Stage1UsingResolverBox.resolve_for_source/5 用」薄いラッパー。
/// 実際のロジックは `lower` に集約されている。
pub fn lower_case_a_for_stage1_resolver(
&self,
func: &MirFunction,
loop_form: &LoopForm,