tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat(llvm): Phase 131-11-H/12 - ループキャリアPHI型修正 & vmap snapshot SSOT

Browse Source 
## Phase 131-11-H: ループキャリアPHI型修正
- PHI生成時に初期値（entry block）の型のみ使用
- backedge の値を型推論に使わない（循環依存回避）
- NYASH_CARRIER_PHI_DEBUG=1 でトレース

## Phase 131-12-P0: def_blocks 登録 & STRICT エラー化
- safe_vmap_write() で PHI 上書き保護
- resolver miss を STRICT でエラー化（フォールバック 0 禁止）
- def_blocks 自動登録

## Phase 131-12-P1: vmap_cur スナップショット実装
- DeferredTerminator 構造体（block, term_ops, vmap_snapshot）
- Pass A で vmap_cur をスナップショット
- Pass C でスナップショット復元（try-finally）
- STRICT モード assert

## 結果
- ✅ MIR PHI型: Integer（正しい）
- ✅ VM: Result: 3
- ✅ vmap snapshot 機構: 動作確認
- ⚠️ LLVM: Result: 0（別のバグ、次Phase で調査）

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
nyash-codex
2025-12-14 21:28:41 +09:00
parent 413504d6de
commit 7dfd6ff1d9
21 changed files with 1391 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
docs/development/current/main/investigations/README.md
View File

@ -1,61 +1,48 @@
# 調査ログ・根本原因分析 # Investigations Folder
このフォルダは、バグ修正・最適化の過程で発見した根本原因分析・調査プロセスを保管します。 This folder contains investigation notes and analysis for debugging sessions.
## 参照方法 ## Active Investigations
1. **「このバグの根本原因は？」** → investigations/ で検索 ### Phase 131-12: LLVM Wrong Result (Case C)
2. **「この設計決定の背景は？」** → [../20-Decisions.md](../20-Decisions.md) で確認
3. **「実装の詳細は？」** → [../phases/](../phases/README.md) で確認
## 命名規則 **Status**: ✅ Root cause identified
**Problem**: LLVM backend returns wrong results for loop exit values
**Root Cause**: vmap object identity mismatch between Pass A and Pass C
- **形式**: `<topic>-investigation-YYYY-MM-DD.md` または `<topic>-root-cause-analysis.md` **Key Documents**:
- **目的**: 時系列が分かる形、または主題ごとに整理 1. [phase131-12-case-c-llvm-wrong-result.md](phase131-12-case-c-llvm-wrong-result.md) - Initial investigation scope
2. [phase131-12-p1-vmap-identity-analysis.md](phase131-12-p1-vmap-identity-analysis.md) - Detailed trace analysis
3. [phase131-12-p1-trace-summary.md](phase131-12-p1-trace-summary.md) - Executive summary with fix recommendations
## 最新調査 **Quick Summary**:
- **Bug**: Pass A deletes `_current_vmap` before Pass C runs
- **Impact**: Terminators use wrong vmap object, missing all Pass A writes
- **Fix**: Store vmap_cur in deferred_terminators tuple (Option 3)
- `python-resolver-investigation.md` - Python LLVM バックエンド resolver.is_stringish() 調査 **Next Steps**:
- `phase131-11-root-cause-analysis.md` - PHI 型推論循環依存分析 1. Implement Option 3 fix in block_lower.py
2. Add Fail-Fast check in instruction_lower.py
3. Verify with NYASH_LLVM_VMAP_TRACE=1
4. Run full test suite
## 作成ルール（SSOT） ## Trace Environment Variables
詳しくは [../DOCS_LAYOUT.md](../DOCS_LAYOUT.md) を参照。 ### Phase 131-12-P1 Traces
```bash
- ✅ **置き場所**: `investigations/` 配下のみ NYASH_LLVM_VMAP_TRACE=1 # Object identity and vmap keys tracing
- ✅ **内容**: 詳細な根本原因分析、デバッグプロセス、試行錯誤の記録 NYASH_LLVM_USE_HARNESS=1 # Enable llvmlite harness
- ✅ **結論反映**: 調査結果の結論は以下に反映 NYASH_LLVM_DUMP_IR=<path> # Save LLVM IR to file
- [../10-Now.md](../10-Now.md) - 現在の進行状況サマリー
- [../20-Decisions.md](../20-Decisions.md) - 設計決定記録
- [../design/](../design/README.md) - アーキテクチャ設計書（必要な場合）
- ❌ **避けるべき**: 調査ログそのものを SSOT にしない
## 使用例
### 調査ログ作成時
```markdown
# Python LLVM バックエンド resolver.is_stringish() 調査
**日時**: 2025-12-14
**担当**: taskちゃん
**目的**: Case C で Result: 0 が出力される原因特定
## 調査フロー
1. ...
2. ...
## 根本原因
``` ```
### 結論反映時（10-Now.md） ## Investigation Workflow
```markdown
## 🔍 Phase 131-11-E: TypeFacts/TypeDemands 分離
**根本原因**: MIR Builder の後方伝播型推論 1. **Scope** - Define problem and test case (phase131-12-case-c-*.md)
- **詳細**: [investigations/python-resolver-investigation.md](investigations/python-resolver-investigation.md) 2. **Trace** - Add instrumentation and collect data (phase131-12-p1-vmap-identity-*.md)
- **修正**: PhiTypeResolver が TypeFacts のみ参照 3. **Analysis** - Identify root cause with evidence (phase131-12-p1-trace-summary.md)
``` 4. **Fix** - Implement solution with validation
5. **Document** - Update investigation notes with results
--- ## Archive
**最終更新**: 2025-12-14 Completed investigations are kept for reference and pattern recognition.

59
docs/development/current/main/investigations/phase131-12-case-c-llvm-wrong-result.md Normal file
View File

@ -0,0 +1,59 @@
# Phase 131-12: Case C (LLVM wrong result) Investigation Notes
Status: Active
Scope: `apps/tests/llvm_stage3_loop_only.hako` が **VM では正しいが LLVM では結果が一致しない**問題の切り分け。
Related:
- SSOT (LLVM棚卸し): `docs/development/current/main/phase131-3-llvm-lowering-inventory.md`
- Case C (pattern): `docs/development/current/main/phase131-11-case-c-summary.md`
- PHI type cycle report (historical): `docs/development/current/main/phase-131-11-g-phi-type-bug-report.md`
- ENV: `docs/reference/environment-variables.md`（`NYASH_LLVM_DUMP_IR`, `NYASH_LLVM_TRACE_*`）
## 事象
- VM: `Result: 3`（期待通り）
- LLVM: `Result: 0`（不一致）
前提:
- MIR の PHI 型（loop-carrier）が循環で `String` になる問題は Phase 131-11-H で修正済み。
- それでも LLVM で結果不一致が残るため、次は **LLVM backend 側の value/phi/exit 値の取り回し**を疑う。
## 切り分け（最優先）
### 1) 文字列連結経路の影響を切る
Case C は `print("Result: " + counter)` を含むため、以下の2系統を分けて確認する:
- **Loop 値そのもの**が壊れているのか？
- **String concat / print** の coercion 経路が壊れているのか？
最小の派生ケース（新規fixtureにせず /tmp でOK）:
1. `return counter`（出力なし、戻り値のみ）
2. `print(counter)`（文字列連結なし）
3. `print("Result: " + counter)`（元の形）
VM/LLVM で挙動を揃えて比較する。
### 2) LLVM IR を必ず保存して diff する
同一入力に対して:
- `NYASH_LLVM_DUMP_IR=/tmp/case_c.ll tools/build_llvm.sh apps/tests/llvm_stage3_loop_only.hako -o /tmp/case_c`
- 必要に応じて `NYASH_LLVM_TRACE_PHI=1 NYASH_LLVM_TRACE_VALUES=1 NYASH_LLVM_TRACE_OUT=/tmp/case_c.trace`
確認点（IR）:
- loop-carrier に対応する `phi` が **正しい incoming** を持っているか
- ループ exit 後に参照される値が **backedge の最終値**になっているか（init 値のままになっていないか）
- `print`/`concat` 直前で `counter` が `0` に固定されていないか（Constant folding ではなく wiring 問題）
## 期待される原因クラス
- **Exit value wiring**: JoinIR→MIR→LLVM のどこかで exit 後の “host slot” へ値が戻っていない
- **PHI/value resolution**: LLVM backend の `vmap` / `resolve_*` が exit 後の ValueId を誤解決している
- **String concat coercion**: `counter` を string へ変換する経路で別の ValueId を参照している
## 受け入れ基準（この調査のDone）
- `return counter` と `print(counter)` が VM/LLVM で一致するまで、問題を局所化できていること。
- その状態で、必要な修正点（どのファイル/どの関数）が特定できていること。

197
docs/development/current/main/investigations/phase131-12-p1-trace-summary.md Normal file
View File

@ -0,0 +1,197 @@
# Phase 131-12-P1: vmap Object Identity Trace - Summary
## Status: ✅ Root Cause Identified
**Date**: 2025-12-14
**Investigation**: vmap_cur object identity issue causing wrong values in LLVM backend
**Result**: **Hypothesis C confirmed** - Object identity problem in Pass A→C temporal coupling
## Critical Discovery
### The Smoking Gun
```python
# Pass A (block_lower.py line 168)
builder._current_vmap = vmap_cur # ← Create per-block vmap
# Pass A (block_lower.py line 240)
builder._deferred_terminators[bid] = (bb, term_ops) # ← Defer terminators
# Pass A (block_lower.py line 265)
delattr(builder, '_current_vmap') # ← DELETE vmap_cur ❌
# Pass C (lower_terminators, line 282)
# When lowering deferred terminators:
vmap_ctx = getattr(owner, '_current_vmap', owner.vmap) # ← Falls back to global vmap! ❌
```
**Problem**: Pass A deletes `_current_vmap` before Pass C runs, causing terminators to use the wrong vmap object.
### Trace Evidence
```
bb1 block creation: vmap_ctx id=140506427346368 ← Creation
bb1 const instruction: vmap_ctx id=140506427346368 ← Same (good)
bb1 ret terminator: vmap_ctx id=140506427248448 ← DIFFERENT (bad!)
^^^^^^^^^^^^^^
This is owner.vmap, not vmap_cur!
```
**Impact**: Values written to `vmap_cur` in Pass A are invisible to terminators in Pass C.
## The Bug Flow
1. **Pass A**: Create `vmap_cur` for block
2. **Pass A**: Lower body instructions → writes go to `vmap_cur`
3. **Pass A**: Store terminators for later
4. **Pass A**: **Delete `_current_vmap`** ← THE BUG
5. **Pass C**: Lower terminators → fallback to `owner.vmap` (different object!)
6. **Result**: Terminators read from wrong vmap, missing all Pass A writes
## Proof: Per-Block vs Global vmap
### Expected (Per-Block Context)
```python
vmap_cur = {...} # Block-local SSA values
builder._current_vmap = vmap_cur
# All instructions in this block use the SAME object
```
### Actual (Broken State)
```python
vmap_cur = {...} # Block-local SSA values
builder._current_vmap = vmap_cur # Pass A body instructions use this
# Pass A ends
delattr(builder, '_current_vmap') # DELETED!
# Pass C starts
vmap_ctx = owner.vmap # Falls back to GLOBAL vmap (different object!)
# Terminators see different data than body instructions! ❌
```
## Fix Options (Recommended: Option 3)
### Option 1: Don't Delete Until Pass C Completes
- Quick fix but creates temporal coupling
- Harder to reason about state lifetime
### Option 2: Read from block_end_values SSOT
- Good: Uses snapshot as source of truth
- Issue: Requires restoring to builder state
### Option 3: Store vmap_cur in Deferred Data (RECOMMENDED)
```python
# Pass A (line 240)
builder._deferred_terminators[bid] = (bb, term_ops, vmap_cur) # ← Add vmap_cur
# Pass C (line 282)
for bid, (bb, term_ops, vmap_ctx) in deferred.items():
builder._current_vmap = vmap_ctx # ← Restore exact context
# Lower terminators with correct vmap
```
**Why Option 3?**
- Explicit ownership: vmap_cur is passed through deferred tuple
- No temporal coupling: Pass C gets exact context from Pass A
- SSOT principle: One source of vmap per block
- Fail-Fast: Type error if tuple structure changes
## Architecture Impact
### Current Problem
- **Temporal Coupling**: Pass C depends on Pass A's ephemeral state
- **Silent Fallback**: Wrong vmap used without error
- **Hidden Sharing**: Global vmap shared across blocks
### Fixed Architecture (Box-First)
```
Pass A: Create vmap_cur (per-block "box")
↓
Store in deferred tuple (explicit ownership transfer)
↓
Pass C: Restore vmap_cur from tuple (unpack "box")
↓
Use exact same object (SSOT)
```
**Aligns with CLAUDE.md principles**:
- ✅ Box-First: vmap_cur is a "box" passed between passes
- ✅ SSOT: One vmap per block, explicit transfer
- ✅ Fail-Fast: Type error if deferred tuple changes
## Test Commands
### Verify Fix
```bash
# Before fix: Shows different IDs for terminator
NYASH_LLVM_VMAP_TRACE=1 NYASH_LLVM_USE_HARNESS=1 \
./target/release/hakorune --backend llvm apps/tests/llvm_stage3_loop_only.hako 2>&1 | \
grep "\[vmap/id\]"
# After fix: Should show SAME ID throughout block
```
### Full Verification
```bash
# Check full execution
NYASH_LLVM_VMAP_TRACE=1 NYASH_LLVM_USE_HARNESS=1 \
./target/release/hakorune --backend llvm apps/tests/llvm_stage3_loop_only.hako
# Expected: Result: 3 (matching VM)
```
## Files Modified
### Trace Implementation (Phase 131-12-P1)
- `/home/tomoaki/git/hakorune-selfhost/src/llvm_py/builders/block_lower.py`
- `/home/tomoaki/git/hakorune-selfhost/src/llvm_py/builders/instruction_lower.py`
- `/home/tomoaki/git/hakorune-selfhost/src/llvm_py/instructions/const.py`
- `/home/tomoaki/git/hakorune-selfhost/src/llvm_py/instructions/copy.py`
- `/home/tomoaki/git/hakorune-selfhost/src/llvm_py/instructions/binop.py`
- `/home/tomoaki/git/hakorune-selfhost/src/llvm_py/utils/values.py`
### Fix Target (Next Phase)
- `/home/tomoaki/git/hakorune-selfhost/src/llvm_py/builders/block_lower.py` (Option 3)
## Related Documents
- Investigation: `/docs/development/current/main/investigations/phase131-12-case-c-llvm-wrong-result.md`
- Detailed Analysis: `/docs/development/current/main/investigations/phase131-12-p1-vmap-identity-analysis.md`
- LLVM Inventory: `/docs/development/current/main/phase131-3-llvm-lowering-inventory.md`
- Environment Variables: `/docs/reference/environment-variables.md`
## Next Steps
1. **Implement Option 3 fix** (store vmap_cur in deferred tuple)
2. **Add Fail-Fast check** in instruction_lower.py (detect missing _current_vmap)
3. **Verify with trace** (consistent IDs across Pass A→C)
4. **Run full test suite** (ensure VM/LLVM parity)
5. **Document pattern** (for future multi-pass architectures)
## Lessons Learned
### Box-First Principle Application
- Mutable builder state (`_current_vmap`) should be **explicitly passed** through phases
- Don't rely on `getattr` fallbacks - they hide bugs
- Per-block context is a "box" - treat it as first-class data
### Fail-Fast Opportunity
```python
# BEFORE (silent fallback)
vmap_ctx = getattr(owner, '_current_vmap', owner.vmap) # Wrong vmap silently used
# AFTER (fail-fast)
vmap_ctx = getattr(owner, '_current_vmap', None)
if vmap_ctx is None:
raise RuntimeError("Pass A/C timing bug: _current_vmap not set")
```
### SSOT Enforcement
- `block_end_values` is snapshot SSOT
- `_current_vmap` is working buffer
- Pass C should **restore** working buffer from SSOT or deferred data
---
**Investigation Complete**: Root cause identified with high confidence. Ready for fix implementation.

187
docs/development/current/main/investigations/phase131-12-p1-vmap-identity-analysis.md Normal file
View File

@ -0,0 +1,187 @@
# Phase 131-12-P1: vmap Object Identity Trace Analysis
## Executive Summary
**Status**: ⚠️ Hypothesis C (Object Identity Problem) - **PARTIALLY CONFIRMED**
### Key Findings
1. **vmap_ctx identity changes between blocks**:
- bb1: `vmap_ctx id=140506427346368` (creation)
- bb1 ret: `vmap_ctx id=140506427248448` (DIFFERENT!)
- bb2: `vmap_ctx id=140506427351808` (new object)
2. **Trace stopped early** - execution crashed before reaching critical bb3/exit blocks
3. **No v17 writes detected** - the problematic value was never written
## Detailed Trace Analysis
### Block 1 Trace Sequence
```
[vmap/id] bb1 vmap_cur id=140506427346368 keys=[0] # ← Block creation
[vmap/id] instruction op=const vmap_ctx id=140506427346368 # ← Same object ✅
[vmap/id] const dst=1 vmap id=140506427346368 before_write # ← Same object ✅
[vmap/write] dst=1 written, vmap.keys()=[0, 1] # ← Write successful ✅
[vmap/id] instruction op=ret vmap_ctx id=140506427248448 # ← DIFFERENT OBJECT! ❌
```
**Problem Found**: The `vmap_ctx` object changed identity **within the same block**!
- Creation: `140506427346368`
- Terminator: `140506427248448`
### Block 2 Trace Sequence
```
[vmap/id] bb2 vmap_cur id=140506427351808 keys=[] # ← New block (expected)
[vmap/id] instruction op=const vmap_ctx id=140506427351808 # ← Consistent ✅
[vmap/write] dst=1 written, vmap.keys()=[1] # ← Write successful ✅
[vmap/id] instruction op=const vmap_ctx id=140506427351808 # ← Still consistent ✅
[vmap/write] dst=2 written, vmap.keys()=[1, 2] # ← Write successful ✅
[vmap/id] instruction op=binop vmap_ctx id=140506427351808 # ← Still consistent ✅
# CRASH - execution stopped here
```
Block 2 shows **good consistency** - same object throughout.
## Root Cause Hypothesis
### Hypothesis A (Timing): ❌ REJECTED
- Writes are successful and properly sequenced
- No evidence of post-instruction sync reading from wrong location
### Hypothesis B (PHI Collision): ⚠️ POSSIBLE
- Cannot verify - trace stopped before PHI blocks
- Need to check if existing PHIs block safe_vmap_write
### Hypothesis C (Object Identity): ✅ **CONFIRMED**
- **Critical evidence**: `vmap_ctx` changed identity during bb1 terminator instruction
- This suggests `getattr(owner, '_current_vmap', owner.vmap)` is returning a **different object**
## Source Code Analysis
### Terminator Lowering Path
The identity change happens during `ret` instruction. Checking the code:
**File**: `src/llvm_py/builders/block_lower.py`
Line 236-240:
```python
# Phase 131-4 Pass A: DEFER terminators until after PHI finalization
# Store terminators for Pass C (will be lowered in lower_terminators)
if not hasattr(builder, '_deferred_terminators'):
builder._deferred_terminators = {}
if term_ops:
builder._deferred_terminators[bid] = (bb, term_ops)
```
**Smoking Gun**: Terminators are deferred! When `ret` is lowered in Pass C (line 270+), the `_current_vmap` may have been **deleted**:
Line 263-267:
```python
builder.block_end_values[bid] = snap
try:
delattr(builder, '_current_vmap') # ← DELETED BEFORE PASS C!
except Exception:
pass
```
**Problem**:
1. Pass A creates `_current_vmap` for block (line 168)
2. Pass A defers terminators (line 240)
3. Pass A **deletes** `_current_vmap` (line 265)
4. Pass C lowers terminators → `getattr(owner, '_current_vmap', owner.vmap)` falls back to `owner.vmap`
5. **Result**: Different object! ❌
## Recommended Fix (3 Options)
### Option 1: Preserve vmap_cur for Pass C (Quick Fix)
```python
# Line 263 in block_lower.py
builder.block_end_values[bid] = snap
# DON'T delete _current_vmap yet! Pass C needs it!
# try:
# delattr(builder, '_current_vmap')
# except Exception:
# pass
```
Then delete it in `lower_terminators()` after all terminators are done.
### Option 2: Use block_end_values in Pass C (SSOT)
```python
# In lower_terminators() line 282
for bid, (bb, term_ops) in deferred.items():
# Use snapshot from Pass A as SSOT
vmap_ctx = builder.block_end_values.get(bid, builder.vmap)
builder._current_vmap = vmap_ctx # Restore for consistency
# ... lower terminators ...
```
### Option 3: Store vmap_cur in deferred_terminators (Explicit)
```python
# Line 240
if term_ops:
builder._deferred_terminators[bid] = (bb, term_ops, vmap_cur) # ← Add vmap_cur
# Line 282 in lower_terminators
for bid, (bb, term_ops, vmap_ctx) in deferred.items(): # ← Unpack vmap_ctx
builder._current_vmap = vmap_ctx # Restore
# ... lower terminators ...
```
## Next Steps (Recommended Order)
1. **Verify hypothesis** with simpler test case:
```bash
# Create minimal test without loop complexity
echo 'static box Main { main() { return 42 } }' > /tmp/minimal.hako
NYASH_LLVM_VMAP_TRACE=1 NYASH_LLVM_USE_HARNESS=1 \
./target/release/hakorune --backend llvm /tmp/minimal.hako 2>&1 | grep vmap/id
```
2. **Apply Option 1** (quickest to verify):
- Comment out `delattr(builder, '_current_vmap')` in Pass A
- Add it to end of `lower_terminators()` in Pass C
3. **Re-run full test**:
```bash
NYASH_LLVM_VMAP_TRACE=1 NYASH_LLVM_USE_HARNESS=1 \
./target/release/hakorune --backend llvm apps/tests/llvm_stage3_loop_only.hako
```
4. **Check if bb3/exit blocks now show consistent vmap_ctx IDs**
## Architecture Feedback (Box-First Principle)
**Problem**: Multi-pass architecture (A → B → C) with mutable state (`_current_vmap`) creates temporal coupling.
**Recommendation**: Apply SSOT principle from CLAUDE.md:
- `block_end_values` should be the **single source of truth** for post-block state
- Pass C should **read** from SSOT, not rely on ephemeral `_current_vmap`
- This matches "箱理論" - `block_end_values` is the persistent "box", `_current_vmap` is a working buffer
**Fail-Fast Opportunity**:
```python
# In lower_instruction() line 33
vmap_ctx = getattr(owner, '_current_vmap', None)
if vmap_ctx is None:
# Fail-Fast instead of silent fallback!
raise RuntimeError(
f"[LLVM_PY] _current_vmap not set for instruction {op}. "
f"This indicates Pass A/C timing issue. Check block_lower.py multi-pass logic."
)
```
## Appendix: Environment Variables Used
```bash
NYASH_LLVM_VMAP_TRACE=1 # Our new trace flag
NYASH_LLVM_USE_HARNESS=1 # Enable llvmlite harness
NYASH_LLVM_DUMP_IR=<path> # Save LLVM IR (for later analysis)
```

288
docs/development/current/main/phase-131-11-g-phi-type-bug-report.md Normal file
View File

@ -0,0 +1,288 @@
# Phase 131-11-G: PHI Type Inference Bug - Root Cause Report
**Date**: 2025-12-14
**Status**: Historical (Fixed in Phase 131-11-H)
**Severity**: High (Breaks loop carrier PHI type inference)
## Executive Summary
PHI nodes for loop carriers are getting incorrect `String` type instead of `Integer`, breaking type propagation throughout the loop. Investigation reveals a circular dependency in the type inference chain.
## Update (Phase 131-11-H): Fix Applied
**Fix**: Seed loop-carrier PHI type from the entry (init) value only, to break the cycle.
- File: `src/mir/builder/control_flow/joinir/merge/loop_header_phi_builder.rs`
- Change: when creating the loop-carrier PHI dst, copy the init value’s type into `value_types` (ignore backedge type at creation time).
- Result: MIR/VM observe `%phi` as `Integer` (expected) and the loop semantics are restored on VM.
Note:
- This document remains as the “why it broke” report. The current task should track the remaining LLVM mismatch separately.
- Environment variables introduced for this investigation are now documented in `docs/reference/environment-variables.md`.
## Bug Symptoms
```mir
bb4:
1: %3: String = phi [%2, bb0], [%8, bb7] ← Should be Integer!
1: %8 = %3 Add %7 ← No type assigned!
```
**Expected**: `%3: Integer` (loop counter)
**Actual**: `%3: String` (wrong!)
## Root Cause Chain
### 1. Initial Infection (Source TBD)
PHI %3 gets initial type `String` during JoinIR → MIR lowering, **before** lifecycle.rs runs.
**Evidence**:
```
[lifecycle/phi-scan] main PHI ValueId(3) existing type: Some(String)
```
This happens **before** PhiTypeResolver runs.
### 2. BinOp Type Assignment Failure
When `%8 = %3 + 1` is emitted (`ops.rs:189-221`):
**Code Path**:
```rust
// ops.rs:193-194
let lhs_type = self.classify_operand_type(lhs); // %3 → String
let rhs_type = self.classify_operand_type(rhs); // %7 → Integer
// ops.rs:210-213
(String, Integer) | (Integer, String) => {
// Mixed types: leave as Unknown for use-site coercion
// LLVM backend will handle string concatenation
}
```
**Result**: %8 gets **NO TYPE** in `value_types` map!
### 3. PhiTypeResolver Failure
**Trace Output**:
```
[phi/type] Resolving PHI dst=3 incoming=Phi([(bb0, ValueId(2)), (bb7, ValueId(8))])
[phi/type] ValueId(8) is Base/None but NO TYPE in value_types!
[phi/type] ValueId(2) is Copy -> ValueId(1)
[phi/type] ValueId(1) is Phi with 1 inputs: [(BasicBlockId(6), ValueId(8))]
[phi_resolver] failed for ValueId(3): base_types = []
```
**Why It Fails**:
- Incoming `%2` → Copy → `%1` → PHI → `%8` (circular!)
- Incoming `%8` has **NO TYPE**
- Cannot find any base types → returns `None`
### 4. BinOp Re-propagation Ineffective
**Code** (`lifecycle.rs:605-672`):
```rust
// Tries to fix %8 type
let lhs_type = self.value_types.get(lhs); // %3 → still String!
let rhs_type = self.value_types.get(rhs); // %7 → Integer
match (lhs_class, rhs_class) {
(String, Integer) | (Integer, String) => None, // No update!
}
```
**Result**: Still no type for %8, circular dependency persists.
## Technical Analysis
### Circular Dependency Diagram
```
PHI %3 type (String ❌)
↓
BinOp %8 = %3 + 1
↓ (mixed String + Integer)
NO TYPE ASSIGNED
↓
PHI %3 incoming [%2, %8]
↓ (%8 has no type)
PhiTypeResolver FAILS
↓
BinOp re-propagation
↓ (%3 still String)
NO UPDATE
↓
STUCK IN LOOP!
```
### Why Current Architecture Fails
1. **PHI gets wrong initial type** (before lifecycle.rs)
2. **BinOp depends on operand types** (correct design, but fails with wrong PHI type)
3. **PhiTypeResolver depends on incoming types** (correct design, but %8 is untyped)
4. **Re-propagation can't break cycle** (depends on %3 type, which is wrong)
### SSOT Violation
**TypeFacts SSOT** says:
> Types are determined by **definitions only**, not usage
But PHI %3 gets initial type from **somewhere**, violating this principle.
## Debug Traces Added
### 1. PhiTypeResolver Debug (`NYASH_PHI_TYPE_DEBUG=1`)
**File**: `src/mir/phi_core/phi_type_resolver.rs`
```rust
if debug {
eprintln!("[phi/type] Resolving PHI dst={} incoming={:?}", ...);
eprintln!("[phi/type] {:?} is Copy -> {:?}", v, src);
eprintln!("[phi/type] {:?} is Phi with {} inputs: {:?}", ...);
eprintln!("[phi/type] {:?} is Base with type {:?}", v, ty);
eprintln!("[phi/type] {:?} is Base/None but NO TYPE in value_types!", v);
}
```
### 2. PHI Metadata Propagation Debug (`NYASH_PHI_META_DEBUG=1`)
**File**: `src/mir/builder/origin/phi.rs`
```rust
if debug {
eprintln!("[phi/meta] propagate_phi_meta dst={:?} inputs={:?}", ...);
eprintln!("[phi/meta] incoming {:?} has type {:?}", v, t);
eprintln!("[phi/meta] NO TYPE COPIED (ty_agree=false)");
}
```
### 3. Existing Debug Flags
- `NYASH_PHI_GLOBAL_DEBUG=1` - Global PHI re-inference (lifecycle.rs)
- `NYASH_BINOP_REPROP_DEBUG=1` - BinOp re-propagation (lifecycle.rs)
- `NYASH_PHI_RESOLVER_DEBUG=1` - PhiTypeResolver summary
## Next Steps (Phase 131-11-H)
### Immediate Tasks
1. **Find Initial String Type Source**
- Add traces to all PHI creation sites in JoinIR lowering
- Check `emit_phi` in merge modules
- Check loop pattern lowering (Pattern 1-4)
2. **Fix PHI Initial Type Assignment**
- Loop carrier PHI should start as `Unknown` or use init value type **only**
- Do NOT use backedge type for initial assignment
- Let PhiTypeResolver handle multi-path inference
3. **Fix BinOp Mixed-Type Handling**
- `(String, Integer)` case should check if String is actually a loop carrier
- Fallback to `Integer` if one operand is Unknown PHI
### Architectural Fix Options
#### Option A: Remove Initial PHI Typing
```rust
// In PHI emission
// DO NOT set dst type during emission
// Let PhiTypeResolver handle it later
```
**Pros**: Simple, follows SSOT
**Cons**: More values stay Unknown longer
#### Option B: Smart Initial Typing
```rust
// In PHI emission for loops
if is_loop_carrier {
// Use init value type only (ignore backedge)
if let Some(init_type) = get_init_value_type() {
value_types.insert(dst, init_type);
}
}
```
**Pros**: Fewer Unknown values
**Cons**: Requires loop structure awareness
#### Option C: BinOp Fallback for Unknown
```rust
// In BinOp emission
(String, Integer) | (Integer, String) => {
// Check if "String" operand is actually Unknown PHI
if lhs_is_unknown_phi || rhs_is_unknown_phi {
value_types.insert(dst, MirType::Integer); // Assume numeric
}
// else: leave Unknown for true string concat
}
```
**Pros**: Breaks circular dependency
**Cons**: Heuristic, might mistype some cases
### Recommended Fix: **Option B** (Smart Initial Typing)
**Rationale**:
1. Preserves SSOT (init value is a definition)
2. Prevents circular dependency (backedge ignored initially)
3. PhiTypeResolver still validates and corrects if needed
4. Minimal code changes (confined to loop lowering)
## Test Case
**File**: `apps/tests/llvm_stage3_loop_only.hako`
```nyash
static box Main {
main() {
local counter = 0
loop (true) {
counter = counter + 1 // ← This should be Integer type!
if counter == 3 { break }
continue
}
print("Result: " + counter)
return 0
}
}
```
**Expected MIR**:
```mir
bb4:
1: %3: Integer = phi [%2, bb0], [%8, bb7] ← Integer, not String!
1: %8: Integer = %3 Add %7 ← Should have type!
```
## References
- **Phase 131-11-E**: TypeFacts/TypeDemands separation
- **Phase 131-11-F**: MIR JSON metadata output
- **Phase 131-9**: Global PHI type inference
- **Phase 84-3**: PhiTypeResolver box design
## Files Modified (Debug Traces)
1. `src/mir/phi_core/phi_type_resolver.rs` - Added detailed PHI resolution traces
2. `src/mir/builder/origin/phi.rs` - Added metadata propagation traces
## Environment Variables Reference
```bash
# Complete PHI type debugging
NYASH_PHI_TYPE_DEBUG=1 \
NYASH_PHI_META_DEBUG=1 \
NYASH_PHI_GLOBAL_DEBUG=1 \
NYASH_BINOP_REPROP_DEBUG=1 \
./target/release/hakorune --dump-mir apps/tests/llvm_stage3_loop_only.hako
# Quick diagnosis
NYASH_PHI_TYPE_DEBUG=1 ./target/release/hakorune --dump-mir test.hako 2>&1 | grep "\[phi/type\]"
```
---
**Status**: Ready for Phase 131-11-H implementation (Fix PHI initial typing)

265
docs/development/current/main/phase-131-11-h-implementation-report.md Normal file
View File

@ -0,0 +1,265 @@
# Phase 131-11-H: ループキャリアPHI 型修正実装 - 完了報告
## 実装概要
**日付**: 2025-12-14
**フェーズ**: Phase 131-11-H
**目的**: ループキャリアPHI の型を初期値の型のみから決定し、backedge を無視することで循環依存を回避
## 問題の背景
### Phase 131-11-G で特定されたバグ
1. **ループキャリアPHI が String 型で初期化される**
- `%3: String = phi [%2, bb0], [%8, bb7]` ❌
- 初期値 %2 は Integer (const 0) なのに String になる
2. **BinOp が混合型と判定される**
- PHI が String → BinOp (Add) が String + Integer → 混合型
- 型割り当てなし → PhiTypeResolver 失敗
3. **循環依存で修正不可能**
- PHI が backedge (%8) を参照
- %8 は PHI の値に依存
- 循環依存により型推論が失敗
## 修正方針（Option B）
**ループキャリアPHI 生成時に初期値の型のみ使用**
- ✅ **backedge（ループ内からの値）は無視**
- ✅ **初期値（entry block からの値）の型のみ使用**
- ✅ **SSOT 原則維持**（TypeFacts のみ参照）
- ✅ **循環依存回避**
### 理論的根拠
- **TypeFacts（既知の型情報）のみ使用**: 初期値は定数 0 = Integer（既知）
- **TypeDemands（型要求）無視**: backedge からの要求は無視（循環回避）
- **単一責任**: PHI 生成 = 初期値の型のみ設定、ループ内の型変化は PhiTypeResolver に委譲
## 実装内容
### 変更ファイル
**`src/mir/builder/control_flow/joinir/merge/loop_header_phi_builder.rs`**
### 変更箇所1: ループ変数 PHI
```rust
// Allocate PHI for loop variable
let loop_var_phi_dst = builder.next_value_id();
// Phase 72: Observe PHI dst allocation
#[cfg(debug_assertions)]
crate::mir::join_ir::verify_phi_reserved::observe_phi_dst(loop_var_phi_dst);
// Phase 131-11-H: Set PHI type from entry incoming (init value) only
// Ignore backedge to avoid circular dependency in type inference
if let Some(init_type) = builder.value_types.get(&loop_var_init).cloned() {
builder.value_types.insert(loop_var_phi_dst, init_type.clone());
if debug || std::env::var("NYASH_CARRIER_PHI_DEBUG").ok().as_deref() == Some("1") {
eprintln!(
"[carrier/phi] Loop var '{}': dst=%{} entry_type={:?} (backedge ignored)",
loop_var_name, loop_var_phi_dst.as_u32(), init_type
);
}
}
```
### 変更箇所2: その他のキャリア PHI
```rust
// Allocate PHIs for other carriers
for (name, host_id, init, role) in carriers {
// Phase 86: Use centralized CarrierInit builder
let init_value = super::carrier_init_builder::init_value(
builder,
&init,
*host_id,
&name,
debug,
);
let phi_dst = builder.next_value_id();
// Phase 72: Observe PHI dst allocation
#[cfg(debug_assertions)]
crate::mir::join_ir::verify_phi_reserved::observe_phi_dst(phi_dst);
// Phase 131-11-H: Set PHI type from entry incoming (init value) only
// Ignore backedge to avoid circular dependency in type inference
if let Some(init_type) = builder.value_types.get(&init_value).cloned() {
builder.value_types.insert(phi_dst, init_type.clone());
if debug || std::env::var("NYASH_CARRIER_PHI_DEBUG").ok().as_deref() == Some("1") {
eprintln!(
"[carrier/phi] Carrier '{}': dst=%{} entry_type={:?} (backedge ignored)",
name, phi_dst.as_u32(), init_type
);
}
}
// ... rest of the code
}
```
## 検証結果
### ✅ Test 1: MIR Dump - PHI 型確認
```bash
./target/release/hakorune --dump-mir apps/tests/llvm_stage3_loop_only.hako 2>&1 | grep -A1 "bb4:"
```
**Before**:
```
bb4:
%3: String = phi [%2, bb0], [%8, bb7] ← String ❌
```
**After**:
```
bb4:
%3: Integer = phi [%2, bb0], [%8, bb7] ← Integer ✅
```
### ✅ Test 2: デバッグ出力確認
```bash
NYASH_CARRIER_PHI_DEBUG=1 ./target/release/hakorune apps/tests/llvm_stage3_loop_only.hako
```
**出力**:
```
[carrier/phi] Loop var 'counter': dst=%3 entry_type=Integer (backedge ignored)
```
### ✅ Test 3: VM 実行確認
```bash
./target/release/hakorune apps/tests/llvm_stage3_loop_only.hako
```
**出力**:
```
Result: 3 ✅ 正しい結果
```
### ✅ Test 4: 退行テスト (Case B)
```bash
./target/release/hakorune apps/tests/loop_min_while.hako
```
**出力**:
```
0
1
2 ✅ 退行なし
```
## LLVM 実行について
### 現状
```bash
tools/build_llvm.sh apps/tests/llvm_stage3_loop_only.hako -o /tmp/case_c
/tmp/case_c
```
**出力**: `Result: 0` ❌
### 調査結果
- **Before our changes**: `Result: 0` (同じ結果)
- **After our changes**: `Result: 0` (変化なし)
**結論**: LLVM バックエンドの既存バグであり、PHI 型修正とは無関係
- VM 実行は正しく `Result: 3` を出力
- MIR は正しく生成されている（PHI は Integer 型）
- LLVM バックエンドの値伝播またはコード生成に問題がある
## 箱化モジュール化原則の遵守
### SSOT 原則
- ✅ **TypeFacts のみ使用**: entry block の incoming 値は TypeFacts（定数 0 = Integer）
- ✅ **TypeDemands 無視**: backedge（ループ内）からの要求は無視
- ✅ **単一責任**: PHI 生成 = 初期値の型のみ設定、ループ内の型変化は PhiTypeResolver に委譲
### Fail-Fast vs 柔軟性
**実装**: Option A（柔軟性）を採用
- entry block からの型が取得できない場合は何もしない
- Unknown として開始（PhiTypeResolver に委譲）
- panic/エラーは出さない
**理由**: PhiTypeResolver が後段で型推論を行うため、初期型が不明でも問題ない
### デバッグしやすさ
**環境変数**: `NYASH_CARRIER_PHI_DEBUG=1`
```rust
if debug || std::env::var("NYASH_CARRIER_PHI_DEBUG").ok().as_deref() == Some("1") {
eprintln!(
"[carrier/phi] dst=%{} entry_type={:?} (backedge ignored)",
phi_dst.as_u32(), init_type
);
}
```
## 影響範囲
### 変更した機能
- ループキャリアPHI の型設定ロジック
- `loop_header_phi_builder.rs` の 2箇所（ループ変数 + その他のキャリア）
### 影響を受けないもの
- PhiTypeResolver（後段の型推論システム）
- If/else の PHI 生成
- Exit PHI 生成
- 他の MIR 生成ロジック
### 互換性
- ✅ 既存のテストすべて PASS
- ✅ 退行なし（Case B 確認済み）
- ✅ VM 実行完全動作
## 次のステップ
### 短期
1. ✅ **Phase 131-11-H 完了**: ループキャリアPHI 型修正実装完了
2. ⏭️ **LLVM バグ修正**: 別タスクとして切り出し（Phase 131-12?）
### 中期
- LLVM バックエンドの値伝播調査
- Exit PHI の値が正しく伝わらない原因特定
## まとめ
### 成果
✅ **ループキャリアPHI の型が正しく Integer になった**
✅ **循環依存を回避する設計を実装**
✅ **SSOT 原則を遵守**
✅ **すべてのテストが PASS**
### 重要な発見
- LLVM バックエンドに既存バグあり（PHI 型修正とは無関係）
- VM 実行は完全に正しく動作
- MIR 生成は正しい
### 次のアクション
- LLVM バグは別タスクとして Phase 131-12 で対応
- 本フェーズ (Phase 131-11-H) は完了

12
docs/development/current/main/phase131-11-case-c-summary.md
View File

@ -1,7 +1,7 @@
# Phase 131-11: Case C 本命タスク - 調査完了レポート # Phase 131-11: Case C 本命タスク - 調査完了レポート
**Date**: 2025-12-14 **Date**: 2025-12-14
**Status**: ✅ Root Cause Analysis Complete - Ready for Implementation **Status**: Active - Pattern detection landed; follow-ups tracked
--- ---
@ -11,6 +11,16 @@
**Test File**: `apps/tests/llvm_stage3_loop_only.hako` **Test File**: `apps/tests/llvm_stage3_loop_only.hako`
## 状態アップデート（Phase 131-11 A–C / H）
- Phase 131-11 A–C: `loop(true)` + break/continue を専用パターン（`pattern5_infinite_early_exit.rs`）へルーティングできる状態まで到達（検出/shape guard）。
- Phase 131-11 H: ループキャリアPHIの型が循環で壊れる問題に対して、PHI作成時に entry(init) 側の型のみを seed する修正が入った。
- 参考（原因レポート）: `docs/development/current/main/phase-131-11-g-phi-type-bug-report.md`
- PHI/型デバッグ: `docs/reference/environment-variables.md` の `NYASH_PHI_TYPE_DEBUG` / `NYASH_PHI_META_DEBUG`
現状メモ:
- VM では期待値に一致するが、LLVM では結果が一致しないケースが残っている（別トピックとして棚卸し/切り分けが必要）。
--- ---
## 🔍 Root Cause (完全解明済み) ## 🔍 Root Cause (完全解明済み)

37
docs/development/current/main/phase131-3-llvm-lowering-inventory.md
View File

@ -10,7 +10,7 @@
| A | `apps/tests/phase87_llvm_exe_min.hako` | ✅ | ✅ | ✅ | **PASS** - Simple return 42, no BoxCall, exit code verified | | A | `apps/tests/phase87_llvm_exe_min.hako` | ✅ | ✅ | ✅ | **PASS** - Simple return 42, no BoxCall, exit code verified |
| B | `apps/tests/loop_min_while.hako` | ✅ | ✅ | ✅ | **PASS** - Loop/PHI path runs end-to-end (Phase 131-10): prints `0,1,2` and exits | | B | `apps/tests/loop_min_while.hako` | ✅ | ✅ | ✅ | **PASS** - Loop/PHI path runs end-to-end (Phase 131-10): prints `0,1,2` and exits |
| B2 | `/tmp/case_b_simple.hako` | ✅ | ✅ | ✅ | **PASS** - Simple print(42) without loop works | | B2 | `/tmp/case_b_simple.hako` | ✅ | ✅ | ✅ | **PASS** - Simple print(42) without loop works |
| C | `apps/tests/llvm_stage3_loop_only.hako` | ❌ | - | - | **TAG-EMIT** - Complex loop (break/continue) fails JoinIR pattern matching | | C | `apps/tests/llvm_stage3_loop_only.hako` | ✅ | ✅ | ⚠️ | **TAG-RUN** - Runs but result mismatch (VM ok / LLVM wrong) |
## Root Causes Identified ## Root Causes Identified
@ -175,7 +175,7 @@ RC: 0
--- ---
### 4. TAG-EMIT: JoinIR Pattern Coverage Gap (Case C) - ✅ ROOT CAUSE IDENTIFIED ### 4. Case C: loop(true) + break/continue - from TAG-EMIT to TAG-RUN
**File**: `apps/tests/llvm_stage3_loop_only.hako` **File**: `apps/tests/llvm_stage3_loop_only.hako`
@ -195,29 +195,22 @@ static box Main {
} }
``` ```
**MIR Compilation**: FAILURE **MIR Compilation**: SUCCESS（Phase 131-11）
```
❌ MIR compilation error: [joinir/freeze] Loop lowering failed:
JoinIR does not support this pattern, and LoopBuilder has been removed.
Function: main
Hint: This loop pattern is not supported. All loops must use JoinIR lowering.
```
**Root Cause** (Phase 131-11 Analysis): **What changed**:
1. **Pattern Gap**: `loop(true)` (infinite loop) not recognized by Patterns 1-4 - Pattern gap was resolved by introducing a dedicated infinite-loop early-exit pattern (Phase 131-11 A–C).
2. **Loop Variable Extraction Fails**: `extract_loop_variable_from_condition()` expects binary comparison (`i < 3`), not boolean literal (`true`) - A loop-carrier PHI type-cycle bug was fixed by seeding the PHI type from the entry(init) value (Phase 131-11 H).
3. **Classification Priority Bug**: `has_continue = true` routes to Pattern 4, but Pattern 4 expects a loop variable - Root cause report: `docs/development/current/main/phase-131-11-g-phi-type-bug-report.md`
**Failure Flow**: **Current issue**: **TAG-RUN (wrong result)**
``` VM and MIR look correct, but LLVM output does not match expected result for Case C.
1. LoopPatternContext::new() detects has_continue=true, has_break=true
2. classify() returns Pattern4Continue (because has_continue)
3. Pattern4::can_lower() tries extract_loop_variable_from_condition(BoolLiteral(true))
4. ❌ Fails: "Unsupported loop condition pattern"
5. No pattern matches → freeze() error
```
**Solution** (Phase 131-11 Recommended): **Next actions**:
- Dump LLVM IR (`NYASH_LLVM_DUMP_IR=...`) and trace PHI/value resolution (`NYASH_LLVM_TRACE_PHI=1`, `NYASH_LLVM_TRACE_VALUES=1`).
- Reduce Case C to isolate whether the bug is “loop value” or “string concat/print path”:
- `return counter` (no string concat)
- `print(counter)` (no `"Result: " + ...`)
- Compare with VM and inspect the IR use-sites.
- Add `is_infinite_loop: bool` feature to `LoopFeatures` (detect `loop(true)`). - Add `is_infinite_loop: bool` feature to `LoopFeatures` (detect `loop(true)`).
- Fix classification so `has_break && has_continue` does not route to Pattern 4. - Fix classification so `has_break && has_continue` does not route to Pattern 4.
- Introduce a dedicated pattern kind + lowerer for **infinite loop + early-exit (+ optional continue)**: - Introduce a dedicated pattern kind + lowerer for **infinite loop + early-exit (+ optional continue)**:

17
docs/reference/environment-variables.md
View File

@ -112,6 +112,16 @@ NYASH_USE_STAGE1_CLI=1 STAGE1_EMIT_MIR_JSON=1 \
| `NYASH_LLVM_LIBS` | (empty) | 追加リンクライブラリ | | `NYASH_LLVM_LIBS` | (empty) | 追加リンクライブラリ |
| `NYASH_LLVM_USE_HARNESS` | (auto) | Python harness 使用を強制 | | `NYASH_LLVM_USE_HARNESS` | (auto) | Python harness 使用を強制 |
### LLVM harness debug（Python llvmlite）
| 変数 | デフォルト | 説明 |
| --- | --- | --- |
| `NYASH_LLVM_DUMP_IR=1` | OFF | 生成した LLVM IR を `<output>.ll` に書き出す（harness 実装側の簡易ダンプ） |
| `NYASH_LLVM_DUMP_IR=/path/to/out.ll` | unset | 生成した LLVM IR を指定パスに書き出す（`tools/build_llvm.sh` の内部経由でも可） |
| `NYASH_LLVM_TRACE_PHI=1` | OFF | PHI 配線/スナップショット解決の詳細トレース（Python backend） |
| `NYASH_LLVM_TRACE_VALUES=1` | OFF | value 解決トレース（Python backend） |
| `NYASH_LLVM_TRACE_OUT=/tmp/llvm_trace.log` | unset | LLVM トレースの出力先（未指定なら stdout） |
### 使用例 ### 使用例
```bash ```bash
@ -260,6 +270,13 @@ env NYASH_FEATURES=stage3 NYASH_LLVM_USE_HARNESS=1 \
| `NYASH_TRACE_VARMAP=1` | OFF | Any | `MirBuilder.variable_map` の状態をトレース出力（`[varmap/<tag>] {name=ValueId(..),..}`）。JoinIR loop 統合のデバッグ用。 | | `NYASH_TRACE_VARMAP=1` | OFF | Any | `MirBuilder.variable_map` の状態をトレース出力（`[varmap/<tag>] {name=ValueId(..),..}`）。JoinIR loop 統合のデバッグ用。 |
| `NYASH_DCE_TRACE=1` | OFF | Any | DCE パスが削除した純粋命令を stderr にログ出力（`src/mir/passes/dce.rs`）。 | | `NYASH_DCE_TRACE=1` | OFF | Any | DCE パスが削除した純粋命令を stderr にログ出力（`src/mir/passes/dce.rs`）。 |
### MIR / PHI diagnostics（dev-only）
| 変数 | デフォルト | 適用経路 | 説明 |
| --- | --- | --- | --- |
| `NYASH_PHI_TYPE_DEBUG=1` | OFF | Any | `PhiTypeResolver` の詳細トレース（`[phi/type] ...`） |
| `NYASH_PHI_META_DEBUG=1` | OFF | Any | PHI metadata の伝播トレース（PHI dst / incoming の追跡） |
--- ---
参考: [docs/development/architecture/mir-logs-observability.md](../development/architecture/mir-logs-observability.md) / [src/mir/verification/](../../src/mir/verification/) 参考: [docs/development/architecture/mir-logs-observability.md](../development/architecture/mir-logs-observability.md) / [src/mir/verification/](../../src/mir/verification/)

109
src/llvm_py/builders/block_lower.py
View File

@ -1,9 +1,20 @@
from typing import Dict, Any, List, Tuple from typing import Dict, Any, List, Tuple, NamedTuple
from llvmlite import ir from llvmlite import ir
from trace import debug as trace_debug from trace import debug as trace_debug
from trace import phi_json as trace_phi_json from trace import phi_json as trace_phi_json
class DeferredTerminator(NamedTuple):
"""Phase 131-12-P1: Deferred terminator with vmap snapshot.
This structure captures the terminator operations along with the vmap state
at the end of Pass A, ensuring Pass C uses the correct SSA context.
"""
bb: ir.Block
term_ops: List[Dict[str, Any]]
vmap_snapshot: Dict[int, ir.Value]
def lower_blocks(builder, func: ir.Function, block_by_id: Dict[int, Dict[str, Any]], order: List[int], loop_plan: Dict[str, Any] | None): def lower_blocks(builder, func: ir.Function, block_by_id: Dict[int, Dict[str, Any]], order: List[int], loop_plan: Dict[str, Any] | None):
"""Lower blocks in multi-pass to ensure PHIs are always before terminators. """Lower blocks in multi-pass to ensure PHIs are always before terminators.
@ -34,6 +45,8 @@ def lower_blocks(builder, func: ir.Function, block_by_id: Dict[int, Dict[str, An
try: try:
builder.resolver.builder = ib builder.resolver.builder = ib
builder.resolver.module = builder.module builder.resolver.module = builder.module
# P0-1: Set current block_id for def_blocks tracking
builder.resolver.current_block_id = bid
except Exception: except Exception:
pass pass
builder.loop_count += 1 builder.loop_count += 1
@ -116,6 +129,8 @@ def lower_blocks(builder, func: ir.Function, block_by_id: Dict[int, Dict[str, An
try: try:
builder.resolver.builder = ib builder.resolver.builder = ib
builder.resolver.module = builder.module builder.resolver.module = builder.module
# P0-1: Set current block_id for def_blocks tracking
builder.resolver.current_block_id = bid
except Exception: except Exception:
pass pass
block_data = block_by_id.get(bid, {}) block_data = block_by_id.get(bid, {})
@ -162,6 +177,10 @@ def lower_blocks(builder, func: ir.Function, block_by_id: Dict[int, Dict[str, An
except Exception: except Exception:
vmap_cur = dict(builder.vmap) vmap_cur = dict(builder.vmap)
builder._current_vmap = vmap_cur builder._current_vmap = vmap_cur
# Phase 131-12-P1: Object identity trace for vmap_cur investigation
import os, sys
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/id] bb{bid} vmap_cur id={id(vmap_cur)} keys={sorted(vmap_cur.keys())[:10]}", file=sys.stderr)
created_ids: List[int] = [] created_ids: List[int] = []
defined_here_all: set = set() defined_here_all: set = set()
for _inst in body_ops: for _inst in body_ops:
@ -229,11 +248,17 @@ def lower_blocks(builder, func: ir.Function, block_by_id: Dict[int, Dict[str, An
except Exception: except Exception:
pass pass
# Phase 131-4 Pass A: DEFER terminators until after PHI finalization # Phase 131-4 Pass A: DEFER terminators until after PHI finalization
# Store terminators for Pass C (will be lowered in lower_terminators) # Phase 131-12-P1 P0-2: Store terminators WITH vmap_cur snapshot for Pass C
if not hasattr(builder, '_deferred_terminators'): if not hasattr(builder, '_deferred_terminators'):
builder._deferred_terminators = {} builder._deferred_terminators = {}
if term_ops: if term_ops:
builder._deferred_terminators[bid] = (bb, term_ops) # CRITICAL: dict(vmap_cur) creates a snapshot copy to prevent mutation issues
vmap_snapshot = dict(vmap_cur)
builder._deferred_terminators[bid] = DeferredTerminator(bb, term_ops, vmap_snapshot)
# Phase 131-12-P1: Trace snapshot creation
import os, sys
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/id] Pass A bb{bid} snapshot id={id(vmap_snapshot)} keys={sorted(vmap_snapshot.keys())[:10]}", file=sys.stderr)
# Phase 131-7: Sync ALL created values to global vmap (not just PHIs) # Phase 131-7: Sync ALL created values to global vmap (not just PHIs)
# This ensures Pass C (deferred terminators) can access values from Pass A # This ensures Pass C (deferred terminators) can access values from Pass A
try: try:
@ -265,9 +290,11 @@ def lower_blocks(builder, func: ir.Function, block_by_id: Dict[int, Dict[str, An
def lower_terminators(builder, func: ir.Function): def lower_terminators(builder, func: ir.Function):
"""Phase 131-4 Pass C: Lower deferred terminators after PHI finalization. """Phase 131-4 Pass C: Lower deferred terminators after PHI finalization.
Phase 131-12-P1 P0-3: Restore vmap_cur snapshot for each block's terminator lowering.
This ensures PHI nodes are always at block heads before terminators are added, This ensures PHI nodes are always at block heads before terminators are added,
maintaining LLVM IR's invariant: PHIs first, then other instructions, then terminators. maintaining LLVM IR's invariant: PHIs first, then other instructions, then terminators.
The vmap snapshot ensures terminators see the SSA context from Pass A, not later mutations.
""" """
if not hasattr(builder, '_deferred_terminators'): if not hasattr(builder, '_deferred_terminators'):
return return
@ -275,31 +302,65 @@ def lower_terminators(builder, func: ir.Function):
deferred = builder._deferred_terminators deferred = builder._deferred_terminators
trace_debug(f"[llvm-py/pass-c] Lowering {len(deferred)} blocks with deferred terminators") trace_debug(f"[llvm-py/pass-c] Lowering {len(deferred)} blocks with deferred terminators")
for bid, (bb, term_ops) in deferred.items(): import os, sys
ib = ir.IRBuilder(bb) strict_mode = os.environ.get('NYASH_LLVM_STRICT') == '1'
try:
builder.resolver.builder = ib
builder.resolver.module = builder.module
# Phase 131-4: Disable PHI synthesis during terminator lowering
# Terminators should only use values that already exist (from Pass A/B)
builder.resolver._disable_phi_synthesis = True
except Exception:
pass
for inst in term_ops: for bid, deferred_term in deferred.items():
# Phase 131-12-P1: Unpack DeferredTerminator with vmap snapshot
bb = deferred_term.bb
term_ops = deferred_term.term_ops
vmap_snapshot = deferred_term.vmap_snapshot
# Phase 131-12-P1 P0-4: STRICT mode assertion
if strict_mode:
assert vmap_snapshot is not None, f"STRICT: vmap_snapshot must exist for bb{bid}"
trace_debug(f"[llvm-py/pass-c/strict] bb{bid} vmap_snapshot id={id(vmap_snapshot)}")
# Phase 131-12-P1 P0-3: Save and restore _current_vmap
old_current_vmap = getattr(builder, '_current_vmap', None)
builder._current_vmap = vmap_snapshot
# Trace snapshot restoration
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/id] Pass C bb{bid} restored snapshot id={id(vmap_snapshot)} keys={sorted(vmap_snapshot.keys())[:10]}", file=sys.stderr)
# Phase 131-12-P1 P0-4: STRICT mode verification
if strict_mode:
assert hasattr(builder, '_current_vmap'), f"STRICT: _current_vmap must be set for bb{bid} terminator lowering"
assert id(builder._current_vmap) == id(vmap_snapshot), f"STRICT: _current_vmap must match snapshot for bb{bid}"
try:
ib = ir.IRBuilder(bb)
try: try:
trace_debug(f"[llvm-py/pass-c] term op: {inst.get('op')} dst={inst.get('dst')} in bb{bid}") builder.resolver.builder = ib
builder.resolver.module = builder.module
# Phase 131-4: Disable PHI synthesis during terminator lowering
# Terminators should only use values that already exist (from Pass A/B)
builder.resolver._disable_phi_synthesis = True
except Exception: except Exception:
pass pass
try:
if bb.terminator is not None: for inst in term_ops:
# Terminator already exists (e.g., from loop lowering), skip try:
trace_debug(f"[llvm-py/pass-c] bb{bid} already has terminator, skipping") trace_debug(f"[llvm-py/pass-c] term op: {inst.get('op')} dst={inst.get('dst')} in bb{bid}")
break except Exception:
except Exception: pass
pass try:
ib.position_at_end(bb) if bb.terminator is not None:
builder.lower_instruction(ib, inst, func) # Terminator already exists (e.g., from loop lowering), skip
trace_debug(f"[llvm-py/pass-c] bb{bid} already has terminator, skipping")
break
except Exception:
pass
ib.position_at_end(bb)
builder.lower_instruction(ib, inst, func)
finally:
# Phase 131-12-P1 P0-3: Restore previous _current_vmap state (prevent side effects)
if old_current_vmap is None:
if hasattr(builder, '_current_vmap'):
delattr(builder, '_current_vmap')
else:
builder._current_vmap = old_current_vmap
# Clean up deferred state # Clean up deferred state
try: try:

4
src/llvm_py/builders/instruction_lower.py
View File

@ -31,6 +31,10 @@ def lower_instruction(owner, builder: ir.IRBuilder, inst: Dict[str, Any], func:
op = inst.get("op") op = inst.get("op")
# Pick current vmap context (per-block context during lowering) # Pick current vmap context (per-block context during lowering)
vmap_ctx = getattr(owner, '_current_vmap', owner.vmap) vmap_ctx = getattr(owner, '_current_vmap', owner.vmap)
# Phase 131-12-P1: Object identity trace for vmap_ctx investigation
import os, sys
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/id] instruction op={op} vmap_ctx id={id(vmap_ctx)}", file=sys.stderr)
if op == "const": if op == "const":
dst = inst.get("dst") dst = inst.get("dst")

18
src/llvm_py/instructions/binop.py
View File

@ -5,7 +5,7 @@ Handles +, -, *, /, %, &, |, ^, <<, >>
import llvmlite.ir as ir import llvmlite.ir as ir
from typing import Dict, Optional, Any from typing import Dict, Optional, Any
from utils.values import resolve_i64_strict from utils.values import resolve_i64_strict, safe_vmap_write
import os import os
from .compare import lower_compare from .compare import lower_compare
@ -28,7 +28,7 @@ def _canonicalize_i64(builder: ir.IRBuilder, value, vid, vmap: Dict[int, ir.Valu
elif width > 64: elif width > 64:
value = builder.trunc(value, target, name=f"{hint}_trunc_{vid}") value = builder.trunc(value, target, name=f"{hint}_trunc_{vid}")
if isinstance(vid, int): if isinstance(vid, int):
vmap[vid] = value safe_vmap_write(vmap, vid, value, f"canonicalize_{hint}")
return value return value
def lower_binop( def lower_binop(
@ -233,7 +233,7 @@ def lower_binop(
if callee is None: if callee is None:
callee = ir.Function(builder.module, hh_fnty, name='nyash.string.concat_hh') callee = ir.Function(builder.module, hh_fnty, name='nyash.string.concat_hh')
res = builder.call(callee, [hl, hr], name=f"concat_hh_{dst}") res = builder.call(callee, [hl, hr], name=f"concat_hh_{dst}")
vmap[dst] = res safe_vmap_write(vmap, dst, res, "binop_concat_hh", resolver=resolver)
else: else:
# Mixed string + non-string (e.g., "len=" + 5). Use pointer concat helpers then box. # Mixed string + non-string (e.g., "len=" + 5). Use pointer concat helpers then box.
i32 = ir.IntType(32); i8p = ir.IntType(8).as_pointer(); i64 = ir.IntType(64) i32 = ir.IntType(32); i8p = ir.IntType(8).as_pointer(); i64 = ir.IntType(64)
@ -290,7 +290,7 @@ def lower_binop(
boxer = f; break boxer = f; break
if boxer is None: if boxer is None:
boxer = ir.Function(builder.module, ir.FunctionType(i64, [i8p]), name='nyash.box.from_i8_string') boxer = ir.Function(builder.module, ir.FunctionType(i64, [i8p]), name='nyash.box.from_i8_string')
vmap[dst] = builder.call(boxer, [p], name=f"concat_box_{dst}") safe_vmap_write(vmap, dst, builder.call(boxer, [p], name=f"concat_box_{dst}"), "binop_concat_si")
else: else:
li = as_i64(lhs_val) li = as_i64(lhs_val)
rp = to_i8p_from_vid(rhs, rhs_raw, rhs_val, 'r') rp = to_i8p_from_vid(rhs, rhs_raw, rhs_val, 'r')
@ -307,7 +307,7 @@ def lower_binop(
boxer = f; break boxer = f; break
if boxer is None: if boxer is None:
boxer = ir.Function(builder.module, ir.FunctionType(i64, [i8p]), name='nyash.box.from_i8_string') boxer = ir.Function(builder.module, ir.FunctionType(i64, [i8p]), name='nyash.box.from_i8_string')
vmap[dst] = builder.call(boxer, [p], name=f"concat_box_{dst}") safe_vmap_write(vmap, dst, builder.call(boxer, [p], name=f"concat_box_{dst}"), "binop_concat_is")
# Tag result as string handle so subsequent '+' stays in string domain # Tag result as string handle so subsequent '+' stays in string domain
try: try:
if resolver is not None and hasattr(resolver, 'mark_string'): if resolver is not None and hasattr(resolver, 'mark_string'):
@ -353,6 +353,10 @@ def lower_binop(
else: else:
# Unknown op - return zero # Unknown op - return zero
result = ir.Constant(i64, 0) result = ir.Constant(i64, 0)
# Phase 131-12-P1: Object identity trace before write
import sys # os already imported at module level
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/id] binop op={op} dst={dst} vmap id={id(vmap)} before_write", file=sys.stderr)
# Store result # Store result
vmap[dst] = result safe_vmap_write(vmap, dst, result, f"binop_{op}")

16
src/llvm_py/instructions/compare.py
View File

@ -5,7 +5,7 @@ Handles comparison operations (<, >, <=, >=, ==, !=)
import llvmlite.ir as ir import llvmlite.ir as ir
from typing import Dict, Optional, Any from typing import Dict, Optional, Any
from utils.values import resolve_i64_strict from utils.values import resolve_i64_strict, safe_vmap_write
import os import os
from .externcall import lower_externcall from .externcall import lower_externcall
from trace import values as trace_values from trace import values as trace_values
@ -28,7 +28,7 @@ def _canonicalize_i64(builder: ir.IRBuilder, value, vid, vmap: Dict[int, ir.Valu
elif width > 64: elif width > 64:
value = builder.trunc(value, target, name=f"{hint}_trunc_{vid}") value = builder.trunc(value, target, name=f"{hint}_trunc_{vid}")
if isinstance(vid, int): if isinstance(vid, int):
vmap[vid] = value safe_vmap_write(vmap, vid, value, f"canonicalize_{hint}")
return value return value
def lower_compare( def lower_compare(
@ -126,11 +126,11 @@ def lower_compare(
eqf = ir.Function(builder.module, ir.FunctionType(i64, [i64, i64]), name='nyash.string.eq_hh') eqf = ir.Function(builder.module, ir.FunctionType(i64, [i64, i64]), name='nyash.string.eq_hh')
eq = builder.call(eqf, [lh, rh], name='str_eq') eq = builder.call(eqf, [lh, rh], name='str_eq')
if op == '==': if op == '==':
vmap[dst] = eq safe_vmap_write(vmap, dst, eq, "compare_str_eq", resolver=resolver)
else: else:
one = ir.Constant(i64, 1) one = ir.Constant(i64, 1)
ne = builder.sub(one, eq, name='str_ne') ne = builder.sub(one, eq, name='str_ne')
vmap[dst] = ne safe_vmap_write(vmap, dst, ne, "compare_str_ne", resolver=resolver)
return return
# Default integer compare path # Default integer compare path
@ -159,7 +159,7 @@ def lower_compare(
# should explicitly cast at their use site (e.g., via resolver or # should explicitly cast at their use site (e.g., via resolver or
# instruction-specific lowering) to avoid emitting casts after # instruction-specific lowering) to avoid emitting casts after
# terminators when used as branch conditions. # terminators when used as branch conditions.
vmap[dst] = cmp_result safe_vmap_write(vmap, dst, cmp_result, f"compare_{pred}")
def lower_fcmp( def lower_fcmp(
builder: ir.IRBuilder, builder: ir.IRBuilder,
@ -188,10 +188,10 @@ def lower_fcmp(
# Perform ordered comparison using canonical predicates # Perform ordered comparison using canonical predicates
pred = op if op in ('<','>','<=','>=','==','!=') else '==' pred = op if op in ('<','>','<=','>=','==','!=') else '=='
cmp_result = builder.fcmp_ordered(pred, lhs_val, rhs_val, name=f"fcmp_{dst}") cmp_result = builder.fcmp_ordered(pred, lhs_val, rhs_val, name=f"fcmp_{dst}")
# Convert i1 to i64 # Convert i1 to i64
i64 = ir.IntType(64) i64 = ir.IntType(64)
result = builder.zext(cmp_result, i64, name=f"fcmp_i64_{dst}") result = builder.zext(cmp_result, i64, name=f"fcmp_i64_{dst}")
# Store result # Store result
vmap[dst] = result safe_vmap_write(vmap, dst, result, f"fcmp_{pred}")

21
src/llvm_py/instructions/const.py
View File

@ -5,6 +5,7 @@ Handles integer, float, string, and void constants
import llvmlite.ir as ir import llvmlite.ir as ir
from typing import Dict, Any from typing import Dict, Any
from utils.values import safe_vmap_write
def lower_const( def lower_const(
builder: ir.IRBuilder, builder: ir.IRBuilder,
@ -31,13 +32,17 @@ def lower_const(
# Integer constant # Integer constant
i64 = ir.IntType(64) i64 = ir.IntType(64)
llvm_val = ir.Constant(i64, int(const_val)) llvm_val = ir.Constant(i64, int(const_val))
vmap[dst] = llvm_val # Phase 131-12-P1: Object identity trace before write
import os, sys
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/id] const dst={dst} vmap id={id(vmap)} before_write", file=sys.stderr)
safe_vmap_write(vmap, dst, llvm_val, "const_i64", resolver=resolver)
elif const_type == 'f64': elif const_type == 'f64':
# Float constant # Float constant
f64 = ir.DoubleType() f64 = ir.DoubleType()
llvm_val = ir.Constant(f64, float(const_val)) llvm_val = ir.Constant(f64, float(const_val))
vmap[dst] = llvm_val safe_vmap_write(vmap, dst, llvm_val, "const_f64", resolver=resolver)
elif const_type == 'string' or (isinstance(const_type, dict) and const_type.get('kind') in ('handle','ptr') and const_type.get('box_type') == 'StringBox'): elif const_type == 'string' or (isinstance(const_type, dict) and const_type.get('kind') in ('handle','ptr') and const_type.get('box_type') == 'StringBox'):
# String constant - create global and immediately box to i64 handle # String constant - create global and immediately box to i64 handle
@ -75,7 +80,7 @@ def lower_const(
if boxer is None: if boxer is None:
boxer = ir.Function(module, boxer_ty, name='nyash.box.from_i8_string') boxer = ir.Function(module, boxer_ty, name='nyash.box.from_i8_string')
handle = builder.call(boxer, [gep], name=f"const_str_h_{dst}") handle = builder.call(boxer, [gep], name=f"const_str_h_{dst}")
vmap[dst] = handle safe_vmap_write(vmap, dst, handle, "const_string", resolver=resolver)
if resolver is not None: if resolver is not None:
if hasattr(resolver, 'string_literals'): if hasattr(resolver, 'string_literals'):
resolver.string_literals[dst] = str_val resolver.string_literals[dst] = str_val
@ -87,13 +92,13 @@ def lower_const(
resolver.string_ptrs[dst] = gep resolver.string_ptrs[dst] = gep
except Exception: except Exception:
pass pass
elif const_type == 'void': elif const_type == 'void':
# Void/null constant - use i64 zero # Void/null constant - use i64 zero
i64 = ir.IntType(64) i64 = ir.IntType(64)
vmap[dst] = ir.Constant(i64, 0) safe_vmap_write(vmap, dst, ir.Constant(i64, 0), "const_void", resolver=resolver)
else: else:
# Unknown type - default to i64 zero # Unknown type - default to i64 zero
i64 = ir.IntType(64) i64 = ir.IntType(64)
vmap[dst] = ir.Constant(i64, 0) safe_vmap_write(vmap, dst, ir.Constant(i64, 0), "const_unknown", resolver=resolver)

8
src/llvm_py/instructions/copy.py
View File

@ -5,7 +5,7 @@ MIR13 PHI-off uses explicit copies along edges/blocks to model merges.
import llvmlite.ir as ir import llvmlite.ir as ir
from typing import Dict, Optional, Any from typing import Dict, Optional, Any
from utils.values import resolve_i64_strict from utils.values import resolve_i64_strict, safe_vmap_write
def lower_copy( def lower_copy(
builder: ir.IRBuilder, builder: ir.IRBuilder,
@ -43,4 +43,8 @@ def lower_copy(
val = resolve_i64_strict(resolver, src, current_block, preds, block_end_values, vmap, bb_map) val = resolve_i64_strict(resolver, src, current_block, preds, block_end_values, vmap, bb_map)
if val is None: if val is None:
val = ir.Constant(ir.IntType(64), 0) val = ir.Constant(ir.IntType(64), 0)
vmap[dst] = val # Phase 131-12-P1: Object identity trace before write
import os, sys
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/id] copy dst={dst} src={src} vmap id={id(vmap)} before_write", file=sys.stderr)
safe_vmap_write(vmap, dst, val, "copy", resolver=resolver)

13
src/llvm_py/instructions/phi.py
View File

@ -6,6 +6,7 @@ Critical for SSA form - handles value merging from different control flow paths
import llvmlite.ir as ir import llvmlite.ir as ir
from phi_wiring import phi_at_block_head from phi_wiring import phi_at_block_head
from typing import Dict, List, Tuple, Optional from typing import Dict, List, Tuple, Optional
from utils.values import safe_vmap_write
def lower_phi( def lower_phi(
builder: ir.IRBuilder, builder: ir.IRBuilder,
@ -131,6 +132,18 @@ def lower_phi(
# Store PHI result # Store PHI result
vmap[dst_vid] = phi vmap[dst_vid] = phi
# Register PHI definition in def_blocks (critical for resolver dominance tracking)
if resolver is not None and hasattr(resolver, 'def_blocks') and cur_bid is not None:
resolver.def_blocks.setdefault(dst_vid, set()).add(cur_bid)
import os
if os.environ.get('NYASH_LLVM_PHI_DEBUG') == '1':
try:
from trace import phi as trace_phi_debug
trace_phi_debug(f"[PHI_DEBUG] Registered dst_vid={dst_vid} in def_blocks for block={cur_bid}")
except Exception:
pass
# Strict mode: fail fast on synthesized zeros (indicates incomplete incoming or dominance issue) # Strict mode: fail fast on synthesized zeros (indicates incomplete incoming or dominance issue)
import os import os
if used_default_zero and os.environ.get('NYASH_LLVM_PHI_STRICT') == '1': if used_default_zero and os.environ.get('NYASH_LLVM_PHI_STRICT') == '1':

27
src/llvm_py/instructions/typeop.py
View File

@ -5,6 +5,7 @@ Handles type conversions and type checks
import llvmlite.ir as ir import llvmlite.ir as ir
from typing import Dict, Optional, Any from typing import Dict, Optional, Any
from utils.values import safe_vmap_write
def lower_typeop( def lower_typeop(
builder: ir.IRBuilder, builder: ir.IRBuilder,
@ -57,8 +58,8 @@ def lower_typeop(
if op == "cast": if op == "cast":
# Type casting - for now just pass through # Type casting - for now just pass through
# In real implementation, would check/convert box types # In real implementation, would check/convert box types
vmap[dst_vid] = src_val safe_vmap_write(vmap, dst_vid, src_val, "typeop_cast", resolver=resolver)
elif op == "is": elif op == "is":
# Type check - returns boolean (i64: 1 or 0) # Type check - returns boolean (i64: 1 or 0)
# For now, simplified implementation # For now, simplified implementation
@ -75,17 +76,17 @@ def lower_typeop(
else: else:
# For other types, would need runtime type info # For other types, would need runtime type info
result = ir.Constant(ir.IntType(64), 0) result = ir.Constant(ir.IntType(64), 0)
vmap[dst_vid] = result safe_vmap_write(vmap, dst_vid, result, "typeop_is", resolver=resolver)
elif op == "as": elif op == "as":
# Safe cast - returns value or null/0 # Safe cast - returns value or null/0
# For now, same as cast # For now, same as cast
vmap[dst_vid] = src_val safe_vmap_write(vmap, dst_vid, src_val, "typeop_as", resolver=resolver)
else: else:
# Unknown operation # Unknown operation
vmap[dst_vid] = ir.Constant(ir.IntType(64), 0) safe_vmap_write(vmap, dst_vid, ir.Constant(ir.IntType(64), 0), "typeop_unknown")
def lower_convert( def lower_convert(
builder: ir.IRBuilder, builder: ir.IRBuilder,
@ -134,12 +135,12 @@ def lower_convert(
if not src_val: if not src_val:
# Default based on target type # Default based on target type
if to_type == "f64": if to_type == "f64":
vmap[dst_vid] = ir.Constant(ir.DoubleType(), 0.0) safe_vmap_write(vmap, dst_vid, ir.Constant(ir.DoubleType(), 0.0), "convert_default_f64")
elif to_type == "ptr": elif to_type == "ptr":
i8 = ir.IntType(8) i8 = ir.IntType(8)
vmap[dst_vid] = ir.Constant(i8.as_pointer(), None) safe_vmap_write(vmap, dst_vid, ir.Constant(i8.as_pointer(), None), "convert_default_ptr")
else: else:
vmap[dst_vid] = ir.Constant(ir.IntType(64), 0) safe_vmap_write(vmap, dst_vid, ir.Constant(ir.IntType(64), 0), "convert_default_i64")
return return
# Perform conversion # Perform conversion
@ -165,5 +166,5 @@ def lower_convert(
else: else:
# Unknown conversion - pass through # Unknown conversion - pass through
result = src_val result = src_val
vmap[dst_vid] = result safe_vmap_write(vmap, dst_vid, result, f"convert_{from_type}_to_{to_type}")

3
src/llvm_py/phi_wiring/tagging.py
View File

@ -114,6 +114,9 @@ def setup_phi_placeholders(builder, blocks: List[Dict[str, Any]]):
# Definition hint: PHI defines dst in this block # Definition hint: PHI defines dst in this block
try: try:
builder.def_blocks.setdefault(int(dst0), set()).add(int(bid0)) builder.def_blocks.setdefault(int(dst0), set()).add(int(bid0))
import os
if os.environ.get('NYASH_LLVM_PHI_DEBUG') == '1':
trace({"phi_def_blocks": "registered", "dst": int(dst0), "block": int(bid0)})
except Exception: except Exception:
pass pass
try: try:

66
src/llvm_py/resolver.py
View File

@ -88,7 +88,20 @@ class Resolver:
Creates PHI at block start if needed, caches the result. Creates PHI at block start if needed, caches the result.
""" """
cache_key = (current_block.name, value_id) cache_key = (current_block.name, value_id)
import os
if os.environ.get('NYASH_LLVM_PHI_DEBUG') == '1':
try:
bid = int(str(current_block.name).replace('bb',''))
in_def_blocks = value_id in self.def_blocks
if in_def_blocks:
def_in_blocks = list(self.def_blocks.get(value_id, set()))
else:
def_in_blocks = []
trace_phi(f"[resolve_i64/entry] bb{bid} v{value_id} in_def_blocks={in_def_blocks} def_in={def_in_blocks}")
except Exception as e:
trace_phi(f"[resolve_i64/entry] ERROR: {e}")
# Check cache # Check cache
if cache_key in self.i64_cache: if cache_key in self.i64_cache:
return self.i64_cache[cache_key] return self.i64_cache[cache_key]
@ -158,10 +171,18 @@ class Resolver:
defined_here = False defined_here = False
if defined_here: if defined_here:
existing = vmap.get(value_id) existing = vmap.get(value_id)
import os
if os.environ.get('NYASH_LLVM_PHI_DEBUG') == '1':
existing_type = type(existing).__name__ if existing is not None else "None"
trace_phi(f"[resolve/def_here] bb{bid} v{value_id} existing={existing_type} in vmap={value_id in vmap}")
if existing is not None and hasattr(existing, 'type') and isinstance(existing.type, ir.IntType) and existing.type.width == 64: if existing is not None and hasattr(existing, 'type') and isinstance(existing.type, ir.IntType) and existing.type.width == 64:
trace_values(f"[resolve] local reuse: bb{bid} v{value_id}") trace_values(f"[resolve] local reuse: bb{bid} v{value_id}")
self.i64_cache[cache_key] = existing self.i64_cache[cache_key] = existing
return existing return existing
elif existing is not None:
if os.environ.get('NYASH_LLVM_PHI_DEBUG') == '1':
existing_llvm_type = str(existing.type) if hasattr(existing, 'type') else "no_type"
trace_phi(f"[resolve/def_here] bb{bid} v{value_id} existing has wrong type: {existing_llvm_type}")
else: else:
# Do NOT blindly reuse vmap across blocks: it may reference values defined # Do NOT blindly reuse vmap across blocks: it may reference values defined
# in non-dominating predecessors (e.g., other branches). Only reuse when # in non-dominating predecessors (e.g., other branches). Only reuse when
@ -235,6 +256,24 @@ class Resolver:
result = placeholder if (placeholder is not None and hasattr(placeholder, 'add_incoming')) else ir.Constant(self.i64, 0) result = placeholder if (placeholder is not None and hasattr(placeholder, 'add_incoming')) else ir.Constant(self.i64, 0)
else: else:
# No declared PHI and multi-pred: do not synthesize; fallback to zero # No declared PHI and multi-pred: do not synthesize; fallback to zero
import os
if os.environ.get('NYASH_LLVM_STRICT') == '1':
# P0-2: STRICT mode - fail fast on undeclared PHI in multi-pred context
def_blocks_info = "not_in_def_blocks"
try:
if value_id in self.def_blocks:
def_blocks_info = f"def_blocks={sorted(list(self.def_blocks[value_id]))}"
except Exception:
pass
raise RuntimeError(
f"[LLVM_PY/STRICT] Undeclared PHI in multi-pred block:\n"
f" ValueId: {value_id}\n"
f" Block: bb{cur_bid}\n"
f" Predecessors: {pred_ids}\n"
f" {def_blocks_info}\n"
f" Hint: Value needs PHI but not declared in block_phi_incomings"
)
result = ir.Constant(self.i64, 0) result = ir.Constant(self.i64, 0)
# Cache and return # Cache and return
@ -342,6 +381,31 @@ class Resolver:
preds_s = ','.join(str(x) for x in pred_ids) preds_s = ','.join(str(x) for x in pred_ids)
trace_phi(f"[resolve] end_i64 miss: bb{block_id} v{value_id} preds=[{preds_s}] → 0") trace_phi(f"[resolve] end_i64 miss: bb{block_id} v{value_id} preds=[{preds_s}] → 0")
# P0-2: STRICT mode - fail fast on resolution miss
import os
if os.environ.get('NYASH_LLVM_STRICT') == '1':
# Collect diagnostic information
def_blocks_info = "not_in_def_blocks"
try:
if value_id in self.def_blocks:
def_blocks_info = f"def_blocks={sorted(list(self.def_blocks[value_id]))}"
except Exception:
pass
# Build search path for diagnostics
search_path = [block_id] + pred_ids
raise RuntimeError(
f"[LLVM_PY/STRICT] PHI resolution miss:\n"
f" ValueId: {value_id}\n"
f" Target block: {block_id}\n"
f" Predecessors: [{preds_s}]\n"
f" Search path: {search_path}\n"
f" {def_blocks_info}\n"
f" Hint: PHI dst may not be registered in def_blocks, or dominance issue"
)
z = ir.Constant(self.i64, 0) z = ir.Constant(self.i64, 0)
self._end_i64_cache[key] = z self._end_i64_cache[key] = z
return z return z

70
src/llvm_py/utils/values.py
View File

@ -5,6 +5,8 @@ Centralize policies like "prefer same-block SSA; otherwise resolve with dominanc
from typing import Any, Dict, Optional from typing import Any, Dict, Optional
import llvmlite.ir as ir import llvmlite.ir as ir
import sys
import os
def resolve_i64_strict( def resolve_i64_strict(
resolver, resolver,
@ -21,19 +23,87 @@ def resolve_i64_strict(
- If prefer_local and vmap has a same-block definition, reuse it. - If prefer_local and vmap has a same-block definition, reuse it.
- Otherwise, delegate to resolver to localize with PHI/casts as needed. - Otherwise, delegate to resolver to localize with PHI/casts as needed.
""" """
import os
debug = os.environ.get('NYASH_LLVM_PHI_DEBUG') == '1'
# Prefer current vmap SSA first (block-local map is passed in vmap) # Prefer current vmap SSA first (block-local map is passed in vmap)
val = vmap.get(value_id) val = vmap.get(value_id)
if debug:
val_type = type(val).__name__ if val is not None else "None"
from trace import phi as trace_phi
trace_phi(f"[resolve_i64_strict] v{value_id} vmap={val_type}")
if prefer_local and val is not None: if prefer_local and val is not None:
if debug:
trace_phi(f"[resolve_i64_strict] v{value_id} -> local vmap")
return val return val
# If local map misses, try builder-global vmap (e.g., predeclared PHIs) # If local map misses, try builder-global vmap (e.g., predeclared PHIs)
try: try:
if hasattr(resolver, 'global_vmap') and isinstance(resolver.global_vmap, dict): if hasattr(resolver, 'global_vmap') and isinstance(resolver.global_vmap, dict):
gval = resolver.global_vmap.get(value_id) gval = resolver.global_vmap.get(value_id)
if gval is not None: if gval is not None:
if debug:
trace_phi(f"[resolve_i64_strict] v{value_id} -> global_vmap")
return gval return gval
except Exception: except Exception:
pass pass
# Fallback to resolver # Fallback to resolver
if resolver is None: if resolver is None:
if debug:
trace_phi(f"[resolve_i64_strict] v{value_id} -> 0 (no resolver)")
return ir.Constant(ir.IntType(64), 0) return ir.Constant(ir.IntType(64), 0)
if debug:
trace_phi(f"[resolve_i64_strict] v{value_id} -> resolver.resolve_i64")
return resolver.resolve_i64(value_id, current_block, preds, block_end_values, vmap, bb_map) return resolver.resolve_i64(value_id, current_block, preds, block_end_values, vmap, bb_map)
def safe_vmap_write(vmap: Dict[int, Any], dst: int, value: Any, context: str = "", resolver=None, block_id: Optional[int] = None) -> None:
"""
PHI overwrite protection for vmap writes + def_blocks registration (P0-1 unified).
Implements fail-fast protection against ValueId namespace collisions.
Args:
vmap: Value map to write to
dst: Destination ValueId
value: LLVM IR value to write
context: Context string for error messages (e.g., "const", "binop")
resolver: Optional resolver for def_blocks tracking (P0-1)
block_id: Optional block ID for def_blocks registration (P0-1)
Behavior:
- STRICT mode (NYASH_LLVM_STRICT=1): Raises error if overwriting PHI
- TRACE mode (NYASH_LLVM_TRACE_VMAP=1): Logs warning but skips overwrite
- Default: Silently skips PHI overwrite (SSOT: PHI defined once)
- P0-1: If resolver and block_id provided, register in def_blocks
"""
existing = vmap.get(dst)
if existing is not None and hasattr(existing, 'add_incoming'):
# PHI node detected - overwrite forbidden (SSOT principle)
if os.environ.get('NYASH_LLVM_STRICT') == '1':
raise RuntimeError(
f"[LLVM_PY/{context}] Cannot overwrite PHI dst={dst}. "
f"ValueId namespace collision detected. "
f"Existing: PHI node, Attempted: {type(value).__name__}"
)
# STRICT not enabled - warn and skip
if os.environ.get('NYASH_LLVM_TRACE_VMAP') == '1':
print(f"[vmap/warn] Skipping overwrite of PHI dst={dst} in context={context}", file=sys.stderr)
return # Do not overwrite PHI
# Safe to write
vmap[dst] = value
# Phase 131-12-P1: Trace successful write
if os.environ.get('NYASH_LLVM_VMAP_TRACE') == '1':
print(f"[vmap/write] dst={dst} written, vmap.keys()={sorted(vmap.keys())[:20]}", file=sys.stderr)
# P0-1: Register definition in def_blocks for dominance tracking (SSOT for all instructions)
if resolver is not None and hasattr(resolver, 'def_blocks'):
# Auto-detect block_id from resolver if not provided explicitly
bid = block_id
if bid is None and hasattr(resolver, 'current_block_id'):
bid = resolver.current_block_id
if bid is not None:
resolver.def_blocks.setdefault(dst, set()).add(bid)
if os.environ.get('NYASH_LLVM_TRACE_VMAP') == '1':
print(f"[vmap/def_blocks] Registered v{dst} in block {bid} (context={context})", file=sys.stderr)

26
src/mir/builder/control_flow/joinir/merge/loop_header_phi_builder.rs
View File

@ -93,6 +93,19 @@ impl LoopHeaderPhiBuilder {
#[cfg(debug_assertions)] #[cfg(debug_assertions)]
crate::mir::join_ir::verify_phi_reserved::observe_phi_dst(loop_var_phi_dst); crate::mir::join_ir::verify_phi_reserved::observe_phi_dst(loop_var_phi_dst);
// Phase 131-11-H: Set PHI type from entry incoming (init value) only
// Ignore backedge to avoid circular dependency in type inference
if let Some(init_type) = builder.value_types.get(&loop_var_init).cloned() {
builder.value_types.insert(loop_var_phi_dst, init_type.clone());
if debug || std::env::var("NYASH_CARRIER_PHI_DEBUG").ok().as_deref() == Some("1") {
eprintln!(
"[carrier/phi] Loop var '{}': dst=%{} entry_type={:?} (backedge ignored)",
loop_var_name, loop_var_phi_dst.as_u32(), init_type
);
}
}
info.carrier_phis.insert( info.carrier_phis.insert(
loop_var_name.to_string(), loop_var_name.to_string(),
CarrierPhiEntry { CarrierPhiEntry {
@ -129,6 +142,19 @@ impl LoopHeaderPhiBuilder {
#[cfg(debug_assertions)] #[cfg(debug_assertions)]
crate::mir::join_ir::verify_phi_reserved::observe_phi_dst(phi_dst); crate::mir::join_ir::verify_phi_reserved::observe_phi_dst(phi_dst);
// Phase 131-11-H: Set PHI type from entry incoming (init value) only
// Ignore backedge to avoid circular dependency in type inference
if let Some(init_type) = builder.value_types.get(&init_value).cloned() {
builder.value_types.insert(phi_dst, init_type.clone());
if debug || std::env::var("NYASH_CARRIER_PHI_DEBUG").ok().as_deref() == Some("1") {
eprintln!(
"[carrier/phi] Carrier '{}': dst=%{} entry_type={:?} (backedge ignored)",
name, phi_dst.as_u32(), init_type
);
}
}
info.carrier_phis.insert( info.carrier_phis.insert(
name.clone(), name.clone(),
CarrierPhiEntry { CarrierPhiEntry {