From 739ad7fbe771ab7d8f8d7be29d20db2b91e76241 Mon Sep 17 00:00:00 2001 From: nyash-codex Date: Mon, 8 Dec 2025 19:22:57 +0900 Subject: [PATCH] chore: Remove unused imports (Task 4) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Task 4: Additional dead code and unused imports cleanup - Removed 7 unused imports across 6 files: - conversion_pipeline.rs: MirModule - pattern1_minimal.rs: BTreeMap - pattern2_with_break.rs: BTreeMap - pattern3_with_if_phi.rs: BTreeMap - pattern4_with_continue.rs: CarrierInfo, BTreeMap - condition_var_analyzer.rs: BasicBlockId - Build verified: 0 unused import warnings remaining - Warning count reduced: 70 → 63 warnings Result: Cleaner code, reduced compiler warnings --- .../control_flow/joinir/patterns/conversion_pipeline.rs | 2 +- .../builder/control_flow/joinir/patterns/pattern1_minimal.rs | 2 +- .../control_flow/joinir/patterns/pattern2_with_break.rs | 2 +- .../control_flow/joinir/patterns/pattern3_with_if_phi.rs | 2 +- .../control_flow/joinir/patterns/pattern4_with_continue.rs | 3 +-- src/mir/loop_pattern_detection/condition_var_analyzer.rs | 1 - 6 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs b/src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs index f69b8333..4ceeb092 100644 --- a/src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs +++ b/src/mir/builder/control_flow/joinir/patterns/conversion_pipeline.rs @@ -27,7 +27,7 @@ //! - **Testability**: Can test conversion independently //! - **Reduces duplication**: Eliminates 120 lines across Pattern 1-4 -use crate::mir::{MirModule, ValueId}; +use crate::mir::ValueId; use crate::mir::builder::MirBuilder; use crate::mir::join_ir::JoinModule; use crate::mir::join_ir::lowering::inline_boundary::JoinInlineBoundary; diff --git a/src/mir/builder/control_flow/joinir/patterns/pattern1_minimal.rs b/src/mir/builder/control_flow/joinir/patterns/pattern1_minimal.rs index 482b4559..58344d47 100644 --- a/src/mir/builder/control_flow/joinir/patterns/pattern1_minimal.rs +++ b/src/mir/builder/control_flow/joinir/patterns/pattern1_minimal.rs @@ -52,7 +52,7 @@ impl MirBuilder { ) -> Result, String> { use crate::mir::join_ir::lowering::simple_while_minimal::lower_simple_while_minimal; use crate::mir::BasicBlockId; - use std::collections::{BTreeMap, BTreeSet}; + use std::collections::BTreeSet; // Phase 195: Use unified trace trace::trace().debug("pattern1", "Calling Pattern 1 minimal lowerer"); diff --git a/src/mir/builder/control_flow/joinir/patterns/pattern2_with_break.rs b/src/mir/builder/control_flow/joinir/patterns/pattern2_with_break.rs index 784fef96..a6cfc296 100644 --- a/src/mir/builder/control_flow/joinir/patterns/pattern2_with_break.rs +++ b/src/mir/builder/control_flow/joinir/patterns/pattern2_with_break.rs @@ -95,7 +95,7 @@ impl MirBuilder { ) -> Result, String> { use crate::mir::join_ir::lowering::loop_with_break_minimal::lower_loop_with_break_minimal; use crate::mir::BasicBlockId; - use std::collections::{BTreeMap, BTreeSet}; + use std::collections::BTreeSet; // Phase 195: Use unified trace trace::trace().debug("pattern2", "Calling Pattern 2 minimal lowerer"); diff --git a/src/mir/builder/control_flow/joinir/patterns/pattern3_with_if_phi.rs b/src/mir/builder/control_flow/joinir/patterns/pattern3_with_if_phi.rs index ec4cb6c8..21749c9d 100644 --- a/src/mir/builder/control_flow/joinir/patterns/pattern3_with_if_phi.rs +++ b/src/mir/builder/control_flow/joinir/patterns/pattern3_with_if_phi.rs @@ -70,7 +70,7 @@ impl MirBuilder { ) -> Result, String> { use crate::mir::join_ir::lowering::loop_with_if_phi_minimal::lower_loop_with_if_phi_pattern; use crate::mir::BasicBlockId; - use std::collections::{BTreeMap, BTreeSet}; + use std::collections::BTreeSet; // Phase 195: Use unified trace trace::trace().debug("pattern3", "Calling Pattern 3 minimal lowerer"); diff --git a/src/mir/builder/control_flow/joinir/patterns/pattern4_with_continue.rs b/src/mir/builder/control_flow/joinir/patterns/pattern4_with_continue.rs index dac5bf7d..58b37bc7 100644 --- a/src/mir/builder/control_flow/joinir/patterns/pattern4_with_continue.rs +++ b/src/mir/builder/control_flow/joinir/patterns/pattern4_with_continue.rs @@ -168,10 +168,9 @@ impl MirBuilder { _func_name: &str, debug: bool, ) -> Result, String> { - use crate::mir::join_ir::lowering::carrier_info::CarrierInfo; use crate::mir::join_ir::lowering::loop_with_continue_minimal::lower_loop_with_continue_minimal; use crate::mir::BasicBlockId; - use std::collections::{BTreeMap, BTreeSet}; + use std::collections::BTreeSet; use super::pattern4_carrier_analyzer::Pattern4CarrierAnalyzer; // Phase 195: Use unified trace diff --git a/src/mir/loop_pattern_detection/condition_var_analyzer.rs b/src/mir/loop_pattern_detection/condition_var_analyzer.rs index 59e54958..e672e4fe 100644 --- a/src/mir/loop_pattern_detection/condition_var_analyzer.rs +++ b/src/mir/loop_pattern_detection/condition_var_analyzer.rs @@ -15,7 +15,6 @@ use crate::ast::ASTNode; use crate::mir::join_ir::lowering::loop_scope_shape::LoopScopeShape; -use crate::mir::BasicBlockId; use std::collections::HashSet; /// Extract all variable names from an AST expression