tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor(joinir): Document loop pattern detection architecture (Task 2)

Browse Source 
Task 2: Loop pattern detection structure investigation
- Analyzed src/mir/loop_pattern_detection/ (~3k lines, not 26k as expected)
- Module is already well-structured with Phase 194+ architecture
- Legacy functions (Phase 188) are still actively used, not truly deprecated
- Added clarifying comment to prevent future confusion about "legacy" label

Decision: Skip reorganization - current structure is clean and functional.
No subdirectory needed for active production code.
This commit is contained in:
nyash-codex
2025-12-08 19:17:34 +09:00
parent 1193b8b66d
commit 6d0b4e3bfd
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/mir/loop_pattern_detection/mod.rs
View File

@ -329,6 +329,12 @@ pub fn classify_with_diagnosis(features: &LoopFeatures) -> (LoopPatternKind, Str
// ============================================================================
// Legacy Detection Functions (Phase 188)
// ============================================================================
//
// NOTE (Phase 179): These functions are still actively used by pattern lowerers.
// The term "legacy" refers to Phase 188 implementation style (name-based detection),
// not deprecation status. Do NOT move to legacy/ subdirectory - still production code.
//
// Future work: Gradually migrate to Phase 194+ structure-based detection (extract_features/classify).
// ============================================================================
// Pattern 1: Simple While Loop