Phase 21.4 Complete: FileBox SSOT + Analyzer Stabilization (7 Tasks)
✅ Task 1: Fallback Guarantee (create_box failure → ring1/core-ro auto fallback) - Three-tier fallback system: plugin → builtin → core-ro - Mode control: auto/plugin-only/core-ro - New: src/box_factory/builtin_impls/file_box.rs - New: tools/test_filebox_fallback_smoke.sh ✅ Task 2: Provider Registration SSOT (static/dynamic/core-ro unified) - ProviderFactory trait with priority-based selection - Global registry PROVIDER_FACTORIES implementation - Priority: dynamic(100) > builtin(10) > core-ro(0) - New: src/boxes/file/builtin_factory.rs - New: tools/smoke_provider_modes.sh ✅ Task 3: FileBox Publication Unification - Verified: basic/file_box.rs already minimized (11 lines) - Perfect re-export pattern maintained ✅ Task 4: ENV Unification (FILEBOX_MODE/DISABLE_PLUGINS priority) - Removed auto-setting of NYASH_USE_PLUGIN_BUILTINS - Removed auto-setting of NYASH_PLUGIN_OVERRIDE_TYPES - Added deprecation warnings with migration guide - ENV hierarchy: DISABLE_PLUGINS > BOX_FACTORY_POLICY > FILEBOX_MODE ✅ Task 5: Error Log Visibility (Analyzer rule execution errors to stderr) - Added [rule/exec] logging before IR-based rule execution - Format: [rule/exec] HC012 (dead_static_box) <filepath> - VM errors now traceable via stderr output ✅ Task 6: Unnecessary Using Removal (14 rules Str alias cleanup) - Removed unused `using ... as Str` from 14 rule files - All rules use local _itoa() helper instead - 14 lines of dead code eliminated ✅ Task 7: HC017 Skip & TODO Documentation (UTF-8 support required) - Enhanced run_tests.sh with clear skip message - Added "Known Limitations" section to README.md - Technical requirements documented (3 implementation options) - Re-enable timeline: Phase 22 (Unicode Support Phase) 📊 Test Results: - Analyzer: 10 tests PASS, 1 skipped (HC017) - FileBox fallback: All 3 modes PASS - Provider modes: All 4 modes PASS - Build: Success (0 errors, 0 warnings) 🎯 Key Achievements: - 28 files modified/created - Three-Tier Fallback System (stability) - SSOT Provider Registry (extensibility) - ENV unification (operational clarity) - Error visibility (debugging efficiency) - Code cleanup (maintainability) - Comprehensive documentation (Phase 22 ready) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
45
tools/test_filebox_fallback_smoke.sh
Normal file
45
tools/test_filebox_fallback_smoke.sh
Normal file
@ -0,0 +1,45 @@
|
||||
#!/bin/bash
|
||||
# FileBox Fallback Smoke Test
|
||||
# Tests all three NYASH_FILEBOX_MODE modes: auto, core-ro, plugin-only
|
||||
|
||||
set -e
|
||||
|
||||
# Build first
|
||||
echo "=== Building hakorune ==="
|
||||
cargo build --release
|
||||
|
||||
HAKO="./target/release/hakorune"
|
||||
TEST_FILE="local_tests/test_filebox_fallback.hako"
|
||||
|
||||
# Test 1: Auto mode (default) - should fallback to builtin
|
||||
echo ""
|
||||
echo "=== Test 1: Auto mode (default, plugins disabled) ==="
|
||||
if NYASH_DISABLE_PLUGINS=1 NYASH_FILEBOX_MODE=auto "$HAKO" "$TEST_FILE" 2>&1 | grep -E "FileBox.*builtin.*core-ro.*fallback|created successfully"; then
|
||||
echo "✓ Test 1 passed: Auto mode uses builtin fallback"
|
||||
else
|
||||
echo "✗ Test 1 failed"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Test 2: Core-ro mode - should use builtin directly
|
||||
echo ""
|
||||
echo "=== Test 2: Core-ro mode ==="
|
||||
if NYASH_DISABLE_PLUGINS=1 NYASH_FILEBOX_MODE=core-ro "$HAKO" "$TEST_FILE" 2>&1 | grep -E "FileBox.*builtin.*core-ro|created successfully"; then
|
||||
echo "✓ Test 2 passed: Core-ro mode uses builtin"
|
||||
else
|
||||
echo "✗ Test 2 failed"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Test 3: Plugin-only mode - should fail when plugins disabled
|
||||
echo ""
|
||||
echo "=== Test 3: Plugin-only mode (should fail) ==="
|
||||
if ! NYASH_DISABLE_PLUGINS=1 NYASH_FILEBOX_MODE=plugin-only "$HAKO" "$TEST_FILE" 2>&1; then
|
||||
echo "✓ Test 3 passed: Plugin-only mode correctly fails when plugins disabled"
|
||||
else
|
||||
echo "✗ Test 3 failed: Plugin-only mode should have failed"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
echo ""
|
||||
echo "=== All fallback tests passed! ==="
|
||||
Reference in New Issue
Block a user