feat(llvm): Phase 132 - Pattern 1 exit value parity fix + Box-First refactoring

## Phase 132: Exit PHI Value Parity Fix

### Problem
Pattern 1 (Simple While) returned 0 instead of final loop variable value (3)
- VM: RC: 3  (correct)
- LLVM: Result: 0  (wrong)

### Root Cause (Two Layers)
1. **JoinIR/Boundary**: Missing exit_bindings → ExitLineReconnector not firing
2. **LLVM Python**: block_end_values snapshot dropping PHI values

### Fix
**JoinIR** (simple_while_minimal.rs):
- Jump(k_exit, [i_param]) passes exit value

**Boundary** (pattern1_minimal.rs):
- Added LoopExitBinding with carrier_name="i", role=LoopState
- Enables ExitLineReconnector to update variable_map

**LLVM** (block_lower.py):
- Use predeclared_ret_phis for reliable PHI filtering
- Protect builder.vmap PHIs from overwrites (SSOT principle)

### Result
-  VM: RC: 3
-  LLVM: Result: 3
-  VM/LLVM parity achieved

## Phase 132-Post: Box-First Refactoring

### Rust Side
**JoinModule::require_function()** (mod.rs):
- Encapsulate function search logic
- 10 lines → 1 line (90% reduction)
- Reusable for Pattern 2-5

### Python Side
**PhiManager Box** (phi_manager.py - new):
- Centralized PHI lifecycle management
- 47 lines → 8 lines (83% reduction)
- SSOT: builder.vmap owns PHIs
- Fail-Fast: No silent overwrites

**Integration**:
- LLVMBuilder: Added phi_manager
- block_lower.py: Delegated to PhiManager
- tagging.py: Register PHIs with manager

### Documentation
**New Files**:
- docs/development/architecture/exit-phi-design.md
- docs/development/current/main/investigations/phase132-llvm-exit-phi-wrong-result.md
- docs/development/current/main/phases/phase-132/

**Updated**:
- docs/development/current/main/10-Now.md
- docs/development/current/main/phase131-3-llvm-lowering-inventory.md

### Design Principles
- Box-First: Logic encapsulated in classes/methods
- SSOT: Single Source of Truth (builder.vmap for PHIs)
- Fail-Fast: Early explicit failures, no fallbacks
- Separation of Concerns: 3-layer architecture

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
nyash-codex
2025-12-15 03:17:31 +09:00
parent a955dd6b18
commit 447d4ea246
16 changed files with 669 additions and 54 deletions

View File

@ -0,0 +1,66 @@
# Phase 132: Exit Values Parity (VM == LLVM)
**Date**: 2025-12-15
**Status**: ✅ Done
**Scope**: Pattern 1Simple Whileで「ループ終了後の `return i`」が VM/LLVM で一致することを固定する
---
## 背景
最小ケース:
```nyash
static box Main {
main() {
local i = 0
loop(i < 3) { i = i + 1 }
return i // 期待: 3
}
}
```
- VM: `RC: 3`
- LLVM: `Result: 0` ❌(修正前)
---
## 根本原因2層
### 1) JoinIR/Boundary 層: exit 値が境界を通っていない
- Pattern 1 の JoinIR で `k_exit` に渡す args が空のままだと、exit 側でホストの `variable_map["i"]` が更新されない。
- その結果 `return i` が初期値0を返し得る。
### 2) LLVM Python 層: PHI の SSOT が壊れている
- `phi.basic_block` が llvmlite で確定前は `None` になり得るため、PHI を落とす filter を信頼できない。
- `builder.vmap` にある PHI placeholder を、Pass A の “sync created values” が上書きしてしまい、`ret` が PHI ではなく `0` を参照することがある。
---
## 修正内容
### JoinIR/Boundary 層exit 値を明示的に渡す)
- `src/mir/join_ir/lowering/simple_while_minimal.rs`
- `Jump(k_exit, [i_param])` として exit 値を渡す
- `src/mir/builder/control_flow/joinir/patterns/pattern1_minimal.rs`
- `LoopExitBinding` を作成して `with_exit_bindings()` で境界に設定
### LLVM Python 層PHI SSOT を保護する)
- `src/llvm_py/builders/block_lower.py`
- PHI filtering を `predeclared_ret_phis` ベースにし、`phi.basic_block` 依存を排除
- `builder.vmap` の既存 PHIplaceholderを上書きしないPHI を SSOT として保護)
---
## 検証
- `/tmp/p1_return_i.hako` が VM/LLVM で `3` を返す
- `NYASH_LLVM_STRICT=1` でも “miss→0” に落ちないFail-Fast が維持される)
詳細ログ:
- `docs/development/current/main/investigations/phase132-llvm-exit-phi-wrong-result.md`