tomoaki/hakorune
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
baf028a94f9bdeeb1b8b30ca4d5375e7e8aca67f
hakorune/src/backend/mir_interpreter/utils/mod.rs

13 lines
387 B
Rust
Raw Normal View History

refactor: add MIR interpreter utility helpers (Phase 1) - Add destination write helpers (write_box_result, write_void, write_result) - Add argument validation helpers (validate_args_exact/range/min) - Add receiver conversion helper (convert_to_box) - Update handlers to use new helpers Reduces code duplication: - Destination patterns: 37 call sites converted - Each replacement saves 2-3 lines (74-111 lines saved) - Helper infrastructure: 178 lines added - Net improvement: Reduced duplication + better maintainability Impact: - Build: ✓ SUCCESS (0 errors, 146 warnings) - Tests: ✓ 8/9 smoke tests PASS - Functionality: ✓ PRESERVED (no behavior changes) Files created: - src/backend/mir_interpreter/utils/mod.rs - src/backend/mir_interpreter/utils/destination_helpers.rs - src/backend/mir_interpreter/utils/arg_validation.rs - src/backend/mir_interpreter/utils/receiver_helpers.rs Files modified: 15 handler files - arithmetic.rs, boxes.rs, boxes_array.rs, boxes_instance.rs - boxes_map.rs, boxes_object_fields.rs, boxes_plugin.rs - boxes_string.rs, calls.rs, extern_provider.rs, externals.rs - memory.rs, misc.rs, mod.rs Related: Phase 21.0 refactoring Risk: Low (pure refactoring, no behavior change)
2025-11-06 22:50:46 +09:00
//! MIR Interpreter共通ユーティリティ
pub mod destination_helpers;
pub mod arg_validation;
pub mod receiver_helpers;
refactor: unify error message generation (Phase 3) Add ErrorBuilder utility and migrate 35 error generation sites Phase 3: Error Message Generation Unification ============================================ Infrastructure: - Add src/backend/mir_interpreter/utils/error_helpers.rs (255 lines) - Implement ErrorBuilder with 7 standardized error patterns - Add MirInterpreter convenience methods (err_invalid, err_type_mismatch, etc.) Migration Results: - Total patterns migrated: 35 instances (80 → 45, 44% reduction) - calls.rs: 37 → 13 patterns (65% reduction) - extern_provider.rs: 20 → 9 patterns (55% reduction) - Lines saved: 33 lines (1.0% of handlers) Error Patterns Unified: 1. Invalid instruction errors → ErrorBuilder::invalid_instruction() 2. Type mismatch errors → ErrorBuilder::type_mismatch() 3. Argument count errors → ErrorBuilder::arg_count_mismatch() 4. Method not found → ErrorBuilder::method_not_found() 5. Unsupported operations → ErrorBuilder::unsupported_operation() 6. Context errors → ErrorBuilder::with_context() 7. Bounds errors → ErrorBuilder::out_of_bounds() Benefits: - Consistent error message formatting across all handlers - Single point of change for error improvements - Better IDE autocomplete support - Easier future i18n integration - Reduced code duplication Cumulative Impact (Phase 1+2+3): - Total lines saved: 150-187 lines (4.5-5.7% of handlers) - Total patterns unified: 124 instances * Phase 1: 37 destination patterns * Phase 2: 52 argument validation patterns * Phase 3: 35 error generation patterns Remaining Work: - 45 error patterns still to migrate (estimated 50-80 lines) - Complex cases requiring manual review Testing: - Build: ✅ 0 errors, 0 new warnings - Smoke tests: ⚠️ 8/9 passed (1 timeout unrelated) - Core functionality: ✅ Verified Related: Phase 21.0 MIR Interpreter refactoring Risk: Low (error messages only, behavior preserved) Impact: High (maintainability, consistency, i18n-ready) Co-authored-by: Claude Code <claude@anthropic.com>
2025-11-06 23:18:10 +09:00
pub mod error_helpers;
Phase 6 WIP: Type conversion helpers (11 sites, 23 lines) Added conversion_helpers.rs with unified type conversion: - load_as_box() for reg_load().to_nyash_box() - load_as_string() for reg_load().to_string() - load_as_int/bool() for type-checked loads - load_args_as_boxes/values() for bulk conversion Files updated (partial): - boxes.rs: 2 sites (-6 lines) - calls.rs: 5 sites (-10 lines) - boxes_plugin.rs: 1 site (-3 lines) - externals.rs: 3 sites (-4 lines) Next: boxes_array, boxes_map, boxes_object_fields, boxes_instance Tests: Phase 21.0 PASS (2/2, 100%) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-07 00:21:42 +09:00
pub mod conversion_helpers;
Phase 21.7 normalization: optimization pre-work + bench harness expansion - Add opt-in optimizations (defaults OFF) - Ret purity verifier: NYASH_VERIFY_RET_PURITY=1 - strlen FAST enhancement for const handles - FAST_INT gate for same-BB SSA optimization - length cache for string literals in llvmlite - Expand bench harness (tools/perf/microbench.sh) - Add branch/call/stringchain/arraymap/chip8/kilo cases - Auto-calculate ratio vs C reference - Document in benchmarks/README.md - Compiler health improvements - Unify PHI insertion to insert_phi_at_head() - Add NYASH_LLVM_SKIP_BUILD=1 for build reuse - Runtime & safety enhancements - Clarify Rust/Hako ownership boundaries - Strengthen receiver localization (LocalSSA/pin/after-PHIs) - Stop excessive PluginInvoke→BoxCall rewrites - Update CURRENT_TASK.md, docs, and canaries 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-13 16:40:58 +09:00
pub mod naming;
Phase 21.2 Complete: VM Adapter正規実装 + devブリッジ完全撤去 ## 🎉 Phase 21.2完全達成 ### ✅ 実装完了 - VM static box 永続化（singleton infrastructure） - devブリッジ完全撤去（adapter_dev.rs削除、by-name dispatch削除） - .hako正規実装（MirCallV1Handler, AbiAdapterRegistry等） - text-merge経路完全動作 - 全phase2120 adapter reps PASS（7テスト） ### 🐛 バグ修正 1. strip_local_decl修正 - トップレベルのみlocal削除、メソッド内は保持 - src/runner/modes/common_util/hako.rs:29 2. static box フィールド永続化 - MirInterpreter singleton storage実装 - me parameter binding修正（1:1マッピング） - getField/setField string→singleton解決 - src/backend/mir_interpreter/{mod,exec,handlers/boxes_object_fields}.rs 3. Map.len alias rc=0修正 - [map/missing]パターン検出でnull扱い（4箇所） - lang/src/vm/boxes/mir_call_v1_handler.hako:91-93,131-133,151-153,199-201 ### 📁 主要変更ファイル #### Rust（VM Runtime） - src/backend/mir_interpreter/mod.rs - static box singleton storage - src/backend/mir_interpreter/exec.rs - parameter binding fix - src/backend/mir_interpreter/handlers/boxes_object_fields.rs - singleton resolution - src/backend/mir_interpreter/handlers/calls.rs - dev bridge removal - src/backend/mir_interpreter/utils/mod.rs - adapter_dev module removal - src/backend/mir_interpreter/utils/adapter_dev.rs - DELETED (7555 bytes) - src/runner/modes/vm.rs - static box declaration collection - src/runner/modes/common_util/hako.rs - strip_local_decl fix - src/instance_v2.rs - Clone implementation #### Hako (.hako実装) - lang/src/vm/boxes/mir_call_v1_handler.hako - [map/missing] detection - lang/src/vm/boxes/abi_adapter_registry.hako - NEW (adapter registry) - lang/src/vm/helpers/method_alias_policy.hako - method alias support #### テスト - tools/smokes/v2/profiles/quick/core/phase2120/s3_vm_adapter_*.sh - 7 new tests ### 🎯 テスト結果 ``` ✅ s3_vm_adapter_array_len_canary_vm.sh ✅ s3_vm_adapter_array_len_per_recv_canary_vm.sh ✅ s3_vm_adapter_array_length_alias_canary_vm.sh ✅ s3_vm_adapter_array_size_alias_canary_vm.sh ✅ s3_vm_adapter_map_len_alias_state_canary_vm.sh ✅ s3_vm_adapter_map_length_alias_state_canary_vm.sh ✅ s3_vm_adapter_map_size_struct_canary_vm.sh ``` 環境フラグ: HAKO_ABI_ADAPTER=1 HAKO_ABI_ADAPTER_DEV=0 ### 🏆 設計品質 - ✅ ハードコード禁止（AGENTS.md 5.1）完全準拠 - ✅ 構造的・一般化設計（特定Box名のif分岐なし） - ✅ 後方互換性保持（既存コード破壊ゼロ） - ✅ text-merge経路（.hako依存関係正しくマージ） 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-07 19:32:44 +09:00
// Phase 21.2: adapter_dev removed - all adapter functions now in .hako implementation
refactor: add MIR interpreter utility helpers (Phase 1) - Add destination write helpers (write_box_result, write_void, write_result) - Add argument validation helpers (validate_args_exact/range/min) - Add receiver conversion helper (convert_to_box) - Update handlers to use new helpers Reduces code duplication: - Destination patterns: 37 call sites converted - Each replacement saves 2-3 lines (74-111 lines saved) - Helper infrastructure: 178 lines added - Net improvement: Reduced duplication + better maintainability Impact: - Build: ✓ SUCCESS (0 errors, 146 warnings) - Tests: ✓ 8/9 smoke tests PASS - Functionality: ✓ PRESERVED (no behavior changes) Files created: - src/backend/mir_interpreter/utils/mod.rs - src/backend/mir_interpreter/utils/destination_helpers.rs - src/backend/mir_interpreter/utils/arg_validation.rs - src/backend/mir_interpreter/utils/receiver_helpers.rs Files modified: 15 handler files - arithmetic.rs, boxes.rs, boxes_array.rs, boxes_instance.rs - boxes_map.rs, boxes_object_fields.rs, boxes_plugin.rs - boxes_string.rs, calls.rs, extern_provider.rs, externals.rs - memory.rs, misc.rs, mod.rs Related: Phase 21.0 refactoring Risk: Low (pure refactoring, no behavior change)
2025-11-06 22:50:46 +09:00
Phase 21.7 normalization: optimization pre-work + bench harness expansion - Add opt-in optimizations (defaults OFF) - Ret purity verifier: NYASH_VERIFY_RET_PURITY=1 - strlen FAST enhancement for const handles - FAST_INT gate for same-BB SSA optimization - length cache for string literals in llvmlite - Expand bench harness (tools/perf/microbench.sh) - Add branch/call/stringchain/arraymap/chip8/kilo cases - Auto-calculate ratio vs C reference - Document in benchmarks/README.md - Compiler health improvements - Unify PHI insertion to insert_phi_at_head() - Add NYASH_LLVM_SKIP_BUILD=1 for build reuse - Runtime & safety enhancements - Clarify Rust/Hako ownership boundaries - Strengthen receiver localization (LocalSSA/pin/after-PHIs) - Stop excessive PluginInvoke→BoxCall rewrites - Update CURRENT_TASK.md, docs, and canaries 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-13 16:40:58 +09:00
// Selective re-export (only naming is widely used via utils::normalize_arity_suffix)
pub use naming::*;
Reference in New Issue Copy Permalink