hakorune/tools/plugin-tester/src/main.rs

//! Nyash Plugin Tester v2 - nyash.toml中心設計対応版
//! 
//! 究極のシンプル設計:
//! - Host VTable廃止
//! - nyash_plugin_invokeのみ使用
//! - すべてのメタ情報はnyash.tomlから取得

use clap::{Parser, Subcommand};
use colored::*;
use libloading::{Library, Symbol};
use serde::Deserialize;
use std::collections::HashMap;
use std::fs;
use std::path::{Path, PathBuf};

// ============ nyash.toml v2 Types ============

#[derive(Debug, Deserialize)]
struct NyashConfigV2 {
    libraries: HashMap<String, LibraryDefinition>,
}

#[derive(Debug, Deserialize)]
struct LibraryDefinition {
    boxes: Vec<String>,
    path: String,
}

#[derive(Debug, Deserialize)]
struct BoxTypeConfig {
    type_id: u32,
    #[serde(default = "default_abi_version")]
    abi_version: u32,
    methods: HashMap<String, MethodDefinition>,
}

fn default_abi_version() -> u32 { 1 }

#[derive(Debug, Deserialize)]
struct MethodDefinition {
    method_id: u32,
}

// ============ CLI ============

#[derive(Parser)]
#[command(name = "plugin-tester-v2")]
#[command(about = "Nyash plugin testing tool v2 - nyash.toml centric", long_about = None)]
struct Args {
    #[command(subcommand)]
    command: Commands,
}

#[derive(Subcommand)]
enum Commands {
    /// Check plugin with nyash.toml v2
    Check {
        /// Path to nyash.toml file
        #[arg(short, long, default_value = "../../nyash.toml")]
        config: PathBuf,
        
        /// Library name (e.g., "libnyash_filebox_plugin.so")
        #[arg(short, long)]
        library: Option<String>,
    },
    /// Test Box lifecycle with nyash.toml v2
    Lifecycle {
        /// Path to nyash.toml file
        #[arg(short, long, default_value = "../../nyash.toml")]
        config: PathBuf,
        
        /// Box type name (e.g., "FileBox")
        box_type: String,
    },
    /// Validate all plugins in nyash.toml
    ValidateAll {
        /// Path to nyash.toml file
        #[arg(short, long, default_value = "../../nyash.toml")]
        config: PathBuf,
    },
    /// Phase 15.5: Safety check with ChatGPT recommended features
    SafetyCheck {
        /// Path to nyash.toml file
        #[arg(short, long, default_value = "../../nyash.toml")]
        config: PathBuf,

        /// Library name to check (optional, checks all if not specified)
        #[arg(short, long)]
        library: Option<String>,

        /// Box type to check (optional, checks all if not specified)
        #[arg(short, long)]
        box_type: Option<String>,
    },
}

// ============ TLV Helpers ============

fn tlv_encode_empty() -> Vec<u8> {
    vec![1, 0, 0, 0]  // version=1, argc=0
}

fn tlv_encode_one_handle(type_id: u32, instance_id: u32) -> Vec<u8> {
    // BID-1 TLV header: u16 ver=1, u16 argc=1
    // Entry: tag=8(Handle), rsv=0, size=u16(8), payload=[type_id(4), instance_id(4)]
    let mut buf = Vec::with_capacity(4 + 4 + 8);
    buf.extend_from_slice(&1u16.to_le_bytes()); // ver
    buf.extend_from_slice(&1u16.to_le_bytes()); // argc
    buf.push(8u8); // tag=Handle
    buf.push(0u8); // reserved
    buf.extend_from_slice(&(8u16).to_le_bytes()); // size
    buf.extend_from_slice(&type_id.to_le_bytes());
    buf.extend_from_slice(&instance_id.to_le_bytes());
    buf
}

fn tlv_encode_two_strings(a: &str, b: &str) -> Vec<u8> {
    let ab = a.as_bytes();
    let bb = b.as_bytes();
    let mut buf = Vec::with_capacity(4 + 2 * (4 + ab.len().min(u16::MAX as usize)));
    buf.extend_from_slice(&1u16.to_le_bytes()); // ver
    buf.extend_from_slice(&2u16.to_le_bytes()); // argc=2
    // first string
    buf.push(6u8); buf.push(0u8);
    buf.extend_from_slice(&((ab.len().min(u16::MAX as usize) as u16).to_le_bytes()));
    buf.extend_from_slice(ab);
    // second string
    buf.push(6u8); buf.push(0u8);
    buf.extend_from_slice(&((bb.len().min(u16::MAX as usize) as u16).to_le_bytes()));
    buf.extend_from_slice(bb);
    buf
}

fn tlv_encode_bytes(data: &[u8]) -> Vec<u8> {
    let mut buf = Vec::with_capacity(4 + 4 + data.len());
    buf.extend_from_slice(&1u16.to_le_bytes()); // ver
    buf.extend_from_slice(&1u16.to_le_bytes()); // argc=1
    buf.push(7u8); buf.push(0u8);
    buf.extend_from_slice(&((data.len().min(u16::MAX as usize) as u16).to_le_bytes()));
    buf.extend_from_slice(data);
    buf
}

fn tlv_decode_u32(data: &[u8]) -> Result<u32, String> {
    if data.len() >= 4 {
        Ok(u32::from_le_bytes([data[0], data[1], data[2], data[3]]))
    } else {
        Err("Buffer too short for u32".to_string())
    }
}

// ============ Main Functions ============

fn main() {
    let args = Args::parse();
    
    match args.command {
        Commands::Check { config, library } => check_v2(&config, library.as_deref()),
        Commands::Lifecycle { config, box_type } => test_lifecycle_v2(&config, &box_type),
        Commands::ValidateAll { config } => validate_all(&config),
        Commands::SafetyCheck { config, library, box_type } => {
            safety_check_v2(&config, library.as_deref(), box_type.as_deref())
        }
    }
}

fn resolve_plugin_path(base: &Path, raw: &str) -> PathBuf {
    let candidate = if Path::new(raw).is_absolute() { PathBuf::from(raw) } else { base.join(raw) };
    if candidate.exists() {
        return candidate;
    }
    // If missing, try appending platform-specific extension
    let ext = if cfg!(target_os = "windows") { "dll" } else if cfg!(target_os = "macos") { "dylib" } else { "so" };
    let mut with_ext = candidate.clone();
    if with_ext.extension().is_none() {
        with_ext.set_extension(ext);
    } else {
        // If an extension exists but file is missing, try replacing it
        with_ext.set_extension(ext);
    }
    with_ext
}

fn check_v2(config_path: &PathBuf, library_filter: Option<&str>) {
    println!("{}", "=== Plugin Check v2 (nyash.toml centric) ===".bold());
    
    // Load nyash.toml v2
    let config_content = match fs::read_to_string(config_path) {
        Ok(content) => content,
        Err(e) => {
            eprintln!("{}: Failed to read config: {}", "ERROR".red(), e);
            return;
        }
    };
    
    let config: NyashConfigV2 = match toml::from_str(&config_content) {
        Ok(cfg) => cfg,
        Err(e) => {
            eprintln!("{}: Failed to parse nyash.toml v2: {}", "ERROR".red(), e);
            return;
        }
    };
    
    println!("{}: Loaded {} libraries from nyash.toml", "✓".green(), config.libraries.len());
    
    // Also parse raw TOML for nested box configs
    let raw_config: toml::Value = match toml::from_str(&config_content) {
        Ok(val) => val,
        Err(e) => {
            eprintln!("{}: Failed to parse TOML value: {}", "ERROR".red(), e);
            return;
        }
    };
    
    // Base dir for relative plugin paths
    let config_base = config_path.parent().unwrap_or(Path::new("."));

    // Check each library
    for (lib_name, lib_def) in &config.libraries {
        if let Some(filter) = library_filter {
            if lib_name != filter {
                continue;
            }
        }
        
        println!("\n{}: {}", "Library".bold(), lib_name.cyan());
        println!("  Path: {}", lib_def.path);
        println!("  Box types: {:?}", lib_def.boxes);
        
        // Try to load the plugin
        let lib_path = resolve_plugin_path(config_base, &lib_def.path);
        let library = match unsafe { Library::new(&lib_path) } {
            Ok(lib) => lib,
            Err(e) => {
                eprintln!("  {}: Failed to load: {} (path: {})", "ERROR".red(), e, lib_path.display());
                continue;
            }
        };
        
        println!("  {}: Plugin loaded successfully", "✓".green());
        
        // Check for nyash_plugin_invoke (the only required function!)
        match unsafe { library.get::<Symbol<unsafe extern "C" fn(u32, u32, u32, *const u8, usize, *mut u8, *mut usize) -> i32>>(b"nyash_plugin_invoke") } {
            Ok(_) => println!("  {}: nyash_plugin_invoke found", "✓".green()),
            Err(_) => {
                eprintln!("  {}: nyash_plugin_invoke NOT FOUND - not a valid v2 plugin!", "ERROR".red());
                continue;
            }
        }
        
        // Check each box type from nyash.toml
        for box_name in &lib_def.boxes {
            println!("\n  {}: {}", "Box Type".bold(), box_name.cyan());
            
            // Get box config from nested TOML
            let box_config = get_box_config(&raw_config, lib_name, box_name);
            
            if let Some(config) = box_config {
                println!("    Type ID: {}", config.type_id);
                println!("    ABI Version: {}", config.abi_version);
                println!("    Methods: {}", config.methods.len());
                
                // List methods
                for (method_name, method_def) in &config.methods {
                    let method_type = match method_def.method_id {
                        0 => " (constructor)".yellow(),
                        4294967295 => " (destructor)".yellow(),
                        _ => "".normal(),
                    };
                    
                    println!("    - {}: method_id={}{}", 
                        method_name, 
                        method_def.method_id,
                        method_type
                    );
                }
            } else {
                eprintln!("    {}: No configuration found for this box type", "WARNING".yellow());
            }
        }
    }
    
    println!("\n{}", "Check completed!".green().bold());
}

fn test_lifecycle_v2(config_path: &PathBuf, box_type: &str) {
    println!("{}", "=== Lifecycle Test v2 ===".bold());
    println!("Box type: {}", box_type.cyan());
    
    // Load nyash.toml
    let config_content = match fs::read_to_string(config_path) {
        Ok(content) => content,
        Err(e) => {
            eprintln!("{}: Failed to read config: {}", "ERROR".red(), e);
            return;
        }
    };
    
    let config: NyashConfigV2 = match toml::from_str(&config_content) {
        Ok(cfg) => cfg,
        Err(e) => {
            eprintln!("{}: Failed to parse nyash.toml: {}", "ERROR".red(), e);
            return;
        }
    };
    
    let raw_config: toml::Value = toml::from_str(&config_content).unwrap();
    
    // Find library that provides this box type
    let (lib_name, lib_def) = match find_library_for_box(&config, box_type) {
        Some((name, def)) => (name, def),
        None => {
            eprintln!("{}: Box type '{}' not found in nyash.toml", "ERROR".red(), box_type);
            return;
        }
    };
    
    println!("Found in library: {}", lib_name.cyan());
    
    // Get box configuration
    let box_config = match get_box_config(&raw_config, lib_name, box_type) {
        Some(cfg) => cfg,
        None => {
            eprintln!("{}: No configuration for box type", "ERROR".red());
            return;
        }
    };
    
    println!("Type ID: {}", box_config.type_id);
    
    // Resolve plugin path relative to config dir
    let config_base = config_path.parent().unwrap_or(Path::new("."));
    let lib_path = resolve_plugin_path(config_base, &lib_def.path);

    // Load plugin
    let library = match unsafe { Library::new(&lib_path) } {
        Ok(lib) => lib,
        Err(e) => {
            eprintln!("{}: Failed to load plugin: {} (path: {})", "ERROR".red(), e, lib_path.display());
            return;
        }
    };
    
    // Get invoke function
    let invoke_fn: Symbol<unsafe extern "C" fn(u32, u32, u32, *const u8, usize, *mut u8, *mut usize) -> i32> = 
        match unsafe { library.get(b"nyash_plugin_invoke") } {
            Ok(f) => f,
            Err(_) => {
                eprintln!("{}: nyash_plugin_invoke not found", "ERROR".red());
                return;
            }
        };
    
    unsafe {
        // Test birth
        println!("\n{}", "1. Testing birth (constructor)...".cyan());
        
        let args = tlv_encode_empty();  // No arguments for FileBox birth
        let mut result_buf = vec![0u8; 1024];
        let mut result_len = result_buf.len();
        
        let result = invoke_fn(
            box_config.type_id,
            0, // method_id = 0 (birth)
            0, // instance_id = 0 (static/birth)
            args.as_ptr(),
            args.len(),
            result_buf.as_mut_ptr(),
            &mut result_len
        );
        
        if result != 0 {
            eprintln!("{}: Birth failed with code {}", "ERROR".red(), result);
            return;
        }
        
        // Parse instance_id from result
        let instance_id = match tlv_decode_u32(&result_buf[..result_len]) {
            Ok(id) => id,
            Err(e) => {
                eprintln!("{}: Failed to decode instance_id: {}", "ERROR".red(), e);
                return;
            }
        };
        
        println!("{}: Birth successful, instance_id = {}", "✓".green(), instance_id);

        // 1b. Open the first instance (if open exists)
        if let Some(open_def) = box_config.methods.get("open") {
            println!("\n{}", "1b. Opening src FileBox (id=instance_id) ...".cyan());
            let args_open = tlv_encode_two_strings("test_lifecycle.txt", "w");
            let mut out = vec![0u8; 1024];
            let mut out_len = out.len();
            let rc = invoke_fn(box_config.type_id, open_def.method_id, instance_id, args_open.as_ptr(), args_open.len(), out.as_mut_ptr(), &mut out_len);
            if rc == 0 { println!("{}: open ok", "✓".green()); } else { eprintln!("{}: open rc={}", "WARN".yellow(), rc); }
        }

        // 1c. Write some bytes (if write exists)
        if let Some(write_def) = box_config.methods.get("write") {
            println!("\n{}", "1c. Writing to src FileBox ...".cyan());
            let args_write = tlv_encode_bytes(b"hello nyash");
            let mut out = vec![0u8; 1024];
            let mut out_len = out.len();
            let rc = invoke_fn(box_config.type_id, write_def.method_id, instance_id, args_write.as_ptr(), args_write.len(), out.as_mut_ptr(), &mut out_len);
            if rc == 0 { println!("{}: write ok", "✓".green()); } else { eprintln!("{}: write rc={}", "WARN".yellow(), rc); }
        }

        // 1d. Create destination instance via cloneSelf() if available; else birth
        let mut dst_id = None;
        if let Some(clone_def) = box_config.methods.get("cloneSelf") {
            println!("\n{}", "1d. Cloning via cloneSelf() ...".cyan());
            let args0 = tlv_encode_empty();
            let mut out = vec![0u8; 1024];
            let mut out_len = out.len();
            let rc = invoke_fn(box_config.type_id, clone_def.method_id, instance_id, args0.as_ptr(), args0.len(), out.as_mut_ptr(), &mut out_len);
            if rc == 0 && out_len >= 16 && out[4] == 8 { // Handle
                // parse handle payload at bytes 8..16
                let t = u32::from_le_bytes([out[8],out[9],out[10],out[11]]);
                let i = u32::from_le_bytes([out[12],out[13],out[14],out[15]]);
                if t == box_config.type_id { dst_id = Some(i); println!("{}: cloneSelf returned id={}", "✓".green(), i); }
            } else { eprintln!("{}: cloneSelf rc={}", "WARN".yellow(), rc); }
        }
        if dst_id.is_none() {
            println!("\n{}", "1d. Cloning fallback via birth() ...".cyan());
            let args0 = tlv_encode_empty();
            let mut out = vec![0u8; 1024];
            let mut out_len = out.len();
            let rc = invoke_fn(box_config.type_id, 0, 0, args0.as_ptr(), args0.len(), out.as_mut_ptr(), &mut out_len);
            if rc == 0 { dst_id = tlv_decode_u32(&out[..out_len]).ok(); }
            if let Some(i) = dst_id { println!("{}: birth dst id={}", "✓".green(), i); } else { eprintln!("{}: birth dst failed rc={}", "WARN".yellow(), rc); }
        }

        // 1e. copyFrom(dst <- src)
        if let (Some(copy_def), Some(dst)) = (box_config.methods.get("copyFrom"), dst_id) {
            println!("\n{}", "1e. Testing copyFrom(dst <- src) ...".cyan());
            let arg_buf = tlv_encode_one_handle(box_config.type_id, instance_id);
            let mut out = vec![0u8; 1024];
            let mut out_len = out.len();
            let rc = invoke_fn(box_config.type_id, copy_def.method_id, dst, arg_buf.as_ptr(), arg_buf.len(), out.as_mut_ptr(), &mut out_len);
            if rc == 0 { println!("{}: copyFrom ok", "✓".green()); } else { eprintln!("{}: copyFrom rc={}", "WARN".yellow(), rc); }
        }

        // 1f. close both
        if let Some(close_def) = box_config.methods.get("close") {
            println!("\n{}", "1f. Closing both instances ...".cyan());
            let args0 = tlv_encode_empty();
            let mut out = vec![0u8; 64];
            let mut out_len = out.len();
            let _ = invoke_fn(box_config.type_id, close_def.method_id, instance_id, args0.as_ptr(), args0.len(), out.as_mut_ptr(), &mut out_len);
            if let Some(dst) = dst_id {
                out_len = out.len();
                let _ = invoke_fn(box_config.type_id, close_def.method_id, dst, args0.as_ptr(), args0.len(), out.as_mut_ptr(), &mut out_len);
            }
            println!("{}: close done", "✓".green());
        }

        // Optional: If method 'cloneSelf' exists, call it and verify Handle return
        if box_config.methods.contains_key("cloneSelf") {
            println!("\n{}", "1c. Testing method returning Box: cloneSelf() ...".cyan());
            let args0 = tlv_encode_empty();
            let mut out = vec![0u8; 1024];
            let mut out_len = out.len();
            let method_id = box_config.methods.get("cloneSelf").unwrap().method_id;
            let rc = invoke_fn(
                box_config.type_id,
                method_id,
                instance_id,
                args0.as_ptr(),
                args0.len(),
                out.as_mut_ptr(),
                &mut out_len,
            );
            if rc == 0 {
                // Parse TLV header + entry, expecting tag=8 size=8
                if out_len >= 12 && out[4] == 8 && out[7] as usize == 8 { // simplistic check
                    println!("{}: cloneSelf returned a Handle (tag=8)", "✓".green());
                } else {
                    eprintln!("{}: cloneSelf returned unexpected format", "WARN".yellow());
                }
            } else {
                eprintln!("{}: cloneSelf call failed (rc={})", "WARN".yellow(), rc);
            }
        }
        
        // Test fini
        println!("\n{}", "2. Testing fini (destructor)...".cyan());
        
        result_len = result_buf.len();
        let result = invoke_fn(
            box_config.type_id,
            4294967295, // method_id = 0xFFFFFFFF (fini)
            instance_id,
            args.as_ptr(),
            args.len(),
            result_buf.as_mut_ptr(),
            &mut result_len
        );
        
        if result != 0 {
            eprintln!("{}: Fini failed with code {}", "ERROR".red(), result);
        } else {
            println!("{}: Fini successful", "✓".green());
        }
    }
    
    println!("\n{}", "Lifecycle test completed!".green().bold());
}

fn validate_all(config_path: &PathBuf) {
    println!("{}", "=== Validate All Plugins ===".bold());
    check_v2(config_path, None);
}

// ============ Phase 15.5: Safety Check Functions ============

/// Phase 15.5: ChatGPT recommended safety check with 4 core features
fn safety_check_v2(config_path: &PathBuf, library_filter: Option<&str>, box_type_filter: Option<&str>) {
    println!("{}", "=== Plugin Safety Check v2 (ChatGPT Recommended Features) ===".bold());
    println!("🛡️  Checking: Universal Slot Conflicts, E_METHOD Detection, TLV Response, StringBox Issues");

    // Load configuration
    let (config, raw_config) = match load_config(config_path) {
        Ok((cfg, raw)) => (cfg, raw),
        Err(e) => {
            eprintln!("{}: {}", "ERROR".red(), e);
            return;
        }
    };

    let config_base = config_path.parent().unwrap_or(Path::new("."));
    let mut total_issues = 0;
    let mut total_checks = 0;

    // Check each library
    for (lib_name, lib_def) in &config.libraries {
        if let Some(filter) = library_filter {
            if lib_name != filter {
                continue;
            }
        }

        println!("\n{}: {}", "Library".bold(), lib_name.cyan());

        // Check each box type
        for box_name in &lib_def.boxes {
            if let Some(filter) = box_type_filter {
                if box_name != filter {
                    continue;
                }
            }

            println!("\n  {}: {}", "Box Type".bold(), box_name.yellow());

            let box_config = match get_box_config(&raw_config, lib_name, box_name) {
                Some(cfg) => cfg,
                None => {
                    eprintln!("    {}: No configuration found", "WARNING".yellow());
                    continue;
                }
            };

            // Perform 4 safety checks
            let issues = perform_safety_checks(&box_config, lib_name, box_name, &lib_def, config_base);
            total_issues += issues;
            total_checks += 1;
        }
    }

    // Summary
    println!("\n{}", "=== Safety Check Summary ===".bold());
    println!("📊 Checked: {} box types", total_checks);
    if total_issues == 0 {
        println!("✅ {}: All safety checks passed!", "SUCCESS".green().bold());
    } else {
        println!("🚨 {}: {} issues found", "ISSUES".red().bold(), total_issues);
        println!("   Please review and fix the issues above");
    }
}

/// Load and parse nyash.toml configuration
fn load_config(config_path: &PathBuf) -> Result<(NyashConfigV2, toml::Value), String> {
    let config_content = fs::read_to_string(config_path)
        .map_err(|e| format!("Failed to read config: {}", e))?;

    let config: NyashConfigV2 = toml::from_str(&config_content)
        .map_err(|e| format!("Failed to parse nyash.toml v2: {}", e))?;

    let raw_config: toml::Value = toml::from_str(&config_content)
        .map_err(|e| format!("Failed to parse TOML value: {}", e))?;

    Ok((config, raw_config))
}

/// Perform all 4 ChatGPT recommended safety checks
fn perform_safety_checks(
    box_config: &BoxTypeConfig,
    lib_name: &str,
    box_name: &str,
    lib_def: &LibraryDefinition,
    config_base: &Path
) -> u32 {
    let mut issues = 0;

    // 1. Universal Slot Conflicts Check
    issues += check_universal_slot_conflicts(&box_config.methods, box_name);

    // 2. StringBox Specific Issues Check
    if box_name == "StringBox" {
        issues += check_stringbox_issues(&box_config.methods);
    }

    // 3. E_METHOD Detection (requires plugin loading)
    issues += check_e_method_detection(box_config, lib_def, config_base);

    // 4. TLV Response Validation (requires plugin loading)
    issues += check_tlv_response_validation(box_config, lib_def, config_base);

    if issues == 0 {
        println!("    ✅ All safety checks passed");
    }

    issues
}

/// Check #1: Universal Slot Conflicts (0-3 reserved)
fn check_universal_slot_conflicts(methods: &HashMap<String, MethodDefinition>, box_name: &str) -> u32 {
    let mut issues = 0;

    // Universal slot definitions (from MIR slot_registry.rs)
    let universal_slots = [
        (0, "toString"),
        (1, "type"),
        (2, "equals"),
        (3, "clone"),
    ];

    for (method_name, method_def) in methods {
        for (slot_id, universal_name) in &universal_slots {
            if method_def.method_id == *slot_id {
                if method_name != universal_name {
                    eprintln!("    🚨 {}: Method '{}' claims universal slot {} (reserved for '{}')",
                        "UNIVERSAL SLOT CONFLICT".red().bold(),
                        method_name, slot_id, universal_name);
                    eprintln!("       Fix: Change method_id in nyash.toml to {} or higher", 4);
                    issues += 1;
                } else {
                    println!("    ✅ Universal slot {}: {} correctly assigned", slot_id, universal_name);
                }
            }
        }
    }

    issues
}

/// Check #2: StringBox Specific Issues (the problem we discovered!)
fn check_stringbox_issues(methods: &HashMap<String, MethodDefinition>) -> u32 {
    let mut issues = 0;

    // Check for the exact issue we found: get=1, set=2 conflicts
    if let Some(get_method) = methods.get("get") {
        if get_method.method_id <= 3 {
            eprintln!("    🚨 {}: StringBox.get() uses method_id {} (universal slot!)",
                "STRINGBOX ISSUE".red().bold(), get_method.method_id);
            eprintln!("       This is the exact bug we found! WebChatGPT worked because it used different IDs");
            eprintln!("       Fix: Change get method_id to 4 or higher");
            issues += 1;
        }
    }

    if let Some(set_method) = methods.get("set") {
        if set_method.method_id <= 3 {
            eprintln!("    🚨 {}: StringBox.set() uses method_id {} (universal slot!)",
                "STRINGBOX ISSUE".red().bold(), set_method.method_id);
            eprintln!("       Fix: Change set method_id to 5 or higher");
            issues += 1;
        }
    }

    if issues == 0 {
        println!("    ✅ StringBox method IDs look good");
    }

    issues
}

/// Check #3: E_METHOD Detection (checks if plugin actually implements declared methods)
fn check_e_method_detection(
    box_config: &BoxTypeConfig,
    lib_def: &LibraryDefinition,
    config_base: &Path
) -> u32 {
    let mut issues = 0;

    // Try to load the plugin
    let lib_path = resolve_plugin_path(config_base, &lib_def.path);
    let library = match unsafe { Library::new(&lib_path) } {
        Ok(lib) => lib,
        Err(e) => {
            eprintln!("    🚨 {}: Cannot load plugin: {} (path: {})",
                "PLUGIN LOAD ERROR".red().bold(), e, lib_path.display());
            return 1;
        }
    };

    // Get invoke function
    let invoke_fn: Symbol<unsafe extern "C" fn(u32, u32, u32, *const u8, usize, *mut u8, *mut usize) -> i32> =
        match unsafe { library.get(b"nyash_plugin_invoke") } {
            Ok(f) => f,
            Err(_) => {
                eprintln!("    🚨 {}: nyash_plugin_invoke not found", "E_METHOD CHECK FAILED".red().bold());
                return 1;
            }
        };

    println!("    🔍 Testing method implementations...");

    // Test each declared method to see if it returns E_METHOD (-3)
    for (method_name, method_def) in &box_config.methods {
        // Skip constructor and destructor for this test
        if method_def.method_id == 0 || method_def.method_id == 4294967295 {
            continue;
        }

        unsafe {
            let args = tlv_encode_empty();
            let mut result_buf = vec![0u8; 64];
            let mut result_len = result_buf.len();

            // Test with a dummy instance (we're just checking if method exists)
            let result = invoke_fn(
                box_config.type_id,
                method_def.method_id,
                999999, // Dummy instance ID
                args.as_ptr(),
                args.len(),
                result_buf.as_mut_ptr(),
                &mut result_len
            );

            match result {
                -3 => {
                    eprintln!("    🚨 {}: Method '{}' (id={}) returns E_METHOD - NOT IMPLEMENTED!",
                        "E_METHOD DETECTED".red().bold(), method_name, method_def.method_id);
                    eprintln!("       This is exactly what caused StringBox.get() to fail!");
                    eprintln!("       Fix: Implement method '{}' in plugin or remove from nyash.toml", method_name);
                    issues += 1;
                }
                -8 => {
                    println!("    ✅ Method '{}' exists (invalid handle, but method found)", method_name);
                }
                0 => {
                    println!("    ✅ Method '{}' exists and works", method_name);
                }
                _ => {
                    println!("    ⚠️  Method '{}' returned code {} (exists but may have issues)", method_name, result);
                }
            }
        }
    }

    issues
}

/// Check #4: TLV Response Validation (checks if methods return proper TLV data)
fn check_tlv_response_validation(
    box_config: &BoxTypeConfig,
    lib_def: &LibraryDefinition,
    config_base: &Path
) -> u32 {
    let mut issues = 0;

    // Try to load the plugin (reuse logic from E_METHOD check)
    let lib_path = resolve_plugin_path(config_base, &lib_def.path);
    let library = match unsafe { Library::new(&lib_path) } {
        Ok(lib) => lib,
        Err(_) => {
            eprintln!("    🚨 {}: Cannot load plugin for TLV validation", "TLV CHECK FAILED".red().bold());
            return 1;
        }
    };

    let invoke_fn: Symbol<unsafe extern "C" fn(u32, u32, u32, *const u8, usize, *mut u8, *mut usize) -> i32> =
        match unsafe { library.get(b"nyash_plugin_invoke") } {
            Ok(f) => f,
            Err(_) => {
                eprintln!("    🚨 {}: nyash_plugin_invoke not found for TLV validation", "TLV CHECK FAILED".red().bold());
                return 1;
            }
        };

    println!("    🔍 Testing TLV response formats...");

    // Test birth method (constructor) for proper TLV Handle response
    if box_config.methods.contains_key("birth") || box_config.methods.values().any(|m| m.method_id == 0) {
        unsafe {
            let args = tlv_encode_empty();
            let mut result_buf = vec![0u8; 1024];
            let mut result_len = result_buf.len();

            let result = invoke_fn(
                box_config.type_id,
                0, // birth method
                0, // static call
                args.as_ptr(),
                args.len(),
                result_buf.as_mut_ptr(),
                &mut result_len
            );

            if result == 0 {
                // Check if response is valid TLV with Handle (tag=8)
                if result_len >= 8 && result_buf[4] == 8 {
                    println!("    ✅ Constructor returns proper TLV Handle (tag=8)");
                } else {
                    eprintln!("    🚨 {}: Constructor returns invalid TLV format (expected Handle tag=8)",
                        "TLV FORMAT ERROR".red().bold());
                    eprintln!("       Got length={}, first_tag={}", result_len,
                        if result_len > 4 { result_buf[4] } else { 0 });
                    issues += 1;
                }
            } else {
                eprintln!("    ⚠️  Constructor failed (code={}), cannot validate TLV", result);
            }
        }
    }

    // Test string-returning methods (should return tag=6 String or tag=7 Bytes)
    let string_methods = ["toString", "type", "get", "toUtf8"];
    for method_name in &string_methods {
        if let Some(method_def) = box_config.methods.get(*method_name) {
            unsafe {
                let args = tlv_encode_empty();
                let mut result_buf = vec![0u8; 1024];
                let mut result_len = result_buf.len();

                let result = invoke_fn(
                    box_config.type_id,
                    method_def.method_id,
                    999999, // Dummy instance
                    args.as_ptr(),
                    args.len(),
                    result_buf.as_mut_ptr(),
                    &mut result_len
                );

                if result == 0 && result_len >= 8 {
                    let tag = result_buf[4];
                    match tag {
                        6 => println!("    ✅ Method '{}' returns String TLV (tag=6)", method_name),
                        7 => println!("    ✅ Method '{}' returns Bytes TLV (tag=7)", method_name),
                        _ => {
                            eprintln!("    🚨 {}: Method '{}' returns unexpected TLV tag {} (expected 6 or 7)",
                                "TLV TYPE ERROR".red().bold(), method_name, tag);
                            issues += 1;
                        }
                    }
                } else if result == -8 {
                    println!("    ⚠️  Method '{}' needs valid instance for TLV test", method_name);
                }
            }
        }
    }

    issues
}

// ============ Helper Functions ============

fn find_library_for_box<'a>(config: &'a NyashConfigV2, box_type: &str) -> Option<(&'a str, &'a LibraryDefinition)> {
    config.libraries.iter()
        .find(|(_, lib)| lib.boxes.contains(&box_type.to_string()))
        .map(|(name, lib)| (name.as_str(), lib))
}

fn get_box_config(raw_config: &toml::Value, lib_name: &str, box_name: &str) -> Option<BoxTypeConfig> {
    raw_config
        .get("libraries")
        .and_then(|v| v.get(lib_name))
        .and_then(|v| v.get(box_name))
        .and_then(|v| v.clone().try_into::<BoxTypeConfig>().ok())
}