tomoaki/hakmem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
ef2d1caa2a2c5f2271a90b43a813c1d70afa3387
hakmem/core
History
Moe Charm (CI) ef2d1caa2a Phase 7-1.3: Simplify HAK_RET_ALLOC macro definition (-35% LOC, -100% #undef) 
Problem:
- Phase 7-1.3 working code had complex #ifndef/#undef pattern
- Bidirectional dependency between hakmem_tiny.c and tiny_alloc_fast.inc.h
- Dangerous #undef usage masking real errors
- 3 levels of #ifdef nesting, hard to understand control flow

Solution:
- Single definition point in core/hakmem_tiny.c (lines 116-152)
- Clear feature flag based selection: #if HAKMEM_TINY_HEADER_CLASSIDX
- Removed duplicate definition and #undef from tiny_alloc_fast.inc.h
- Added clear comment pointing to single definition point

Results:
- -35% lines of code (7 lines deleted)
- -100% #undef usage (eliminated dangerous pattern)
- -33% nesting depth (3 levels → 2 levels)
- Much clearer control flow (single decision point)
- Same performance: 2.63M ops/s Larson, 17.7M ops/s bench_random_mixed

Implementation:
1. core/hakmem_tiny.c: Replaced #ifndef/#undef with #if HAKMEM_TINY_HEADER_CLASSIDX
2. core/tiny_alloc_fast.inc.h: Deleted duplicate macro, added pointer comment

Testing:
- Larson 1T: 2.63M ops/s (expected ~2.73M, within variance)
- bench_random_mixed (128B): 17.7M ops/s (better than before!)
- All builds clean with HEADER_CLASSIDX=1

Recommendation from Task Agent Ultrathink (Option A - Single Definition):
https://github.com/anthropics/claude-code/issues/...

Phase: 7-1.3 (Ifdef Simplification)
Date: 2025-11-08
2025-11-08 11:49:21 +09:00
..
box
Perf: Phase 7-1.3 - Hybrid mincore + Macro fix (+194-333%)
2025-11-08 04:50:41 +09:00
superslab
Phase 7-1 PoC: Region-ID Direct Lookup (+39%~+436% improvement!)
2025-11-08 03:18:17 +09:00
hakmem_ace_controller.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace_controller.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace_metrics.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace_metrics.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace_stats.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace_stats.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace_ucb1.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace_ucb1.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ace.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_batch.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_batch.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_bigcache.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_bigcache.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_build_flags.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_config.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_config.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_debug.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_debug.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_elo.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_elo.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_evo.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_evo.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_features.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_internal.h
Perf: Phase 7-1.3 - Hybrid mincore + Macro fix (+194-333%)
2025-11-08 04:50:41 +09:00
hakmem_l25_pool.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_l25_pool.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_learn_log.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_learn_log.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_learner.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_learner.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_libc.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_mid_mt.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_mid_mt.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_p2.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_p2.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_policy.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_policy.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_pool.c
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
hakmem_pool.c.bak2
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_pool.c.bak3
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_pool.c.refactored
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_pool.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_prof.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_prof.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_site_rules.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_site_rules.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_size_hist.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_size_hist.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_sizeclass_dist.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_sizeclass_dist.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_super_registry.c
Phase 6-2.4: Fix SuperSlab free SEGV: remove guess loop and add memory readability check; add registry atomic consistency (base as _Atomic uintptr_t with acq/rel); add debug toggles (SUPER_REG_DEBUG/REQTRACE); update CURRENT_TASK with results and next steps; capture suite results.
2025-11-07 18:07:48 +09:00
hakmem_super_registry.h
Phase 6-2.4: Fix SuperSlab free SEGV: remove guess loop and add memory readability check; add registry atomic consistency (base as _Atomic uintptr_t with acq/rel); add debug toggles (SUPER_REG_DEBUG/REQTRACE); update CURRENT_TASK with results and next steps; capture suite results.
2025-11-07 18:07:48 +09:00
hakmem_sys.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_sys.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_syscall.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_syscall.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_alloc_new.inc
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_alloc_v3.inc
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_alloc.inc
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_assist.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_background.inc
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_batch_refill.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_bg_bin.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_bg_spill.c
Phase 6-2.3~6-2.5: Critical bug fixes + SuperSlab optimization (WIP)
2025-11-07 20:31:01 +09:00
hakmem_tiny_bg_spill.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_bump.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_config.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_config.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_drain_ema.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_fastcache.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_free.inc
Fix: CRITICAL double-allocation bug in trc_linear_carve()
2025-11-08 01:18:37 +09:00
hakmem_tiny_free.inc.bak
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_hot_pop_v4.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_hot_pop.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_hotmag.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_init.inc
Phase 6-2.3~6-2.5: Critical bug fixes + SuperSlab optimization (WIP)
2025-11-07 20:31:01 +09:00
hakmem_tiny_intel.inc
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_lifecycle.inc
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_magazine.c
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_magazine.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_metadata.inc
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_mini_mag.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_query_api.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_query.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_refill_p0.inc.h
Perf: Optimize remote queue drain to skip when empty
2025-11-08 01:44:24 +09:00
hakmem_tiny_refill.inc.h
Phase 6-2.6: Fix slab_data_start() consistency in refill/validation paths
2025-11-07 22:34:24 +09:00
hakmem_tiny_registry_api.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_registry.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_remote_target.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_remote_target.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_remote.inc
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_rss_api.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_rss.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_sfc.c
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_simple.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_simple.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_slab_mgmt.inc
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_slow.inc
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_smallmag.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_ss_target.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_ss_target.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_stats_api.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_stats.c
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny_stats.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_superslab_constants.h
Phase 6-2.5: Fix SuperSlab alignment bug + refactor constants
2025-11-07 21:45:20 +09:00
hakmem_tiny_superslab.c
Fix: CRITICAL double-allocation bug in trc_linear_carve()
2025-11-08 01:18:37 +09:00
hakmem_tiny_superslab.h
Phase 6-2.8: SuperSlab modular refactoring (665 lines → 104 lines)
2025-11-07 23:05:33 +09:00
hakmem_tiny_tls_list.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_tls_ops.h
Phase 6-2.3~6-2.5: Critical bug fixes + SuperSlab optimization (WIP)
2025-11-07 20:31:01 +09:00
hakmem_tiny_ultra_front.inc.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_tiny_ultra_simple.inc
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hakmem_tiny.c
Phase 7-1.3: Simplify HAK_RET_ALLOC macro definition (-35% LOC, -100% #undef)
2025-11-08 11:49:21 +09:00
hakmem_tiny.h
Phase 7-1 PoC: Region-ID Direct Lookup (+39%~+436% improvement!)
2025-11-08 03:18:17 +09:00
hakmem_trace.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_ucb1.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_whale.c
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem_whale.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
hakmem.c
Phase 6-2.4: Fix SuperSlab free SEGV: remove guess loop and add memory readability check; add registry atomic consistency (base as _Atomic uintptr_t with acq/rel); add debug toggles (SUPER_REG_DEBUG/REQTRACE); update CURRENT_TASK with results and next steps; capture suite results.
2025-11-07 18:07:48 +09:00
hakmem.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
mid_tcache.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
slab_handle.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_alloc_fast_sfc.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_alloc_fast.inc.h
Phase 7-1.3: Simplify HAK_RET_ALLOC macro definition (-35% LOC, -100% #undef)
2025-11-08 11:49:21 +09:00
tiny_api.h
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
tiny_atomic.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
tiny_debug_ring.c
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_debug_ring.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_debug.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
tiny_fastcache.c
Phase 6-2.4: Fix SuperSlab free SEGV: remove guess loop and add memory readability check; add registry atomic consistency (base as _Atomic uintptr_t with acq/rel); add debug toggles (SUPER_REG_DEBUG/REQTRACE); update CURRENT_TASK with results and next steps; capture suite results.
2025-11-07 18:07:48 +09:00
tiny_fastcache.h
Phase 6-8: RDTSC cycle profiling - Critical bottleneck discovered!
2025-11-05 05:44:18 +00:00
tiny_free_fast_v2.inc.h
Perf: Phase 7-1.3 - Hybrid mincore + Macro fix (+194-333%)
2025-11-08 04:50:41 +09:00
tiny_free_fast.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_free_magazine.inc.h
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
tiny_mmap_gate.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_publish.c
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_publish.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
tiny_ready_bg.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_ready.h
Phase 6-2.4: Fix SuperSlab free SEGV: remove guess loop and add memory readability check; add registry atomic consistency (base as _Atomic uintptr_t with acq/rel); add debug toggles (SUPER_REG_DEBUG/REQTRACE); update CURRENT_TASK with results and next steps; capture suite results.
2025-11-07 18:07:48 +09:00
tiny_refill_opt.h
Perf: Make diagnostic logging compile-time disabled in release builds
2025-11-08 01:46:37 +09:00
tiny_refill.h
Phase 6-2.4: Fix SuperSlab free SEGV: remove guess loop and add memory readability check; add registry atomic consistency (base as _Atomic uintptr_t with acq/rel); add debug toggles (SUPER_REG_DEBUG/REQTRACE); update CURRENT_TASK with results and next steps; capture suite results.
2025-11-07 18:07:48 +09:00
tiny_region_id.h
Perf: Phase 7-1.3 - Hybrid mincore + Macro fix (+194-333%)
2025-11-08 04:50:41 +09:00
tiny_remote_bg.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_remote.c
Fix: CRITICAL double-allocation bug in trc_linear_carve()
2025-11-08 01:18:37 +09:00
tiny_remote.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
tiny_route.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_sticky.c
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
tiny_sticky.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00
tiny_superslab_alloc.inc.h
Fix: CRITICAL double-allocation bug in trc_linear_carve()
2025-11-08 01:18:37 +09:00
tiny_superslab_free.inc.h
Phase 7-1 PoC: Region-ID Direct Lookup (+39%~+436% improvement!)
2025-11-08 03:18:17 +09:00
tiny_system.h
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
tiny_tls_guard.h
Phase 6-2.6: Fix slab_data_start() consistency in refill/validation paths
2025-11-07 22:34:24 +09:00
tiny_tls.h
Debug Counters Implementation - Clean History
2025-11-05 12:31:14 +09:00