tomoaki/hakmem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
c2f104618f406d9141844c8d9f5840b8c2d0f6c3
hakmem/core/box
History
Moe Charm (CI) c2f104618f Fix critical TLS drain memory leak causing potential double-free 
## Root Cause

TLS drain was dropping pointers when SuperSlab lookup or slab_idx validation failed:
- Pop pointer from TLS SLL
- Lookup/validation fails
- continue → LEAK! Pointer never returned to any freelist

## Impact

Memory leak + potential double allocation:
1. Pointer P popped but leaked
2. Same address P reallocated from carve/other source
3. User frees P again → duplicate detection → ABORT

## Fix

**Before (BUGGY)**:
```c
if (!ss || invalid_slab_idx) {
    continue;  // ← LEAK!
}
```

**After (FIXED)**:
```c
if (!ss || invalid_slab_idx) {
    // Push back to TLS SLL head (retry later)
    tiny_next_write(class_idx, base, g_tls_sll[class_idx].head);
    g_tls_sll[class_idx].head = base;
    g_tls_sll[class_idx].count++;
    break;  // Stop draining to avoid infinite retry
}
```

## Files Changed

- core/box/tls_sll_drain_box.h: Fix 2 leak sites (SS lookup + slab_idx validation)
- docs/analysis/LARSON_DOUBLE_FREE_INVESTIGATION.md: Investigation report

## Related

- Larson double-free investigation (47% crash rate)
- Commit e4868bf23: Freelist header write + abort() on duplicate
- ChatGPT analysis: Larson benchmark code is correct (no user bug)
2025-11-27 06:49:38 +09:00
..
ace_pool_connector.c
Tiny: fix header/stride mismatch and harden refill paths
2025-11-09 18:55:50 +09:00
ace_pool_connector.h
Tiny: fix header/stride mismatch and harden refill paths
2025-11-09 18:55:50 +09:00
adopt_gate_box.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
bench_fast_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
bench_fast_box.h
Phase 20-2: BenchFast mode - Structural bottleneck analysis (+4.5% ceiling)
2025-11-16 06:36:02 +09:00
capacity_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
capacity_box.d
Phase E3-FINAL: Fix Box API offset bugs - ALL classes now use correct offsets
2025-11-13 06:50:20 +09:00
capacity_box.h
Box API Phase 1-3: Capacity Manager, Carve-Push, Prewarm 実装
2025-11-13 01:45:30 +09:00
carve_push_box.c
Fix: TLS SLL double-free diagnostics - Add error handling and detection improvements
2025-11-22 08:43:18 +09:00
carve_push_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
carve_push_box.h
Box API Phase 1-3: Capacity Manager, Carve-Push, Prewarm 実装
2025-11-13 01:45:30 +09:00
external_guard_box.h
Phase 3d-A: SlabMeta Box boundary - Encapsulate SuperSlab metadata access
2025-11-20 02:01:52 +09:00
free_local_box.c
Code Cleanup: Remove false positives, redundant validations, and reduce verbose logging
2025-11-21 23:00:24 +09:00
free_local_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
free_local_box.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
free_publish_box.c
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
free_publish_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
free_publish_box.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
free_remote_box.c
Code Cleanup: Remove false positives, redundant validations, and reduce verbose logging
2025-11-21 23:00:24 +09:00
free_remote_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
free_remote_box.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
front_gate_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
front_gate_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
front_gate_box.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
front_gate_classifier.c
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
front_gate_classifier.d
ENV Cleanup: Delete Ultra HEAP & BG Remote dead code (-1,096 LOC)
2025-11-27 04:35:47 +09:00
front_gate_classifier.h
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
front_gate_v2.h
Phase 15: Box Separation (partial) - Box headers completed, routing deferred
2025-11-15 22:08:51 +09:00
front_metrics_box.c
ENV cleanup: Add RELEASE guards to DEBUG ENV variables (14 vars)
2025-11-27 03:41:07 +09:00
front_metrics_box.d
Phase 21-1-B: Ring cache Alloc/Free 統合 - C2/C3 hot path integration
2025-11-16 07:51:37 +09:00
front_metrics_box.h
ENV cleanup: Remove obsolete ULTRAHOT variable + organize docs
2025-11-26 17:12:41 +09:00
hak_alloc_api.inc.h
Adaptive CAS: Single-threaded fast path optimization
2025-11-22 03:30:47 +09:00
hak_core_init.inc.h
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
hak_exit_debug.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hak_free_api.inc.h
Phase 15: Box BenchMeta separation + ExternalGuard debug + investigation report
2025-11-15 23:00:21 +09:00
hak_kpi_util.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
hak_wrappers.inc.h
ENV cleanup: Consolidate SFC_DEBUG getenv() calls (86% reduction)
2025-11-27 03:18:33 +09:00
integrity_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
integrity_box.d
Add Box I (Integrity), Box E (Expansion), and comprehensive P0 debugging infrastructure
2025-11-12 02:45:00 +09:00
integrity_box.h
Add Box I (Integrity), Box E (Expansion), and comprehensive P0 debugging infrastructure
2025-11-12 02:45:00 +09:00
mailbox_box.c
ENV cleanup: Add RELEASE guards to DEBUG ENV variables (14 vars)
2025-11-27 03:41:07 +09:00
mailbox_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
mailbox_box.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
pagefault_telemetry_box.c
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
pagefault_telemetry_box.d
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
pagefault_telemetry_box.h
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
pool_api.inc.h
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
pool_init_api.inc.h
release: silence runtime logs and stabilize benches
2025-11-11 01:47:06 +09:00
pool_mf2_adoption.inc.h
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
pool_mf2_helpers.inc.h
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
pool_mf2_types.inc.h
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
pool_mid_desc.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
pool_mid_tc.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
pool_refill.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
pool_stats.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
pool_tls_core.inc.h
CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
2025-11-07 01:27:04 +09:00
pool_tls_types.inc.h
Phase 1: Box Theory refactoring + include reduction
2025-11-06 21:54:12 +09:00
prewarm_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
prewarm_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
prewarm_box.h
Box API Phase 1-3: Capacity Manager, Carve-Push, Prewarm 実装
2025-11-13 01:45:30 +09:00
ptr_conversion_box.h
Phase E3-FINAL: Fix Box API offset bugs - ALL classes now use correct offsets
2025-11-13 06:50:20 +09:00
slab_freelist_atomic.h
Adaptive CAS: Single-threaded fast path optimization
2025-11-22 03:30:47 +09:00
ss_ace_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_ace_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_allocation_box.c
ENV cleanup: Add RELEASE guards to DEBUG ENV variables (14 vars)
2025-11-27 03:41:07 +09:00
ss_allocation_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_cache_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_cache_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_hot_cold_box.h
Phase 12-1.1: EMPTY Slab Detection + Immediate Reuse (+13% improvement, 10.2M→11.5M ops/s)
2025-11-21 04:56:48 +09:00
ss_hot_prewarm_box.c
Phase 26: Front Gate Unification - Tiny allocator fast path (+12.9%)
2025-11-17 05:29:08 +09:00
ss_hot_prewarm_box.d
Phase 21-1-B: Ring cache Alloc/Free 統合 - C2/C3 hot path integration
2025-11-16 07:51:37 +09:00
ss_hot_prewarm_box.h
Phase 19 & 20-1: Frontend optimization + TLS cache prewarm (+16.2% total)
2025-11-16 05:48:59 +09:00
ss_legacy_backend_box.c
Code Cleanup: Remove false positives, redundant validations, and reduce verbose logging
2025-11-21 23:00:24 +09:00
ss_legacy_backend_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_os_acquire_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_os_acquire_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_slab_management_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_slab_management_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_slab_meta_box.h
Phase 1: Atomic Freelist Implementation - MT Safety Foundation
2025-11-22 02:46:57 +09:00
ss_stats_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_stats_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
ss_unified_backend_box.c
Fix C0/C7 class confusion: Upgrade C7 stride to 2048B and fix meta->class_idx initialization
2025-11-21 13:44:05 +09:00
ss_unified_backend_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
superslab_expansion_box.c
Fix C0/C7 class confusion: Upgrade C7 stride to 2048B and fix meta->class_idx initialization
2025-11-21 13:44:05 +09:00
superslab_expansion_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
superslab_expansion_box.h
Add Box I (Integrity), Box E (Expansion), and comprehensive P0 debugging infrastructure
2025-11-12 02:45:00 +09:00
tiny_near_empty_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
tiny_near_empty_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
tiny_next_ptr_box.h
Fix C0/C7 class confusion: Upgrade C7 stride to 2048B and fix meta->class_idx initialization
2025-11-21 13:44:05 +09:00
tiny_sizeclass_hist_box.c
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
tiny_sizeclass_hist_box.d
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
tiny_sizeclass_hist_box.h
Phase 3d-B: TLS Cache Merge - Unified g_tls_sll[] structure (+12-18% expected)
2025-11-20 07:32:30 +09:00
tls_sll_box.h
Larson crash investigation: Add freelist header write + abort() on duplicate
2025-11-27 05:57:22 +09:00
tls_sll_drain_box.h
Fix critical TLS drain memory leak causing potential double-free
2025-11-27 06:49:38 +09:00
ultra_slim_alloc_box.h
Phase 19-2: Ultra SLIM debug logging and root cause analysis
2025-11-22 06:50:38 +09:00
unified_batch_box.c
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00
unified_batch_box.d
Remove dead code: UltraHot, RingCache, FrontC23, Class5 Hotpath
2025-11-26 12:33:49 +09:00
unified_batch_box.h
Phase 23 Unified Cache + PageFaultTelemetry generalization: Mid/VM page-fault bottleneck identified
2025-11-17 02:47:58 +09:00