176bbf6569
Root Cause:
- shared_pool_ensure_capacity_unlocked() used realloc() for metadata
- realloc() → hak_alloc_at(128) → shared_pool_init() → realloc() → INFINITE RECURSION
- Triggered by workset=128 (high memory pressure) but not workset=64
Symptoms:
- bench_fixed_size_hakmem 1 16 128: timeout (infinite hang)
- bench_fixed_size_hakmem 1 1024 128: works fine
- Size-class specific: C1-C3 (16-64B) hung, C7 (1024B) worked
Fix:
- Replace realloc() with direct mmap() for Shared Pool metadata allocation
- Use munmap() to free old mappings (not free()\!)
- Breaks recursion: Shared Pool metadata now allocated outside HAKMEM allocator
Files Modified:
- core/hakmem_shared_pool.c:
* Added sys/mman.h include
* shared_pool_ensure_capacity_unlocked(): realloc → mmap/munmap (40 lines)
- benchmarks/src/fixed/bench_fixed_size.c: (cleanup only, no logic change)
Performance (before → after):
- 16B / workset=128: timeout → 18.5M ops/s ✅ FIXED
- 1024B / workset=128: 4.3M ops/s → 18.5M ops/s (no regression)
- 16B / workset=64: 44M ops/s → 18.5M ops/s (no regression)
Testing:
./out/release/bench_fixed_size_hakmem 10000 256 128
Expected: ~18M ops/s (instant completion)
Before: infinite hang
Commit includes debug trace cleanup (Task agent removed all fprintf debug output).
Phase: 13-C (TinyHeapV2 debugging / Shared Pool stability fix)
110 lines
4.2 KiB
Makefile
110 lines
4.2 KiB
Makefile
hakmem.o: core/hakmem.c core/hakmem.h core/hakmem_build_flags.h \
|
|
core/hakmem_config.h core/hakmem_features.h core/hakmem_internal.h \
|
|
core/hakmem_sys.h core/hakmem_whale.h core/hakmem_bigcache.h \
|
|
core/hakmem_pool.h core/hakmem_l25_pool.h core/hakmem_policy.h \
|
|
core/hakmem_learner.h core/hakmem_size_hist.h core/hakmem_ace.h \
|
|
core/hakmem_site_rules.h core/hakmem_tiny.h core/hakmem_trace.h \
|
|
core/hakmem_tiny_mini_mag.h core/hakmem_tiny_superslab.h \
|
|
core/superslab/superslab_types.h core/hakmem_tiny_superslab_constants.h \
|
|
core/superslab/superslab_inline.h core/superslab/superslab_types.h \
|
|
core/tiny_debug_ring.h core/tiny_remote.h \
|
|
core/hakmem_tiny_superslab_constants.h core/tiny_fastcache.h \
|
|
core/box/tiny_next_ptr_box.h core/hakmem_tiny_config.h \
|
|
core/tiny_nextptr.h core/hakmem_mid_mt.h core/hakmem_super_registry.h \
|
|
core/hakmem_elo.h core/hakmem_ace_stats.h core/hakmem_batch.h \
|
|
core/hakmem_evo.h core/hakmem_debug.h core/hakmem_prof.h \
|
|
core/hakmem_syscall.h core/hakmem_ace_controller.h \
|
|
core/hakmem_ace_metrics.h core/hakmem_ace_ucb1.h core/ptr_trace.h \
|
|
core/box/hak_exit_debug.inc.h core/box/hak_kpi_util.inc.h \
|
|
core/box/hak_core_init.inc.h core/hakmem_phase7_config.h \
|
|
core/box/hak_alloc_api.inc.h core/box/hak_free_api.inc.h \
|
|
core/hakmem_tiny_superslab.h core/box/../tiny_free_fast_v2.inc.h \
|
|
core/box/../tiny_region_id.h core/box/../hakmem_build_flags.h \
|
|
core/box/../tiny_box_geometry.h \
|
|
core/box/../hakmem_tiny_superslab_constants.h \
|
|
core/box/../hakmem_tiny_config.h core/box/../ptr_track.h \
|
|
core/box/../box/tls_sll_box.h core/box/../box/../hakmem_tiny_config.h \
|
|
core/box/../box/../hakmem_build_flags.h core/box/../box/../tiny_remote.h \
|
|
core/box/../box/../tiny_region_id.h \
|
|
core/box/../box/../hakmem_tiny_integrity.h \
|
|
core/box/../box/../hakmem_tiny.h core/box/../box/../ptr_track.h \
|
|
core/box/../box/../tiny_debug_ring.h core/box/../box/tls_sll_drain_box.h \
|
|
core/box/../box/tls_sll_box.h core/box/../box/free_local_box.h \
|
|
core/box/../hakmem_tiny_integrity.h core/box/../front/tiny_heap_v2.h \
|
|
core/box/../front/../hakmem_tiny.h core/box/front_gate_classifier.h \
|
|
core/box/hak_wrappers.inc.h
|
|
core/hakmem.h:
|
|
core/hakmem_build_flags.h:
|
|
core/hakmem_config.h:
|
|
core/hakmem_features.h:
|
|
core/hakmem_internal.h:
|
|
core/hakmem_sys.h:
|
|
core/hakmem_whale.h:
|
|
core/hakmem_bigcache.h:
|
|
core/hakmem_pool.h:
|
|
core/hakmem_l25_pool.h:
|
|
core/hakmem_policy.h:
|
|
core/hakmem_learner.h:
|
|
core/hakmem_size_hist.h:
|
|
core/hakmem_ace.h:
|
|
core/hakmem_site_rules.h:
|
|
core/hakmem_tiny.h:
|
|
core/hakmem_trace.h:
|
|
core/hakmem_tiny_mini_mag.h:
|
|
core/hakmem_tiny_superslab.h:
|
|
core/superslab/superslab_types.h:
|
|
core/hakmem_tiny_superslab_constants.h:
|
|
core/superslab/superslab_inline.h:
|
|
core/superslab/superslab_types.h:
|
|
core/tiny_debug_ring.h:
|
|
core/tiny_remote.h:
|
|
core/hakmem_tiny_superslab_constants.h:
|
|
core/tiny_fastcache.h:
|
|
core/box/tiny_next_ptr_box.h:
|
|
core/hakmem_tiny_config.h:
|
|
core/tiny_nextptr.h:
|
|
core/hakmem_mid_mt.h:
|
|
core/hakmem_super_registry.h:
|
|
core/hakmem_elo.h:
|
|
core/hakmem_ace_stats.h:
|
|
core/hakmem_batch.h:
|
|
core/hakmem_evo.h:
|
|
core/hakmem_debug.h:
|
|
core/hakmem_prof.h:
|
|
core/hakmem_syscall.h:
|
|
core/hakmem_ace_controller.h:
|
|
core/hakmem_ace_metrics.h:
|
|
core/hakmem_ace_ucb1.h:
|
|
core/ptr_trace.h:
|
|
core/box/hak_exit_debug.inc.h:
|
|
core/box/hak_kpi_util.inc.h:
|
|
core/box/hak_core_init.inc.h:
|
|
core/hakmem_phase7_config.h:
|
|
core/box/hak_alloc_api.inc.h:
|
|
core/box/hak_free_api.inc.h:
|
|
core/hakmem_tiny_superslab.h:
|
|
core/box/../tiny_free_fast_v2.inc.h:
|
|
core/box/../tiny_region_id.h:
|
|
core/box/../hakmem_build_flags.h:
|
|
core/box/../tiny_box_geometry.h:
|
|
core/box/../hakmem_tiny_superslab_constants.h:
|
|
core/box/../hakmem_tiny_config.h:
|
|
core/box/../ptr_track.h:
|
|
core/box/../box/tls_sll_box.h:
|
|
core/box/../box/../hakmem_tiny_config.h:
|
|
core/box/../box/../hakmem_build_flags.h:
|
|
core/box/../box/../tiny_remote.h:
|
|
core/box/../box/../tiny_region_id.h:
|
|
core/box/../box/../hakmem_tiny_integrity.h:
|
|
core/box/../box/../hakmem_tiny.h:
|
|
core/box/../box/../ptr_track.h:
|
|
core/box/../box/../tiny_debug_ring.h:
|
|
core/box/../box/tls_sll_drain_box.h:
|
|
core/box/../box/tls_sll_box.h:
|
|
core/box/../box/free_local_box.h:
|
|
core/box/../hakmem_tiny_integrity.h:
|
|
core/box/../front/tiny_heap_v2.h:
|
|
core/box/../front/../hakmem_tiny.h:
|
|
core/box/front_gate_classifier.h:
|
|
core/box/hak_wrappers.inc.h:
|