b6010dd253
Objective: Clean up warm pool implementation by extracting inline boxes for statistics, carving, and prefill logic. Achieved full modularity with zero performance regression using aggressive inline optimization. Changes: 1. **Legacy Code Removal** (Phase 0) - Removed unused static __thread prefill_attempt_count variable - Cleaned up duplicate comments - Simplified carve failure handling 2. **Warm Pool Statistics Box** (Phase 1) - New file: core/box/warm_pool_stats_box.h - Inline APIs: warm_pool_record_hit/miss/prefilled() - All statistics recording externalized - Integrated into unified_cache.c - Performance: 0 cost (inlined to direct memory write) 3. **Slab Carving Box** (Phase 2) - New file: core/box/slab_carve_box.h - Inline API: slab_carve_from_ss() - Extracted unified_cache_carve_from_ss() function - Now reusable by other refill paths (P0, etc.) - Performance: 100% inlined, O(slabs) scan unchanged 4. **Warm Pool Prefill Box** (Phase 3) - New file: core/box/warm_pool_prefill_box.h - Inline API: warm_pool_do_prefill() - Extracted prefill loop with configurable budget - WARM_POOL_PREFILL_BUDGET = 3 (tunable) - Cold path optimization (only on empty pool) - Performance: Cold path cost (non-critical) Architecture: - core/front/tiny_unified_cache.c now 40+ lines shorter - Logic distributed to 3 well-defined boxes - Each box has single responsibility (SRP) - Inline compilation preserves hot path performance - LTO (-flto) enables cross-file inlining Performance Results: - 1M allocations: 4.099M ops/s (maintained) - 5M allocations: 4.046M ops/s (maintained) - 55.6% warm pool hit rate (unchanged) - Zero regression on throughput - All three boxes fully inlined by compiler Code Quality Improvements: ✅ Removed legacy unused variables ✅ Separated concerns into specialized boxes ✅ Improved readability and maintainability ✅ Preserved performance via aggressive inline ✅ Enabled future reuse (carve box for P0) Testing: ✅ Compilation: No errors ✅ Functionality: 1M and 5M allocation tests pass ✅ Performance: Baseline maintained ✅ Statistics: Output identical to pre-refactor Next Phase: Consider similar modularization for: - Registry scanning (registry_scan_box.h) - TLS management (tls_management_box.h) - Cache operations (unified_cache_policy_box.h) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
79 lines
2.7 KiB
C
79 lines
2.7 KiB
C
// warm_pool_prefill_box.h - Warm Pool Prefill Box
|
|
// Purpose: Secondary prefill optimization - load multiple superlslabs when pool is empty
|
|
// License: MIT
|
|
// Date: 2025-12-04
|
|
|
|
#ifndef HAK_WARM_POOL_PREFILL_BOX_H
|
|
#define HAK_WARM_POOL_PREFILL_BOX_H
|
|
|
|
#include <stdint.h>
|
|
#include "../hakmem_tiny_config.h"
|
|
#include "../hakmem_tiny_superslab.h"
|
|
#include "../tiny_tls.h"
|
|
#include "../front/tiny_warm_pool.h"
|
|
#include "../box/warm_pool_stats_box.h"
|
|
|
|
// Forward declarations
|
|
extern __thread TinyTLSSlab g_tls_slabs[TINY_NUM_CLASSES];
|
|
extern SuperSlab* superslab_refill(int class_idx);
|
|
|
|
// ============================================================================
|
|
// Warm Pool Prefill Policy
|
|
// ============================================================================
|
|
|
|
// Prefill budget: How many additional SuperSlabs to load when pool is empty
|
|
// - If pool is empty, load PREFILL_BUDGET extra slabs to build working set
|
|
// - This avoids repeated registry scans on rapid cache misses
|
|
#define WARM_POOL_PREFILL_BUDGET 3
|
|
|
|
// ============================================================================
|
|
// Warm Pool Prefill API (Inline for Cold Path)
|
|
// ============================================================================
|
|
|
|
// Perform secondary prefill when warm pool becomes empty
|
|
// Called from unified_cache_refill() cold path when warm_pool_count() == 0
|
|
//
|
|
// Algorithm:
|
|
// 1. Check if pool is empty
|
|
// 2. If yes, load PREFILL_BUDGET additional superlslabs via superslab_refill
|
|
// 3. Push all but the last to warm pool
|
|
// 4. Return the last one for immediate carving (in tls->ss)
|
|
//
|
|
// Returns: 0 on success, -1 if superslab_refill fails
|
|
//
|
|
// Performance: Only triggered when pool is empty, cold path cost
|
|
//
|
|
static inline int warm_pool_do_prefill(int class_idx, TinyTLSSlab* tls) {
|
|
int budget = (tiny_warm_pool_count(class_idx) == 0) ? WARM_POOL_PREFILL_BUDGET : 1;
|
|
|
|
while (budget > 0) {
|
|
if (!tls->ss) {
|
|
// Need to load a new SuperSlab
|
|
if (!superslab_refill(class_idx)) {
|
|
return -1; // Error: cannot allocate new SuperSlab
|
|
}
|
|
tls = &g_tls_slabs[class_idx]; // Reload TLS after refill
|
|
}
|
|
|
|
// Check SuperSlab validity
|
|
if (!(tls->ss && tls->ss->magic == SUPERSLAB_MAGIC)) {
|
|
break;
|
|
}
|
|
|
|
if (budget > 1) {
|
|
// Prefill mode: push to pool and load another
|
|
tiny_warm_pool_push(class_idx, tls->ss);
|
|
warm_pool_record_prefilled(class_idx);
|
|
tls->ss = NULL; // Force next iteration to refill
|
|
budget--;
|
|
} else {
|
|
// Final slab: keep in TLS for immediate carving
|
|
budget = 0;
|
|
}
|
|
}
|
|
|
|
return 0; // Success
|
|
}
|
|
|
|
#endif // HAK_WARM_POOL_PREFILL_BOX_H
|