tomoaki/hakmem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
89a9212700e69d2ee891f1d437f90f847e224a4d
hakmem/hakmem_tiny_sfc.d
Moe Charm (CI) f99ef77ad7 Phase 29: Pool Hotbox v2 Stats Prune - NO-OP (infrastructure ready) 
Target: g_pool_hotbox_v2_stats atomics (12 total) in Pool v2
Result: 0.00% impact (code path inactive by default, ENV-gated)
Verdict: NO-OP - Maintain compile-out for future-proofing

Audit Results:
- Classification: 12/12 TELEMETRY (100% observational)
- Counters: alloc_calls, alloc_fast, alloc_refill, alloc_refill_fail,
  alloc_fallback_v1, free_calls, free_fast, free_fallback_v1,
  page_of_fail_* (4 failure counters)
- Verification: All stats/logging only, zero flow control usage
- Phase 28 lesson applied: Traced all usages, confirmed no CORRECTNESS

Key Finding: Pool v2 OFF by default
- Requires HAKMEM_POOL_V2_ENABLED=1 to activate
- Benchmark never executes Pool v2 code paths
- Compile-out has zero performance impact (code never runs)

Implementation (future-ready):
- Added HAKMEM_POOL_HOTBOX_V2_STATS_COMPILED (default: 0)
- Wrapped 13 atomic write sites in core/hakmem_pool.c
- Pattern: #if HAKMEM_POOL_HOTBOX_V2_STATS_COMPILED ... #endif
- Expected impact if Pool v2 enabled: +0.3~0.8% (HOT+WARM atomics)

A/B Test Results:
- Baseline (COMPILED=0): 52.98 M ops/s (±0.43M, 0.81% stdev)
- Research (COMPILED=1): 53.31 M ops/s (±0.80M, 1.50% stdev)
- Delta: -0.62% (noise, not real effect - code path not active)

Critical Lesson Learned (NEW):
Phase 29 revealed ENV-gated features can appear on hot paths but never
execute. Updated audit checklist:
1. Classify atomics (CORRECTNESS vs TELEMETRY)
2. Verify no flow control usage
3. NEW: Verify code path is ACTIVE in benchmark (check ENV gates)
4. Implement compile-out
5. A/B test

Verification methods added to documentation:
- rg "getenv.*FEATURE" to check ENV gates
- perf record/report to verify execution
- Debug printf for quick validation

Cumulative Progress (Phase 24-29):
- Phase 24 (class stats): +0.93% GO
- Phase 25 (free stats): +1.07% GO
- Phase 26 (diagnostics): -0.33% NEUTRAL
- Phase 27 (unified cache): +0.74% GO
- Phase 28 (bg spill): NO-OP (all CORRECTNESS)
- Phase 29 (pool v2): NO-OP (inactive code path)
- Total: 17 atomics removed, +2.74% improvement

Documentation:
- PHASE29_POOL_HOTBOX_V2_AUDIT.md: Complete audit with TELEMETRY classification
- PHASE29_POOL_HOTBOX_V2_STATS_RESULTS.md: Results + new lesson learned
- ATOMIC_PRUNE_CUMULATIVE_SUMMARY.md: Updated with Phase 29 + new checklist
- PHASE29_COMPLETE.md: Completion summary with recommendations

Decision: Keep compile-out despite NO-OP
- Code cleanliness (binary size reduction)
- Future-proofing (ready when Pool v2 enabled)
- Consistency with Phase 24-28 pattern

Generated with Claude Code
https://claude.com/claude-code

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-16 06:33:41 +09:00

121 lines
4.9 KiB
Makefile
Raw Blame History

hakmem_tiny_sfc.o: core/hakmem_tiny_sfc.c core/tiny_alloc_fast_sfc.inc.h \
core/hakmem_tiny.h core/hakmem_build_flags.h core/hakmem_trace.h \
core/hakmem_tiny_mini_mag.h core/box/hak_lane_classify.inc.h \
core/box/ptr_type_box.h core/box/tiny_next_ptr_box.h \
core/hakmem_tiny_config.h core/tiny_nextptr.h core/tiny_region_id.h \
core/tiny_box_geometry.h core/hakmem_tiny_superslab_constants.h \
core/hakmem_tiny_config.h core/ptr_track.h core/hakmem_super_registry.h \
core/hakmem_tiny_superslab.h core/superslab/superslab_types.h \
core/hakmem_tiny_superslab_constants.h core/superslab/superslab_inline.h \
core/superslab/superslab_types.h core/superslab/../tiny_box_geometry.h \
core/tiny_debug_ring.h core/tiny_remote.h core/box/ss_addr_map_box.h \
core/box/../hakmem_build_flags.h core/box/super_reg_box.h \
core/box/ss_pt_lookup_box.h core/box/ss_pt_types_box.h \
core/box/ss_pt_env_box.h core/box/ss_pt_env_box.h core/tiny_debug_api.h \
core/box/tiny_header_hotfull_env_box.h core/box/tiny_layout_box.h \
core/box/../hakmem_tiny_config.h core/box/tiny_header_box.h \
core/box/tiny_layout_box.h core/box/../tiny_region_id.h \
core/box/tiny_header_write_once_env_box.h core/hakmem_stats_master.h \
core/tiny_tls.h core/box/tls_sll_box.h core/box/../hakmem_internal.h \
core/box/../hakmem.h core/box/../hakmem_build_flags.h \
core/box/../hakmem_config.h core/box/../hakmem_features.h \
core/box/../hakmem_sys.h core/box/../hakmem_whale.h \
core/box/../box/ptr_type_box.h core/box/../hakmem_debug_master.h \
core/box/../tiny_remote.h core/box/../hakmem_tiny_integrity.h \
core/box/../hakmem_tiny.h core/box/../ptr_track.h \
core/box/../ptr_trace.h core/box/../hakmem_trace_master.h \
core/box/../hakmem_stats_master.h core/box/../tiny_debug_ring.h \
core/box/ss_addr_map_box.h core/box/../superslab/superslab_inline.h \
core/box/tiny_ptr_bridge_box.h \
core/box/../hakmem_tiny_superslab_internal.h \
core/box/../hakmem_tiny_superslab.h core/box/../box/ss_hot_cold_box.h \
core/box/../box/../superslab/superslab_types.h \
core/box/../box/ss_allocation_box.h core/hakmem_tiny_superslab.h \
core/box/../hakmem_debug_master.h core/box/../hakmem_tiny_config.h \
core/box/../hakmem_shared_pool.h core/box/../superslab/superslab_types.h \
core/box/../hakmem_internal.h core/box/../tiny_region_id.h \
core/box/../hakmem_tiny_integrity.h \
core/box/../box/slab_freelist_atomic.h core/box/tiny_header_box.h \
core/box/tiny_heap_env_box.h core/box/c7_hotpath_env_box.h \
core/hakmem_env_cache.h
core/tiny_alloc_fast_sfc.inc.h:
core/hakmem_tiny.h:
core/hakmem_build_flags.h:
core/hakmem_trace.h:
core/hakmem_tiny_mini_mag.h:
core/box/hak_lane_classify.inc.h:
core/box/ptr_type_box.h:
core/box/tiny_next_ptr_box.h:
core/hakmem_tiny_config.h:
core/tiny_nextptr.h:
core/tiny_region_id.h:
core/tiny_box_geometry.h:
core/hakmem_tiny_superslab_constants.h:
core/hakmem_tiny_config.h:
core/ptr_track.h:
core/hakmem_super_registry.h:
core/hakmem_tiny_superslab.h:
core/superslab/superslab_types.h:
core/hakmem_tiny_superslab_constants.h:
core/superslab/superslab_inline.h:
core/superslab/superslab_types.h:
core/superslab/../tiny_box_geometry.h:
core/tiny_debug_ring.h:
core/tiny_remote.h:
core/box/ss_addr_map_box.h:
core/box/../hakmem_build_flags.h:
core/box/super_reg_box.h:
core/box/ss_pt_lookup_box.h:
core/box/ss_pt_types_box.h:
core/box/ss_pt_env_box.h:
core/box/ss_pt_env_box.h:
core/tiny_debug_api.h:
core/box/tiny_header_hotfull_env_box.h:
core/box/tiny_layout_box.h:
core/box/../hakmem_tiny_config.h:
core/box/tiny_header_box.h:
core/box/tiny_layout_box.h:
core/box/../tiny_region_id.h:
core/box/tiny_header_write_once_env_box.h:
core/hakmem_stats_master.h:
core/tiny_tls.h:
core/box/tls_sll_box.h:
core/box/../hakmem_internal.h:
core/box/../hakmem.h:
core/box/../hakmem_build_flags.h:
core/box/../hakmem_config.h:
core/box/../hakmem_features.h:
core/box/../hakmem_sys.h:
core/box/../hakmem_whale.h:
core/box/../box/ptr_type_box.h:
core/box/../hakmem_debug_master.h:
core/box/../tiny_remote.h:
core/box/../hakmem_tiny_integrity.h:
core/box/../hakmem_tiny.h:
core/box/../ptr_track.h:
core/box/../ptr_trace.h:
core/box/../hakmem_trace_master.h:
core/box/../hakmem_stats_master.h:
core/box/../tiny_debug_ring.h:
core/box/ss_addr_map_box.h:
core/box/../superslab/superslab_inline.h:
core/box/tiny_ptr_bridge_box.h:
core/box/../hakmem_tiny_superslab_internal.h:
core/box/../hakmem_tiny_superslab.h:
core/box/../box/ss_hot_cold_box.h:
core/box/../box/../superslab/superslab_types.h:
core/box/../box/ss_allocation_box.h:
core/hakmem_tiny_superslab.h:
core/box/../hakmem_debug_master.h:
core/box/../hakmem_tiny_config.h:
core/box/../hakmem_shared_pool.h:
core/box/../superslab/superslab_types.h:
core/box/../hakmem_internal.h:
core/box/../tiny_region_id.h:
core/box/../hakmem_tiny_integrity.h:
core/box/../box/slab_freelist_atomic.h:
core/box/tiny_header_box.h:
core/box/tiny_heap_env_box.h:
core/box/c7_hotpath_env_box.h:
core/hakmem_env_cache.h:
Reference in New Issue View Git Blame Copy Permalink