## Major Additions ### 1. Box I: Integrity Verification System (NEW - 703 lines) - Files: core/box/integrity_box.h (267 lines), core/box/integrity_box.c (436 lines) - Purpose: Unified integrity checking across all HAKMEM subsystems - Features: * 4-level integrity checking (0-4, compile-time controlled) * Priority 1: TLS array bounds validation * Priority 2: Freelist pointer validation * Priority 3: TLS canary monitoring * Priority ALPHA: Slab metadata invariant checking (5 invariants) * Atomic statistics tracking (thread-safe) * Beautiful BOX_BOUNDARY design pattern ### 2. Box E: SuperSlab Expansion System (COMPLETE) - Files: core/box/superslab_expansion_box.h, core/box/superslab_expansion_box.c - Purpose: Safe SuperSlab expansion with TLS state guarantee - Features: * Immediate slab 0 binding after expansion * TLS state snapshot and restoration * Design by Contract (pre/post-conditions, invariants) * Thread-safe with mutex protection ### 3. Comprehensive Integrity Checking System - File: core/hakmem_tiny_integrity.h (NEW) - Unified validation functions for all allocator subsystems - Uninitialized memory pattern detection (0xa2, 0xcc, 0xdd, 0xfe) - Pointer range validation (null-page, kernel-space) ### 4. P0 Bug Investigation - Root Cause Identified **Bug**: SEGV at iteration 28440 (deterministic with seed 42) **Pattern**: 0xa2a2a2a2a2a2a2a2 (uninitialized/ASan poisoning) **Location**: TLS SLL (Single-Linked List) cache layer **Root Cause**: Race condition or use-after-free in TLS list management (class 0) **Detection**: Box I successfully caught invalid pointer at exact crash point ### 5. Defensive Improvements - Defensive memset in SuperSlab allocation (all metadata arrays) - Enhanced pointer validation with pattern detection - BOX_BOUNDARY markers throughout codebase (beautiful modular design) - 5 metadata invariant checks in allocation/free/refill paths ## Integration Points - Modified 13 files with Box I/E integration - Added 10+ BOX_BOUNDARY markers - 5 critical integrity check points in P0 refill path ## Test Results (100K iterations) - Baseline: 7.22M ops/s - Hotpath ON: 8.98M ops/s (+24% improvement ✓) - P0 Bug: Still crashes at 28440 iterations (TLS SLL race condition) - Root cause: Identified but not yet fixed (requires deeper investigation) ## Performance - Box I overhead: Zero in release builds (HAKMEM_INTEGRITY_LEVEL=0) - Debug builds: Full validation enabled (HAKMEM_INTEGRITY_LEVEL=4) - Beautiful modular design maintains clean separation of concerns ## Known Issues - P0 Bug at 28440 iterations: Race condition in TLS SLL cache (class 0) - Cause: Use-after-free or race in remote free draining - Next step: Valgrind investigation to pinpoint exact corruption location ## Code Quality - Total new code: ~1400 lines (Box I + Box E + integrity system) - Design: Beautiful Box Theory with clear boundaries - Modularity: Complete separation of concerns - Documentation: Comprehensive inline comments and BOX_BOUNDARY markers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
147 lines
5.5 KiB
C
147 lines
5.5 KiB
C
// superslab_expansion_box.h - Box E: SuperSlab Expansion with TLS State Guarantee
|
|
// Purpose: Encapsulates SuperSlab chunk expansion with Design by Contract
|
|
// Box Theory: Provides ACID-like guarantees for TLS state during expansion
|
|
//
|
|
// Design Principles:
|
|
// 1. Complete encapsulation - all expansion logic lives here
|
|
// 2. TLS state guarantee - caller's TLS pointers remain valid after expansion
|
|
// 3. Thread-safe - mutex protection for concurrent expansion attempts
|
|
// 4. Atomic state transitions - no partial updates visible to caller
|
|
// 5. Debug validation - compile-time optional invariant checking
|
|
//
|
|
// License: MIT
|
|
// Date: 2025-11-12
|
|
|
|
#ifndef HAKMEM_SUPERSLAB_EXPANSION_BOX_H
|
|
#define HAKMEM_SUPERSLAB_EXPANSION_BOX_H
|
|
|
|
#include <stdint.h>
|
|
#include <stdbool.h>
|
|
#include "../superslab/superslab_types.h" // SuperSlabHead, SuperSlab
|
|
#include "../tiny_tls.h" // TinyTLSSlab
|
|
|
|
// ============================================================================
|
|
// Box E: Type Definitions
|
|
// ============================================================================
|
|
|
|
// TLS state snapshot (immutable after capture)
|
|
typedef struct ExpansionTLSState {
|
|
SuperSlab* ss; // Current SuperSlab (may change after expansion)
|
|
TinySlabMeta* meta; // Current slab metadata
|
|
uint8_t* slab_base; // Current slab base pointer
|
|
uint8_t slab_idx; // Current slab index
|
|
uint8_t class_idx; // Size class
|
|
uint8_t _pad[2]; // Padding
|
|
} ExpansionTLSState;
|
|
|
|
// Expansion operation result
|
|
typedef struct ExpansionResult {
|
|
bool success; // true if expansion succeeded
|
|
ExpansionTLSState new_state; // New TLS state (valid only if success=true)
|
|
int error_code; // Error code (0=success, -1=OOM, -2=invalid params)
|
|
} ExpansionResult;
|
|
|
|
// ============================================================================
|
|
// Box E: Core API - Design by Contract
|
|
// ============================================================================
|
|
|
|
// Capture current TLS state (immutable snapshot)
|
|
// Precondition: class_idx < TINY_NUM_CLASSES_SS
|
|
// Postcondition: Returns snapshot of current TLS state
|
|
ExpansionTLSState expansion_capture_tls_state(uint8_t class_idx);
|
|
|
|
// Expand SuperSlabHead with TLS state guarantee
|
|
// Precondition: head != NULL, class_idx < TINY_NUM_CLASSES_SS
|
|
// Postcondition: If success, new_state contains valid TLS pointers to expanded chunk
|
|
// If failure, head->current_chunk unchanged
|
|
// Thread-safe: Yes (mutex protected)
|
|
ExpansionResult expansion_expand_with_tls_guarantee(
|
|
SuperSlabHead* head,
|
|
uint8_t class_idx
|
|
);
|
|
|
|
// Apply new TLS state to current thread
|
|
// Precondition: new_state is valid (from successful expansion), tls_array != NULL
|
|
// Postcondition: tls_array[class_idx] updated atomically
|
|
// Note: tls_array should be g_tls_slabs from the caller's context
|
|
void expansion_apply_tls_state(
|
|
uint8_t class_idx,
|
|
const ExpansionTLSState* new_state,
|
|
TinyTLSSlab* tls_array // Pointer to g_tls_slabs from caller
|
|
);
|
|
|
|
// ============================================================================
|
|
// Box E: High-Level API - One-Call Expansion
|
|
// ============================================================================
|
|
|
|
// Safe expansion: capture → expand → apply in one call
|
|
// Returns true if expansion succeeded, false on OOM or invalid params
|
|
// Thread-safe: Yes
|
|
//
|
|
// Parameters:
|
|
// head: SuperSlabHead to expand
|
|
// class_idx: Size class index
|
|
// tls_array: Pointer to g_tls_slabs array (from caller's context)
|
|
//
|
|
// Usage:
|
|
// extern __thread TinyTLSSlab g_tls_slabs[]; // In caller's scope
|
|
// if (!expansion_safe_expand(head, class_idx, g_tls_slabs)) {
|
|
// // Expansion failed (OOM)
|
|
// return NULL;
|
|
// }
|
|
// // TLS state is now updated, reload local pointers
|
|
// TinyTLSSlab* tls = &g_tls_slabs[class_idx];
|
|
// SuperSlab* ss = tls->ss;
|
|
static inline bool expansion_safe_expand(SuperSlabHead* head, uint8_t class_idx, TinyTLSSlab* tls_array) {
|
|
if (!head || class_idx >= TINY_NUM_CLASSES_SS || !tls_array) {
|
|
return false;
|
|
}
|
|
|
|
ExpansionResult result = expansion_expand_with_tls_guarantee(head, class_idx);
|
|
if (!result.success) {
|
|
return false;
|
|
}
|
|
|
|
expansion_apply_tls_state(class_idx, &result.new_state, tls_array);
|
|
return true;
|
|
}
|
|
|
|
// ============================================================================
|
|
// Box E: Debug & Validation (Conditional Compilation)
|
|
// ============================================================================
|
|
|
|
#if !defined(HAKMEM_BUILD_RELEASE) || defined(HAKMEM_EXPANSION_BOX_DEBUG)
|
|
|
|
// Validate TLS state invariants
|
|
// Returns true if all invariants hold, false otherwise
|
|
bool expansion_validate_tls_state(
|
|
const ExpansionTLSState* state,
|
|
const char* context // For debug logging (e.g., "before_expansion")
|
|
);
|
|
|
|
// Verify expansion succeeded correctly
|
|
// Returns true if expansion is valid, false otherwise
|
|
bool expansion_verify_expansion(
|
|
SuperSlabHead* head,
|
|
const ExpansionTLSState* old_state,
|
|
const ExpansionTLSState* new_state
|
|
);
|
|
|
|
// Log expansion event (debug only)
|
|
void expansion_log_event(
|
|
const char* event, // Event name (e.g., "START", "SUCCESS", "FAILURE")
|
|
uint8_t class_idx,
|
|
const ExpansionTLSState* state
|
|
);
|
|
|
|
#else
|
|
|
|
// No-op in release builds
|
|
#define expansion_validate_tls_state(state, context) ((void)0, true)
|
|
#define expansion_verify_expansion(head, old, new) ((void)0, true)
|
|
#define expansion_log_event(event, cls, state) ((void)0)
|
|
|
|
#endif
|
|
|
|
#endif // HAKMEM_SUPERSLAB_EXPANSION_BOX_H
|