Files
hakmem/benchmarks/scripts/run_redis_matrix.sh
Moe Charm (CI) 1da8754d45 CRITICAL FIX: TLS 未初期化による 4T SEGV を完全解消
**問題:**
- Larson 4T で 100% SEGV (1T は 2.09M ops/s で完走)
- System/mimalloc は 4T で 33.52M ops/s 正常動作
- SS OFF + Remote OFF でも 4T で SEGV

**根本原因: (Task agent ultrathink 調査結果)**
```
CRASH: mov (%r15),%r13
R15 = 0x6261  ← ASCII "ba" (ゴミ値、未初期化TLS)
```

Worker スレッドの TLS 変数が未初期化:
- `__thread void* g_tls_sll_head[TINY_NUM_CLASSES];`  ← 初期化なし
- pthread_create() で生成されたスレッドでゼロ初期化されない
- NULL チェックが通過 (0x6261 != NULL) → dereference → SEGV

**修正内容:**
全 TLS 配列に明示的初期化子 `= {0}` を追加:

1. **core/hakmem_tiny.c:**
   - `g_tls_sll_head[TINY_NUM_CLASSES] = {0}`
   - `g_tls_sll_count[TINY_NUM_CLASSES] = {0}`
   - `g_tls_live_ss[TINY_NUM_CLASSES] = {0}`
   - `g_tls_bcur[TINY_NUM_CLASSES] = {0}`
   - `g_tls_bend[TINY_NUM_CLASSES] = {0}`

2. **core/tiny_fastcache.c:**
   - `g_tiny_fast_cache[TINY_FAST_CLASS_COUNT] = {0}`
   - `g_tiny_fast_count[TINY_FAST_CLASS_COUNT] = {0}`
   - `g_tiny_fast_free_head[TINY_FAST_CLASS_COUNT] = {0}`
   - `g_tiny_fast_free_count[TINY_FAST_CLASS_COUNT] = {0}`

3. **core/hakmem_tiny_magazine.c:**
   - `g_tls_mags[TINY_NUM_CLASSES] = {0}`

4. **core/tiny_sticky.c:**
   - `g_tls_sticky_ss[TINY_NUM_CLASSES][TINY_STICKY_RING] = {0}`
   - `g_tls_sticky_idx[TINY_NUM_CLASSES][TINY_STICKY_RING] = {0}`
   - `g_tls_sticky_pos[TINY_NUM_CLASSES] = {0}`

**効果:**
```
Before: 1T: 2.09M   |  4T: SEGV 💀
After:  1T: 2.41M   |  4T: 4.19M   (+15% 1T, SEGV解消)
```

**テスト:**
```bash
# 1 thread: 完走
./larson_hakmem 2 8 128 1024 1 12345 1
→ Throughput = 2,407,597 ops/s 

# 4 threads: 完走(以前は SEGV)
./larson_hakmem 2 8 128 1024 1 12345 4
→ Throughput = 4,192,155 ops/s 
```

**調査協力:** Task agent (ultrathink mode) による完璧な根本原因特定

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-07 01:27:04 +09:00

72 lines
2.1 KiB
Bash

#!/usr/bin/env bash
set -euo pipefail
# Redis-style allocator benchmark triad (System/mimalloc/HAKMEM via LD_PRELOAD)
# Usage: benchmarks/scripts/run_redis_matrix.sh [threads] [cycles] [ops] [reps]
ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")"/../.. && pwd)"
cd "$ROOT_DIR"
THREADS=${1:-1}
CYCLES=${2:-100}
OPS=${3:-1000}
REPS=${4:-5}
BENCH="./benchmarks/redis/workload_bench_system"
MI_LIB_DEFAULT="mimalloc-bench/extern/mi/out/release/libmimalloc.so"
MI_LIB="${MIMALLOC_SO:-$MI_LIB_DEFAULT}"
if [[ ! -x "$BENCH" ]]; then
echo "[error] $BENCH not found or not executable" >&2
exit 1
fi
if [[ ! -f "$MI_LIB" ]]; then
echo "[warn] mimalloc .so not found at $MI_LIB (set MIMALLOC_SO) — skipping mi runs" >&2
HAVE_MI=0
else
HAVE_MI=1
fi
# Ensure shared lib exists for HAKMEM LD_PRELOAD
[[ -f ./libhakmem.so ]] || make -s shared >/dev/null || true
TS=$(date +%Y%m%d_%H%M%S)
OUTDIR="bench_results/auto/redis_${TS}"
mkdir -p "$OUTDIR"
CSV="$OUTDIR/results.csv"
echo "ts,scenario,allocator,env,threads,cycles,ops,rep,throughput_ops_s" >"$CSV"
extract_ops_s() {
# workload_bench prints: "Throughput: 28.97 M ops/sec"
# return ops/s as integer
awk '/Throughput:/ {print int($2*1000000)}' | tail -n1
}
run_case() {
local alloc="$1"; shift
local envstr="$1"; shift
local rep="$2"; shift
local ts=$(date +%H%M%S)
local out
out=$($envstr "$BENCH" -t "$THREADS" -c "$CYCLES" -o "$OPS" 2>/dev/null || true)
local tput=$(echo "$out" | extract_ops_s)
if [[ -n "${tput:-}" ]]; then
echo "$ts,redis,$alloc,$(echo "$envstr" | sed 's/,/;/g'),$THREADS,$CYCLES,$OPS,$rep,$tput" >>"$CSV"
fi
}
echo "[info] writing CSV to $CSV"
# System
for ((i=1;i<=REPS;i++)); do run_case system "env -i" "$i"; done
# mimalloc
if (( HAVE_MI == 1 )); then
for ((i=1;i<=REPS;i++)); do run_case mimalloc "env -i LD_PRELOAD=$MI_LIB" "$i"; done
fi
# HAKMEM (safer LD flags for tiny-only)
for ((i=1;i<=REPS;i++)); do \
run_case hakmem "env -i LD_PRELOAD=./libhakmem.so HAKMEM_WRAP_TINY=1 HAKMEM_LD_SAFE=1 HAKMEM_TINY_SUPERSLAB=0 HAKMEM_TINY_TRACE_RING=0 HAKMEM_SAFE_FREE=0" "$i"; done
echo "[done] $CSV"