03df05ec75
## Summary
Implemented Phase 12 Shared SuperSlab Pool (mimalloc-style) to address
SuperSlab allocation churn (877 SuperSlabs → 100-200 target).
## Implementation (ChatGPT + Claude)
1. **Metadata changes** (superslab_types.h):
- Added class_idx to TinySlabMeta (per-slab dynamic class)
- Removed size_class from SuperSlab (no longer per-SuperSlab)
- Changed owner_tid (16-bit) → owner_tid_low (8-bit)
2. **Shared Pool** (hakmem_shared_pool.{h,c}):
- Global pool shared by all size classes
- shared_pool_acquire_slab() - Get free slab for class_idx
- shared_pool_release_slab() - Return slab when empty
- Per-class hints for fast path optimization
3. **Integration** (23 files modified):
- Updated all ss->size_class → meta->class_idx
- Updated all meta->owner_tid → meta->owner_tid_low
- superslab_refill() now uses shared pool
- Free path releases empty slabs back to pool
4. **Build system** (Makefile):
- Added hakmem_shared_pool.o to OBJS_BASE and TINY_BENCH_OBJS_BASE
## Status: ⚠️ Build OK, Runtime CRASH
**Build**: ✅ SUCCESS
- All 23 files compile without errors
- Only warnings: superslab_allocate type mismatch (legacy code)
**Runtime**: ❌ SEGFAULT
- Crash location: sll_refill_small_from_ss()
- Exit code: 139 (SIGSEGV)
- Test case: ./bench_random_mixed_hakmem 1000 256 42
## Known Issues
1. **SEGFAULT in refill path** - Likely shared_pool_acquire_slab() issue
2. **Legacy superslab_allocate()** still exists (type mismatch warning)
3. **Remaining TODOs** from design doc:
- SuperSlab physical layout integration
- slab_handle.h cleanup
- Remove old per-class head implementation
## Next Steps
1. Debug SEGFAULT (gdb backtrace shows sll_refill_small_from_ss)
2. Fix shared_pool_acquire_slab() or superslab_init_slab()
3. Basic functionality test (1K → 100K iterations)
4. Measure SuperSlab count reduction (877 → 100-200)
5. Performance benchmark (+650-860% expected)
## Files Changed (25 files)
core/box/free_local_box.c
core/box/free_remote_box.c
core/box/front_gate_classifier.c
core/hakmem_super_registry.c
core/hakmem_tiny.c
core/hakmem_tiny_bg_spill.c
core/hakmem_tiny_free.inc
core/hakmem_tiny_lifecycle.inc
core/hakmem_tiny_magazine.c
core/hakmem_tiny_query.c
core/hakmem_tiny_refill.inc.h
core/hakmem_tiny_superslab.c
core/hakmem_tiny_superslab.h
core/hakmem_tiny_tls_ops.h
core/slab_handle.h
core/superslab/superslab_inline.h
core/superslab/superslab_types.h
core/tiny_debug.h
core/tiny_free_fast.inc.h
core/tiny_free_magazine.inc.h
core/tiny_remote.c
core/tiny_superslab_alloc.inc.h
core/tiny_superslab_free.inc.h
Makefile
## New Files (3 files)
PHASE12_SHARED_SUPERSLAB_POOL_DESIGN.md
core/hakmem_shared_pool.c
core/hakmem_shared_pool.h
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: ChatGPT <chatgpt@openai.com>
53 lines
1.9 KiB
C
53 lines
1.9 KiB
C
#ifndef TINY_DEBUG_H
|
|
#define TINY_DEBUG_H
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <stdatomic.h>
|
|
#include "hakmem_tiny_superslab.h"
|
|
#include "hakmem_tiny.h"
|
|
|
|
static inline int tiny_alloc_debug_enabled(void) {
|
|
static int g_debug = -1;
|
|
if (__builtin_expect(g_debug == -1, 0)) {
|
|
const char* e = getenv("HAKMEM_TINY_ALLOC_DEBUG");
|
|
g_debug = (e && atoi(e) != 0) ? 1 : 0;
|
|
}
|
|
return g_debug;
|
|
}
|
|
|
|
static inline void tiny_alloc_dump_tls_state(int class_idx, const char* tag, TinyTLSSlab* tls) {
|
|
if (!tiny_alloc_debug_enabled()) return;
|
|
fprintf(stderr,
|
|
"[ALLOC-DBG:%s] class=%d tls_ss=%p slab_idx=%u meta=%p slab_base=%p\n",
|
|
tag ? tag : "?", class_idx,
|
|
(void*)tls->ss, (unsigned)tls->slab_idx,
|
|
(void*)tls->meta, (void*)tls->slab_base);
|
|
SuperSlab* ss = tls->ss;
|
|
if (!(ss && ss->magic == SUPERSLAB_MAGIC)) {
|
|
fprintf(stderr,
|
|
" tls_ss invalid: ss=%p magic=0x%llx\n",
|
|
(void*)ss,
|
|
ss ? (unsigned long long)ss->magic : 0ull);
|
|
return;
|
|
}
|
|
int cap = ss_slabs_capacity(ss);
|
|
fprintf(stderr,
|
|
" ss active_slabs=%u cap=%d bitmap=0x%08x total_active=%u ref=%u\n",
|
|
ss->active_slabs, cap, ss->slab_bitmap,
|
|
atomic_load_explicit(&ss->total_active_blocks, memory_order_relaxed),
|
|
atomic_load_explicit(&ss->refcount, memory_order_relaxed));
|
|
int limit = (cap < 6) ? cap : 6;
|
|
for (int i = 0; i < limit; i++) {
|
|
uint32_t mask = 1u << i;
|
|
TinySlabMeta* meta = &ss->slabs[i];
|
|
fprintf(stderr,
|
|
" slab%02d active=%d used=%u cap=%u freelist=%p owner=%u class=%u\n",
|
|
i, (ss->slab_bitmap & mask) ? 1 : 0,
|
|
(unsigned)meta->used, (unsigned)meta->capacity,
|
|
meta->freelist, meta->owner_tid_low, meta->class_idx);
|
|
}
|
|
}
|
|
|
|
#endif // TINY_DEBUG_H
|