tomoaki/hakmem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
418 Commits 2 Branches 0 Tags
cd3280eee71475211c1b718bcaa9dcc7dd71b48e
Commit Graph

418 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Moe Charm (CI)
ef4bc27c0b Add detailed refactoring instruction for Gemini - Phase 1 implementation 
Content:
- Task 1.1: Create tiny_layout_box.h (Box for layout definitions)
- Task 1.2: Audit tiny_nextptr.h (eliminate direct arithmetic)
- Task 1.3: Ensure type consistency in hakmem_tiny.c
- Task 1.4: Test Phantom Types in Debug build

Goals:
- Centralize all layout/offset logic
- Enforce type safety at Box boundaries
- Prepare for future Phase 2 (Headerless layout)
- Maintain A/B testability

Each task includes:
- Detailed implementation instructions
- Checklist for verification
- Testing requirements
- Deliverables specification

🤖 Generated with Claude Code

Co-Authored-By: Gemini <gemini@example.com>
Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-03 11:20:59 +09:00
Moe Charm (CI)
a948332f6c Update REFACTOR_PLAN_GEMINI_ENHANCED.md with Gemini final findings 
Status Updates (2025-12-03):
- Phase 0.1-0.2: ✅ Already implemented (ptr_type_box.h, ptr_conversion_box.h)
- Phase 0.3: ✅ VERIFIED - Gemini mathematically proved sh8bench adds +1 to odd returns
- Phase 2: 🔄 RECONSIDERED - Headerless layout is legitimate long-term goal
- Phase 3.1: Current NORMALIZE + log is correct fail-safe behavior

Root Cause Analysis:
- Issue A (Fixed): Header restoration gaps at Box boundaries (4 commits)
- Issue B (Root): hakmem returns odd addresses, violating C standard alignment

Gemini's Proof:
- Log analysis: node=0xe1 → user_ptr=0xe2 = +1 delta
- ASan doesn't reproduce because Redzone ensures alignment
- Conclusion: sh8bench expects alignof(max_align_t), hakmem violates it

Recommendations:
- Short-term: Current defensive measures (Atomic Fence + Header Write) sufficient
- Long-term: Phase 2 (Headerless Layout) for C standard compliance

🤖 Generated with Claude Code

Co-Authored-By: Gemini <gemini@example.com>
Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-03 11:20:18 +09:00
Moe Charm (CI)
3e3138f685 Add final investigation report for TLS_SLL_HDR_RESET 2025-12-03 11:14:59 +09:00
Moe Charm (CI)
6df1bdec37 Fix TLS SLL race condition with atomic fence and report investigation results 2025-12-03 10:57:16 +09:00
Moe Charm (CI)
bd5e97f38a Save current state before investigating TLS_SLL_HDR_RESET 2025-12-03 10:34:39 +09:00
Moe Charm (CI)
6154e7656c 根治修正: unified_cache_refill SEGVAULT + コンパイラ最適化対策 
問題:
  - リリース版sh8benchでunified_cache_refill+0x46fでSEGVAULT
  - コンパイラ最適化により、ヘッダー書き込みとtiny_next_read()の
    順序が入れ替わり、破損したポインタをout[]に格納

根本原因:
  - ヘッダー書き込みがtiny_next_read()の後にあった
  - volatile barrierがなく、コンパイラが自由に順序を変更
  - ASan版では最適化が制限されるため問題が隠蔽されていた

修正内容（P1-P3）:

P1: unified_cache_refill SEGVAULT修正 (core/front/tiny_unified_cache.c:341-350)
  - ヘッダー書き込みをtiny_next_read()の前に移動
  - __atomic_thread_fence(__ATOMIC_RELEASE)追加
  - コンパイラ最適化による順序入れ替えを防止

P2: 二重書き込み削除 (core/box/tiny_front_cold_box.h:75-82)
  - tiny_region_id_write_header()削除
  - unified_cache_refillが既にヘッダー書き込み済み
  - 不要なメモリ操作を削除して効率化

P3: tiny_next_read()安全性強化 (core/tiny_nextptr.h:73-86)
  - __atomic_thread_fence(__ATOMIC_ACQUIRE)追加
  - メモリ操作の順序を保証

P4: ヘッダー書き込みデフォルトON (core/tiny_region_id.h - ChatGPT修正)
  - g_write_headerのデフォルトを1に変更
  - HAKMEM_TINY_WRITE_HEADER=0で旧挙動に戻せる

テスト結果:
  ✅ unified_cache_refill SEGVAULT: 解消（sh8bench実行可能に）
  ❌ TLS_SLL_HDR_RESET: まだ発生中（別の根本原因、調査継続）

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-03 09:57:12 +09:00
Moe Charm (CI)
4cc2d8addf sh8bench修正: LRU registry未登録問題 + self-heal修復 
問題:
  - sh8benchでfree(): invalid pointer発生
  - header=0xA0だがsuperslab registry未登録のポインタがlibcへ

根本原因:
  - LRU pop時にhak_super_register()が呼ばれていなかった
  - hakmem_super_registry.c:hak_ss_lru_pop()の設計不備

修正内容:

1. 根治修正 (core/hakmem_super_registry.c:466)
   - LRU popしたSuperSlabを明示的にregistry再登録
   - hak_super_register((uintptr_t)curr, curr) 追加
   - これによりfree時のhak_super_lookup()が成功

2. Self-heal修復 (core/box/hak_wrappers.inc.h:387-436)
   - Safety net: 未登録SuperSlabを検出して再登録
   - mincore()でマッピング確認 + magic検証
   - libcへの誤ルート遮断（free()クラッシュ回避）
   - 詳細デバッグログ追加（HAKMEM_WRAP_DIAG=1）

3. デバッグ指示書追加 (docs/sh8bench_debug_instruction.md)
   - TLS_SLL_HDR_RESET問題の調査手順

テスト:
  - cfrac, larson等の他ベンチマークは正常動作確認
  - sh8benchのTLS_SLL_HDR_RESET問題は別issue（調査中）

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-03 09:15:59 +09:00
Moe Charm (CI)
f7d0d236e0 malloc_count アトミック操作削除: sh8bench 17s→10s (41%改善) 
perf分析により、malloc()関数内のmalloc_countインクリメントが
27.55%のCPU時間を消費していることが判明。

変更:
- core/box/hak_wrappers.inc.h:84-86
- NDEBUGビルドでmalloc_countインクリメントを無効化
- lock incq命令によるキャッシュライン競合を完全に排除

効果:
- sh8bench (8スレッド): 17秒 → 10-11秒 (35-41%改善)
- 目標14秒を大幅に達成
- futex時間: 2.4s → 3.2s (総実行時間短縮により相対的に増加)

分析手法:
- perf record -g で詳細プロファイリング実施
- アトミック操作がボトルネックと特定
- sysalloc比較: hakmem 10s vs sysalloc 3s (差を大幅縮小)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-03 07:56:38 +09:00
Moe Charm (CI)
60b02adf54 hak_init_wait_for_ready: タイムアウト削除 + デバッグ出力抑制 
- hak_init_wait_for_ready(): タイムアウト(i > 1000000)を削除
  - 他スレッドは初期化完了まで確実に待機するように変更
  - init_waitによるlibcフォールバックを防止

- tls_sll_drain_box.h: デバッグ出力を#ifndef NDEBUGで囲む
  - releaseビルドでの不要なfprintf出力を抑制
  - [TLS_SLL_DRAIN] メッセージがベンチマーク時に出なくなった

性能への影響:
- sh8bench 8スレッド: 17秒（変更なし）
- フォールバック: 8回（初期化時のみ、正常動作）

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 23:29:07 +09:00
Moe Charm (CI)
ad852e5d5e Priority-2 ENV Cache: hakmem_batch.c (1変数追加、1箇所置換) 
【追加ENV変数】
- HAKMEM_BATCH_BG (default: 0)

【置換ファイル】
- core/hakmem_batch.c (1箇所 → ENV Cache)

【変更詳細】
1. ENV Cache (hakmem_env_cache.h):
   - 構造体に1変数追加 (48→49変数)
   - hakmem_env_cache_init()に初期化追加
   - アクセサマクロ追加
   - カウント更新: 48→49

2. hakmem_batch.c:
   - batch_init():
     getenv("HAKMEM_BATCH_BG") → HAK_ENV_BATCH_BG()
   - #include "hakmem_env_cache.h" 追加

【効果】
- Batch初期化からgetenv()呼び出しを排除
- Cold pathだが、起動時のENV参照を削減

【テスト】
✅ make shared → 成功
✅ /tmp/test_mixed3_final → PASSED

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:58:25 +09:00
Moe Charm (CI)
b741d61b46 Priority-2 ENV Cache: hakmem_debug.c (1変数追加、1箇所置換) 
【追加ENV変数】
- HAKMEM_TIMING (default: 0)

【置換ファイル】
- core/hakmem_debug.c (1箇所 → ENV Cache)

【変更詳細】
1. ENV Cache (hakmem_env_cache.h):
   - 構造体に1変数追加 (47→48変数)
   - hakmem_env_cache_init()に初期化追加
   - アクセサマクロ追加
   - カウント更新: 47→48

2. hakmem_debug.c:
   - hkm_timing_init():
     getenv("HAKMEM_TIMING") + strcmp() → HAK_ENV_TIMING_ENABLED()
   - #include "hakmem_env_cache.h" 追加

【効果】
- デバッグタイミング初期化からgetenv()呼び出しを排除
- Cold pathだが、起動時のENV参照を削減

【テスト】
✅ make shared → 成功
✅ /tmp/test_mixed3_final → PASSED

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:56:55 +09:00
Moe Charm (CI)
22a67e5cab Priority-2 ENV Cache: hakmem_smallmid.c (1変数追加、1箇所置換) 
【追加ENV変数】
- HAKMEM_SMALLMID_ENABLE (default: 0)

【置換ファイル】
- core/hakmem_smallmid.c (1箇所 → ENV Cache)

【変更詳細】
1. ENV Cache (hakmem_env_cache.h):
   - 構造体に1変数追加 (46→47変数)
   - hakmem_env_cache_init()に初期化追加
   - アクセサマクロ追加
   - カウント更新: 46→47

2. hakmem_smallmid.c:
   - smallmid_is_enabled():
     getenv("HAKMEM_SMALLMID_ENABLE") → HAK_ENV_SMALLMID_ENABLE()
   - #include "hakmem_env_cache.h" 追加

【効果】
- SmallMid有効化チェックからgetenv()呼び出しを排除
- Warm path起動時のENV参照を1回に削減

【テスト】
✅ make shared → 成功
✅ /tmp/test_mixed3_final → PASSED

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:55:31 +09:00
Moe Charm (CI)
f0e77a000e Priority-2 ENV Cache: hakmem_tiny.c (3箇所置換) 
【置換ファイル】
- core/hakmem_tiny.c (3箇所 → ENV Cache)

【変更詳細】
1. tiny_heap_v2_print_stats():
   - getenv("HAKMEM_TINY_HEAP_V2_STATS") → HAK_ENV_TINY_HEAP_V2_STATS()

2. tiny_alloc_1024_diag_atexit():
   - getenv("HAKMEM_TINY_ALLOC_1024_METRIC") → HAK_ENV_TINY_ALLOC_1024_METRIC()

3. tiny_tls_sll_diag_atexit():
   - getenv("HAKMEM_TINY_SLL_DIAG") → HAK_ENV_TINY_SLL_DIAG()

- #include "hakmem_env_cache.h" 追加

【効果】
- 診断系atexit()関数からgetenv()呼び出しを排除
- 既存ENV変数を利用 (新規追加なし、カウント: 46変数維持)

【テスト】
✅ make shared → 成功
✅ /tmp/test_mixed3_final → PASSED

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:54:03 +09:00
Moe Charm (CI)
183b106733 Priority-2 ENV Cache: Shared Pool Release (1箇所置換) 
【置換ファイル】
- core/hakmem_shared_pool_release.c (1箇所 → ENV Cache)

【変更詳細】
- getenv("HAKMEM_SS_FREE_DEBUG") → HAK_ENV_SS_FREE_DEBUG()
- #include "hakmem_env_cache.h" 追加
- static変数の遅延初期化パターンを削除

【効果】
- Shared Pool Release pathからgetenv()呼び出しを排除
- SS_FREE_DEBUG変数は既にENV Cacheに登録済み (Hot Path Free系)

【テスト】
✅ make shared → 成功
✅ /tmp/test_mixed3_final → PASSED

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:52:48 +09:00
Moe Charm (CI)
c482722705 Priority-2 ENV Cache: Shared Pool Acquire (5変数追加、5箇所置換) 
【追加ENV変数】
- HAKMEM_SS_EMPTY_REUSE (default: 1)
- HAKMEM_SS_EMPTY_SCAN_LIMIT (default: 32)
- HAKMEM_SS_ACQUIRE_DEBUG (default: 0)
- HAKMEM_TINY_TENSION_DRAIN_ENABLE (default: 1)
- HAKMEM_TINY_TENSION_DRAIN_THRESHOLD (default: 1024)

【置換ファイル】
- core/hakmem_shared_pool_acquire.c (5箇所 → ENV Cache)

【変更詳細】
1. ENV Cache (hakmem_env_cache.h):
   - 構造体に5変数追加 (41→46変数)
   - hakmem_env_cache_init()に初期化追加
   - アクセサマクロ5個追加
   - カウント更新: 41→46

2. hakmem_shared_pool_acquire.c:
   - getenv("HAKMEM_SS_EMPTY_REUSE") → HAK_ENV_SS_EMPTY_REUSE()
   - getenv("HAKMEM_SS_EMPTY_SCAN_LIMIT") → HAK_ENV_SS_EMPTY_SCAN_LIMIT()
   - getenv("HAKMEM_SS_ACQUIRE_DEBUG") → HAK_ENV_SS_ACQUIRE_DEBUG()
   - getenv("HAKMEM_TINY_TENSION_DRAIN_ENABLE") → HAK_ENV_TINY_TENSION_DRAIN_ENABLE()
   - getenv("HAKMEM_TINY_TENSION_DRAIN_THRESHOLD") → HAK_ENV_TINY_TENSION_DRAIN_THRESHOLD()
   - #include "hakmem_env_cache.h" 追加

【効果】
- Shared Pool Acquire warm pathからgetenv()呼び出しを完全排除
- Lock-free Stage2のgetenv()オーバーヘッド削減

【テスト】
✅ make shared → 成功
✅ /tmp/test_mixed3_final → PASSED

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:51:50 +09:00
Moe Charm (CI)
b80b3d445e Priority-2: ENV Cache - SFC (Super Front Cache) getenv() 置換 
変更内容:
- hakmem_env_cache.h: 4つの新ENV変数を追加
  (SFC_DEBUG, SFC_ENABLE, SFC_CAPACITY, SFC_REFILL_COUNT)
- hakmem_tiny_sfc.c: 4箇所の getenv() を置換
  (init時のdebug/enable/capacity/refill設定)
  ※Per-class動的変数(2箇所)は初期化時のみのため後回し

効果: SFC層からも syscall を排除 (ENV変数数: 37→41)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:32:22 +09:00
Moe Charm (CI)
38ce143ddf Priority-2: ENV Cache - SuperSlab Registry/LRU/Prewarm getenv() 置換 
変更内容:
- hakmem_env_cache.h: 7つの新ENV変数を追加
  (SUPER_REG_DEBUG, SUPERSLAB_MAX_CACHED, SUPERSLAB_MAX_MEMORY_MB,
   SUPERSLAB_TTL_SEC, SS_LRU_DEBUG, SS_PREWARM_DEBUG, PREWARM_SUPERSLABS)
- hakmem_super_registry.c: 11箇所の getenv() を置換
  (Registry debug, LRU config, LRU debug x3, Prewarm debug x2, Prewarm config)

効果: SuperSlab管理層からも syscall を排除 (ENV変数数: 30→37)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:30:29 +09:00
Moe Charm (CI)
936dc365ba Priority-2: ENV Cache - Warm Path (FastCache/SuperSlab) getenv() 置換 
変更内容:
- hakmem_env_cache.h: 2つの新ENV変数を追加
  (TINY_FAST_STATS, TINY_UNIFIED_CACHE)
- tiny_fastcache.c: 2箇所の getenv() を置換
  (TINY_PROFILE, TINY_FAST_STATS)
- tiny_fastcache.h: 1箇所の getenv() を置換
  (TINY_PROFILE in inline function)
- superslab_slab.c: 1箇所の getenv() を置換
  (TINY_SLL_DIAG)
- tiny_unified_cache.c: 1箇所の getenv() を置換
  (TINY_UNIFIED_CACHE)

効果: Warm path層からも syscall を排除 (ENV変数数: 28→30)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:25:48 +09:00
Moe Charm (CI)
8336febdcb Priority-2: ENV Cache - SuperSlab層の getenv() を完全置換 
変更内容:
- tiny_superslab_alloc.inc.h: 1箇所の getenv() を置換
  (TINY_ALLOC_REMOTE_RELAX)
- tiny_superslab_free.inc.h: 7箇所の getenv() を置換
  (TINY_SLL_DIAG, TINY_ROUTE_FREE x2, TINY_FREE_TO_SS,
   SS_FREE_DEBUG x3, TINY_FREELIST_MASK)

効果: SuperSlab層からも syscall 完全排除

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:22:42 +09:00
Moe Charm (CI)
802b6e775f Priority-2: ENV Variable Cache - ホットパスから syscall を完全排除 
実装内容:
- 新規 Box: core/hakmem_env_cache.h (28個のENV変数をキャッシュ)
- hakmem.c: グローバルインスタンス + constructor 追加
- tiny_alloc_fast.inc.h: 7箇所の getenv() → キャッシュアクセサに置換
- tiny_free_fast_v2.inc.h: 3箇所の getenv() → キャッシュアクセサに置換

パフォーマンス改善:
- ホットパス syscall: ~2000回/秒 → 0回/秒
- 削減コスト: 約20万+ CPUサイクル/秒

設計:
- __attribute__((constructor)) でライブラリロード時に一度だけ初期化
- ゼロコストマクロ (HAK_ENV_*) でキャッシュ値にアクセス
- 箱理論 (Box Pattern) に準拠: 単一責任、ステートレス

次のステップ: 残り約20箇所のgetenv()も順次置換予定

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 20:16:58 +09:00
Moe Charm (CI)
daddbc926c fix(Phase 11+): Cold Start lazy init for unified_cache_refill 
Root cause: unified_cache_refill() accessed cache->slots before initialization
when a size class was first used via the refill path (not pop path).

Fix: Add lazy initialization check at start of unified_cache_refill()
- Check if cache->slots is NULL before accessing
- Call unified_cache_init() if needed
- Return NULL if init fails (graceful degradation)

Also includes:
- ss_cold_start_box.inc.h: Box Pattern for default prewarm settings
- hakmem_super_registry.c: Use static array in prewarm (avoid recursion)
- Default prewarm enabled (1 SuperSlab/class, configurable via ENV)

Test: 8B→16B→Mixed allocation pattern now works correctly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 19:43:23 +09:00
Moe Charm (CI)
644e3c30d1 feat(Phase 2-1): Lane Classification + Fallback Reduction 
## Phase 2-1: Lane Classification Box (Single Source of Truth)

### New Module: hak_lane_classify.inc.h
- Centralized size-to-lane mapping with unified boundary definitions
- Lane architecture:
  - LANE_TINY:  [0, 1024B]      SuperSlab (unchanged)
  - LANE_POOL:  [1025, 52KB]    Pool per-thread (extended!)
  - LANE_ACE:   [52KB, 2MB]     ACE learning
  - LANE_HUGE:  [2MB+]          mmap direct
- Key invariant: POOL_MIN = TINY_MAX + 1 (no gaps)

### Fixed: Tiny/Pool Boundary Mismatch
- Before: TINY_MAX_SIZE=1024 vs tiny_get_max_size()=2047 (inconsistent!)
- After:  Both reference LANE_TINY_MAX=1024 (authoritative)
- Impact: Eliminates 1025-2047B "unmanaged zone" causing libc fragmentation

### Updated Files
- core/hakmem_tiny.h: Use LANE_TINY_MAX, fix sizes[7]=1024 (was 2047)
- core/hakmem_pool.h: Use POOL_MIN_REQUEST_SIZE=1025 (was 2048)
- core/box/hak_alloc_api.inc.h: Lane-based routing (HAK_LANE_IS_*)

## jemalloc Block Bug Fix

### Root Cause
- g_jemalloc_loaded initialized to -1 (unknown)
- Condition `if (block && g_jemalloc_loaded)` treated -1 as true
- Result: ALL allocations fallback to libc (even when jemalloc not loaded!)

### Fix
- Change condition to `g_jemalloc_loaded > 0`
- Only fallback when jemalloc is ACTUALLY loaded
- Applied to: malloc/free/calloc/realloc

### Impact
- Before: 100% libc fallback (jemalloc block false positive)
- After:  Only genuine cases fallback (init_wait, lockdepth, etc.)

## Fallback Diagnostics (ChatGPT contribution)

### New Feature: HAKMEM_WRAP_DIAG
- ENV flag to enable fallback logging
- Reason-specific counters (init_wait, jemalloc_block, lockdepth, etc.)
- First 4 occurrences logged per reason
- Helps identify unwanted fallback paths

### Implementation
- core/box/wrapper_env_box.{c,h}: ENV cache + DIAG flag
- core/box/hak_wrappers.inc.h: wrapper_record_fallback() calls

## Verification

### Fallback Reduction
- Before fix: [wrap] libc malloc: jemalloc block (100% fallback)
- After fix:  Only init_wait + lockdepth (expected, minimal)

### Known Issue
- Tiny allocator OOM (size=8) still crashes
- This is a pre-existing bug, unrelated to Phase 2-1
- Was hidden by jemalloc block false positive
- Will be investigated separately

## Performance Impact

### sh8bench 8 threads
- Phase 1-1: 15秒
- Phase 2-1: 14秒 (~7% improvement)

### Note
- True hakmem performance now measurable (no more 100% fallback)
- Tiny OOM prevents full benchmark completion
- Next: Fix Tiny allocator for complete evaluation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: ChatGPT <chatgpt@openai.com>
 2025-12-02 19:13:28 +09:00
Moe Charm (CI)
695aec8279 feat(Phase 1-2): Add atomic initialization wait mechanism (safety improvement) 
Implements thread-safe atomic initialization tracking and a wait helper for
non-init threads to avoid libc fallback during the initialization window.

Changes:
- Convert g_initializing to _Atomic type for thread-safe access
- Add g_init_thread to identify which thread performs initialization
- Implement hak_init_wait_for_ready() helper with spin/yield mechanism
- Update hak_core_init.inc.h to use atomic operations
- Update hak_wrappers.inc.h to call wait helper instead of checking g_initializing

Results & Analysis:
- Performance: ±0% (21s → 21s, no measurable improvement)
- Safety: ✓ Prevents recursion in init window
- Investigation: Initialization overhead is <1% of total allocations
  - Expected: 2-8% improvement
  - Actual: 0% improvement (spin/yield overhead ≈ savings)
  - libc overhead: 41% → 57% (relative increase, likely sampling variation)

Key Findings from Perf Analysis:
- getenv: 0% (maintained from Phase 1-1) ✓
- libc malloc/free: ~24.54% of cycles
- libc fragmentation (malloc_consolidate/unlink_chunk): ~16% of cycles
- Total libc overhead: ~41% (difficult to optimize without changing algorithm)

Next Phase Target:
- Phase 2: Investigate libc fragmentation (malloc_consolidate 9.33%, unlink_chunk 6.90%)
- Potential approaches: hakmem Mid/ACE allocator expansion, sh8bench pattern analysis

Recommendation: Keep Phase 1-2 for safety (no performance regression), proceed to Phase 2.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-12-02 16:44:27 +09:00
Moe Charm (CI)
49969d2e0f feat(Phase 1-1): Complete getenv elimination from malloc/free hot paths (+39-42% perf) 
## Summary
Eliminated all getenv() calls from malloc/free wrappers and allocator hot paths by implementing
constructor-based environment variable caching. This achieves 39-42% performance improvement
(36s → 22s on sh8bench single-thread).

## Performance Impact
- sh8bench 1 thread: 35-36s → 21-22s (+39-42% improvement) 🚀
- sh8bench 8 threads: ~15s (maintained)
- getenv overhead: 36.32% → 0% (completely eliminated)

## Changes

### New Files
- **core/box/tiny_env_box.{c,h}**: Centralized environment variable cache for Tiny allocator
  - Caches 43 environment variables (HAKMEM_TINY_*, HAKMEM_SLL_*, HAKMEM_SS_*, etc.)
  - Constructor-based initialization with atomic CAS for thread safety
  - Inline accessor tiny_env_cfg() for hot path access

- **core/box/wrapper_env_box.{c,h}**: Environment cache for malloc/free wrappers
  - Caches 3 wrapper variables (HAKMEM_STEP_TRACE, HAKMEM_LD_SAFE, HAKMEM_FREE_WRAP_TRACE)
  - Constructor priority 101 ensures early initialization
  - Replaces all lazy-init patterns in wrapper code

### Modified Files
- **Makefile**: Added tiny_env_box.o and wrapper_env_box.o to OBJS_BASE and SHARED_OBJS

- **core/box/hak_wrappers.inc.h**:
  - Removed static lazy-init variables (g_step_trace, ld_safe_mode cache)
  - Replaced with wrapper_env_cfg() lookups (wcfg->step_trace, wcfg->ld_safe_mode)
  - All getenv() calls eliminated from malloc/free hot paths

- **core/hakmem.c**:
  - Added hak_ld_env_init() with constructor for LD_PRELOAD caching
  - Added hak_force_libc_ctor() for HAKMEM_FORCE_LIBC_ALLOC* caching
  - Simplified hak_ld_env_mode() to return cached value only
  - Simplified hak_force_libc_alloc() to use cached values
  - Eliminated all getenv/atoi calls from hot paths

## Technical Details

### Constructor Initialization Pattern
All environment variables are now read once at library load time using __attribute__((constructor)):
```c
__attribute__((constructor(101)))
static void wrapper_env_ctor(void) {
    wrapper_env_init_once();  // Atomic CAS ensures exactly-once init
}
```

### Thread Safety
- Atomic compare-and-swap (CAS) ensures single initialization
- Spin-wait for initialization completion in multi-threaded scenarios
- Memory barriers (memory_order_acq_rel) ensure visibility

### Hot Path Impact
Before: Every malloc/free → getenv("LD_PRELOAD") + getenv("HAKMEM_STEP_TRACE") + ...
After:  Every malloc/free → Single pointer dereference (wcfg->field)

## Next Optimization Target (Phase 1-2)
Perf analysis reveals libc fallback accounts for ~51% of cycles:
- _int_malloc: 15.04%
- malloc: 9.81%
- _int_free: 10.07%
- malloc_consolidate: 9.27%
- unlink_chunk: 6.82%

Reducing libc fallback from 51% → 10% could yield additional +25-30% improvement.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: ChatGPT <chatgpt@openai.com>
 2025-12-02 16:16:51 +09:00
Moe Charm (CI)
7e3c3d6020 Update CURRENT_TASK after Mid MT removal 2025-12-02 00:53:26 +09:00
Moe Charm (CI)
f1b7964ef9 Remove unused Mid MT layer 2025-12-01 23:43:44 +09:00
Moe Charm (CI)
195c74756c Fix mid free routing and relax mid W_MAX 2025-12-01 22:06:10 +09:00
Moe Charm (CI)
4ef0171bc0 feat: Add ACE allocation failure tracing and debug hooks 
This commit introduces a comprehensive tracing mechanism for allocation failures within the Adaptive Cache Engine (ACE) component. This feature allows for precise identification of the root cause for Out-Of-Memory (OOM) issues related to ACE allocations.

Key changes include:
- **ACE Tracing Implementation**:
  - Added  environment variable to enable/disable detailed logging of allocation failures.
  - Instrumented , , and  to distinguish between "Threshold" (size class mismatch), "Exhaustion" (pool depletion), and "MapFail" (OS memory allocation failure).
- **Build System Fixes**:
  - Corrected  to ensure  is properly linked into , resolving an  error.
- **LD_PRELOAD Wrapper Adjustments**:
  - Investigated and understood the  wrapper's behavior under , particularly its interaction with  and  checks.
  - Enabled debugging flags for  environment to prevent unintended fallbacks to 's  for non-tiny allocations, allowing comprehensive testing of the  allocator.
- **Debugging & Verification**:
  - Introduced temporary verbose logging to pinpoint execution flow issues within  interception and  routing. These temporary logs have been removed.
  - Created  to facilitate testing of the tracing features.

This feature will significantly aid in diagnosing and resolving allocation-related OOM issues in  by providing clear insights into the failure pathways.
 2025-12-01 16:37:59 +09:00
Moe Charm (CI)
2bd8da9267 fix: guard Tiny FG misclass and add fg_tiny_gate box 2025-12-01 16:05:55 +09:00
Moe Charm (CI)
f32d996edb Update CURRENT_TASK.md: Phase 9-2 Complete (50M ops/s), Phase 10 Planned (Type Safety) 2025-12-01 13:50:46 +09:00
Moe Charm (CI)
0bc33dc4f5 Phase 9-2: Remove Legacy Backend & Unify to Shared Pool (50M ops/s) 
- Removed Legacy Backend fallback; Shared Pool is now the sole backend.
- Removed Soft Cap limit in Shared Pool to allow full memory management.
- Implemented EMPTY slab recycling with batched meta->used decrement in remote drain.
- Updated tiny_free_local_box to return is_empty status for safe recycling.
- Fixed race condition in release path by removing from legacy list early.
- Achieved 50.3M ops/s in WS8192 benchmark (+200% vs baseline).
 2025-12-01 13:47:23 +09:00
Moe Charm (CI)
3a040a545a Refactor: Split monolithic hakmem_shared_pool.c into acquire/release modules 
- Split core/hakmem_shared_pool.c into acquire/release modules for maintainability.
- Introduced core/hakmem_shared_pool_internal.h for shared internal API.
- Fixed incorrect function name usage (superslab_alloc -> superslab_allocate).
- Increased SUPER_REG_SIZE to 1M to support large working sets (Phase 9-2 fix).
- Updated Makefile.
- Verified with benchmarks.
 2025-11-30 18:11:08 +09:00
Moe Charm (CI)
e769dec283 Refactor: Clean up SuperSlab shared pool code 
- Removed unused/disabled L0 cache implementation from core/hakmem_shared_pool.c.
- Deleted stale backup file core/hakmem_tiny_superslab.c.bak.
- Removed untracked and obsolete shared_pool source files.
 2025-11-30 15:27:53 +09:00
Moe Charm (CI)
128883e7a8 Feat(phase9): Safe removal from legacy list on shared pool free (Task 2) 
Added remove_superslab_from_legacy_head to safely unlink SuperSlabs from
legacy g_superslab_heads when freed by shared_pool_release_slab.
This prevents dangling pointers in the legacy backend if fallback allocation was used.
Called after unlocking alloc_lock to avoid lock inversion.
 2025-11-30 15:21:42 +09:00
Moe Charm (CI)
e3b0fdce57 Feat(phase9): Make shared_pool SuperSlab acquisition deadlock-free (Task 1) 
Refactored SuperSlab allocation within shared pool to prevent deadlocks.
 replaced by ,
which is now lock-agnostic.  is temporarily released
before calling  and re-acquired afterwards in .
This eliminates deadlock potential between shared pool and registry locks.
OOMs previously observed were due to shared pool's soft limits, not a code bug.
 2025-11-30 15:14:34 +09:00
Moe Charm (CI)
0558a9391d Fix: Enable SuperSlab backend by default to resolve OOM. 
Previously,  was not defined at compile-time,
disabling the SuperSlab backend's fallback to the legacy path and causing OOMs.
This commit sets  to 1 in
and ensures its inclusion in .
 2025-11-30 15:08:45 +09:00
Moe Charm (CI)
a50ee0eb5b Dump shared_pool stage stats aggregated across classes 2025-11-30 12:45:48 +09:00
Moe Charm (CI)
96c93ea587 Add stage stats dump toggle for shared pool 2025-11-30 12:33:11 +09:00
Moe Charm (CI)
eee8c7f14b Raise EMPTY scan default to 32 SuperSlabs 2025-11-30 12:17:32 +09:00
Moe Charm (CI)
a592727b38 Factor shared_pool Stage 0.5 EMPTY scan into helper box 2025-11-30 11:38:04 +09:00
Moe Charm (CI)
5545e1633a Document core Tiny/SuperSlab env toggles and defaults 2025-11-30 11:17:21 +09:00
Moe Charm (CI)
0276420938 Extract adopt/refill boundary into tiny_adopt_refill_box 2025-11-30 11:06:44 +09:00
Moe Charm (CI)
f7d2348751 Update current task for Phase 9-2 SuperSlab unification 2025-11-30 11:02:39 +09:00
Moe Charm (CI)
eea3b988bd Phase 9-3: Box Theory refactoring (TLS_SLL_DUP root fix) 
Implementation:
- Step 1: TLS SLL Guard Box (push前meta/class/state突合)
- Step 2: SP_REBIND_SLOT macro (原子的slab rebind)
- Step 3: Unified Geometry Box (ポインタ演算API統一)
- Step 4: Unified Guard Box (HAKMEM_TINY_GUARD=1 統一制御)

New Files (545 lines):
- core/box/tiny_guard_box.h (277L)
  - TLS push guard (SuperSlab/slab/class/state validation)
  - Recycle guard (EMPTY確認)
  - Drain guard (準備)
  - 統一ENV制御: HAKMEM_TINY_GUARD=1

- core/box/tiny_geometry_box.h (174L)
  - BASE_FROM_USER/USER_FROM_BASE conversion
  - SS_FROM_PTR/SLAB_IDX_FROM_PTR lookup
  - PTR_CLASSIFY combined helper
  - 85+箇所の重複コード削減候補を特定

- core/box/sp_rebind_slot_box.h (94L)
  - SP_REBIND_SLOT macro (geometry + TLS reset + class_map原子化)
  - 6箇所に適用 (Stage 0/0.5/1/2/3)
  - デバッグトレース: HAKMEM_SP_REBIND_TRACE=1

Results:
- ✅ TLS_SLL_DUP完全根絶 (0 crashes, 0 guard rejects)
- ✅ パフォーマンス改善 +5.9% (15.16M → 16.05M ops/s on WS8192)
- ✅ コンパイル警告0件（新規）
- ✅ Box Theory準拠 (Single Responsibility, Clear Contract, Observable, Composable)

Test Results:
- Debug build: HAKMEM_TINY_GUARD=1 で10M iterations完走
- Release build: 3回平均 16.05M ops/s
- Guard reject rate: 0%
- Core dump: なし

Box Theory Compliance:
- Single Responsibility: 各Boxが単一責任 (guard/rebind/geometry)
- Clear Contract: 明確なAPI境界
- Observable: ENV変数で制御可能な検証
- Composable: 全allocation/free pathから利用可能

Performance Impact:
- Release build (guard無効): 影響なし (+5.9%改善)
- Debug build (guard有効): 数%のオーバーヘッド (検証コスト)

Architecture Improvements:
- ポインタ演算の一元管理 (85+箇所の統一候補)
- Slab rebindの原子性保証
- 検証機能の統合 (単一ENV制御)

Phase 9 Status:
- 性能目標 (25-30M ops/s): 未達 (16.05M = 53-64%)
- TLS_SLL_DUP根絶: ✅ 達成
- コード品質: ✅ 大幅向上

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-30 10:48:50 +09:00
Moe Charm (CI)
83e88210f2 Phase 9-2: Disable Legacy backend by default (Shared Pool unification) 
Implementation:
- 3-mode control via HAKMEM_TINY_SS_SHARED env var
  - 0: Legacy only
  - 1: Shared Pool + Legacy fallback
  - 2: Shared Pool only (DEFAULT)
- Mode 2 returns NULL on failure (no Legacy fallback)
- 'Reversible box' design - can switch back via env var

Results:
- ✅ Legacy backend cleanly disabled
- ✅ No shared_fail→legacy in Mode 2
- ✅ Env var switching verified

Known Issues:
- TLS_SLL_DUP remains in Shared Pool backend (cls=5, 141 pointers)
- This is a Shared Pool backend internal issue, not Legacy backend
- Phase 9-3 will address root cause

Box Theory Compliance:
- Single Responsibility: Shared Pool only manages state
- Clear Contract: 3 modes clearly defined
- Observable: Debug logs show mode selection
- Composable: Instant env var switching

Performance:
- Some benchmarks may be slower (user approved)
- Stability prioritized over performance

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-30 09:27:08 +09:00
Moe Charm (CI)
adb5913af5 Phase 9-2 Fix: SuperSlab registry exhaustion workaround 
Problem:
- Legacy-allocated SuperSlabs had slot states stuck at SLOT_UNUSED
- sp_slot_mark_empty() failed, preventing EMPTY transition
- Slots never returned to freelist → registry exhaustion
- "SuperSlab registry full" errors flooded the system

Root Cause:
- Dual management: Legacy path vs Shared Pool path
- Legacy SuperSlabs not synced with Shared Pool metadata
- Inconsistent slot state tracking

Solution (Workaround):
- Added sp_meta_sync_slots_from_ss(): Syncs SP metadata from SuperSlab
- Modified shared_pool_release_slab(): Detects SLOT_ACTIVE mismatch
- On mismatch: Syncs from SuperSlab bitmap/class_map, then proceeds
- Allows EMPTY transition → freelist insertion → registry unregister

Implementation:
1. sp_meta_sync_slots_from_ss() (core/hakmem_shared_pool.c:418-452)
   - Rebuilds slot states from SuperSlab->slab_bitmap
   - Updates total_slots, active_slots, class_idx
   - Handles SLOT_ACTIVE, SLOT_EMPTY, SLOT_UNUSED states

2. shared_pool_release_slab() (core/hakmem_shared_pool.c:1336-1349)
   - Checks slot_state != SLOT_ACTIVE but slab_bitmap set
   - Calls sp_meta_sync_slots_from_ss() to rebuild state
   - Allows normal EMPTY flow to proceed

Results (verified by testing):
- "SuperSlab registry full" errors: ELIMINATED (0 occurrences)
- Throughput: 118-125 M ops/sec (stable)
- 3 consecutive stress tests: All passed
- Medium load test (15K iterations): Success

Nature of Fix:
- WORKAROUND (not root cause fix)
- Detects and repairs inconsistency at release time
- Root fix would require: Legacy path elimination + unified architecture
- This fix ensures stability while preserving existing code paths

Next Steps:
- Benchmark performance improvement vs Phase 9-1 baseline
- Plan root cause fix (Phase 10): Unify SuperSlab management
- Consider gradual Legacy path deprecation

Credit: ChatGPT for root cause analysis and implementation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-30 07:36:02 +09:00
Moe Charm (CI)
87b7d30998 Phase 9: SuperSlab optimization & EMPTY slab recycling (WIP) 
Phase 9-1: O(1) SuperSlab lookup optimization
- Created ss_addr_map_box: Hash table (8192 buckets) for O(1) SuperSlab lookup
- Created ss_tls_hint_box: TLS caching layer for SuperSlab hints
- Integrated hash table into registry (init, insert, remove, lookup)
- Modified hak_super_lookup() to use new hash table
- Expected: 50-80 cycles → 10-20 cycles (not verified - SuperSlab disabled by default)

Phase 9-2: EMPTY slab recycling implementation
- Created slab_recycling_box: SLAB_TRY_RECYCLE() macro following Box pattern
- Integrated into remote drain (superslab_slab.c)
- Integrated into TLS SLL drain (tls_sll_drain_box.h) with touched slab tracking
- Observable: Debug tracing via HAKMEM_SLAB_RECYCLE_TRACE
- Updated Makefile: Added new box objects to 3 build targets

Known Issues:
- SuperSlab registry exhaustion still occurs (unregistration not working)
- shared_pool_release_slab() may not be removing from g_super_reg[]
- Needs investigation before Phase 9-2 can be completed

Expected Impact (when fixed):
- Stage 1 hit rate: 0% → 80%
- shared_fail events: 4 → 0
- Kernel overhead: 55% → 15%
- Throughput: 16.5M → 25-30M ops/s (+50-80%)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-30 07:16:50 +09:00
Moe Charm (CI)
4ad3223f5b docs: Update CURRENT_TASK.md and claude.md for Phase 8 completion 
Phase 8 Complete: BenchFast crash root cause fixes

Documentation updates:
1. CURRENT_TASK.md:
   - Phase 8 complete (TLS→Atomic + Header write fixes)
   - 箱理論 root cause analysis (3 critical bugs)
   - Next phase recommendations (Option C: BenchFast pool expansion)
   - Detailed technical explanations for each layer

2. .claude/claude.md:
   - Phase 8 achievement summary
   - 箱理論 4-principle validation
   - Commit references (191e65983, da8f4d2c8)

Key Fixes Documented:
- TLS→Atomic: Cross-thread guard variable (pthread_once bug)
- Header Write: Direct write bypasses P3 optimization (free routing)
- Infrastructure Isolation: __libc_calloc for cache arrays
- Design Fix: Removed unified_cache_init() call

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-30 05:50:43 +09:00
Moe Charm (CI)
da8f4d2c86 Phase 8-TLS-Fix: BenchFast crash root cause fixes 
Two critical bugs fixed:

1. TLS→Atomic guard (cross-thread safety):
   - Changed `__thread int bench_fast_init_in_progress` to `atomic_int`
   - Root cause: pthread_once() creates threads with fresh TLS (= 0)
   - Guard must protect entire process, not just calling thread
   - Box Contract: Observable state across all threads

2. Direct header write (P3 optimization bypass):
   - bench_fast_alloc() now writes header directly: 0xa0 | class_idx
   - Root cause: P3 optimization skips header writes by default
   - BenchFast REQUIRES headers for free routing (0xa0-0xa7 magic)
   - Box Contract: BenchFast always writes headers

Result:
- Normal mode: 16.3M ops/s (working)
- BenchFast mode: No crash (pool exhaustion expected with 128 blocks/class)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-30 05:12:32 +09:00
Moe Charm (CI)
191e659837 Phase 8 Root Cause Fix: BenchFast crash investigation and infrastructure isolation 
Goal: Fix BenchFast mode crash and improve infrastructure separation
Status: Normal mode works perfectly (17.9M ops/s), BenchFast crash reduced but persists (separate issue)

Root Cause Analysis (Layers 0-3):

Layer 1: Removed unnecessary unified_cache_init() call
- Problem: Phase 8 Step 2 added unified_cache_init() to bench_fast_init()
- Design error: BenchFast uses TLS SLL strategy, NOT Unified Cache
- Impact: 16KB mmap allocations created, later misclassified as Tiny → crash
- Fix: Removed unified_cache_init() call from bench_fast_box.c lines 123-129
- Rationale: BenchFast and Unified Cache are different allocation strategies

Layer 2: Infrastructure isolation (__libc bypass)
- Problem: Infrastructure allocations (cache arrays) went through HAKMEM wrapper
- Risk: Can interact with BenchFast mode, causing path conflicts
- Fix: Use __libc_calloc/__libc_free in unified_cache_init/shutdown
- Benefit: Clean separation between workload (measured) and infrastructure (unmeasured)
- Defense: Prevents future crashes from infrastructure/workload mixing

Layer 3: Box Contract documentation
- Problem: Implicit assumptions about BenchFast behavior were undocumented
- Fix: Added comprehensive Box Contract to bench_fast_box.h (lines 13-51)
- Documents:
  * Workload allocations: Tiny only, TLS SLL strategy
  * Infrastructure allocations: __libc bypass, no HAKMEM interaction
  * Preconditions, guarantees, and violation examples
- Benefit: Future developers understand design constraints

Layer 0: Limit prealloc to actual TLS SLL capacity
- Problem: Old code preallocated 50,000 blocks/class
- Reality: Adaptive sizing limits TLS SLL to 128 blocks/class at runtime
- Lost blocks: 50,000 - 128 = 49,872 blocks/class × 6 = 299,232 lost blocks!
- Impact: Lost blocks caused heap corruption
- Fix: Hard-code prealloc to 128 blocks/class (observed actual capacity)
- Result: 768 total blocks (128 × 6), zero lost blocks

Performance Impact:
- Normal mode: ✅ 17.9M ops/s (perfect, no regression)
- BenchFast mode: ⚠️ Still crashes (different root cause, requires further investigation)

Benefits:
- Unified Cache infrastructure properly isolated (__libc bypass)
- BenchFast Box Contract documented (prevents future misunderstandings)
- Prealloc overflow eliminated (no more lost blocks)
- Normal mode unchanged (backward compatible)

Known Issue (separate):
- BenchFast mode still crashes with "free(): invalid pointer"
- Crash location: Likely bench_random_mixed.c line 145 (BENCH_META_FREE(slots))
- Next steps: GDB debugging, AddressSanitizer build, or strace analysis
- Not caused by Phase 8 changes (pre-existing issue)

Files Modified:
- core/box/bench_fast_box.h        - Box Contract documentation (Layer 3)
- core/box/bench_fast_box.c        - Removed prewarm, limited prealloc (Layer 0+1)
- core/front/tiny_unified_cache.c  - __libc bypass (Layer 2)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-30 04:51:36 +09:00