|
|
3f461ba25f
|
Cleanup: Consolidate debug ENV vars to HAKMEM_DEBUG_LEVEL
Integrated 4 new debug environment variables added during bug fixes
into the existing unified HAKMEM_DEBUG_LEVEL system (expanded to 0-5 levels).
Changes:
1. Expanded HAKMEM_DEBUG_LEVEL from 0-3 to 0-5 levels:
- 0 = OFF (production)
- 1 = ERROR (critical errors)
- 2 = WARN (warnings)
- 3 = INFO (allocation paths, header validation, stats)
- 4 = DEBUG (guard instrumentation, failfast)
- 5 = TRACE (verbose tracing)
2. Integrated 4 environment variables:
- HAKMEM_ALLOC_PATH_TRACE → HAKMEM_DEBUG_LEVEL >= 3 (INFO)
- HAKMEM_TINY_SLL_VALIDATE_HDR → HAKMEM_DEBUG_LEVEL >= 3 (INFO)
- HAKMEM_TINY_REFILL_FAILFAST → HAKMEM_DEBUG_LEVEL >= 4 (DEBUG)
- HAKMEM_TINY_GUARD → HAKMEM_DEBUG_LEVEL >= 4 (DEBUG)
3. Kept 2 special-purpose variables (fine-grained control):
- HAKMEM_TINY_GUARD_CLASS (target class for guard)
- HAKMEM_TINY_GUARD_MAX (max guard events)
4. Backward compatibility:
- Legacy ENV vars still work via hak_debug_check_level()
- New code uses unified system
- No behavior changes for existing users
Updated files:
- core/hakmem_debug_master.h (level 0-5 expansion)
- core/hakmem_tiny_superslab_internal.h (alloc path trace)
- core/box/tls_sll_box.h (header validation)
- core/tiny_failfast.c (failfast level)
- core/tiny_refill_opt.h (failfast guard)
- core/hakmem_tiny_ace_guard_box.inc (guard enable)
- core/hakmem_tiny.c (include hakmem_debug_master.h)
Impact:
- Simpler debug control: HAKMEM_DEBUG_LEVEL=3 instead of 4 separate ENVs
- Easier to discover/use
- Consistent debug levels across codebase
- Reduces ENV variable proliferation (43+ vars surveyed)
Future work:
- Consolidate remaining 39+ debug variables (documented in survey)
- Gradual migration over 2-3 releases
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
2025-11-29 06:57:03 +09:00 |
|
|
|
6b6ad69aca
|
Refactor: Extract 5 Box modules from hakmem_tiny.c (-52% size reduction)
Split hakmem_tiny.c (2081 lines) into focused modules for better maintainability.
## Changes
**hakmem_tiny.c**: 2081 → 995 lines (-1086 lines, -52% reduction)
## Extracted Modules (5 boxes)
1. **config_box** (211 lines)
- Size class tables, integrity counters
- Debug flags, benchmark macros
- HAK_RET_ALLOC/HAK_STAT_FREE instrumentation
2. **publish_box** (419 lines)
- Publish/Adopt counters and statistics
- Bench mailbox, partial ring
- Live cap/Hot slot management
- TLS helper functions (tiny_tls_default_*)
3. **globals_box** (256 lines)
- Global variable declarations (~70 variables)
- TinyPool instance and initialization flag
- TLS variables (g_tls_lists, g_fast_head, g_fast_count)
- SuperSlab configuration (partial ring, empty reserves)
- Adopt gate functions
4. **phase6_wrappers_box** (122 lines)
- Phase 6 Box Theory wrapper layer
- hak_tiny_alloc_fast_wrapper()
- hak_tiny_free_fast_wrapper()
- Diagnostic instrumentation
5. **ace_guard_box** (100 lines)
- ACE Learning Layer (hkm_ace_set_drain_threshold)
- FastCache API (tiny_fc_room, tiny_fc_push_bulk)
- Tiny Guard debugging system (5 functions)
## Benefits
- **Readability**: Giant 2k file → focused 1k core + 5 coherent modules
- **Maintainability**: Each box has clear responsibility and boundaries
- **Build**: All modules compile successfully ✅
## Technical Details
- Phase 1: ChatGPT extracted config_box + publish_box (-625 lines)
- Phase 2-4: Claude extracted globals_box + phase6_wrappers_box + ace_guard_box (-461 lines)
- All extractions use .inc files (same translation unit, preserves static/TLS linkage)
- Fixed Makefile: Added tiny_sizeclass_hist_box.o to OBJS_BASE and BENCH_HAKMEM_OBJS_BASE
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
2025-11-21 01:16:45 +09:00 |
|
